HyukjinKwon commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524947360
##
File path: .github/workflows/build_and_test.yml
##
@@ -416,12 +390,11 @@ jobs:
run: |
export MAVEN_OPTS="-Xmx2g
HyukjinKwon opened a new pull request #30394:
URL: https://github.com/apache/spark/pull/30394
Check if .m2 is required.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28647:
URL: https://github.com/apache/spark/pull/28647#issuecomment-728754094
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28647:
URL: https://github.com/apache/spark/pull/28647#issuecomment-728754079
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35804/
dongjoon-hyun commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524945402
##
File path: .github/workflows/build_and_test.yml
##
@@ -416,12 +390,11 @@ jobs:
run: |
export MAVEN_OPTS="-Xmx2g
SparkQA commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728753070
**[Test build #131207 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131207/testReport)**
for PR 30391 at commit
HyukjinKwon commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524945013
##
File path: .github/workflows/build_and_test.yml
##
@@ -421,7 +395,7 @@ jobs:
rm -rf ~/.m2/repository/org/apache/spark
Review comment:
dongjoon-hyun commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524944927
##
File path: .github/workflows/build_and_test.yml
##
@@ -416,12 +390,11 @@ jobs:
run: |
export MAVEN_OPTS="-Xmx2g
dongjoon-hyun commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524943408
##
File path: .github/workflows/build_and_test.yml
##
@@ -421,7 +395,7 @@ jobs:
rm -rf ~/.m2/repository/org/apache/spark
Review comment:
HyukjinKwon commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524943842
##
File path: .github/workflows/build_and_test.yml
##
@@ -416,12 +390,11 @@ jobs:
run: |
export MAVEN_OPTS="-Xmx2g
HyukjinKwon commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728751123
Addressed!
This is an automated message from the Apache Git Service.
To respond to the message, please log
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728750100
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35805/
HyukjinKwon commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524942149
##
File path: .github/workflows/build_and_test.yml
##
@@ -421,7 +395,7 @@ jobs:
rm -rf ~/.m2/repository/org/apache/spark
Review comment:
maropu commented on a change in pull request #30372:
URL: https://github.com/apache/spark/pull/30372#discussion_r524941668
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##
@@ -1734,15 +1734,17 @@ object
maropu commented on a change in pull request #30372:
URL: https://github.com/apache/spark/pull/30372#discussion_r524941488
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##
@@ -1734,15 +1734,17 @@ object
dongjoon-hyun commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728749215
Please check
https://github.com/apache/spark/pull/30391#discussion_r524939916 .
This is an automated
dongjoon-hyun commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524940363
##
File path: .github/workflows/build_and_test.yml
##
@@ -421,7 +395,7 @@ jobs:
rm -rf ~/.m2/repository/org/apache/spark
Review comment:
dongjoon-hyun commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524939916
##
File path: .github/workflows/build_and_test.yml
##
@@ -421,7 +395,7 @@ jobs:
rm -rf ~/.m2/repository/org/apache/spark
Review comment:
AmplabJenkins removed a comment on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728747106
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728747106
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728724756
**[Test build #131202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131202/testReport)**
for PR 28386 at commit
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728746848
**[Test build #131202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131202/testReport)**
for PR 28386 at commit
AmplabJenkins removed a comment on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728743942
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728746560
**[Test build #131206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131206/testReport)**
for PR 30391 at commit
AmplabJenkins removed a comment on pull request #2:
URL: https://github.com/apache/spark/pull/2#issuecomment-728745887
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mridulm commented on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728746062
I am not sure I follow - the `reduce` will reduce it at driver - based on
the individual priority queues per partition - while `treeReduce` will
progressively reduce it in
AmplabJenkins removed a comment on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728745377
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #2:
URL: https://github.com/apache/spark/pull/2#issuecomment-728745887
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728745183
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728745377
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728745363
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35803/
AmplabJenkins commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728745179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728745179
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728745161
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35802/
SparkQA commented on pull request #2:
URL: https://github.com/apache/spark/pull/2#issuecomment-728744819
**[Test build #131189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131189/testReport)**
for PR 2 at commit
SparkQA removed a comment on pull request #2:
URL: https://github.com/apache/spark/pull/2#issuecomment-728649075
**[Test build #131189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131189/testReport)**
for PR 2 at commit
AmplabJenkins removed a comment on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728743938
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
mridulm commented on pull request #30164:
URL: https://github.com/apache/spark/pull/30164#issuecomment-728744238
Thanks for the +1 and review @Ngone51 !
I dont have any further comments, the recent changes proposed look good to
me too.
Any other review comments @tgravescs,
AmplabJenkins removed a comment on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728743881
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728743938
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728743881
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728743346
**[Test build #131205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131205/testReport)**
for PR 30391 at commit
AmplabJenkins commented on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728740932
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28647:
URL: https://github.com/apache/spark/pull/28647#issuecomment-728740967
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35804/
AmplabJenkins removed a comment on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728740932
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728740916
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35801/
SparkQA commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728740285
**[Test build #131204 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131204/testReport)**
for PR 30391 at commit
AmplabJenkins removed a comment on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728738673
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728737413
**[Test build #131203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131203/testReport)**
for PR 30393 at commit
AmplabJenkins commented on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728738666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728738655
**[Test build #131203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131203/testReport)**
for PR 30393 at commit
AmplabJenkins removed a comment on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728738666
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
BryanCutler commented on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728737383
ping @HyukjinKwon to please take a look when you can, thanks!
This is an automated message from the Apache
SparkQA commented on pull request #30393:
URL: https://github.com/apache/spark/pull/30393#issuecomment-728737413
**[Test build #131203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131203/testReport)**
for PR 30393 at commit
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728736268
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35803/
tanelk edited a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-728736015
> @tanelk Are you still working on this?
I haven't work on it for a while, but I'll get back to it this week.
tanelk commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-728736015
> @tanelk Are you still working on this?
I havent work on it for a while, but I'll get back to it this week.
viirya commented on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728735611
I will run benchmark later if the test is passed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #30325:
URL: https://github.com/apache/spark/pull/30325#issuecomment-728735429
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728735386
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35802/
AmplabJenkins commented on pull request #30325:
URL: https://github.com/apache/spark/pull/30325#issuecomment-728735429
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #30325:
URL: https://github.com/apache/spark/pull/30325#issuecomment-728642372
**[Test build #131186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131186/testReport)**
for PR 30325 at commit
SparkQA commented on pull request #30325:
URL: https://github.com/apache/spark/pull/30325#issuecomment-728734485
**[Test build #131186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131186/testReport)**
for PR 30325 at commit
BryanCutler opened a new pull request #30393:
URL: https://github.com/apache/spark/pull/30393
### What changes were proposed in this pull request?
This change adds MapType support for PySpark with Arrow, if using pyarrow >=
2.0.0.
### Why are the changes needed?
AmplabJenkins removed a comment on pull request #30145:
URL: https://github.com/apache/spark/pull/30145#issuecomment-728733454
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30145:
URL: https://github.com/apache/spark/pull/30145#issuecomment-728733454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728732814
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728732787
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35800/
SparkQA removed a comment on pull request #30145:
URL: https://github.com/apache/spark/pull/30145#issuecomment-728642439
**[Test build #131187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131187/testReport)**
for PR 30145 at commit
AmplabJenkins commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728732814
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30145:
URL: https://github.com/apache/spark/pull/30145#issuecomment-728732426
**[Test build #131187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131187/testReport)**
for PR 30145 at commit
SparkQA commented on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728732186
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35801/
AmplabJenkins removed a comment on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728731347
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728731332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728731332
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
LuciferYang commented on a change in pull request #30351:
URL: https://github.com/apache/spark/pull/30351#discussion_r524923149
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##
@@ -894,10 +893,6 @@ trait ScalaReflection extends
LuciferYang commented on a change in pull request #30351:
URL: https://github.com/apache/spark/pull/30351#discussion_r524923149
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##
@@ -894,10 +893,6 @@ trait ScalaReflection extends
SparkQA removed a comment on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728683503
**[Test build #131194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131194/testReport)**
for PR 30391 at commit
SparkQA commented on pull request #30391:
URL: https://github.com/apache/spark/pull/30391#issuecomment-728730647
**[Test build #131194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131194/testReport)**
for PR 30391 at commit
MichaelChirico commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728726963
> Adding magrittr as a dependency
Best saved for a different thread, but TL;DR: yes, I think that's a good
idea, `magrittr` will help writing `SparkR` code that's
HyukjinKwon commented on a change in pull request #30391:
URL: https://github.com/apache/spark/pull/30391#discussion_r524918338
##
File path: .github/workflows/build_and_test.yml
##
@@ -421,7 +395,7 @@ jobs:
rm -rf ~/.m2/repository/org/apache/spark
Review comment:
HyukjinKwon commented on pull request #30378:
URL: https://github.com/apache/spark/pull/30378#issuecomment-728725027
There's a discussion thread in the mailing list about JDK 14 FYI:
http://apache-spark-developers-list.1001551.n3.nabble.com/Spark-on-JDK-14-td30348.html
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728724756
**[Test build #131202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131202/testReport)**
for PR 28386 at commit
MichaelChirico commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728724666
> Ideally, we'd like both to behave the same way (possibly resolving the
problem with mutate), that's however a breaking change.
A reasonable request (though
AmplabJenkins removed a comment on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728723077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728723065
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728718374
**[Test build #131200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131200/testReport)**
for PR 28386 at commit
AmplabJenkins commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728723065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728723045
**[Test build #131200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131200/testReport)**
for PR 28386 at commit
SparkQA commented on pull request #28647:
URL: https://github.com/apache/spark/pull/28647#issuecomment-728721434
**[Test build #131201 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131201/testReport)**
for PR 28647 at commit
jsoref commented on pull request #30323:
URL: https://github.com/apache/spark/pull/30323#issuecomment-728721289
ok, so, part one is merged.
`bin`, `repl`, and `streaming` seem to be the next least recently touched...
What's do you recommend doing next?
SparkQA commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728720126
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35800/
SparkQA commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-728718374
**[Test build #131200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131200/testReport)**
for PR 28386 at commit
MichaelChirico commented on a change in pull request #28386:
URL: https://github.com/apache/spark/pull/28386#discussion_r524910801
##
File path: R/pkg/R/DataFrame.R
##
@@ -3444,7 +3445,8 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Review
maropu commented on pull request #30342:
URL: https://github.com/apache/spark/pull/30342#issuecomment-728715902
Thanks! Merged to branch-3.0.
This is an automated message from the Apache Git Service.
To respond to the
maropu closed pull request #30342:
URL: https://github.com/apache/spark/pull/30342
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
SparkQA commented on pull request #30368:
URL: https://github.com/apache/spark/pull/30368#issuecomment-728715339
**[Test build #131199 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131199/testReport)**
for PR 30368 at commit
MichaelChirico commented on a change in pull request #28386:
URL: https://github.com/apache/spark/pull/28386#discussion_r524908881
##
File path: R/pkg/R/DataFrame.R
##
@@ -3444,7 +3445,8 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
SparkQA commented on pull request #30392:
URL: https://github.com/apache/spark/pull/30392#issuecomment-728712269
**[Test build #131198 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131198/testReport)**
for PR 30392 at commit
AmplabJenkins removed a comment on pull request #30387:
URL: https://github.com/apache/spark/pull/30387#issuecomment-728710246
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
1 - 100 of 926 matches
Mail list logo