SparkQA commented on pull request #30403:
URL: https://github.com/apache/spark/pull/30403#issuecomment-733477869
**[Test build #131741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131741/testReport)**
for PR 30403 at commit
JQ-Cao opened a new pull request #30495:
URL: https://github.com/apache/spark/pull/30495
# What changes were proposed in this pull request?
display the jvm peak memory usage on the executors page to help user tune
"spark.executor.memory" and "spark.executor.memoryOverhead"
# Why
imback82 commented on a change in pull request #30403:
URL: https://github.com/apache/spark/pull/30403#discussion_r530117606
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##
@@ -679,3 +679,30 @@ case class
HyukjinKwon commented on a change in pull request #30486:
URL: https://github.com/apache/spark/pull/30486#discussion_r530117309
##
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##
@@ -1803,6 +1803,16 @@ package object config {
.toSequence
SparkQA removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467434
**[Test build #131732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131732/testReport)**
for PR 30493 at commit
SparkQA commented on pull request #30403:
URL: https://github.com/apache/spark/pull/30403#issuecomment-733473558
**[Test build #131741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131741/testReport)**
for PR 30403 at commit
dongjoon-hyun commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733473447
`HiveCompatibilitySuite.scala` seems to still have it.
```
SparkQA commented on pull request #30442:
URL: https://github.com/apache/spark/pull/30442#issuecomment-733472027
**[Test build #131739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131739/testReport)**
for PR 30442 at commit
SparkQA commented on pull request #30408:
URL: https://github.com/apache/spark/pull/30408#issuecomment-733471851
**[Test build #131740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131740/testReport)**
for PR 30408 at commit
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733470894
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733470869
**[Test build #131732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131732/testReport)**
for PR 30493 at commit
SparkQA commented on pull request #30494:
URL: https://github.com/apache/spark/pull/30494#issuecomment-733470435
**[Test build #131738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131738/testReport)**
for PR 30494 at commit
AmplabJenkins removed a comment on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733470052
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733470052
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733469741
Got it, @gengliangwang .
This is an automated message from the Apache Git Service.
To respond to the
maryannxue commented on pull request #30494:
URL: https://github.com/apache/spark/pull/30494#issuecomment-733469415
cc @cloud-fan @manuzhang
This is an automated message from the Apache Git Service.
To respond to the
wangyum commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r530112342
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala
##
@@ -139,6 +163,11 @@ class FiltersSuite extends
maryannxue opened a new pull request #30494:
URL: https://github.com/apache/spark/pull/30494
### What changes were proposed in this pull request?
This PR fixes an AQE issue where local shuffle reader, partition coalescing,
or skew join optimization can be mistakenly
AmplabJenkins removed a comment on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733469007
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733469007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30470:
URL: https://github.com/apache/spark/pull/30470#issuecomment-733468984
**[Test build #131737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131737/testReport)**
for PR 30470 at commit
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
AngersZh commented on pull request #30470:
URL: https://github.com/apache/spark/pull/30470#issuecomment-733468432
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA removed a comment on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733414971
**[Test build #131714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131714/testReport)**
for PR 30486 at commit
SparkQA commented on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733468067
**[Test build #131714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131714/testReport)**
for PR 30486 at commit
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
SparkQA commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733467808
**[Test build #131736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131736/testReport)**
for PR 28026 at commit
AmplabJenkins removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733454811
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30421:
URL: https://github.com/apache/spark/pull/30421#issuecomment-733467504
**[Test build #131735 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131735/testReport)**
for PR 30421 at commit
AmplabJenkins removed a comment on pull request #30468:
URL: https://github.com/apache/spark/pull/30468#issuecomment-733400778
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467434
**[Test build #131732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131732/testReport)**
for PR 30493 at commit
SparkQA commented on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733467470
**[Test build #131734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131734/testReport)**
for PR 30478 at commit
SparkQA commented on pull request #30484:
URL: https://github.com/apache/spark/pull/30484#issuecomment-733467380
**[Test build #131733 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131733/testReport)**
for PR 30484 at commit
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
AmplabJenkins commented on pull request #30468:
URL: https://github.com/apache/spark/pull/30468#issuecomment-733467293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gengliangwang commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
insert into
dongjoon-hyun commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r530110592
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala
##
@@ -139,6 +163,11 @@ class FiltersSuite extends
AmplabJenkins removed a comment on pull request #30465:
URL: https://github.com/apache/spark/pull/30465#issuecomment-733465977
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30470:
URL: https://github.com/apache/spark/pull/30470#issuecomment-733465975
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30480:
URL: https://github.com/apache/spark/pull/30480#issuecomment-733465978
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30427:
URL: https://github.com/apache/spark/pull/30427#issuecomment-733465981
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30485:
URL: https://github.com/apache/spark/pull/30485#issuecomment-733465980
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30465:
URL: https://github.com/apache/spark/pull/30465#issuecomment-733465977
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30485:
URL: https://github.com/apache/spark/pull/30485#issuecomment-733465980
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30480:
URL: https://github.com/apache/spark/pull/30480#issuecomment-733465978
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733465976
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30470:
URL: https://github.com/apache/spark/pull/30470#issuecomment-733465975
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733465976
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30427:
URL: https://github.com/apache/spark/pull/30427#issuecomment-733466002
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wangyum commented on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733465693
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
wangyum commented on a change in pull request #30478:
URL: https://github.com/apache/spark/pull/30478#discussion_r530109339
##
File path: pom.xml
##
@@ -2088,7 +2088,7 @@
${hive.group}
hive-service-rpc
-${hive.version}
+3.1.2
Review
SparkQA removed a comment on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733419309
**[Test build #131720 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131720/testReport)**
for PR 30478 at commit
SparkQA commented on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733464620
**[Test build #131720 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131720/testReport)**
for PR 30478 at commit
dongjoon-hyun commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r530106219
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala
##
@@ -139,6 +163,11 @@ class FiltersSuite extends
Ngone51 commented on a change in pull request #30433:
URL: https://github.com/apache/spark/pull/30433#discussion_r530108377
##
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##
@@ -827,13 +833,16 @@ void
LuciferYang commented on pull request #30487:
URL: https://github.com/apache/spark/pull/30487#issuecomment-733463574
thx ~ @HyukjinKwon :)
This is an automated message from the Apache Git Service.
To respond to the message,
dongjoon-hyun commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r530106219
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala
##
@@ -139,6 +163,11 @@ class FiltersSuite extends
dongjoon-hyun commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r530105650
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala
##
@@ -63,6 +65,28 @@ class FiltersSuite extends
dongjoon-hyun commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r530104000
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##
@@ -711,7 +735,8 @@ private[client] class Shim_v0_13
SparkQA removed a comment on pull request #30465:
URL: https://github.com/apache/spark/pull/30465#issuecomment-733350814
**[Test build #131708 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131708/testReport)**
for PR 30465 at commit
SparkQA commented on pull request #30465:
URL: https://github.com/apache/spark/pull/30465#issuecomment-733458807
**[Test build #131708 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131708/testReport)**
for PR 30465 at commit
SparkQA removed a comment on pull request #30470:
URL: https://github.com/apache/spark/pull/30470#issuecomment-733415016
**[Test build #131715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131715/testReport)**
for PR 30470 at commit
SparkQA commented on pull request #30470:
URL: https://github.com/apache/spark/pull/30470#issuecomment-733458020
**[Test build #131715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131715/testReport)**
for PR 30470 at commit
dongjoon-hyun commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733457527
According to the report of SPARK-31710, it was a correctness issue. This
should be considered seriously. Are you using ANSI mode in production really?
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733456524
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733456524
@dongjoon-hyun I can understand your concern. But if we are going to have
this configuration, then it is reasonable to add a feature flag for each
disallowed
gengliangwang commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733456524
@dongjoon-hyun I can understand your concern. But if we are going to have
this configuration, then it is reasonable to add a feature flag for each
disallowed conversion
SparkQA removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733453828
**[Test build #131731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131731/testReport)**
for PR 30493 at commit
AngersZh commented on a change in pull request #30421:
URL: https://github.com/apache/spark/pull/30421#discussion_r53003
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##
@@ -503,13 +503,32 @@ class AstBuilder extends
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733455283
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733454803
**[Test build #131731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131731/testReport)**
for PR 30493 at commit
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733454811
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AngersZh commented on pull request #30421:
URL: https://github.com/apache/spark/pull/30421#issuecomment-733453929
> Let's revisit the entire process:
>
> 1. the parser creates partition spec which is `Map[String, String]`
> 2. for v1 commands, we pass `Map[String, String]` to
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733453828
**[Test build #131731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131731/testReport)**
for PR 30493 at commit
dongjoon-hyun closed pull request #30485:
URL: https://github.com/apache/spark/pull/30485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
SparkQA commented on pull request #30212:
URL: https://github.com/apache/spark/pull/30212#issuecomment-733452764
**[Test build #131730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131730/testReport)**
for PR 30212 at commit
gengliangwang commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r530097508
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -98,6 +98,19 @@ object Cast {
case _ =>
gengliangwang opened a new pull request #30493:
URL: https://github.com/apache/spark/pull/30493
### What changes were proposed in this pull request?
Remove SQL configuration spark.sql.legacy.allowCastNumericToTimestamp
### Why are the changes needed?
In the
HeartSaVioR commented on pull request #30427:
URL: https://github.com/apache/spark/pull/30427#issuecomment-733451967
Thanks all for reviewing! Merged to master.
This is an automated message from the Apache Git Service.
To
HeartSaVioR closed pull request #30427:
URL: https://github.com/apache/spark/pull/30427
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
SparkQA commented on pull request #29950:
URL: https://github.com/apache/spark/pull/29950#issuecomment-733450335
**[Test build #131729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131729/testReport)**
for PR 29950 at commit
SparkQA commented on pull request #30492:
URL: https://github.com/apache/spark/pull/30492#issuecomment-733450215
**[Test build #131727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131727/testReport)**
for PR 30492 at commit
SparkQA commented on pull request #30488:
URL: https://github.com/apache/spark/pull/30488#issuecomment-733450217
**[Test build #131728 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131728/testReport)**
for PR 30488 at commit
AmplabJenkins removed a comment on pull request #29122:
URL: https://github.com/apache/spark/pull/29122#issuecomment-733449347
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29122:
URL: https://github.com/apache/spark/pull/29122#issuecomment-733449347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #29966:
URL: https://github.com/apache/spark/pull/29966#discussion_r530094153
##
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##
@@ -2980,6 +2980,75 @@ private[spark] object Utils extends Logging {
AmplabJenkins removed a comment on pull request #30485:
URL: https://github.com/apache/spark/pull/30485#issuecomment-733449071
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733449076
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30465:
URL: https://github.com/apache/spark/pull/30465#issuecomment-733449073
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733449074
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30427:
URL: https://github.com/apache/spark/pull/30427#issuecomment-733449070
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30485:
URL: https://github.com/apache/spark/pull/30485#issuecomment-733449071
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30465:
URL: https://github.com/apache/spark/pull/30465#issuecomment-733449073
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733449074
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30478:
URL: https://github.com/apache/spark/pull/30478#issuecomment-733449076
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on a change in pull request #30478:
URL: https://github.com/apache/spark/pull/30478#discussion_r530094039
##
File path: pom.xml
##
@@ -2088,7 +2088,7 @@
${hive.group}
hive-service-rpc
-${hive.version}
+3.1.2
AmplabJenkins commented on pull request #30427:
URL: https://github.com/apache/spark/pull/30427#issuecomment-733449070
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733398510
**[Test build #131712 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131712/testReport)**
for PR 30486 at commit
SparkQA commented on pull request #30486:
URL: https://github.com/apache/spark/pull/30486#issuecomment-733448325
**[Test build #131712 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131712/testReport)**
for PR 30486 at commit
SparkQA removed a comment on pull request #30485:
URL: https://github.com/apache/spark/pull/30485#issuecomment-72418
**[Test build #131707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131707/testReport)**
for PR 30485 at commit
101 - 200 of 1058 matches
Mail list logo