[GitHub] [spark] huaxingao opened a new pull request #30544: [SPARK-32405][SQL] [FOLLOWUP] Throw Exception if provider is specified in JDBCTableCatalog create table

2020-11-29 Thread GitBox
huaxingao opened a new pull request #30544: URL: https://github.com/apache/spark/pull/30544 ### What changes were proposed in this pull request? Throw Exception if JDBC Table Catalog has provider in create table. ### Why are the changes needed? JDBC Table Catalog

[GitHub] [spark] SparkQA removed a comment on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735523055 **[Test build #131948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131948/testReport)** for PR 30541 at commit

[GitHub] [spark] SparkQA commented on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
SparkQA commented on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735616329 **[Test build #131948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131948/testReport)** for PR 30541 at commit

[GitHub] [spark] beliefer opened a new pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

2020-11-29 Thread GitBox
beliefer opened a new pull request #30543: URL: https://github.com/apache/spark/pull/30543 ### What changes were proposed in this pull request? There are a lot of mainstream databases support regex function `REGEXP_LIKE`. Currently, Spark supports `RLike` and we just need add a new

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532399380 ## File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala ## @@ -25,12 +25,104 @@ import org.apache.hadoop.conf.Configuration

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532399083 ## File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala ## @@ -25,12 +25,104 @@ import org.apache.hadoop.conf.Configuration

[GitHub] [spark] wangyum commented on a change in pull request #30535: [SPARK-33584][SQL] Hive Metastore support filter by string type with date values

2020-11-29 Thread GitBox
wangyum commented on a change in pull request #30535: URL: https://github.com/apache/spark/pull/30535#discussion_r532397784 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ## @@ -757,6 +757,7 @@ private[client] class Shim_v0_13 extends

[GitHub] [spark] SparkQA commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse

2020-11-29 Thread GitBox
SparkQA commented on pull request #29573: URL: https://github.com/apache/spark/pull/29573#issuecomment-735612452 **[Test build #131968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131968/testReport)** for PR 29573 at commit

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Refract current grouping analytics

2020-11-29 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r532396498 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2027,65 +1952,76 @@ class Analyzer(override val

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #29573: URL: https://github.com/apache/spark/pull/29573#issuecomment-735560305 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse

2020-11-29 Thread GitBox
HyukjinKwon commented on pull request #29573: URL: https://github.com/apache/spark/pull/29573#issuecomment-735611286 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532395160 ## File path: core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ## @@ -80,15 +80,10 @@ object DriverWrapper extends Logging {

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532394800 ## File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala ## @@ -25,12 +25,104 @@ import org.apache.hadoop.conf.Configuration

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532394546 ## File path: docs/sql-ref-syntax-aux-resource-mgmt-add-jar.md ## @@ -33,15 +33,30 @@ ADD JAR file_name * **file_name** -The name of the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30491: [SPARK-33567][SQL] DSv2: Use callback instead of passing Spark session and v2 relation for refreshing cache

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30491: URL: https://github.com/apache/spark/pull/30491#issuecomment-735609413 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532394154 ## File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala ## @@ -25,12 +25,104 @@ import org.apache.hadoop.conf.Configuration

[GitHub] [spark] AmplabJenkins commented on pull request #30491: [SPARK-33567][SQL] DSv2: Use callback instead of passing Spark session and v2 relation for refreshing cache

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30491: URL: https://github.com/apache/spark/pull/30491#issuecomment-735609413 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532393977 ## File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala ## @@ -25,12 +25,104 @@ import org.apache.hadoop.conf.Configuration

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735608575 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30491: [SPARK-33567][SQL] DSv2: Use callback instead of passing Spark session and v2 relation for refreshing cache

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30491: URL: https://github.com/apache/spark/pull/30491#issuecomment-735523085 **[Test build #131951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131951/testReport)** for PR 30491 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30540: [SPARK-33498][SQL][FOLLOW-UP] Deduplicate the unittest by using checkCastWithParseError

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30540: URL: https://github.com/apache/spark/pull/30540#issuecomment-735608599 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735605948 **[Test build #131967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131967/testReport)** for PR 30421 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735608575 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735608543 **[Test build #131967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131967/testReport)** for PR 30421 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30540: [SPARK-33498][SQL][FOLLOW-UP] Deduplicate the unittest by using checkCastWithParseError

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30540: URL: https://github.com/apache/spark/pull/30540#issuecomment-735608599 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30491: [SPARK-33567][SQL] DSv2: Use callback instead of passing Spark session and v2 relation for refreshing cache

2020-11-29 Thread GitBox
SparkQA commented on pull request #30491: URL: https://github.com/apache/spark/pull/30491#issuecomment-735608493 **[Test build #131951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131951/testReport)** for PR 30491 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30540: [SPARK-33498][SQL][FOLLOW-UP] Deduplicate the unittest by using checkCastWithParseError

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30540: URL: https://github.com/apache/spark/pull/30540#issuecomment-735523024 **[Test build #131949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131949/testReport)** for PR 30540 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735607652 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735607652 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30540: [SPARK-33498][SQL][FOLLOW-UP] Deduplicate the unittest by using checkCastWithParseError

2020-11-29 Thread GitBox
SparkQA commented on pull request #30540: URL: https://github.com/apache/spark/pull/30540#issuecomment-735607672 **[Test build #131949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131949/testReport)** for PR 30540 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30539: URL: https://github.com/apache/spark/pull/30539#issuecomment-735606969 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30539: URL: https://github.com/apache/spark/pull/30539#issuecomment-735606969 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30539: URL: https://github.com/apache/spark/pull/30539#issuecomment-735554419 **[Test build #131960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131960/testReport)** for PR 30539 at commit

[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
SparkQA commented on pull request #30539: URL: https://github.com/apache/spark/pull/30539#issuecomment-735606294 **[Test build #131960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131960/testReport)** for PR 30539 at commit

[GitHub] [spark] SparkQA commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735605948 **[Test build #131967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131967/testReport)** for PR 30421 at commit

[GitHub] [spark] SparkQA commented on pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-29 Thread GitBox
SparkQA commented on pull request #30473: URL: https://github.com/apache/spark/pull/30473#issuecomment-735605839 **[Test build #131966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131966/testReport)** for PR 30473 at commit

[GitHub] [spark] SparkQA commented on pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
SparkQA commented on pull request #30516: URL: https://github.com/apache/spark/pull/30516#issuecomment-735605687 **[Test build #131965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131965/testReport)** for PR 30516 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735604863 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-29 Thread GitBox
maropu commented on pull request #29893: URL: https://github.com/apache/spark/pull/29893#issuecomment-735604940 Nice feature, @yaooqinn ! It would be nice to update the SQL doc, too, as you said above. This is an automated

[GitHub] [spark] AmplabJenkins commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735604863 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30508: Revert "[SPARK-33212][BUILD] Move to shaded clients for Hadoop 3.x profile"

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30508: URL: https://github.com/apache/spark/pull/30508#issuecomment-735603978 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30395: [SPARK-32863][SS] Full outer stream-stream join

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30395: URL: https://github.com/apache/spark/pull/30395#issuecomment-735603975 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735603973 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30486: [SPARK-33530][CORE] Support --archives and spark.archives option natively

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30486: URL: https://github.com/apache/spark/pull/30486#issuecomment-735603974 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735523052 **[Test build #131952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131952/testReport)** for PR 30421 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #29573: URL: https://github.com/apache/spark/pull/29573#issuecomment-735603977 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735603973 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30486: [SPARK-33530][CORE] Support --archives and spark.archives option natively

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30486: URL: https://github.com/apache/spark/pull/30486#issuecomment-735603974 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30508: Revert "[SPARK-33212][BUILD] Move to shaded clients for Hadoop 3.x profile"

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30508: URL: https://github.com/apache/spark/pull/30508#issuecomment-735603978 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735603972 **[Test build #131952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131952/testReport)** for PR 30421 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #29573: URL: https://github.com/apache/spark/pull/29573#issuecomment-735603977 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30395: [SPARK-32863][SS] Full outer stream-stream join

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30395: URL: https://github.com/apache/spark/pull/30395#issuecomment-735603975 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] leanken commented on a change in pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
leanken commented on a change in pull request #30516: URL: https://github.com/apache/spark/pull/30516#discussion_r532389009 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala ## @@ -195,7 +197,7 @@ case class

[GitHub] [spark] dongjoon-hyun commented on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
dongjoon-hyun commented on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735603097 Thank you so much! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-29 Thread GitBox
maropu commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r532375495 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -1920,17 +1920,23 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] Ngone51 commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-29 Thread GitBox
Ngone51 commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r532388132 ## File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala ## @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] cloud-fan commented on a change in pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-29 Thread GitBox
cloud-fan commented on a change in pull request #30398: URL: https://github.com/apache/spark/pull/30398#discussion_r532387063 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3643,9 +3643,13 @@ class AstBuilder extends

[GitHub] [spark] waitinfuture commented on a change in pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
waitinfuture commented on a change in pull request #30516: URL: https://github.com/apache/spark/pull/30516#discussion_r532387281 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1023,6 +1023,21 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-29 Thread GitBox
cloud-fan commented on a change in pull request #30398: URL: https://github.com/apache/spark/pull/30398#discussion_r532387063 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3643,9 +3643,13 @@ class AstBuilder extends

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30542: [SPARK-33594][SQL] Forbid binary type as partition column

2020-11-29 Thread GitBox
AngersZh edited a comment on pull request #30542: URL: https://github.com/apache/spark/pull/30542#issuecomment-735599760 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AngersZhuuuu commented on pull request #30542: [SPARK-33594][SQL] Forbid binary type as partition column

2020-11-29 Thread GitBox
AngersZh commented on pull request #30542: URL: https://github.com/apache/spark/pull/30542#issuecomment-735599760 > Is the issue specific to Parquet Vectorized reader? or some other datasources work incorrectly? Currently only with Parquet Vectorized Reader

[GitHub] [spark] SparkQA removed a comment on pull request #30395: [SPARK-32863][SS] Full outer stream-stream join

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30395: URL: https://github.com/apache/spark/pull/30395#issuecomment-735508760 **[Test build #131944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131944/testReport)** for PR 30395 at commit

[GitHub] [spark] SparkQA commented on pull request #30395: [SPARK-32863][SS] Full outer stream-stream join

2020-11-29 Thread GitBox
SparkQA commented on pull request #30395: URL: https://github.com/apache/spark/pull/30395#issuecomment-735598844 **[Test build #131944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131944/testReport)** for PR 30395 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-29 Thread GitBox
Ngone51 commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r532384748 ## File path: core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AngersZhuuuu commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AngersZh commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735597050 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] Ngone51 commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-29 Thread GitBox
Ngone51 commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r532383387 ## File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala ## @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] huaxingao commented on pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-29 Thread GitBox
huaxingao commented on pull request #30473: URL: https://github.com/apache/spark/pull/30473#issuecomment-735592504 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] huaxingao commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-29 Thread GitBox
huaxingao commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r532375082 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class

[GitHub] [spark] HyukjinKwon commented on pull request #30540: [SPARK-33498][SQL][FOLLOW-UP] Deduplicate the unittest by using checkCastWithParseError

2020-11-29 Thread GitBox
HyukjinKwon commented on pull request #30540: URL: https://github.com/apache/spark/pull/30540#issuecomment-735582638 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
SparkQA commented on pull request #30516: URL: https://github.com/apache/spark/pull/30516#issuecomment-735582371 **[Test build #131964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131964/testReport)** for PR 30516 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30516: URL: https://github.com/apache/spark/pull/30516#issuecomment-734289305 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
HyukjinKwon commented on pull request #30516: URL: https://github.com/apache/spark/pull/30516#issuecomment-735581741 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30508: Revert "[SPARK-33212][BUILD] Move to shaded clients for Hadoop 3.x profile"

2020-11-29 Thread GitBox
HyukjinKwon commented on a change in pull request #30508: URL: https://github.com/apache/spark/pull/30508#discussion_r532373156 ## File path: pom.xml ## @@ -1405,24 +1371,8 @@ com.sun.jersey.contribs * - -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30539: URL: https://github.com/apache/spark/pull/30539#issuecomment-735580871 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30539: URL: https://github.com/apache/spark/pull/30539#issuecomment-735580871 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon edited a comment on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon edited a comment on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735575643 @shaneknapp, - I removed `SPARK_MASTER_SBT_HADOOP_2_7` in - `spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3` -

[GitHub] [spark] HyukjinKwon edited a comment on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon edited a comment on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735575643 @shaneknapp, - I removed `SPARK_MASTER_SBT_HADOOP_2_7` in `spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3`, `spark-branch-3.0-test-sbt-hadoop-2.7-hive-1.2` and

[GitHub] [spark] SparkQA commented on pull request #30508: Revert "[SPARK-33212][BUILD] Move to shaded clients for Hadoop 3.x profile"

2020-11-29 Thread GitBox
SparkQA commented on pull request #30508: URL: https://github.com/apache/spark/pull/30508#issuecomment-735578862 **[Test build #131963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131963/testReport)** for PR 30508 at commit

[GitHub] [spark] SparkQA commented on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
SparkQA commented on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735578793 **[Test build #131962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131962/testReport)** for PR 30541 at commit

[GitHub] [spark] HyukjinKwon edited a comment on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon edited a comment on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735575643 @shaneknapp, - I removed `SPARK_MASTER_SBT_HADOOP_2_7` in `spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3` and `spark-branch-3.0-test-sbt-hadoop-2.7-hive-1.2` -

[GitHub] [spark] HyukjinKwon commented on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon commented on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735578487 Sure! I will check other jobs too This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dongjoon-hyun commented on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
dongjoon-hyun commented on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735577868 Could you remove `SPARK_MASTER_SBT_HADOOP_2_7 ` from the followings too? -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30465: URL: https://github.com/apache/spark/pull/30465#issuecomment-735577051 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735577040 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735577041 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29994: [DONOTMERGE][WHITESPACE] workflow exercise

2020-11-29 Thread GitBox
AmplabJenkins removed a comment on pull request #29994: URL: https://github.com/apache/spark/pull/29994#issuecomment-735577044 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] waitinfuture commented on a change in pull request #30516: [SPARK-33572][SQL] Datetime building should fail if the year, month, ..., second combination is invalid

2020-11-29 Thread GitBox
waitinfuture commented on a change in pull request #30516: URL: https://github.com/apache/spark/pull/30516#discussion_r532370460 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1023,6 +1023,21 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735577041 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30465: URL: https://github.com/apache/spark/pull/30465#issuecomment-735577038 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29994: [DONOTMERGE][WHITESPACE] workflow exercise

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #29994: URL: https://github.com/apache/spark/pull/29994#issuecomment-735577044 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
AmplabJenkins commented on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735577040 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon edited a comment on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon edited a comment on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735575643 @shaneknapp, - I removed `SPARK_MASTER_SBT_HADOOP_2_7` in `spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3` - and added `SPARK_TEST_KEY` as a password in

[GitHub] [spark] HyukjinKwon commented on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon commented on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735575643 @shaneknapp, - I removed `SPARK_MASTER_SBT_HADOOP_2_7` in `spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3` - and added `SPARK_TEST_KEY` as a password: ![Screen

[GitHub] [spark] SparkQA removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735508672 **[Test build #131943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131943/testReport)** for PR 30421 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
dongjoon-hyun commented on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735574777 Thank you~ This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-29 Thread GitBox
SparkQA commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-735574727 **[Test build #131943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131943/testReport)** for PR 30421 at commit

[GitHub] [spark] HeartSaVioR edited a comment on pull request #29066: [SPARK-23889][SQL] DataSourceV2: required sorting and clustering for writes

2020-11-29 Thread GitBox
HeartSaVioR edited a comment on pull request #29066: URL: https://github.com/apache/spark/pull/29066#issuecomment-735558685 From what I understand is replacing existing `Distribution` and `ClusteredDistribution` in read path (package `org.apache.spark.sql.connector.read.partitioning`)

[GitHub] [spark] beliefer commented on pull request #30541: [SPARK-28646][SQL] Fix bug of Count so as consistent with mainstream databases

2020-11-29 Thread GitBox
beliefer commented on pull request #30541: URL: https://github.com/apache/spark/pull/30541#issuecomment-735569831 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon commented on pull request #23117: [SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins

2020-11-29 Thread GitBox
HyukjinKwon commented on pull request #23117: URL: https://github.com/apache/spark/pull/23117#issuecomment-735569315 Thank you @dongjoon-hyun. Let me set the key accordinlgy. This is an automated message from the Apache Git

[GitHub] [spark] zhengruifeng commented on a change in pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading

2020-11-29 Thread GitBox
zhengruifeng commented on a change in pull request #30539: URL: https://github.com/apache/spark/pull/30539#discussion_r532358634 ## File path: dev/sparktestsupport/modules.py ## @@ -564,6 +564,7 @@ def __hash__(self): "pyspark.ml.tests.test_stat",

  1   2   3   4   5   >