[GitHub] [spark] SparkQA commented on pull request #30796: [SPARK-33802][INFRA] Override name and email address explicitly when updating PySpark coverage

2020-12-15 Thread GitBox
SparkQA commented on pull request #30796: URL: https://github.com/apache/spark/pull/30796#issuecomment-745866979 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37469/

[GitHub] [spark] kiszk commented on a change in pull request #30644: [SPARK-33689][SQL] ArrayData specialization

2020-12-15 Thread GitBox
kiszk commented on a change in pull request #30644: URL: https://github.com/apache/spark/pull/30644#discussion_r544086078 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/PrimitiveArrayData.scala ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache

[GitHub] [spark] SparkQA commented on pull request #30728: [SPARK-33756][SQL] Make BytesToBytesMap's MapIterator idempotent

2020-12-15 Thread GitBox
SparkQA commented on pull request #30728: URL: https://github.com/apache/spark/pull/30728#issuecomment-745865213 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37466/

[GitHub] [spark] SparkQA commented on pull request #30795: [SPARK-33799][CORE] Handle excluded executors/nodes in ExecutorMonitor

2020-12-15 Thread GitBox
SparkQA commented on pull request #30795: URL: https://github.com/apache/spark/pull/30795#issuecomment-745864710 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37467/

[GitHub] [spark] SparkQA commented on pull request #30790: [SPARK-33798][SQL] Simplify EqualTo(CaseWhen/If, Literal) always false

2020-12-15 Thread GitBox
SparkQA commented on pull request #30790: URL: https://github.com/apache/spark/pull/30790#issuecomment-745852014 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37463/

[GitHub] [spark] cloud-fan commented on a change in pull request #30387: [SPARK-33443][SQL] LEAD/LAG should support [ IGNORE NULLS | RESPECT NULLS ]

2020-12-15 Thread GitBox
cloud-fan commented on a change in pull request #30387: URL: https://github.com/apache/spark/pull/30387#discussion_r544081471 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -116,13 +116,21 @@ trait WindowExecBase extends

[GitHub] [spark] Ngone51 commented on pull request #30716: [SPARK-33747][CORE] Avoid calling unregisterMapOutput when the map stage is being rerunning.

2020-12-15 Thread GitBox
Ngone51 commented on pull request #30716: URL: https://github.com/apache/spark/pull/30716#issuecomment-745849444 After taking another look, I think this problem can prevent by `shuffleFileLostEpoch`? All tasks from the failed reduce stage share the same epoch. So only the first fetch

[GitHub] [spark] Ngone51 removed a comment on pull request #30716: [SPARK-33747][CORE] Avoid calling unregisterMapOutput when the map stage is being rerunning.

2020-12-15 Thread GitBox
Ngone51 removed a comment on pull request #30716: URL: https://github.com/apache/spark/pull/30716#issuecomment-745828531 I've read the latest description. So the issue should only happen when speculation is enabled? BTW, this PR looks more like an improvement to me instead of a bug

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745840295 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37461/

[GitHub] [spark] SparkQA removed a comment on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
SparkQA removed a comment on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745750900 **[Test build #132856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132856/testReport)** for PR 30743 at commit

[GitHub] [spark] HyukjinKwon opened a new pull request #30798: [DO-NOT-MERGE][TESTS] Reenable test cases disabeld in SPARK-31732

2020-12-15 Thread GitBox
HyukjinKwon opened a new pull request #30798: URL: https://github.com/apache/spark/pull/30798 ### What changes were proposed in this pull request? The test failures were due to machine being slow in Jenkins. We switched to Ubuntu 20 if I am not wrong. Let's see if the tests pass

[GitHub] [spark] Ngone51 commented on pull request #30716: [SPARK-33747][CORE] Avoid calling unregisterMapOutput when the map stage is being rerunning.

2020-12-15 Thread GitBox
Ngone51 commented on pull request #30716: URL: https://github.com/apache/spark/pull/30716#issuecomment-745829190 cc @tgravescs @mridulm @jiangxb1987 This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] Ngone51 commented on pull request #30716: [SPARK-33747][CORE] Avoid calling unregisterMapOutput when the map stage is being rerunning.

2020-12-15 Thread GitBox
Ngone51 commented on pull request #30716: URL: https://github.com/apache/spark/pull/30716#issuecomment-745828531 I've read the latest description. So the issue should only happen when speculation is enabled? BTW, this PR looks more like an improvement to me instead of a bug fix.

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745824550 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37464/

[GitHub] [spark] AmplabJenkins commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745824635 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37464/

[GitHub] [spark] AmplabJenkins commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745820391 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132856/

[GitHub] [spark] SparkQA commented on pull request #30779: [SPARK-33789][SQL][TESTS] Refactor unified V1 and V2 datasource tests

2020-12-15 Thread GitBox
SparkQA commented on pull request #30779: URL: https://github.com/apache/spark/pull/30779#issuecomment-745819632 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37462/

[GitHub] [spark] AmplabJenkins commented on pull request #30779: [SPARK-33789][SQL][TESTS] Refactor unified V1 and V2 datasource tests

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30779: URL: https://github.com/apache/spark/pull/30779#issuecomment-745819740 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37462/

[GitHub] [spark] SparkQA commented on pull request #30796: [SPARK-33802][INFRA] Override name and email address explicitly when updating PySpark coverage

2020-12-15 Thread GitBox
SparkQA commented on pull request #30796: URL: https://github.com/apache/spark/pull/30796#issuecomment-745815659 **[Test build #132868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132868/testReport)** for PR 30796 at commit

[GitHub] [spark] SparkQA commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
SparkQA commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745818839 **[Test build #132856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132856/testReport)** for PR 30743 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30793: URL: https://github.com/apache/spark/pull/30793#issuecomment-745818707 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37465/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30793: URL: https://github.com/apache/spark/pull/30793#issuecomment-745818707 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37465/

[GitHub] [spark] SparkQA commented on pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
SparkQA commented on pull request #30793: URL: https://github.com/apache/spark/pull/30793#issuecomment-745818691 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37465/

[GitHub] [spark] SparkQA commented on pull request #30797: [MINOR][DOCS] Fix Jenkins job badge image and link in README.md

2020-12-15 Thread GitBox
SparkQA commented on pull request #30797: URL: https://github.com/apache/spark/pull/30797#issuecomment-745818437 **[Test build #132869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132869/testReport)** for PR 30797 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30790: [SPARK-33798][SQL] Simplify EqualTo(CaseWhen/If, Literal) always false

2020-12-15 Thread GitBox
cloud-fan commented on a change in pull request #30790: URL: https://github.com/apache/spark/pull/30790#discussion_r544065722 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala ## @@ -199,4 +199,98 @@ class

[GitHub] [spark] HyukjinKwon opened a new pull request #30797: [MINOR][DOCS] Fix Jenkins job badge image and link in README.md

2020-12-15 Thread GitBox
HyukjinKwon opened a new pull request #30797: URL: https://github.com/apache/spark/pull/30797 ### What changes were proposed in this pull request? This PR proposes to fix the Jenkins job badge: Before: ![Screen Shot 2020-12-16 at 4 14 14

[GitHub] [spark] SparkQA commented on pull request #30728: [SPARK-33756][SQL] Make BytesToBytesMap's MapIterator idempotent

2020-12-15 Thread GitBox
SparkQA commented on pull request #30728: URL: https://github.com/apache/spark/pull/30728#issuecomment-745817189 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37466/

[GitHub] [spark] HeartSaVioR commented on pull request #30770: [SPARK-33783][SS] Unload State Store Provider after configured keep alive time

2020-12-15 Thread GitBox
HeartSaVioR commented on pull request #30770: URL: https://github.com/apache/spark/pull/30770#issuecomment-745815471 cc. @tdas @zsxwing @jose-torres @gaborgsomogyi @xuanyuanking This is an automated message from the Apache

[GitHub] [spark] HeartSaVioR commented on pull request #30789: [SPARK-33797][SS][DOCS] Update SS doc about State Store and task locality

2020-12-15 Thread GitBox
HeartSaVioR commented on pull request #30789: URL: https://github.com/apache/spark/pull/30789#issuecomment-745815380 cc. @tdas @zsxwing @jose-torres @gaborgsomogyi This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30775: [SPARK-33778][SQL] Allow typesafe join for LeftSemi and LeftAnti

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30775: URL: https://github.com/apache/spark/pull/30775#issuecomment-745814752 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132854/

[GitHub] [spark] SparkQA commented on pull request #30795: [SPARK-33799][CORE] Handle excluded executors/nodes in ExecutorMonitor

2020-12-15 Thread GitBox
SparkQA commented on pull request #30795: URL: https://github.com/apache/spark/pull/30795#issuecomment-745815076 **[Test build #132865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132865/testReport)** for PR 30795 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #30780: [SPARK-33790][CORE] Reduce the rpc call of getFileStatus in SingleFileEventLogFileReader

2020-12-15 Thread GitBox
HeartSaVioR commented on pull request #30780: URL: https://github.com/apache/spark/pull/30780#issuecomment-745814806 I agree this is a good improvement. Thanks! Regardless of approval of the PR, I wonder your experiment result, though. `rootPath` is supposed to be just a file, so 17

[GitHub] [spark] AmplabJenkins commented on pull request #30775: [SPARK-33778][SQL] Allow typesafe join for LeftSemi and LeftAnti

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30775: URL: https://github.com/apache/spark/pull/30775#issuecomment-745814752 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132854/

[GitHub] [spark] SparkQA removed a comment on pull request #30775: [SPARK-33778][SQL] Allow typesafe join for LeftSemi and LeftAnti

2020-12-15 Thread GitBox
SparkQA removed a comment on pull request #30775: URL: https://github.com/apache/spark/pull/30775#issuecomment-745733898 **[Test build #132854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132854/testReport)** for PR 30775 at commit

[GitHub] [spark] SparkQA commented on pull request #30794: [SPARK-33800][SQL] Remove command name in AnalysisException message when a relation is not resolved

2020-12-15 Thread GitBox
SparkQA commented on pull request #30794: URL: https://github.com/apache/spark/pull/30794#issuecomment-745814205 **[Test build #132866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132866/testReport)** for PR 30794 at commit

[GitHub] [spark] HyukjinKwon opened a new pull request #30796: [SPARK-33802][INFRA] Override name and email address explicitly when updating PySpark coverage

2020-12-15 Thread GitBox
HyukjinKwon opened a new pull request #30796: URL: https://github.com/apache/spark/pull/30796 ### What changes were proposed in this pull request? The current Jenkins job fails as below (https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-3.2/1726/console)

[GitHub] [spark] Ngone51 closed pull request #30759: [SPARK-33774][UI][CORE]"Back to Master" returns 500 error in Standalone cluster

2020-12-15 Thread GitBox
Ngone51 closed pull request #30759: URL: https://github.com/apache/spark/pull/30759 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] LuciferYang commented on a change in pull request #30760: [SPARK-33775][BUILD] Suppress sbt compilation warnings in Scala 2.13

2020-12-15 Thread GitBox
LuciferYang commented on a change in pull request #30760: URL: https://github.com/apache/spark/pull/30760#discussion_r544058894 ## File path: project/SparkBuild.scala ## @@ -238,7 +238,16 @@ object SparkBuild extends PomBuild {

[GitHub] [spark] SparkQA commented on pull request #30775: [SPARK-33778][SQL] Allow typesafe join for LeftSemi and LeftAnti

2020-12-15 Thread GitBox
SparkQA commented on pull request #30775: URL: https://github.com/apache/spark/pull/30775#issuecomment-745813882 **[Test build #132854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132854/testReport)** for PR 30775 at commit

[GitHub] [spark] SparkQA commented on pull request #30760: [SPARK-33775][BUILD] Suppress sbt compilation warnings in Scala 2.13

2020-12-15 Thread GitBox
SparkQA commented on pull request #30760: URL: https://github.com/apache/spark/pull/30760#issuecomment-745813764 **[Test build #132867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132867/testReport)** for PR 30760 at commit

[GitHub] [spark] Ngone51 commented on pull request #30795: [SPARK-33799][CORE] Handle excluded executors/nodes in ExecutorMonitor

2020-12-15 Thread GitBox
Ngone51 commented on pull request #30795: URL: https://github.com/apache/spark/pull/30795#issuecomment-745812811 cc @tgravescs @mridulm @jiangxb1987 @attilapiros Cloud you please take a look? cc @vanzin @squito FYI

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30642: URL: https://github.com/apache/spark/pull/30642#issuecomment-745795020 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30642: URL: https://github.com/apache/spark/pull/30642#issuecomment-745812202 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37460/

[GitHub] [spark] Ngone51 opened a new pull request #30795: [SPARK-33799][CORE] Handle excluded executors/nodes in ExecutorMonitor

2020-12-15 Thread GitBox
Ngone51 opened a new pull request #30795: URL: https://github.com/apache/spark/pull/30795 ### What changes were proposed in this pull request? This PR proposes to handle exclusion events in `ExecutorMonitor` so it doesn't count excluded executors as available executors

[GitHub] [spark] SparkQA commented on pull request #30790: [SPARK-33798][SQL] Simplify EqualTo(CaseWhen/If, Literal) always false

2020-12-15 Thread GitBox
SparkQA commented on pull request #30790: URL: https://github.com/apache/spark/pull/30790#issuecomment-745810951 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37463/

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745810026 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37461/

[GitHub] [spark] SparkQA commented on pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
SparkQA commented on pull request #30793: URL: https://github.com/apache/spark/pull/30793#issuecomment-745809290 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37465/

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745807455 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37464/

[GitHub] [spark] SparkQA commented on pull request #30779: [SPARK-33789][SQL][TESTS] Refactor unified V1 and V2 datasource tests

2020-12-15 Thread GitBox
SparkQA commented on pull request #30779: URL: https://github.com/apache/spark/pull/30779#issuecomment-745806294 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37462/

[GitHub] [spark] imback82 opened a new pull request #30794: [SPARK-33800][SQL] Remove command name in AnalysisException message when a relation is not resolved

2020-12-15 Thread GitBox
imback82 opened a new pull request #30794: URL: https://github.com/apache/spark/pull/30794 ### What changes were proposed in this pull request? Based on the discussion https://github.com/apache/spark/pull/30743#discussion_r543124594, this PR proposes to remove the command

[GitHub] [spark] AmplabJenkins commented on pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30642: URL: https://github.com/apache/spark/pull/30642#issuecomment-745795020 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132850/

[GitHub] [spark] SparkQA commented on pull request #30728: [SPARK-33756][SQL] Make BytesToBytesMap's MapIterator idempotent

2020-12-15 Thread GitBox
SparkQA commented on pull request #30728: URL: https://github.com/apache/spark/pull/30728#issuecomment-745794888 **[Test build #132864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132864/testReport)** for PR 30728 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
SparkQA removed a comment on pull request #30642: URL: https://github.com/apache/spark/pull/30642#issuecomment-745716277 **[Test build #132850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132850/testReport)** for PR 30642 at commit

[GitHub] [spark] SparkQA commented on pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
SparkQA commented on pull request #30642: URL: https://github.com/apache/spark/pull/30642#issuecomment-745794174 **[Test build #132850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132850/testReport)** for PR 30642 at commit

[GitHub] [spark] SparkQA commented on pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
SparkQA commented on pull request #30793: URL: https://github.com/apache/spark/pull/30793#issuecomment-745794116 **[Test build #132863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132863/testReport)** for PR 30793 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30728: [SPARK-33756][SQL] Make BytesToBytesMap's MapIterator idempotent

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30728: URL: https://github.com/apache/spark/pull/30728#issuecomment-745429476 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] advancedxy commented on pull request #30728: [SPARK-33756][SQL] Make BytesToBytesMap's MapIterator idempotent

2020-12-15 Thread GitBox
advancedxy commented on pull request #30728: URL: https://github.com/apache/spark/pull/30728#issuecomment-745792924 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] imback82 commented on pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
imback82 commented on pull request #30793: URL: https://github.com/apache/spark/pull/30793#issuecomment-745792753 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] imback82 opened a new pull request #30793: [SPARK-33786][SQL][3.0] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
imback82 opened a new pull request #30793: URL: https://github.com/apache/spark/pull/30793 ### What changes were proposed in this pull request? This is a back port of #30774. This PR proposes to retain the cache's storage level when a table name is altered by `ALTER

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745790787 **[Test build #132862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132862/testReport)** for PR 30784 at commit

[GitHub] [spark] SparkQA commented on pull request #30790: [SPARK-33798][SQL] Simplify EqualTo(CaseWhen/If, Literal) always false

2020-12-15 Thread GitBox
SparkQA commented on pull request #30790: URL: https://github.com/apache/spark/pull/30790#issuecomment-745790752 **[Test build #132861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132861/testReport)** for PR 30790 at commit

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745789702 **[Test build #132859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132859/testReport)** for PR 30784 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30779: [SPARK-33789][SQL][TESTS] Refactor unified V1 and V2 datasource tests

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30779: URL: https://github.com/apache/spark/pull/30779#issuecomment-745466052 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LuciferYang commented on a change in pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
LuciferYang commented on a change in pull request #30784: URL: https://github.com/apache/spark/pull/30784#discussion_r544009980 ## File path: pom.xml ## @@ -3243,6 +3264,31 @@ + + + + +

[GitHub] [spark] SparkQA commented on pull request #30779: [SPARK-33789][SQL][TESTS] Refactor unified V1 and V2 datasource tests

2020-12-15 Thread GitBox
SparkQA commented on pull request #30779: URL: https://github.com/apache/spark/pull/30779#issuecomment-745789135 **[Test build #132860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132860/testReport)** for PR 30779 at commit

[GitHub] [spark] cxzl25 commented on pull request #30780: [SPARK-33790][CORE] Reduce the rpc call of getFileStatus in SingleFileEventLogFileReader

2020-12-15 Thread GitBox
cxzl25 commented on pull request #30780: URL: https://github.com/apache/spark/pull/30780#issuecomment-745788759 ## current `FsHistoryProvider#checkForLogs` - Takes 23 minutes ``` 20/12/16 10:27:13,152 [log-replay-executor-44] INFO FsHistoryProvider: Finished parsing

[GitHub] [spark] HyukjinKwon commented on pull request #30784: [SPARK-33560][test-maven][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
HyukjinKwon commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745788545 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745787682 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37458/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745787681 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132853/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30387: [SPARK-33443][SQL] LEAD/LAG should support [ IGNORE NULLS | RESPECT NULLS ]

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30387: URL: https://github.com/apache/spark/pull/30387#issuecomment-745787680 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37459/

[GitHub] [spark] AmplabJenkins commented on pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745787681 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132853/

[GitHub] [spark] AmplabJenkins commented on pull request #30387: [SPARK-33443][SQL] LEAD/LAG should support [ IGNORE NULLS | RESPECT NULLS ]

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30387: URL: https://github.com/apache/spark/pull/30387#issuecomment-745787680 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37459/

[GitHub] [spark] AmplabJenkins commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745787682 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37458/

[GitHub] [spark] LuciferYang commented on a change in pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
LuciferYang commented on a change in pull request #30784: URL: https://github.com/apache/spark/pull/30784#discussion_r544005908 ## File path: pom.xml ## @@ -2503,9 +2503,6 @@ incremental true - -unchecked Review comment:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
HyukjinKwon commented on a change in pull request #30784: URL: https://github.com/apache/spark/pull/30784#discussion_r544004906 ## File path: pom.xml ## @@ -3243,6 +3264,31 @@ + + + + +

[GitHub] [spark] cloud-fan commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

2020-12-15 Thread GitBox
cloud-fan commented on pull request #30646: URL: https://github.com/apache/spark/pull/30646#issuecomment-745782558 I don't think spark can support it, as we may have catalog implementations that support table name with dot, and this change will break it.

[GitHub] [spark] SparkQA commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
SparkQA commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745781325 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37458/

[GitHub] [spark] cloud-fan commented on pull request #30779: [SPARK-33789][SQL][TESTS] Refactor unified V1 and V2 datasource tests

2020-12-15 Thread GitBox
cloud-fan commented on pull request #30779: URL: https://github.com/apache/spark/pull/30779#issuecomment-745780222 @MaxGekk can you fix the conflicts? This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA removed a comment on pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA removed a comment on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745734279 **[Test build #132853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132853/testReport)** for PR 30784 at commit

[GitHub] [spark] SparkQA commented on pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
SparkQA commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745779911 **[Test build #132853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132853/testReport)** for PR 30784 at commit

[GitHub] [spark] cloud-fan commented on pull request #30774: [SPARK-33786][SQL] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
cloud-fan commented on pull request #30774: URL: https://github.com/apache/spark/pull/30774#issuecomment-745779804 @imback82 can you open a backport PR for 3.0? thanks! This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan closed pull request #30774: [SPARK-33786][SQL] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
cloud-fan closed pull request #30774: URL: https://github.com/apache/spark/pull/30774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30774: [SPARK-33786][SQL] The storage level for a cache should be respected when a table name is altered.

2020-12-15 Thread GitBox
cloud-fan commented on pull request #30774: URL: https://github.com/apache/spark/pull/30774#issuecomment-745779528 GA passed, merging to master/3.1, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [spark] yaooqinn commented on a change in pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
yaooqinn commented on a change in pull request #30642: URL: https://github.com/apache/spark/pull/30642#discussion_r543989302 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala ## @@ -92,15 +81,15 @@ abstract class

[GitHub] [spark] cloud-fan closed pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
cloud-fan closed pull request #30743: URL: https://github.com/apache/spark/pull/30743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
cloud-fan commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745776717 GA passed, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #30387: [SPARK-33443][SQL] LEAD/LAG should support [ IGNORE NULLS | RESPECT NULLS ]

2020-12-15 Thread GitBox
SparkQA commented on pull request #30387: URL: https://github.com/apache/spark/pull/30387#issuecomment-745774398 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37459/

[GitHub] [spark] cloud-fan commented on a change in pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
cloud-fan commented on a change in pull request #30642: URL: https://github.com/apache/spark/pull/30642#discussion_r543972001 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -67,11 +67,12 @@ private[sql] class SharedState(

[GitHub] [spark] cloud-fan commented on a change in pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
cloud-fan commented on a change in pull request #30642: URL: https://github.com/apache/spark/pull/30642#discussion_r543969346 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala ## @@ -92,15 +81,15 @@ abstract class

[GitHub] [spark] SparkQA commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
SparkQA commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745769924 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37458/

[GitHub] [spark] SparkQA commented on pull request #30642: [SPARK-32991][SQL] [FOLLOWUP] Reset command relies on session initials first

2020-12-15 Thread GitBox
SparkQA commented on pull request #30642: URL: https://github.com/apache/spark/pull/30642#issuecomment-745768292 **[Test build #132858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132858/testReport)** for PR 30642 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30792: [SPARK-33752][SQL][3.1] Avoid the getSimpleMessage of AnalysisException adds semicolon repeatedly

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30792: URL: https://github.com/apache/spark/pull/30792#issuecomment-745766968 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745766969 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37455/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30657: [WIP][SPARK-33696][SQL] Upgrade built-in Hive to 2.3.8

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30657: URL: https://github.com/apache/spark/pull/30657#issuecomment-745766966 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132849/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30759: [SPARK-33774][UI][CORE]"Back to Master" returns 500 error in Standalone cluster

2020-12-15 Thread GitBox
AmplabJenkins removed a comment on pull request #30759: URL: https://github.com/apache/spark/pull/30759#issuecomment-745766967 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132848/

[GitHub] [spark] AmplabJenkins commented on pull request #30759: [SPARK-33774][UI][CORE]"Back to Master" returns 500 error in Standalone cluster

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30759: URL: https://github.com/apache/spark/pull/30759#issuecomment-745766967 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132848/

[GitHub] [spark] AmplabJenkins commented on pull request #30657: [WIP][SPARK-33696][SQL] Upgrade built-in Hive to 2.3.8

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30657: URL: https://github.com/apache/spark/pull/30657#issuecomment-745766966 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132849/

[GitHub] [spark] AmplabJenkins commented on pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30784: URL: https://github.com/apache/spark/pull/30784#issuecomment-745766969 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37455/

[GitHub] [spark] AmplabJenkins commented on pull request #30792: [SPARK-33752][SQL][3.1] Avoid the getSimpleMessage of AnalysisException adds semicolon repeatedly

2020-12-15 Thread GitBox
AmplabJenkins commented on pull request #30792: URL: https://github.com/apache/spark/pull/30792#issuecomment-745766970 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #30743: [SPARK-33765][SQL] Migrate UNCACHE TABLE to use UnresolvedRelation to resolve identifier

2020-12-15 Thread GitBox
cloud-fan commented on pull request #30743: URL: https://github.com/apache/spark/pull/30743#issuecomment-745764753 We can probably have a base trait for commands that don't want to optimize its child plan, so that we can remove duplicated code. This can be done in a followup.

  1   2   3   4   5   6   7   8   >