[GitHub] [spark] maropu commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
maropu commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755951184 Thanks for it! Let's wait for the test results... This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
SparkQA commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755951169 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38369/

[GitHub] [spark] tanelk commented on a change in pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
tanelk commented on a change in pull request #31024: URL: https://github.com/apache/spark/pull/31024#discussion_r553160855 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PredicateReorder.scala ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [spark] AngersZhuuuu commented on pull request #29087: [SPARK-28227][SQL] Support projection, aggregate/window functions, and lateral view in the TRANSFORM clause

2021-01-06 Thread GitBox
AngersZh commented on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-755948444 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
maropu commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755948004 @turboFei You need to push two more empty commits for invoking GA tests concurrently. It seems that only one test job is running now.

[GitHub] [spark] tanelk edited a comment on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
tanelk edited a comment on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755947516 It would be nice to do this recursively. Currently you split the outer `and` filters and sort them. each of these can have an `or` filter as a child and it would be

[GitHub] [spark] tanelk commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
tanelk commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755947516 It would be nice to do this recursively. Currently you split the outer `and` filter and sort them. each of these can have an `or` filter and it would be beneficial to sort its

[GitHub] [spark] dongjoon-hyun commented on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755946044 According to the current observation, I'll make a new PR and make it pass `GitHub Action` and Jenkins `Maven`.

[GitHub] [spark] dongjoon-hyun commented on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755945794 Since the test suite was not isolated correctly, this is reverted via https://github.com/apache/spark/commit/194edc86a2959f912b4e4d0bb4867b5cb2fd0813

[GitHub] [spark] HyukjinKwon commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755944681 It's alright. Thanks for taking a look for this @dongjoon-hyun. This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755944415 I'll revert the original PR because it seems to take more time. Sorry about the trouble. This is an

[GitHub] [spark] SparkQA removed a comment on pull request #29087: [SPARK-28227][SQL] Support projection, aggregate/window functions, and lateral view in the TRANSFORM clause

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-755855304 **[Test build #133768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133768/testReport)** for PR 29087 at commit

[GitHub] [spark] SparkQA commented on pull request #29087: [SPARK-28227][SQL] Support projection, aggregate/window functions, and lateral view in the TRANSFORM clause

2021-01-06 Thread GitBox
SparkQA commented on pull request #29087: URL: https://github.com/apache/spark/pull/29087#issuecomment-755942294 **[Test build #133768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133768/testReport)** for PR 29087 at commit

[GitHub] [spark] turboFei removed a comment on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
turboFei removed a comment on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755941318 ok, I will trigger GA test 3 times again. This is an automated message from the Apache Git Service. To

[GitHub] [spark] turboFei commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
turboFei commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755941489 > > To check if we can fix the flakiness, could you push empty commits for invoking GA tests three or four times? > ok, I will trigger GA test 3 times again.

[GitHub] [spark] turboFei commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
turboFei commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755941318 ok, I will trigger GA test 3 times again. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] SparkQA removed a comment on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755854908 **[Test build #133763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133763/testReport)** for PR 31079 at commit

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755940131 **[Test build #133763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133763/testReport)** for PR 31079 at commit

[GitHub] [spark] SparkQA commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
SparkQA commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755939728 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38366/

[GitHub] [spark] SparkQA commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
SparkQA commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-755939069 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38365/

[GitHub] [spark] beliefer commented on a change in pull request #30975: [SPARK-33938][SQL] Optimize Like Any/All by LikeSimplification

2021-01-06 Thread GitBox
beliefer commented on a change in pull request #30975: URL: https://github.com/apache/spark/pull/30975#discussion_r553151297 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -634,36 +635,68 @@ object LikeSimplification

[GitHub] [spark] ulysses-you commented on pull request #31077: [SPARK-34030][SQL] Fold RepartitionByExpression num partition should at Optimizer

2021-01-06 Thread GitBox
ulysses-you commented on pull request #31077: URL: https://github.com/apache/spark/pull/31077#issuecomment-755938503 cc @maropu @cloud-fan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] beliefer commented on a change in pull request #30975: [SPARK-33938][SQL] Optimize Like Any/All by LikeSimplification

2021-01-06 Thread GitBox
beliefer commented on a change in pull request #30975: URL: https://github.com/apache/spark/pull/30975#discussion_r553151297 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -634,36 +635,68 @@ object LikeSimplification

[GitHub] [spark] SparkQA commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
SparkQA commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755937804 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38364/

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755936589 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38363/

[GitHub] [spark] dongjoon-hyun commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755935839 The `CliClient` failure in `hive-thriftserver` module is irrelevant. This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31077: [SPARK-34030][SQL] Fold RepartitionByExpression num partition should at Optimizer

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31077: URL: https://github.com/apache/spark/pull/31077#issuecomment-755934213 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133761/

[GitHub] [spark] SparkQA commented on pull request #31080: [SPARK-28123][SQL] String Functions: support btrim

2021-01-06 Thread GitBox
SparkQA commented on pull request #31080: URL: https://github.com/apache/spark/pull/31080#issuecomment-755934595 **[Test build #133780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133780/testReport)** for PR 31080 at commit

[GitHub] [spark] SparkQA commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
SparkQA commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755934474 **[Test build #133781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133781/testReport)** for PR 31024 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31077: [SPARK-34030][SQL] Fold RepartitionByExpression num partition should at Optimizer

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31077: URL: https://github.com/apache/spark/pull/31077#issuecomment-755934213 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133761/

[GitHub] [spark] SparkQA removed a comment on pull request #31077: [SPARK-34030][SQL] Fold RepartitionByExpression num partition should at Optimizer

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #31077: URL: https://github.com/apache/spark/pull/31077#issuecomment-755839885 **[Test build #133761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133761/testReport)** for PR 31077 at commit

[GitHub] [spark] SparkQA commented on pull request #31077: [SPARK-34030][SQL] Fold RepartitionByExpression num partition should at Optimizer

2021-01-06 Thread GitBox
SparkQA commented on pull request #31077: URL: https://github.com/apache/spark/pull/31077#issuecomment-755933343 **[Test build #133761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133761/testReport)** for PR 31077 at commit

[GitHub] [spark] maropu commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
maropu commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755932293 > To check if we can fix the flakiness, could you push empty commits for invoking GA tests three or four times? @turboFei Could you do this?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755931746 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38367/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755931640 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133777/

[GitHub] [spark] AmplabJenkins commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755931746 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38367/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755931638 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755931727 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38367/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29935: [SPARK-33055][PYTHON][SQL] Add Python CalendarIntervalType

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29935: URL: https://github.com/apache/spark/pull/29935#issuecomment-755931641 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133778/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755931637 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38361/

[GitHub] [spark] AmplabJenkins commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755931637 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38361/

[GitHub] [spark] AmplabJenkins commented on pull request #29935: [SPARK-33055][PYTHON][SQL] Add Python CalendarIntervalType

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #29935: URL: https://github.com/apache/spark/pull/29935#issuecomment-755931641 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133778/

[GitHub] [spark] AmplabJenkins commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755931640 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133777/

[GitHub] [spark] AmplabJenkins commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755931638 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755929893 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38367/

[GitHub] [spark] SparkQA commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
SparkQA commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755927646 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38366/

[GitHub] [spark] SparkQA commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
SparkQA commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-755927168 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38365/

[GitHub] [spark] SparkQA removed a comment on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755874563 **[Test build #133772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133772/testReport)** for PR 31076 at commit

[GitHub] [spark] SparkQA commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
SparkQA commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755926260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA removed a comment on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755909881 **[Test build #133777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133777/testReport)** for PR 31054 at commit

[GitHub] [spark] SparkQA commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
SparkQA commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755925402 **[Test build #133777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133777/testReport)** for PR 31054 at commit

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755925120 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38363/

[GitHub] [spark] beliefer opened a new pull request #31080: [SPARK-28123][SQL] String Functions: Add support btrim

2021-01-06 Thread GitBox
beliefer opened a new pull request #31080: URL: https://github.com/apache/spark/pull/31080 ### What changes were proposed in this pull request? The current implement of `Trim`/`Ltrim`/`Rtrim` only support string, but support byte array is very useful. The function btrim supports byte

[GitHub] [spark] SparkQA removed a comment on pull request #29935: [SPARK-33055][PYTHON][SQL] Add Python CalendarIntervalType

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #29935: URL: https://github.com/apache/spark/pull/29935#issuecomment-755912415 **[Test build #133778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133778/testReport)** for PR 29935 at commit

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755922245 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38361/

[GitHub] [spark] SparkQA commented on pull request #29935: [SPARK-33055][PYTHON][SQL] Add Python CalendarIntervalType

2021-01-06 Thread GitBox
SparkQA commented on pull request #29935: URL: https://github.com/apache/spark/pull/29935#issuecomment-755922081 **[Test build #133778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133778/testReport)** for PR 29935 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755919227 cc @maropu and @cloud-fan This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #29922: [SPARK-32723] [WEBUI] Upgrade to jQuery 3.5.1, 2.4 backport.

2021-01-06 Thread GitBox
SparkQA commented on pull request #29922: URL: https://github.com/apache/spark/pull/29922#issuecomment-755912656 **[Test build #133779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133779/testReport)** for PR 29922 at commit

[GitHub] [spark] SparkQA commented on pull request #29935: [SPARK-33055][PYTHON][SQL] Add Python CalendarIntervalType

2021-01-06 Thread GitBox
SparkQA commented on pull request #29935: URL: https://github.com/apache/spark/pull/29935#issuecomment-755912415 **[Test build #133778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133778/testReport)** for PR 29935 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-755743719 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
SparkQA commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-755911521 **[Test build #133776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133776/testReport)** for PR 31073 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29922: [SPARK-32723] [WEBUI] Upgrade to jQuery 3.5.1, 2.4 backport.

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #29922: URL: https://github.com/apache/spark/pull/29922#issuecomment-755910131 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
SparkQA commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755909881 **[Test build #133777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133777/testReport)** for PR 31054 at commit

[GitHub] [spark] SparkQA commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
SparkQA commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755909814 **[Test build #133775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133775/testReport)** for PR 31076 at commit

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755909816 **[Test build #133774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133774/testReport)** for PR 31079 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755908229 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31068: URL: https://github.com/apache/spark/pull/31068#issuecomment-755908233 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38358/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755908234 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
AmplabJenkins removed a comment on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755908235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38359/

[GitHub] [spark] AmplabJenkins commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755908235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38359/

[GitHub] [spark] AmplabJenkins commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755908234 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to `hive` module

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755908229 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
AmplabJenkins commented on pull request #31068: URL: https://github.com/apache/spark/pull/31068#issuecomment-755908233 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38358/

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755906572 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38361/

[GitHub] [spark] turboFei commented on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

2021-01-06 Thread GitBox
turboFei commented on pull request #31054: URL: https://github.com/apache/spark/pull/31054#issuecomment-755902917 > Could you file another jira and make a PR for it? Sure. This is an automated message from the Apache

[GitHub] [spark] sunchao commented on a change in pull request #31066: [SPARK-34027][SQL] Refresh cache in `ALTER TABLE .. RECOVER PARTITIONS`

2021-01-06 Thread GitBox
sunchao commented on a change in pull request #31066: URL: https://github.com/apache/spark/pull/31066#discussion_r553121035 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -675,7 +675,7 @@ case class

[GitHub] [spark] SparkQA removed a comment on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Add hadoop-common `provided` dependency explicitly

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755854915 **[Test build #133764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133764/testReport)** for PR 31076 at commit

[GitHub] [spark] SparkQA commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Add hadoop-common `provided` dependency explicitly

2021-01-06 Thread GitBox
SparkQA commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755898321 **[Test build #133764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133764/testReport)** for PR 31076 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
HyukjinKwon commented on a change in pull request #31073: URL: https://github.com/apache/spark/pull/31073#discussion_r553120084 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -2841,6 +2841,31 @@ object functions { // DateTime functions

[GitHub] [spark] SparkQA commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-06 Thread GitBox
SparkQA commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-755897991 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38359/

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
HyukjinKwon commented on a change in pull request #31073: URL: https://github.com/apache/spark/pull/31073#discussion_r553120021 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -2841,6 +2841,31 @@ object functions { // DateTime functions

[GitHub] [spark] LuciferYang commented on pull request #31064: [SPARK-34028][SQL] Cleanup "unreachable code" compilation warning

2021-01-06 Thread GitBox
LuciferYang commented on pull request #31064: URL: https://github.com/apache/spark/pull/31064#issuecomment-755897906 thx ~ @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-755897749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] HyukjinKwon closed pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
HyukjinKwon closed pull request #31068: URL: https://github.com/apache/spark/pull/31068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31068: URL: https://github.com/apache/spark/pull/31068#issuecomment-755897628 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA removed a comment on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755888635 **[Test build #133773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133773/testReport)** for PR 31079 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31068: URL: https://github.com/apache/spark/pull/31068#issuecomment-755896387 The flaky tests are known and being fixed at `https://github.com/apache/spark/pull/31076`. Let me just merge this in

[GitHub] [spark] SparkQA commented on pull request #31079: [SPARK-34037][SQL] aggOrder should not be output as a auxiliary internal attribute

2021-01-06 Thread GitBox
SparkQA commented on pull request #31079: URL: https://github.com/apache/spark/pull/31079#issuecomment-755896038 **[Test build #133773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133773/testReport)** for PR 31079 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755895523 Thanks for working on it! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
dongjoon-hyun edited a comment on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755894991 The Hadoop class is not loaded correctly in `sql/core` module and we cannot add `test` dependency. The failure happens when we build first and run test

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
HyukjinKwon commented on a change in pull request #31068: URL: https://github.com/apache/spark/pull/31068#discussion_r553117889 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala ## @@ -141,6 +141,16 @@

[GitHub] [spark] SparkQA commented on pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
SparkQA commented on pull request #31068: URL: https://github.com/apache/spark/pull/31068#issuecomment-755895095 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38358/

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
dongjoon-hyun edited a comment on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755894991 The Hadoop class is not loaded correctly in `sql/core` module and we cannot add `test` dependency.

[GitHub] [spark] dongjoon-hyun commented on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755894991 The Hadoop class is not loaded correctly and we cannot add `test` dependency. This is an automated

[GitHub] [spark] SparkQA commented on pull request #31076: [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Add hadoop-common `provided` dependency explicitly

2021-01-06 Thread GitBox
SparkQA commented on pull request #31076: URL: https://github.com/apache/spark/pull/31076#issuecomment-755894942 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38360/

[GitHub] [spark] HyukjinKwon commented on pull request #31068: [SPARK-34031][SQL] Union operator missing rowCount when CBO enabled

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31068: URL: https://github.com/apache/spark/pull/31068#issuecomment-755894728 @wangyum, sorry but can you push an empty commit to retrigger the GA build? I would like to keep the result of the test failure because it looks like a flaky test.

[GitHub] [spark] dongjoon-hyun commented on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
dongjoon-hyun commented on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755894661 Yes, I'm working on here. - https://github.com/apache/spark/pull/31076 This is an automated message

[GitHub] [spark] HyukjinKwon commented on pull request #31065: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-01-06 Thread GitBox
HyukjinKwon commented on pull request #31065: URL: https://github.com/apache/spark/pull/31065#issuecomment-755894385 @dongjoon-hyun seems like it's still flaky (?). Can you take a quick look for https://github.com/apache/spark/pull/31068/checks?check_run_id=1660627329? I saw this in a PR

[GitHub] [spark] beliefer commented on a change in pull request #30975: [SPARK-33938][SQL] Optimize Like Any/All by LikeSimplification

2021-01-06 Thread GitBox
beliefer commented on a change in pull request #30975: URL: https://github.com/apache/spark/pull/30975#discussion_r553116900 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -634,36 +635,68 @@ object LikeSimplification

[GitHub] [spark] HyukjinKwon closed pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic

2021-01-06 Thread GitBox
HyukjinKwon closed pull request #31067: URL: https://github.com/apache/spark/pull/31067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   3   4   5   6   7   8   >