[GitHub] [spark] cloud-fan commented on a change in pull request #31131: [SPARK-34071][SQL][TESTS] Check stats of cached v1 tables after altering

2021-01-11 Thread GitBox
cloud-fan commented on a change in pull request #31131: URL: https://github.com/apache/spark/pull/31131#discussion_r69367 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandTestUtils.scala ## @@ -91,4 +91,20 @@ trait DDLCommandTestUtils

[GitHub] [spark] cloud-fan commented on a change in pull request #31131: [SPARK-34071][SQL][TESTS] Check stats of cached v1 tables after altering

2021-01-11 Thread GitBox
cloud-fan commented on a change in pull request #31131: URL: https://github.com/apache/spark/pull/31131#discussion_r69367 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandTestUtils.scala ## @@ -91,4 +91,20 @@ trait DDLCommandTestUtils

[GitHub] [spark] SparkQA commented on pull request #31142: [WIP][SPARK-33346][CORE][SQL][MLLIB] Change the never changed 'var' to 'val'

2021-01-11 Thread GitBox
SparkQA commented on pull request #31142: URL: https://github.com/apache/spark/pull/31142#issuecomment-758472667 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38548/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758469086 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133956/

[GitHub] [spark] AmplabJenkins commented on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758469086 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133956/

[GitHub] [spark] SparkQA removed a comment on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
SparkQA removed a comment on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758416020 **[Test build #133956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133956/testReport)** for PR 31146 at commit

[GitHub] [spark] SparkQA commented on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
SparkQA commented on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758468951 **[Test build #133956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133956/testReport)** for PR 31146 at commit

[GitHub] [spark] LantaoJin edited a comment on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

2021-01-11 Thread GitBox
LantaoJin edited a comment on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-758465100 > Is "canceling SQL statement" a STS specific feature? It doesn't seem to be implemented properly, as we lack the ability to track all the spark jobs submitted by one

[GitHub] [spark] HyukjinKwon closed pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
HyukjinKwon closed pull request #31143: URL: https://github.com/apache/spark/pull/31143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
HyukjinKwon commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758465344 Merged to master and branch-3.1. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] LantaoJin commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

2021-01-11 Thread GitBox
LantaoJin commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-758465100 > Is "canceling SQL statement" a STS specific feature? It doesn't seem to be implemented properly, as we lack the ability to track all the spark jobs submitted by one SQL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31129: [SPARK-34003][SQL][FOLLOWUP] Avoid pushing modified Char/Varchar sort attributes into aggregate for existing ones

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31129: URL: https://github.com/apache/spark/pull/31129#issuecomment-758464713 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133952/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758464714 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38547/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758464715 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38543/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-758464716 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38545/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31145: [SPARK-24081][SQL] Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31145: URL: https://github.com/apache/spark/pull/31145#issuecomment-758464712 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38544/

[GitHub] [spark] AmplabJenkins commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758464714 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38547/

[GitHub] [spark] AmplabJenkins commented on pull request #31145: [SPARK-24081][SQL] Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31145: URL: https://github.com/apache/spark/pull/31145#issuecomment-758464712 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38544/

[GitHub] [spark] AmplabJenkins commented on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-758464716 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38545/

[GitHub] [spark] AmplabJenkins commented on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758464715 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38543/

[GitHub] [spark] AmplabJenkins commented on pull request #31129: [SPARK-34003][SQL][FOLLOWUP] Avoid pushing modified Char/Varchar sort attributes into aggregate for existing ones

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31129: URL: https://github.com/apache/spark/pull/31129#issuecomment-758464713 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133952/

[GitHub] [spark] SparkQA commented on pull request #31142: [WIP][SPARK-33346][CORE][SQL][MLLIB] Change the never changed 'var' to 'val'

2021-01-11 Thread GitBox
SparkQA commented on pull request #31142: URL: https://github.com/apache/spark/pull/31142#issuecomment-758458959 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38548/

[GitHub] [spark] SparkQA commented on pull request #31146: [WIP][SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
SparkQA commented on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758458263 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38543/

[GitHub] [spark] SparkQA removed a comment on pull request #31129: [SPARK-34003][SQL][FOLLOWUP] Avoid pushing modified Char/Varchar sort attributes into aggregate for existing ones

2021-01-11 Thread GitBox
SparkQA removed a comment on pull request #31129: URL: https://github.com/apache/spark/pull/31129#issuecomment-758354331 **[Test build #133952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133952/testReport)** for PR 31129 at commit

[GitHub] [spark] SparkQA commented on pull request #31129: [SPARK-34003][SQL][FOLLOWUP] Avoid pushing modified Char/Varchar sort attributes into aggregate for existing ones

2021-01-11 Thread GitBox
SparkQA commented on pull request #31129: URL: https://github.com/apache/spark/pull/31129#issuecomment-758453369 **[Test build #133952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133952/testReport)** for PR 31129 at commit

[GitHub] [spark] cloud-fan commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

2021-01-11 Thread GitBox
cloud-fan commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-758451901 hmm, IIRC the SQL UI can know all the jobs of a SQL statement, how is that done? cc @gengliangwang This is

[GitHub] [spark] cloud-fan commented on pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

2021-01-11 Thread GitBox
cloud-fan commented on pull request #31119: URL: https://github.com/apache/spark/pull/31119#issuecomment-758451547 Is "canceling SQL statement" a STS specific feature? It doesn't seem to be implemented properly, as we lack the ability to track all the spark jobs submitted by one SQL

[GitHub] [spark] LuciferYang commented on a change in pull request #31125: [SPARK-34068][CORE][SQL][MLLIB][GRAPHX] Remove redundant collection conversion

2021-01-11 Thread GitBox
LuciferYang commented on a change in pull request #31125: URL: https://github.com/apache/spark/pull/31125#discussion_r51139 ## File path: core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala ## @@ -227,7 +227,7 @@ private[spark] class

[GitHub] [spark] MaxGekk commented on pull request #31131: [SPARK-34071][SQL][TESTS] Check stats of cached v1 tables after altering

2021-01-11 Thread GitBox
MaxGekk commented on pull request #31131: URL: https://github.com/apache/spark/pull/31131#issuecomment-758448256 @HyukjinKwon @cloud-fan Could you look at this PR, please. This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #31145: [SPARK-24081][SQL] Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases

2021-01-11 Thread GitBox
SparkQA commented on pull request #31145: URL: https://github.com/apache/spark/pull/31145#issuecomment-758445544 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38544/

[GitHub] [spark] SparkQA commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
SparkQA commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758444788 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38547/

[GitHub] [spark] SparkQA commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
SparkQA commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758441397 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38547/

[GitHub] [spark] SparkQA commented on pull request #31142: [WIP][SPARK-33346][CORE][SQL][MLLIB] Change the never changed 'var' to 'val'

2021-01-11 Thread GitBox
SparkQA commented on pull request #31142: URL: https://github.com/apache/spark/pull/31142#issuecomment-758440341 **[Test build #133961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133961/testReport)** for PR 31142 at commit

[GitHub] [spark] LantaoJin commented on a change in pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

2021-01-11 Thread GitBox
LantaoJin commented on a change in pull request #31119: URL: https://github.com/apache/spark/pull/31119#discussion_r41964 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala ## @@ -74,7 +74,9 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31146: [SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
SparkQA commented on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758438483 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38543/

[GitHub] [spark] LuciferYang commented on a change in pull request #31125: [SPARK-34068][CORE][SQL][MLLIB][GRAPHX] Remove redundant collection conversion

2021-01-11 Thread GitBox
LuciferYang commented on a change in pull request #31125: URL: https://github.com/apache/spark/pull/31125#discussion_r41317 ## File path: core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala ## @@ -227,7 +227,7 @@ private[spark] class

[GitHub] [spark] AmplabJenkins commented on pull request #31147: fixed spark3.0 access hive table while data in hbase problem

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31147: URL: https://github.com/apache/spark/pull/31147#issuecomment-758437641 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758437346 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133960/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758437343 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133953/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758437344 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38546/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758437345 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133954/

[GitHub] [spark] AmplabJenkins commented on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758437345 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133954/

[GitHub] [spark] AmplabJenkins commented on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758437343 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133953/

[GitHub] [spark] AmplabJenkins commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758437344 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38546/

[GitHub] [spark] AmplabJenkins commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758437346 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133960/

[GitHub] [spark] SparkQA commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
SparkQA commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758434913 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38546/

[GitHub] [spark] SparkQA commented on pull request #31145: [SPARK-24081][SQL] Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases

2021-01-11 Thread GitBox
SparkQA commented on pull request #31145: URL: https://github.com/apache/spark/pull/31145#issuecomment-758433040 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38544/

[GitHub] [spark] SparkQA commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
SparkQA commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758432997 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38546/

[GitHub] [spark] yangBottle opened a new pull request #31147: fixed spark3.0 access hive table while data in hbase problem

2021-01-11 Thread GitBox
yangBottle opened a new pull request #31147: URL: https://github.com/apache/spark/pull/31147 fixed spark3.0 access hive table while data in hbase problem ### What changes were proposed in this pull request? The PR modify TableReader.scala to create OldHadoopRDD when

[GitHub] [spark] SparkQA removed a comment on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
SparkQA removed a comment on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758373541 **[Test build #133953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133953/testReport)** for PR 31140 at commit

[GitHub] [spark] SparkQA commented on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
SparkQA commented on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758431039 **[Test build #133953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133953/testReport)** for PR 31140 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
SparkQA removed a comment on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758372122 **[Test build #133954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133954/testReport)** for PR 31127 at commit

[GitHub] [spark] SparkQA commented on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
SparkQA commented on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758428144 **[Test build #133954 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133954/testReport)** for PR 31127 at commit

[GitHub] [spark] yangBottle closed pull request #31141: Update TableReader.scala

2021-01-11 Thread GitBox
yangBottle closed pull request #31141: URL: https://github.com/apache/spark/pull/31141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] LuciferYang commented on a change in pull request #31125: [SPARK-34068][CORE][SQL][MLLIB][GRAPHX] Remove redundant collection conversion

2021-01-11 Thread GitBox
LuciferYang commented on a change in pull request #31125: URL: https://github.com/apache/spark/pull/31125#discussion_r29530 ## File path: core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala ## @@ -227,7 +227,7 @@ private[spark] class

[GitHub] [spark] SparkQA removed a comment on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
SparkQA removed a comment on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758413734 **[Test build #133960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133960/testReport)** for PR 30751 at commit

[GitHub] [spark] SparkQA commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
SparkQA commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758419700 **[Test build #133960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133960/testReport)** for PR 30751 at commit

[GitHub] [spark] SparkQA commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
SparkQA commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758416093 **[Test build #133959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133959/testReport)** for PR 31143 at commit

[GitHub] [spark] SparkQA commented on pull request #31146: [SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
SparkQA commented on pull request #31146: URL: https://github.com/apache/spark/pull/31146#issuecomment-758416020 **[Test build #133956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133956/testReport)** for PR 31146 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31119: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

2021-01-11 Thread GitBox
cloud-fan commented on a change in pull request #31119: URL: https://github.com/apache/spark/pull/31119#discussion_r24765 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala ## @@ -74,7 +74,9 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31145: [SPARK-24081][SQL] Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases

2021-01-11 Thread GitBox
SparkQA commented on pull request #31145: URL: https://github.com/apache/spark/pull/31145#issuecomment-758415757 **[Test build #133957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133957/testReport)** for PR 31145 at commit

[GitHub] [spark] SparkQA commented on pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

2021-01-11 Thread GitBox
SparkQA commented on pull request #31144: URL: https://github.com/apache/spark/pull/31144#issuecomment-758415775 **[Test build #133958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133958/testReport)** for PR 31144 at commit

[GitHub] [spark] cloud-fan commented on pull request #31114: [SPARK-34062][SQL] Call `updateTableStats()` from `AlterTableAddPartitionCommand`

2021-01-11 Thread GitBox
cloud-fan commented on pull request #31114: URL: https://github.com/apache/spark/pull/31114#issuecomment-758414354 is there a way to make `updateTableStats()` more generic so that it can be used in ADD PARTITION without perf regression?

[GitHub] [spark] SparkQA commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
SparkQA commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758413734 **[Test build #133960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133960/testReport)** for PR 30751 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31142: [SPARK-33346][CORE][SQL][MLLIB] Use 'val' instead of 'var' when possible.

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31142: URL: https://github.com/apache/spark/pull/31142#issuecomment-758412788 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38542/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31122: [SPARK-34067][SQL] PartitionPruning push down pruningHasBenefit function into insertPredicate function to decrease calculate ti

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31122: URL: https://github.com/apache/spark/pull/31122#issuecomment-758412789 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133949/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758412786 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38540/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758412787 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38541/

[GitHub] [spark] AmplabJenkins commented on pull request #31122: [SPARK-34067][SQL] PartitionPruning push down pruningHasBenefit function into insertPredicate function to decrease calculate time

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31122: URL: https://github.com/apache/spark/pull/31122#issuecomment-758412789 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133949/

[GitHub] [spark] AmplabJenkins commented on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758412787 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38541/

[GitHub] [spark] AmplabJenkins commented on pull request #31142: [SPARK-33346][CORE][SQL][MLLIB] Use 'val' instead of 'var' when possible.

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31142: URL: https://github.com/apache/spark/pull/31142#issuecomment-758412788 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38542/

[GitHub] [spark] AmplabJenkins commented on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758412786 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38540/

[GitHub] [spark] dongjoon-hyun closed pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
dongjoon-hyun closed pull request #31140: URL: https://github.com/apache/spark/pull/31140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
dongjoon-hyun commented on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758412252 Merged to branch-3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
cloud-fan commented on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758412196 thanks, merging to 3.0! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] LantaoJin opened a new pull request #31146: [SPARK-34082][SQL] Window expressions with alias inside WHERE and HAVING clauses fail with explicit exceptions

2021-01-11 Thread GitBox
LantaoJin opened a new pull request #31146: URL: https://github.com/apache/spark/pull/31146 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
HyukjinKwon commented on a change in pull request #31143: URL: https://github.com/apache/spark/pull/31143#discussion_r19355 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1551,6 +1551,14 @@ object SQLConf { "must be

[GitHub] [spark] wangyum opened a new pull request #31145: [SPARK-24081][SQL] Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases

2021-01-11 Thread GitBox
wangyum opened a new pull request #31145: URL: https://github.com/apache/spark/pull/31145 ### What changes were proposed in this pull request? Should not pushdown LeftSemi/LeftAnti over Aggregate for some cases. ```scala spark.range(5).selectExpr("id as a", "id as

[GitHub] [spark] beliefer commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
beliefer commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758405277 LGTM. I left one comment. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #31122: [SPARK-34067][SQL] PartitionPruning push down pruningHasBenefit function into insertPredicate function to decrease calculate time

2021-01-11 Thread GitBox
SparkQA removed a comment on pull request #31122: URL: https://github.com/apache/spark/pull/31122#issuecomment-758314976 **[Test build #133949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133949/testReport)** for PR 31122 at commit

[GitHub] [spark] beliefer commented on a change in pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
beliefer commented on a change in pull request #31143: URL: https://github.com/apache/spark/pull/31143#discussion_r16927 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Count.scala ## @@ -51,8 +52,11 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31122: [SPARK-34067][SQL] PartitionPruning push down pruningHasBenefit function into insertPredicate function to decrease calculate time

2021-01-11 Thread GitBox
SparkQA commented on pull request #31122: URL: https://github.com/apache/spark/pull/31122#issuecomment-758404706 **[Test build #133949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133949/testReport)** for PR 31122 at commit

[GitHub] [spark] SparkQA commented on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
SparkQA commented on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758404684 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38541/

[GitHub] [spark] sarutak opened a new pull request #31144: [SPARK-33690][SQL][FOLLOWUP] Escape further meta-characters in showString

2021-01-11 Thread GitBox
sarutak opened a new pull request #31144: URL: https://github.com/apache/spark/pull/31144 ### What changes were proposed in this pull request? This is a followup PR for SPARK-33690 (#30647) . In addition to the original PR, this PR intends to escape the following meta-characters

[GitHub] [spark] gengliangwang commented on pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
gengliangwang commented on pull request #31143: URL: https://github.com/apache/spark/pull/31143#issuecomment-758402540 cc @beliefer @cloud-fan @HyukjinKwon This is an automated message from the Apache Git Service. To

[GitHub] [spark] gengliangwang opened a new pull request #31143: [SPARK-28646][SQL][FOLLOWUP] Add legacy config for allowing parameterless count

2021-01-11 Thread GitBox
gengliangwang opened a new pull request #31143: URL: https://github.com/apache/spark/pull/31143 ### What changes were proposed in this pull request? Add a legacy configuration `spark.sql.legacy.allowParameterlessCount` in case users need the parameterless count. This is a

[GitHub] [spark] holdenk commented on pull request #30751: [SPARK-32617][K8S][TESTS] Configure kubernetes client based on kubeconfig settings in kubernetes integration tests

2021-01-11 Thread GitBox
holdenk commented on pull request #30751: URL: https://github.com/apache/spark/pull/30751#issuecomment-758399803 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #31140: [SPARK-31952][SQL][3.0] Fix incorrect memory spill metric when doing Aggregate

2021-01-11 Thread GitBox
SparkQA commented on pull request #31140: URL: https://github.com/apache/spark/pull/31140#issuecomment-758394996 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38540/

[GitHub] [spark] mridulm commented on pull request #31138: [SPARK-34059][SQL][CORE][3.0] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
mridulm commented on pull request #31138: URL: https://github.com/apache/spark/pull/31138#issuecomment-758392825 +1 Thanks for backporting this @HyukjinKwon ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] mridulm commented on pull request #31139: [SPARK-34059][SQL][CORE][2.4] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
mridulm commented on pull request #31139: URL: https://github.com/apache/spark/pull/31139#issuecomment-758392721 +1 Thanks for backporting this @HyukjinKwon ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] mridulm commented on pull request #31137: [SPARK-34059][SQL][CORE][3.1] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
mridulm commented on pull request #31137: URL: https://github.com/apache/spark/pull/31137#issuecomment-758392568 +1 Thanks for backporting this @HyukjinKwon ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #31142: [SPARK-33346][CORE][SQL][MLLIB] Use 'val' instead of 'var' when possible.

2021-01-11 Thread GitBox
SparkQA commented on pull request #31142: URL: https://github.com/apache/spark/pull/31142#issuecomment-758391427 **[Test build #133955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133955/testReport)** for PR 31142 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31138: [SPARK-34059][SQL][CORE][3.0] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31138: URL: https://github.com/apache/spark/pull/31138#issuecomment-758390168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133951/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31139: [SPARK-34059][SQL][CORE][2.4] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31139: URL: https://github.com/apache/spark/pull/31139#issuecomment-758390169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133950/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31129: [SPARK-34003][SQL][FOLLOWUP] Avoid pushing modified Char/Varchar sort attributes into aggregate for existing ones

2021-01-11 Thread GitBox
AmplabJenkins removed a comment on pull request #31129: URL: https://github.com/apache/spark/pull/31129#issuecomment-758390170 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38539/

[GitHub] [spark] AmplabJenkins commented on pull request #31141: Update TableReader.scala

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31141: URL: https://github.com/apache/spark/pull/31141#issuecomment-758390390 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #31139: [SPARK-34059][SQL][CORE][2.4] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31139: URL: https://github.com/apache/spark/pull/31139#issuecomment-758390169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133950/

[GitHub] [spark] AmplabJenkins commented on pull request #31129: [SPARK-34003][SQL][FOLLOWUP] Avoid pushing modified Char/Varchar sort attributes into aggregate for existing ones

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31129: URL: https://github.com/apache/spark/pull/31129#issuecomment-758390170 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38539/

[GitHub] [spark] AmplabJenkins commented on pull request #31138: [SPARK-34059][SQL][CORE][3.0] Use for/foreach rather than map to make sure execute it eagerly

2021-01-11 Thread GitBox
AmplabJenkins commented on pull request #31138: URL: https://github.com/apache/spark/pull/31138#issuecomment-758390168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133951/

[GitHub] [spark] SparkQA commented on pull request #31127: [SPARK-34069][CORE] Kill barrier tasks should respect SPARK_JOB_INTERRUPT_ON_CANCEL

2021-01-11 Thread GitBox
SparkQA commented on pull request #31127: URL: https://github.com/apache/spark/pull/31127#issuecomment-758389754 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38541/

  1   2   3   4   5   6   7   >