[GitHub] [spark] cloud-fan commented on a change in pull request #31281: [SPARK-34192][SQL] Move char padding to write side and remove length check on read side too

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31281: URL: https://github.com/apache/spark/pull/31281#discussion_r562449366 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala ## @@ -222,16 +155,14 @@ object CharVarcharUtils ex

[GitHub] [spark] cloud-fan commented on a change in pull request #31281: [SPARK-34192][SQL] Move char padding to write side and remove length check on read side too

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31281: URL: https://github.com/apache/spark/pull/31281#discussion_r562448792 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java ## @@ -22,55 +22,34 @@ public class CharVarch

[GitHub] [spark] yaooqinn commented on a change in pull request #31281: [SPARK-34192][SQL] Move char padding to write side and remove length check on read side too

2021-01-21 Thread GitBox
yaooqinn commented on a change in pull request #31281: URL: https://github.com/apache/spark/pull/31281#discussion_r562446776 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java ## @@ -54,8 +51,6 @@ public static UTF8String v

[GitHub] [spark] SparkQA commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
SparkQA commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-765209456 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38940/ ---

[GitHub] [spark] sarutak edited a comment on pull request #31290: [SPARK-33813][SQL][3.0] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak edited a comment on pull request #31290: URL: https://github.com/apache/spark/pull/31290#issuecomment-765205276 For reviewers: Currently, building test code for `docker-integration-tests` in `branch-3.0` seems to fail due to `ojdbc6:11.2.0.1.0` and `jdb2jcc4:10.5.0.5` are not avail

[GitHub] [spark] sarutak commented on pull request #31290: [SPARK-33813][SQL][3.0] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak commented on pull request #31290: URL: https://github.com/apache/spark/pull/31290#issuecomment-765205744 cc: @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] sarutak commented on pull request #31290: [SPARK-33813][SQL][3.0] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak commented on pull request #31290: URL: https://github.com/apache/spark/pull/31290#issuecomment-765205276 For reviewers: Currently building test code for `docker-integration-tests` fails due to `ojdbc6:11.2.0.1.0` and `jdb2jcc4:10.5.0.5` are not available (I'll fix them in another P

[GitHub] [spark] cloud-fan commented on a change in pull request #31083: [SPARK-34026][SQL] Inject repartition and sort nodes to satisfy required distribution and ordering

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31083: URL: https://github.com/apache/spark/pull/31083#discussion_r562441080 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/WriteDistributionAndOrderingSuite.scala ## @@ -0,0 +1,616 @@ +/* + * Licensed to t

[GitHub] [spark] sarutak opened a new pull request #31290: [SPARK-33813][SQL][3.0] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak opened a new pull request #31290: URL: https://github.com/apache/spark/pull/31290 ### What changes were proposed in this pull request? This PR backports SPARK-33813 (#31283). This PR fixes the issue that reading tables which contain spatial datatypes from MS SQL Server fai

[GitHub] [spark] SparkQA removed a comment on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-765162138 **[Test build #134354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134354/testReport)** for PR 31272 at commit [`59062f1`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
SparkQA commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-765201868 **[Test build #134354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134354/testReport)** for PR 31272 at commit [`59062f1`](https://github.co

[GitHub] [spark] sarutak closed pull request #31289: [SPARK-33813][SQL][3.0] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak closed pull request #31289: URL: https://github.com/apache/spark/pull/31289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] sarutak opened a new pull request #31289: [SPARK-33813][SQL][3.0] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak opened a new pull request #31289: URL: https://github.com/apache/spark/pull/31289 ### What changes were proposed in this pull request? This PR fixes the issue that reading tables which contain spatial datatypes from MS SQL Server fails. MS SQL server supports two non-stand

[GitHub] [spark] cloud-fan commented on a change in pull request #31083: [SPARK-34026][SQL] Inject repartition and sort nodes to satisfy required distribution and ordering

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31083: URL: https://github.com/apache/spark/pull/31083#discussion_r562438219 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala ## @@ -0,0 +1,110 @@ +/* + * Lic

[GitHub] [spark] cloud-fan commented on a change in pull request #31083: [SPARK-34026][SQL] Inject repartition and sort nodes to satisfy required distribution and ordering

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31083: URL: https://github.com/apache/spark/pull/31083#discussion_r562438219 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala ## @@ -0,0 +1,110 @@ +/* + * Lic

[GitHub] [spark] SparkQA commented on pull request #31287: [SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

2021-01-21 Thread GitBox
SparkQA commented on pull request #31287: URL: https://github.com/apache/spark/pull/31287#issuecomment-765197477 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38939/ ---

[GitHub] [spark] cloud-fan commented on a change in pull request #31083: [SPARK-34026][SQL] Inject repartition and sort nodes to satisfy required distribution and ordering

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31083: URL: https://github.com/apache/spark/pull/31083#discussion_r562434347 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala ## @@ -0,0 +1,110 @@ +/* + * Lic

[GitHub] [spark] cloud-fan closed pull request #31269: [SPARK-33933][SQL] Materialize BroadcastQueryStage first to try to avoid broadcast timeout in AQE

2021-01-21 Thread GitBox
cloud-fan closed pull request #31269: URL: https://github.com/apache/spark/pull/31269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] cloud-fan commented on pull request #31269: [SPARK-33933][SQL] Materialize BroadcastQueryStage first to try to avoid broadcast timeout in AQE

2021-01-21 Thread GitBox
cloud-fan commented on pull request #31269: URL: https://github.com/apache/spark/pull/31269#issuecomment-765192924 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] SparkQA commented on pull request #31288: [SPARK-33813][SQL][3.1] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
SparkQA commented on pull request #31288: URL: https://github.com/apache/spark/pull/31288#issuecomment-765192590 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38938/ ---

[GitHub] [spark] SparkQA commented on pull request #31281: [SPARK-34192][SQL] Move char padding to write side and remove length check on read side too

2021-01-21 Thread GitBox
SparkQA commented on pull request #31281: URL: https://github.com/apache/spark/pull/31281#issuecomment-765189914 **[Test build #134355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134355/testReport)** for PR 31281 at commit [`4235420`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765184946 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134349/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-765184947 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38937/

[GitHub] [spark] AmplabJenkins commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-765184947 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38937/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765184946 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134349/ -

[GitHub] [spark] SparkQA commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
SparkQA commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-765184956 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38940/ -

[GitHub] [spark] cloud-fan commented on pull request #31287: [SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

2021-01-21 Thread GitBox
cloud-fan commented on pull request #31287: URL: https://github.com/apache/spark/pull/31287#issuecomment-765183307 Ah actually this fixes a 3.1 regression. Previously we merged a bug fix: https://github.com/apache/spark/pull/30488 , which makes sure ambiguous self-join check is always appl

[GitHub] [spark] SparkQA removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765132112 **[Test build #134349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134349/testReport)** for PR 31286 at commit [`e6fa9b0`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31287: [SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

2021-01-21 Thread GitBox
SparkQA commented on pull request #31287: URL: https://github.com/apache/spark/pull/31287#issuecomment-765181278 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38939/ -

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765181060 **[Test build #134349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134349/testReport)** for PR 31286 at commit [`e6fa9b0`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31288: [SPARK-33813][SQL][3.1] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
SparkQA commented on pull request #31288: URL: https://github.com/apache/spark/pull/31288#issuecomment-765178710 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38938/ -

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-21 Thread GitBox
SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-765178506 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38937/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765159710 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38936/

[GitHub] [spark] SparkQA removed a comment on pull request #31285: [SPARK-33489][PYSPARK] Add NullType support for Arrow executions.

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31285: URL: https://github.com/apache/spark/pull/31285#issuecomment-765051262 **[Test build #134346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134346/testReport)** for PR 31285 at commit [`419bb92`](https://gi

[GitHub] [spark] sarutak commented on pull request #31288: [SPARK-33813][SQL][3.1] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak commented on pull request #31288: URL: https://github.com/apache/spark/pull/31288#issuecomment-765143596 cc: @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] beliefer commented on a change in pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
beliefer commented on a change in pull request #31272: URL: https://github.com/apache/spark/pull/31272#discussion_r562392837 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala ## @@ -60,10 +60,16 @@ object StringUtils extends Logging

[GitHub] [spark] advancedxy commented on a change in pull request #23812: [SPARK-26903][SQL] Remove the TimeZone cache

2021-01-21 Thread GitBox
advancedxy commented on a change in pull request #23812: URL: https://github.com/apache/spark/pull/23812#discussion_r562406723 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -67,13 +66,9 @@ object DateTimeUtils { def

[GitHub] [spark] viirya commented on pull request #31287: [SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

2021-01-21 Thread GitBox
viirya commented on pull request #31287: URL: https://github.com/apache/spark/pull/31287#issuecomment-765163123 BTW, the `Join` example in the PR description is not aligned properly. This is an automated message from the Apac

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765148673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-765159710 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38936/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31285: [SPARK-33489][PYSPARK] Add NullType support for Arrow executions.

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31285: URL: https://github.com/apache/spark/pull/31285#issuecomment-765155837 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134346/ -

[GitHub] [spark] SparkQA commented on pull request #31287: [SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

2021-01-21 Thread GitBox
SparkQA commented on pull request #31287: URL: https://github.com/apache/spark/pull/31287#issuecomment-765161849 **[Test build #134353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134353/testReport)** for PR 31287 at commit [`2c34ade`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-765155839 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134348/ -

[GitHub] [spark] sarutak opened a new pull request #31288: [SPARK-33813][SQL][3.1] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak opened a new pull request #31288: URL: https://github.com/apache/spark/pull/31288 ### What changes were proposed in this pull request? This PR backports SPARK-33813 (#31283). This PR fixes the issue that reading tables which contain spatial datatypes from MS SQL Server fai

[GitHub] [spark] AmplabJenkins commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-765155839 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134348/ -

[GitHub] [spark] SparkQA commented on pull request #31288: [SPARK-33813][SQL][3.1] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
SparkQA commented on pull request #31288: URL: https://github.com/apache/spark/pull/31288#issuecomment-765161115 **[Test build #134352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134352/testReport)** for PR 31288 at commit [`f49bfa1`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31270: [SPARK-34180][SQL] Revert SPARK-33888

2021-01-21 Thread GitBox
SparkQA commented on pull request #31270: URL: https://github.com/apache/spark/pull/31270#issuecomment-764317607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #31249: [SPARK-34104][SPARK-34105][CORE][K8S] Maximum decommissioning time & allow decommissioning for excludes

2021-01-21 Thread GitBox
SparkQA commented on pull request #31249: URL: https://github.com/apache/spark/pull/31249#issuecomment-764434865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] zhongyu09 commented on pull request #31269: [SPARK-33933][SQL] Materialize BroadcastQueryStage first to try to avoid broadcast timeout in AQE

2021-01-21 Thread GitBox
zhongyu09 commented on pull request #31269: URL: https://github.com/apache/spark/pull/31269#issuecomment-764449369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [spark] cloud-fan commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering

2021-01-21 Thread GitBox
cloud-fan commented on pull request #31250: URL: https://github.com/apache/spark/pull/31250#issuecomment-764476215 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] cloud-fan closed pull request #31277: [SPARK-33901][SQL][FOLLOWUP] Add drop table in charvarchar test

2021-01-21 Thread GitBox
cloud-fan closed pull request #31277: URL: https://github.com/apache/spark/pull/31277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31178: [SPARK-34096][SQL] Improve performance for nth_value ignore nulls over offset window

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31178: URL: https://github.com/apache/spark/pull/31178#issuecomment-763898643 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] WeichenXu123 commented on pull request #31266: [MINOR][TESTS] Increase tolerance to 0.2 for NaiveBayesSuite

2021-01-21 Thread GitBox
WeichenXu123 commented on pull request #31266: URL: https://github.com/apache/spark/pull/31266#issuecomment-764087423 @dongjoon-hyun I think this need to backport to branch 3.1/3.0 This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31231: [SPARK-34087][SQL] Make ExecutionListenerManager.listenerBus removable.

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31231: URL: https://github.com/apache/spark/pull/31231#issuecomment-762095180 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #31262: [SPARK-34180][SQL] Fix the regression brought by SPARK-33888 for PostgresDialect

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31262: URL: https://github.com/apache/spark/pull/31262#issuecomment-763898640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #31268: [SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31268: URL: https://github.com/apache/spark/pull/31268#issuecomment-764201685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #31266: [MINOR][TESTS] Increase tolerance to 0.2 for NaiveBayesSuite

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31266: URL: https://github.com/apache/spark/pull/31266#issuecomment-764056895 **[Test build #134294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134294/testReport)** for PR 31266 at commit [`18b050b`](https://gi

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31219: [SPARK-34148][TEST][SS] Move general StateStore tests to StateStoreSuiteBase

2021-01-21 Thread GitBox
dongjoon-hyun edited a comment on pull request #31219: URL: https://github.com/apache/spark/pull/31219#issuecomment-764797579 BTW, this is a test case refactoring without losing a test coverage. In this case, the root cause of veto is the following, @zsxwing ? > This would cause extra wo

[GitHub] [spark] SparkQA commented on pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

2021-01-21 Thread GitBox
SparkQA commented on pull request #31272: URL: https://github.com/apache/spark/pull/31272#issuecomment-764355060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] HyukjinKwon commented on pull request #31285: [SPARK-33489][PYSPARK] Add NullType support for Arrow executions.

2021-01-21 Thread GitBox
HyukjinKwon commented on pull request #31285: URL: https://github.com/apache/spark/pull/31285#issuecomment-765098393 cc @BryanCutler FYI This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] hanyucui closed pull request #31256: [WIP] Fix spark.dynamicAllocation.cachedExecutorIdleTimeout

2021-01-21 Thread GitBox
hanyucui closed pull request #31256: URL: https://github.com/apache/spark/pull/31256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] SparkQA commented on pull request #31258: [SPARK-34168] [SQL] Support DPP in AQE when the join is Broadcast hash join at the beginning

2021-01-21 Thread GitBox
SparkQA commented on pull request #31258: URL: https://github.com/apache/spark/pull/31258#issuecomment-764489958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] cloud-fan commented on a change in pull request #30902: [SPARK-33888][SQL] JDBC SQL TIME type represents incorrectly as TimestampType, it should be physical Int in millis

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #30902: URL: https://github.com/apache/spark/pull/30902#discussion_r561601546 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -408,6 +421,23 @@ object JdbcUtils extends

[GitHub] [spark] SparkQA commented on pull request #31276: [SPARK-34189][ML] w2v findSynonyms optimization

2021-01-21 Thread GitBox
SparkQA commented on pull request #31276: URL: https://github.com/apache/spark/pull/31276#issuecomment-764495375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] beliefer commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-21 Thread GitBox
beliefer commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-764703036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #16478: [SPARK-7768][SQL] Revise user defined types (UDT)

2021-01-21 Thread GitBox
SparkQA commented on pull request #16478: URL: https://github.com/apache/spark/pull/16478#issuecomment-765025445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #31269: [SPARK-33933][SQL] Materialize BroadcastQueryStage first to try to avoid broadcast timeout in AQE

2021-01-21 Thread GitBox
SparkQA commented on pull request #31269: URL: https://github.com/apache/spark/pull/31269#issuecomment-764364332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] yaooqinn commented on a change in pull request #31281: [SPARK-34192][SQL] Move char padding to write side and remove length check on read side too

2021-01-21 Thread GitBox
yaooqinn commented on a change in pull request #31281: URL: https://github.com/apache/spark/pull/31281#discussion_r562367529 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala ## @@ -56,7 +56,7 @@ trait CharVarcharTestSuite extends QueryTest

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31274: [SPARK-34186][SQL][TESTS] Fix DockerJDBCIntegrationSuites to reflect the change of SPARK-33888

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31274: URL: https://github.com/apache/spark/pull/31274#issuecomment-764457458 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #31269: [SPARK-33933][SQL] Materialize BroadcastQueryStage first to try to avoid broadcast timeout in AQE

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31269: URL: https://github.com/apache/spark/pull/31269#discussion_r561615950 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1460,4 +1460,29 @@ class AdaptiveQuer

[GitHub] [spark] SparkQA commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
SparkQA commented on pull request #31283: URL: https://github.com/apache/spark/pull/31283#issuecomment-764752437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] dongjoon-hyun commented on pull request #31278: [SPARK-34188][SQL] Estimate the statistics with the origin expr with charvarchar in CBO

2021-01-21 Thread GitBox
dongjoon-hyun commented on pull request #31278: URL: https://github.com/apache/spark/pull/31278#issuecomment-765015317 Thank you for pinging me, @yaooqinn . Yes. This is the one I was curious on the PR. This is an automated

[GitHub] [spark] SparkQA removed a comment on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade Parquet to 1.11.1

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-764058969 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] HyukjinKwon commented on pull request #31238: [SPARK-32194][PYTHON] Add more refined pyspark exceptions

2021-01-21 Thread GitBox
HyukjinKwon commented on pull request #31238: URL: https://github.com/apache/spark/pull/31238#issuecomment-765044020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] AmplabJenkins commented on pull request #31282: [WIP][SPARK-34191][PYTHON][SQL] Add typing for udf overload

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31282: URL: https://github.com/apache/spark/pull/31282#issuecomment-764708079 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31283: URL: https://github.com/apache/spark/pull/31283#issuecomment-764836341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #31249: [SPARK-34104][SPARK-34105][CORE][K8S] Maximum decommissioning time & allow decommissioning for excludes

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31249: URL: https://github.com/apache/spark/pull/31249#issuecomment-764434865 **[Test build #134312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134312/testReport)** for PR 31249 at commit [`c55b26d`](https://gi

[GitHub] [spark] zsxwing commented on pull request #31219: [SPARK-34148][TEST][SS] Move general StateStore tests to StateStoreSuiteBase

2021-01-21 Thread GitBox
zsxwing commented on pull request #31219: URL: https://github.com/apache/spark/pull/31219#issuecomment-764732644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade Parquet to 1.11.1

2021-01-21 Thread GitBox
SparkQA commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-764058969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] xuanyuanking commented on pull request #31271: [SPARK-34185][DOCS] Review and fix issues in API docs

2021-01-21 Thread GitBox
xuanyuanking commented on pull request #31271: URL: https://github.com/apache/spark/pull/31271#issuecomment-764312725 cc @HyukjinKwon @cloud-fan This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] SparkQA removed a comment on pull request #31277: [SPARK-33901][SQL][FOLLOWUP] Add drop table in charvarchar test

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31277: URL: https://github.com/apache/spark/pull/31277#issuecomment-764494863 **[Test build #134319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134319/testReport)** for PR 31277 at commit [`1bd6631`](https://gi

[GitHub] [spark] LuciferYang commented on pull request #31259: [SPARK-34176][BUILD] Restore the independent mvn test ability of sql/hive module in Scala 2.13

2021-01-21 Thread GitBox
LuciferYang commented on pull request #31259: URL: https://github.com/apache/spark/pull/31259#issuecomment-765067466 thx ~ @HyukjinKwon and @dongjoon-hyun This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins commented on pull request #31267: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31267: URL: https://github.com/apache/spark/pull/31267#issuecomment-764181623 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] cloud-fan closed pull request #31228: [SPARK-33541][SQL] Group exception messages in catalyst/expressions

2021-01-21 Thread GitBox
cloud-fan closed pull request #31228: URL: https://github.com/apache/spark/pull/31228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] SparkQA commented on pull request #31268: [SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions

2021-01-21 Thread GitBox
SparkQA commented on pull request #31268: URL: https://github.com/apache/spark/pull/31268#issuecomment-764185835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-21 Thread GitBox
beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r562391414 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala ## @@ -40,7 +40,7 @@ case class ShowTablesExec(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31269: [SPARK-33933][SQL] Materialize BroadcastQueryStage first to try to avoid broadcast timeout in AQE

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31269: URL: https://github.com/apache/spark/pull/31269#issuecomment-764232341 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #31278: [SPARK-34188][SQL] Estimate the statistics with the origin expr with charvarchar in CBO

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #31278: URL: https://github.com/apache/spark/pull/31278#issuecomment-764558444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on a change in pull request #31206: [SPARK-34138][SQL] Keep dependants cached while refreshing v1 tables

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31206: URL: https://github.com/apache/spark/pull/31206#discussion_r561612958 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -170,6 +170,13 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on a change in pull request #31201: [SPARK-34133][AVRO] Respect case sensitivity when performing Catalyst-to-Avro field matching

2021-01-21 Thread GitBox
cloud-fan commented on a change in pull request #31201: URL: https://github.com/apache/spark/pull/31201#discussion_r561857338 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroUtils.scala ## @@ -201,4 +201,25 @@ private[sql] object AvroUtils extends Logg

[GitHub] [spark] AmplabJenkins removed a comment on pull request #16478: [SPARK-7768][SQL] Revise user defined types (UDT)

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #16478: URL: https://github.com/apache/spark/pull/16478#issuecomment-765047632 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38931/

[GitHub] [spark] SparkQA removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

2021-01-21 Thread GitBox
SparkQA removed a comment on pull request #31012: URL: https://github.com/apache/spark/pull/31012#issuecomment-763836658 **[Test build #134290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134290/testReport)** for PR 31012 at commit [`7502623`](https://gi

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30555: [SPARK-33608][SQL] Handle DELETE/UPDATE/MERGE in PullupCorrelatedPredicates

2021-01-21 Thread GitBox
dongjoon-hyun edited a comment on pull request #30555: URL: https://github.com/apache/spark/pull/30555#issuecomment-764788244 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [spark] sarutak commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
sarutak commented on pull request #31283: URL: https://github.com/apache/spark/pull/31283#issuecomment-764746776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #31178: [SPARK-34096][SQL] Improve performance for nth_value ignore nulls over offset window

2021-01-21 Thread GitBox
SparkQA commented on pull request #31178: URL: https://github.com/apache/spark/pull/31178#issuecomment-763904422 **[Test build #134285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134285/testReport)** for PR 31178 at commit [`bf17bae`](https://github.co

[GitHub] [spark] cloud-fan commented on pull request #31287: [SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

2021-01-21 Thread GitBox
cloud-fan commented on pull request #31287: URL: https://github.com/apache/spark/pull/31287#issuecomment-765134286 cc @Ngone51 @viirya @maropu This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31271: [SPARK-34185][DOCS] Review and fix issues in API docs

2021-01-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31271: URL: https://github.com/apache/spark/pull/31271#issuecomment-764431523 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types

2021-01-21 Thread GitBox
cloud-fan commented on pull request #31283: URL: https://github.com/apache/spark/pull/31283#issuecomment-765113008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31271: [SPARK-34185][DOCS] Review and fix issues in API docs

2021-01-21 Thread GitBox
HyukjinKwon commented on a change in pull request #31271: URL: https://github.com/apache/spark/pull/31271#discussion_r561708813 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1268,7 +1268,7 @@ private[hive] object HiveClientI

[GitHub] [spark] AmplabJenkins commented on pull request #16478: [SPARK-7768][SQL] Revise user defined types (UDT)

2021-01-21 Thread GitBox
AmplabJenkins commented on pull request #16478: URL: https://github.com/apache/spark/pull/16478#issuecomment-765047632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

  1   2   3   4   5   6   7   8   9   >