[GitHub] [spark] SparkQA removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-768021322 **[Test build #134535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134535/testReport)** for PR 31286 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768021257 **[Test build #134532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134532/testReport)** for PR 31341 at commit

[GitHub] [spark] beliefer commented on a change in pull request #31293: [SPARK-33601][SQL] Group exception messages in catalyst/parser

2021-01-27 Thread GitBox
beliefer commented on a change in pull request #31293: URL: https://github.com/apache/spark/pull/31293#discussion_r565122119 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache

[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

2021-01-27 Thread GitBox
SparkQA commented on pull request #31341: URL: https://github.com/apache/spark/pull/31341#issuecomment-768128675 **[Test build #134532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134532/testReport)** for PR 31341 at commit

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-01-27 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-768128221 **[Test build #134535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134535/testReport)** for PR 31286 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31357: [SPARK-34212][SQL][FOLLOWUP] Refine the behavior of reading parquet non-decimal fields as decimal

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31357: URL: https://github.com/apache/spark/pull/31357#discussion_r565119836 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3871,52 +3871,56 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31319: URL: https://github.com/apache/spark/pull/31319#discussion_r565018052 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3868,6 +3869,57 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768125712 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134538/

[GitHub] [spark] AmplabJenkins commented on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768125712 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134538/

[GitHub] [spark] cloud-fan commented on a change in pull request #31319: [SPARK-34212][SQL] Fix incorrect decimal reading from Parquet files

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31319: URL: https://github.com/apache/spark/pull/31319#discussion_r565117876 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3868,6 +3869,57 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] SparkQA removed a comment on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768094325 **[Test build #134538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134538/testReport)** for PR 31354 at commit

[GitHub] [spark] SparkQA commented on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

2021-01-27 Thread GitBox
SparkQA commented on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768125283 **[Test build #134538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134538/testReport)** for PR 31354 at commit

[GitHub] [spark] cloud-fan opened a new pull request #31357: [SPARK-34212][SQL][FOLLOWUP] Refine the behavior of reading parquet non-decimal fields as decimal

2021-01-27 Thread GitBox
cloud-fan opened a new pull request #31357: URL: https://github.com/apache/spark/pull/31357 ### What changes were proposed in this pull request? This is a followup of https://github.com/apache/spark/pull/31319 . When reading parquet int/long as decimal, the behavior

[GitHub] [spark] beliefer commented on pull request #31312: [SPARK-33542][SQL][FOLLOWUP] Group exception messages in catalyst/catalog

2021-01-27 Thread GitBox
beliefer commented on pull request #31312: URL: https://github.com/apache/spark/pull/31312#issuecomment-768124141 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] SparkQA commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
SparkQA commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768120265 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39124/

[GitHub] [spark] beliefer opened a new pull request #31356: [SPARK-34257][SQL] Improve performance for last_value over unbounded window frame

2021-01-27 Thread GitBox
beliefer opened a new pull request #31356: URL: https://github.com/apache/spark/pull/31356 ### What changes were proposed in this pull request? The current implement of `last_value` over unbounded window frame will execute `updateExpressions` multiple times. In fact, `last_value`

[GitHub] [spark] SparkQA commented on pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

2021-01-27 Thread GitBox
SparkQA commented on pull request #31354: URL: https://github.com/apache/spark/pull/31354#issuecomment-768117231 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39123/

[GitHub] [spark] HyukjinKwon edited a comment on pull request #31223: [SPARK-31168][SPARK-33913][BUILD] Upgrade Scala to 2.12.13 and Kafka to 2.7.0

2021-01-27 Thread GitBox
HyukjinKwon edited a comment on pull request #31223: URL: https://github.com/apache/spark/pull/31223#issuecomment-768108712 Sure, thanks. Reverted for now. > I'd take a look at least. Sure, it would be great to know. Please share the result after the investigation.

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
HeartSaVioR edited a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768107101 Actually the proposal is more likely giving data source to force having static number of partitions regardless of output data. I see valid concerns about

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
HeartSaVioR edited a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768107101 Actually the proposal is more likely giving data source to force having static number of partitions regardless of output data. I see valid concerns about

[GitHub] [spark] HyukjinKwon commented on pull request #31223: [SPARK-31168][SPARK-33913][BUILD] Upgrade Scala to 2.12.13 and Kafka to 2.7.0

2021-01-27 Thread GitBox
HyukjinKwon commented on pull request #31223: URL: https://github.com/apache/spark/pull/31223#issuecomment-768108712 Sure, thanks. Reverted for now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] Ngone51 commented on pull request #31223: [SPARK-31168][SPARK-33913][BUILD] Upgrade Scala to 2.12.13 and Kafka to 2.7.0

2021-01-27 Thread GitBox
Ngone51 commented on pull request #31223: URL: https://github.com/apache/spark/pull/31223#issuecomment-768108319 Opened the ticket: https://issues.apache.org/jira/browse/SPARK-34258. Not sure how we add the test for such case in Spark. I'd take a look at least. Thanks

<    3   4   5   6   7   8