[GitHub] [spark] AmplabJenkins removed a comment on pull request #31382: [SPARK-34144][SQL][3.0] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31382: URL: https://github.com/apache/spark/pull/31382#issuecomment-769168012 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134613/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769168005 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39205/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-769168004 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134620/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-769023147 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769168005 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39205/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-769168004 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134620/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769168006 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39206/ -

[GitHub] [spark] AmplabJenkins commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-769168003 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134615/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31382: [SPARK-34144][SQL][3.0] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31382: URL: https://github.com/apache/spark/pull/31382#issuecomment-769168012 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134613/ -

[GitHub] [spark] revans2 commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
revans2 commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-769165342 > Why did Spark allocate an int column vector in the first place? If the parqeut field is INT64, we should use long column vector. There is an assumption in WriteableColum

[GitHub] [spark] SparkQA commented on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
SparkQA commented on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-769164590 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39208/ -

[GitHub] [spark] SparkQA removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768967553 **[Test build #134615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134615/testReport)** for PR 30175 at commit [`4893447`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-769158558 **[Test build #134615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134615/testReport)** for PR 30175 at commit [`4893447`](https://github.co

[GitHub] [spark] cloud-fan closed pull request #31353: [SPARK-34253][SQL] Object hash aggregate should not fallback if no more input rows

2021-01-28 Thread GitBox
cloud-fan closed pull request #31353: URL: https://github.com/apache/spark/pull/31353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] cloud-fan commented on pull request #31353: [SPARK-34253][SQL] Object hash aggregate should not fallback if no more input rows

2021-01-28 Thread GitBox
cloud-fan commented on pull request #31353: URL: https://github.com/apache/spark/pull/31353#issuecomment-769157058 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] cloud-fan commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
cloud-fan commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-769154273 > The reason this happens is because method readLong tries to write the long to a WritableColumnVector which has been initialized to accept only Ints which leads to a NullPoin

[GitHub] [spark] cloud-fan commented on a change in pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

2021-01-28 Thread GitBox
cloud-fan commented on a change in pull request #31340: URL: https://github.com/apache/spark/pull/31340#discussion_r566166649 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectHashAggregateExec.scala ## @@ -74,12 +74,17 @@ case class ObjectHa

[GitHub] [spark] SparkQA commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
SparkQA commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769144570 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39206/ ---

[GitHub] [spark] SparkQA removed a comment on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-769108495 **[Test build #134620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134620/testReport)** for PR 31207 at commit [`6198e0a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
SparkQA commented on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-769142839 **[Test build #134620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134620/testReport)** for PR 31207 at commit [`6198e0a`](https://github.co

[GitHub] [spark] srowen commented on a change in pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
srowen commented on a change in pull request #31385: URL: https://github.com/apache/spark/pull/31385#discussion_r566156140 ## File path: pom.xml ## @@ -967,6 +982,13 @@ 1.14.2 test + +org.junit +junit-bom +5.7.0 +p

[GitHub] [spark] tgravescs commented on a change in pull request #30714: [SPARK-33739] [SQL] Jobs committed through the S3A Magic committer don't track bytes

2021-01-28 Thread GitBox
tgravescs commented on a change in pull request #30714: URL: https://github.com/apache/spark/pull/30714#discussion_r566154624 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -66,14 +67,65 @@ class BasicWriteTa

[GitHub] [spark] tgravescs commented on a change in pull request #30714: [SPARK-33739] [SQL] Jobs committed through the S3A Magic committer don't track bytes

2021-01-28 Thread GitBox
tgravescs commented on a change in pull request #30714: URL: https://github.com/apache/spark/pull/30714#discussion_r566153947 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -66,14 +67,65 @@ class BasicWriteTa

[GitHub] [spark] SparkQA commented on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
SparkQA commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769131354 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39205/ ---

[GitHub] [spark] SparkQA removed a comment on pull request #31382: [SPARK-34144][SQL][3.0] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31382: URL: https://github.com/apache/spark/pull/31382#issuecomment-768966414 **[Test build #134613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134613/testReport)** for PR 31382 at commit [`6d55d7e`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31382: [SPARK-34144][SQL][3.0] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31382: URL: https://github.com/apache/spark/pull/31382#issuecomment-768924923 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #31367: [SPARK-34265][PYTHON][SQL] Instrument Python UDF using SQL Metrics

2021-01-28 Thread GitBox
SparkQA commented on pull request #31367: URL: https://github.com/apache/spark/pull/31367#issuecomment-769126081 **[Test build #134619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134619/testReport)** for PR 31367 at commit [`c6a1bdc`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31382: [SPARK-34144][SQL][3.0] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-28 Thread GitBox
SparkQA commented on pull request #31382: URL: https://github.com/apache/spark/pull/31382#issuecomment-769125616 **[Test build #134613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134613/testReport)** for PR 31382 at commit [`6d55d7e`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-769023149 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134600/ -

[GitHub] [spark] tgravescs commented on a change in pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
tgravescs commented on a change in pull request #31284: URL: https://github.com/apache/spark/pull/31284#discussion_r566146700 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala ## @@ -1196,6 +1196,24 @@ class ParquetIO

[GitHub] [spark] srowen closed pull request #31254: [SPARK-34165][SQL] Add count_distinct as an option to Dataset#summary

2021-01-28 Thread GitBox
srowen closed pull request #31254: URL: https://github.com/apache/spark/pull/31254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] srowen commented on pull request #31254: [SPARK-34165][SQL] Add count_distinct as an option to Dataset#summary

2021-01-28 Thread GitBox
srowen commented on pull request #31254: URL: https://github.com/apache/spark/pull/31254#issuecomment-769111532 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] SparkQA commented on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
SparkQA commented on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-769108495 **[Test build #134620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134620/testReport)** for PR 31207 at commit [`6198e0a`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31381: [SPARK-33867][SQL][3.0] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31381: URL: https://github.com/apache/spark/pull/31381#issuecomment-768898308 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769104935 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39204/

[GitHub] [spark] AmplabJenkins commented on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769104935 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39204/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31381: [SPARK-33867][SQL][3.0] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31381: URL: https://github.com/apache/spark/pull/31381#issuecomment-769104933 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134614/ -

[GitHub] [spark] SparkQA commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
SparkQA commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769101434 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39206/ -

[GitHub] [spark] SparkQA removed a comment on pull request #31381: [SPARK-33867][SQL][3.0] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31381: URL: https://github.com/apache/spark/pull/31381#issuecomment-768959970 **[Test build #134614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134614/testReport)** for PR 31381 at commit [`ae21911`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31381: [SPARK-33867][SQL][3.0] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-28 Thread GitBox
SparkQA commented on pull request #31381: URL: https://github.com/apache/spark/pull/31381#issuecomment-769098226 **[Test build #134614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134614/testReport)** for PR 31381 at commit [`ae21911`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
SparkQA commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769089332 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39205/ -

[GitHub] [spark] LuciferYang commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769084752 Seems does not change the behavior of scala test suites This is an automated message from the Apache

[GitHub] [spark] LuciferYang commented on a change in pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang commented on a change in pull request #31385: URL: https://github.com/apache/spark/pull/31385#discussion_r566101649 ## File path: common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java ## @@ -28,17 +28,18 @@ import com.google.common.collect.I

[GitHub] [spark] LuciferYang edited a comment on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang edited a comment on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769065067 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
maropu commented on a change in pull request #31384: URL: https://github.com/apache/spark/pull/31384#discussion_r566115941 ## File path: docs/sql-data-sources-jdbc.md ## @@ -202,13 +202,27 @@ the following case-insensitive options: keytab Location of the kerber

[GitHub] [spark] SparkQA commented on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
SparkQA commented on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769073585 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39204/ ---

[GitHub] [spark] zero323 commented on a change in pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-28 Thread GitBox
zero323 commented on a change in pull request #31207: URL: https://github.com/apache/spark/pull/31207#discussion_r566116398 ## File path: python/pyspark/sql/functions.py ## @@ -91,13 +92,48 @@ def lit(col): Creates a :class:`Column` of literal value. Review comment:

[GitHub] [spark] LuciferYang commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769065067 The suite use jupiter api run with maven should use Junit 5 jupiter engine , the thread stack as follow: ``` org.apache.spark.util.kvstore.LevelDBSuite.testReopenAnd

[GitHub] [spark] LuciferYang commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769063926 The old Junit 4.x suite run with maven will use `VintageTestEngine` automatically, the thread stack as follow: ``` java.lang.Thread.getStackTrace(Thread.java:1559)

[GitHub] [spark] SparkQA commented on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
SparkQA commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769063086 **[Test build #134617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134617/testReport)** for PR 31384 at commit [`7115245`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
SparkQA commented on pull request #31385: URL: https://github.com/apache/spark/pull/31385#issuecomment-769060388 **[Test build #134618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134618/testReport)** for PR 31385 at commit [`16c0f74`](https://github.com

[GitHub] [spark] LuciferYang commented on a change in pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang commented on a change in pull request #31385: URL: https://github.com/apache/spark/pull/31385#discussion_r566101649 ## File path: common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java ## @@ -28,17 +28,18 @@ import com.google.common.collect.I

[GitHub] [spark] LuciferYang opened a new pull request #31385: [SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-28 Thread GitBox
LuciferYang opened a new pull request #31385: URL: https://github.com/apache/spark/pull/31385 ### What changes were proposed in this pull request? The main purpose of this pr is to upgrade JUnit test framework from 4.x to 5.x. The main change as follows: - Introduce `junit-vintage

[GitHub] [spark] maropu commented on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
maropu commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769059332 Thanks, @gaborgsomogyi! This update looks useful. btw, for reviewers, could you add the screenshot of the updated doc in the PR description?

[GitHub] [spark] maropu commented on a change in pull request #31340: [SPARK-34237][SQL] Add more metrics (fallback, spill) to object hash aggregate

2021-01-28 Thread GitBox
maropu commented on a change in pull request #31340: URL: https://github.com/apache/spark/pull/31340#discussion_r566097445 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala ## @@ -76,6 +82,11 @@ class ObjectAggregati

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768958759 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-768958762 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
AmplabJenkins removed a comment on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769055424 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134616/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769055424 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134616/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-769055423 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134608/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-769055426 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134601/ -

[GitHub] [spark] SparkQA removed a comment on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-768895259 **[Test build #134608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134608/testReport)** for PR 31349 at commit [`8283e98`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-28 Thread GitBox
SparkQA commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-769049782 **[Test build #134608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134608/testReport)** for PR 31349 at commit [`8283e98`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-768998339 **[Test build #134616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134616/testReport)** for PR 31368 at commit [`a467ed6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
SparkQA commented on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769048526 **[Test build #134616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134616/testReport)** for PR 31368 at commit [`a467ed6`](https://github.co

[GitHub] [spark] gaborgsomogyi commented on pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
gaborgsomogyi commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-769035164 cc @dongjoon-hyun @maropu since you were involved in the implementation. This is an automated message from

[GitHub] [spark] gaborgsomogyi opened a new pull request #31384: [SPARK-31816][SQL] Added high level description about JDBC connection providers for users/developers

2021-01-28 Thread GitBox
gaborgsomogyi opened a new pull request #31384: URL: https://github.com/apache/spark/pull/31384 ### What changes were proposed in this pull request? JDBC connection provider API and embedded connection providers already added to the code but no in-depth description about the internals. I

[GitHub] [spark] maropu commented on pull request #31353: [SPARK-34253][SQL] Object hash aggregate should not fallback if no more input rows

2021-01-28 Thread GitBox
maropu commented on pull request #31353: URL: https://github.com/apache/spark/pull/31353#issuecomment-769032012 > ...based on number of keys seen so far 0. btw, '`0`' above is just a typo? This is an automated message

[GitHub] [spark] maropu commented on a change in pull request #31353: [SPARK-34253][SQL] Object hash aggregate should not fallback if no more input rows

2021-01-28 Thread GitBox
maropu commented on a change in pull request #31353: URL: https://github.com/apache/spark/pull/31353#discussion_r566069710 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala ## @@ -158,7 +158,7 @@ class ObjectAggregat

[GitHub] [spark] SparkQA removed a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768870502 **[Test build #134601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134601/testReport)** for PR 31355 at commit [`8b0eb56`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
SparkQA commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-769030172 **[Test build #134601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134601/testReport)** for PR 31355 at commit [`8b0eb56`](https://github.co

[GitHub] [spark] cristichircu commented on a change in pull request #31264: [SPARK-34144][SQL] Exception thrown when trying to write LocalDate and Instant values to a JDBC relation

2021-01-28 Thread GitBox
cristichircu commented on a change in pull request #31264: URL: https://github.com/apache/spark/pull/31264#discussion_r566064330 ## File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ## @@ -606,4 +610,70 @@ class JDBCWriteSuite extends SharedSpar

[GitHub] [spark] AmplabJenkins commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-769023158 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134603/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31373: [SPARK-34273][CORE] Do not reregister BlockManager when SparkContext is stopped

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31373: URL: https://github.com/apache/spark/pull/31373#issuecomment-769023157 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134611/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31383: [SPARK-34278][CORE] Make BlockManagerMaster driver heartbeat timeout configurable

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31383: URL: https://github.com/apache/spark/pull/31383#issuecomment-769023159 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134610/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-769023149 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134600/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31381: [SPARK-33867][SQL][3.0] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31381: URL: https://github.com/apache/spark/pull/31381#issuecomment-769023145 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39203/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31380: [SPARK-34262][SQL][3.0] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31380: URL: https://github.com/apache/spark/pull/31380#issuecomment-769023144 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134602/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31379: [SPARK-34262][SQL][3.1] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31379: URL: https://github.com/apache/spark/pull/31379#issuecomment-769023148 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134599/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-769023146 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134609/ -

[GitHub] [spark] AmplabJenkins commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-769023147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #31382: [SPARK-34144][SQL][3.0] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-28 Thread GitBox
AmplabJenkins commented on pull request #31382: URL: https://github.com/apache/spark/pull/31382#issuecomment-769023151 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39202/ -

[GitHub] [spark] SparkQA commented on pull request #31368: [SPARK-34269][SQL] Simplify SQL view resolution

2021-01-28 Thread GitBox
SparkQA commented on pull request #31368: URL: https://github.com/apache/spark/pull/31368#issuecomment-769022511 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39204/ -

[GitHub] [spark] maropu commented on a change in pull request #31264: [SPARK-34144][SQL] Exception thrown when trying to write LocalDate and Instant values to a JDBC relation

2021-01-28 Thread GitBox
maropu commented on a change in pull request #31264: URL: https://github.com/apache/spark/pull/31264#discussion_r566055991 ## File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ## @@ -606,4 +610,70 @@ class JDBCWriteSuite extends SharedSparkSessi

[GitHub] [spark] SparkQA removed a comment on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-768897473 **[Test build #134609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134609/testReport)** for PR 31378 at commit [`351cba7`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-01-28 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-769016259 **[Test build #134609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134609/testReport)** for PR 31378 at commit [`351cba7`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31379: [SPARK-34262][SQL][3.1] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31379: URL: https://github.com/apache/spark/pull/31379#issuecomment-768865878 **[Test build #134599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134599/testReport)** for PR 31379 at commit [`fb1d319`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31379: [SPARK-34262][SQL][3.1] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-28 Thread GitBox
SparkQA commented on pull request #31379: URL: https://github.com/apache/spark/pull/31379#issuecomment-769015321 **[Test build #134599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134599/testReport)** for PR 31379 at commit [`fb1d319`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-768861544 **[Test build #134600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134600/testReport)** for PR 31284 at commit [`32e71ce`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-28 Thread GitBox
SparkQA commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-769014243 **[Test build #134600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134600/testReport)** for PR 31284 at commit [`32e71ce`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768866810 **[Test build #134603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134603/testReport)** for PR 31355 at commit [`60ebadf`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-28 Thread GitBox
SparkQA commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-769013099 **[Test build #134603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134603/testReport)** for PR 31355 at commit [`60ebadf`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31373: [SPARK-34273][CORE] Do not reregister BlockManager when SparkContext is stopped

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31373: URL: https://github.com/apache/spark/pull/31373#issuecomment-768925251 **[Test build #134611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134611/testReport)** for PR 31373 at commit [`510a505`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31373: [SPARK-34273][CORE] Do not reregister BlockManager when SparkContext is stopped

2021-01-28 Thread GitBox
SparkQA commented on pull request #31373: URL: https://github.com/apache/spark/pull/31373#issuecomment-769011845 **[Test build #134611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134611/testReport)** for PR 31373 at commit [`510a505`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31380: [SPARK-34262][SQL][3.0] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31380: URL: https://github.com/apache/spark/pull/31380#issuecomment-768866788 **[Test build #134602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134602/testReport)** for PR 31380 at commit [`d7b3108`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31380: [SPARK-34262][SQL][3.0] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-28 Thread GitBox
SparkQA commented on pull request #31380: URL: https://github.com/apache/spark/pull/31380#issuecomment-769011130 **[Test build #134602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134602/testReport)** for PR 31380 at commit [`d7b3108`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-769010655 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39201/ ---

[GitHub] [spark] SparkQA removed a comment on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-768779322 **[Test build #134583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134583/testReport)** for PR 30175 at commit [`c51eb2c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30175: [SPARK-33274][SS] Fix job hang in cp mode when total cores less than total kafka partition

2021-01-28 Thread GitBox
SparkQA commented on pull request #30175: URL: https://github.com/apache/spark/pull/30175#issuecomment-769009254 **[Test build #134583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134583/testReport)** for PR 30175 at commit [`c51eb2c`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31383: [SPARK-34278][CORE] Make BlockManagerMaster driver heartbeat timeout configurable

2021-01-28 Thread GitBox
SparkQA removed a comment on pull request #31383: URL: https://github.com/apache/spark/pull/31383#issuecomment-768925133 **[Test build #134610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134610/testReport)** for PR 31383 at commit [`017d2ea`](https://gi

<    1   2   3   4   5   6   >