[GitHub] [spark] yaooqinn commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
yaooqinn commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770652632 @maropu yea, can you directly check-pick by `merge_spark_pr.py` or revert the revert PR? This is an automated

[GitHub] [spark] maropu commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
maropu commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770650758 The current PR is the same with the original one #31336 ? This is an automated message from the Apache Git Servic

[GitHub] [spark] SparkQA commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
SparkQA commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770649788 **[Test build #134718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134718/testReport)** for PR 31407 at commit [`6fc94bc`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
HyukjinKwon commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770649577 Yeah, these are everything if I didn't miss. I could take the Scala specific ones out but just thought it's better to keep it consistent within `functions.scala` too, and th

[GitHub] [spark] SparkQA commented on pull request #31411: [SPARK-33990][SQL][TESTS][3.1] Remove partition data by v2 `ALTER TABLE .. DROP PARTITION`

2021-01-31 Thread GitBox
SparkQA commented on pull request #31411: URL: https://github.com/apache/spark/pull/31411#issuecomment-770647687 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39300/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770647266 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39297/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31409: URL: https://github.com/apache/spark/pull/31409#issuecomment-770647267 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39294/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-770647272 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134698/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-770647269 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39295/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770647268 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39301/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770647265 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39296/ -

[GitHub] [spark] maropu commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
maropu commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770644493 I left minor comments and it looks fine otherwise. cc: @viirya , too. This is an automated message from the Apach

[GitHub] [spark] maropu commented on a change in pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31413: URL: https://github.com/apache/spark/pull/31413#discussion_r567614728 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -591,20 +590,34 @@ case class FileSourceScanExec(

[GitHub] [spark] maropu commented on a change in pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31413: URL: https://github.com/apache/spark/pull/31413#discussion_r567614529 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -591,20 +590,34 @@ case class FileSourceScanExec(

[GitHub] [spark] maropu commented on a change in pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31413: URL: https://github.com/apache/spark/pull/31413#discussion_r567614354 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -591,20 +590,34 @@ case class FileSourceScanExec(

[GitHub] [spark] SparkQA commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
SparkQA commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770640865 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39301/ ---

[GitHub] [spark] LuciferYang closed pull request #31385: [WIP][SPARK-34279][BUILD][TEST] Upgrade Junit from 4.x to 5.x

2021-01-31 Thread GitBox
LuciferYang closed pull request #31385: URL: https://github.com/apache/spark/pull/31385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-31 Thread GitBox
SparkQA commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-770639860 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39302/ -

[GitHub] [spark] SparkQA commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
SparkQA commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770639134 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39298/ -

[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
SparkQA commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770638685 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39296/ ---

[GitHub] [spark] SparkQA commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
SparkQA commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770638601 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39301/ -

[GitHub] [spark] SparkQA commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema

2021-01-31 Thread GitBox
SparkQA commented on pull request #31412: URL: https://github.com/apache/spark/pull/31412#issuecomment-770637957 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39299/ -

[GitHub] [spark] maropu commented on a change in pull request #31213: [SPARK-34141][SQL] Remove side effect from ExtractGenerator

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31213: URL: https://github.com/apache/spark/pull/31213#discussion_r567604547 ## File path: sql/catalyst/src/test/scala-2.12/org/apache/spark/sql/catalyst/analysis/ExtractGeneratorSuite.scala ## @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] [spark] SparkQA removed a comment on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-31 Thread GitBox
SparkQA removed a comment on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-770530074 **[Test build #134698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134698/testReport)** for PR 31362 at commit [`eed6e99`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-31 Thread GitBox
SparkQA commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-770629570 **[Test build #134698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134698/testReport)** for PR 31362 at commit [`eed6e99`](https://github.co

[GitHub] [spark] tanelk commented on a change in pull request #31213: [SPARK-34141][SQL] Remove side effect from ExtractGenerator

2021-01-31 Thread GitBox
tanelk commented on a change in pull request #31213: URL: https://github.com/apache/spark/pull/31213#discussion_r567604212 ## File path: sql/catalyst/src/test/scala-2.12/org/apache/spark/sql/catalyst/analysis/ExtractGeneratorSuite.scala ## @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] [spark] imback82 commented on a change in pull request #31273: [Spark-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

2021-01-31 Thread GitBox
imback82 commented on a change in pull request #31273: URL: https://github.com/apache/spark/pull/31273#discussion_r567603929 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -558,20 +560,27 @@ object ViewHelper { catalog: Se

[GitHub] [spark] SparkQA commented on pull request #31407: [SPARK-34233][SPARK-33990][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
SparkQA commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770628245 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39297/ ---

[GitHub] [spark] SparkQA commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
SparkQA commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770627350 **[Test build #134717 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134717/testReport)** for PR 31413 at commit [`cd90f0a`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-31 Thread GitBox
SparkQA commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-770627218 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39295/ ---

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

2021-01-31 Thread GitBox
SparkQA commented on pull request #31409: URL: https://github.com/apache/spark/pull/31409#issuecomment-770626488 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39294/ ---

[GitHub] [spark] beliefer commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
beliefer commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770625680 I noticed the email about `SQL, Python, Scala and R API Consistency`. This is an automated message from the Apa

[GitHub] [spark] SparkQA commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-31 Thread GitBox
SparkQA commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-770622320 **[Test build #134716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134716/testReport)** for PR 31362 at commit [`cd8e765`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #31258: [SPARK-34168] [SQL] Support DPP in AQE when the join is Broadcast hash join at the beginning

2021-01-31 Thread GitBox
SparkQA removed a comment on pull request #31258: URL: https://github.com/apache/spark/pull/31258#issuecomment-770527863 **[Test build #134700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134700/testReport)** for PR 31258 at commit [`b72830e`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31273: [WIP][Spark-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31273: URL: https://github.com/apache/spark/pull/31273#issuecomment-770615880 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39293/

[GitHub] [spark] SparkQA removed a comment on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
SparkQA removed a comment on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770616369 **[Test build #134712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134712/testReport)** for PR 31413 at commit [`3b72a6b`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770594177 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31258: [SPARK-34168] [SQL] Support DPP in AQE when the join is Broadcast hash join at the beginning

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31258: URL: https://github.com/apache/spark/pull/31258#issuecomment-770615879 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134700/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770617558 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134712/ -

[GitHub] [spark] SparkQA commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema

2021-01-31 Thread GitBox
SparkQA commented on pull request #31412: URL: https://github.com/apache/spark/pull/31412#issuecomment-770622181 **[Test build #134713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134713/testReport)** for PR 31412 at commit [`bbab015`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
SparkQA commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770622083 **[Test build #134715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134715/testReport)** for PR 31410 at commit [`b078e25`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31411: [SPARK-33990][SQL][TESTS][3.1] Remove partition data by v2 `ALTER TABLE .. DROP PARTITION`

2021-01-31 Thread GitBox
SparkQA commented on pull request #31411: URL: https://github.com/apache/spark/pull/31411#issuecomment-770622094 **[Test build #134714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134714/testReport)** for PR 31411 at commit [`9b6e382`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770615882 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-770615877 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39288/

[GitHub] [spark] SparkQA removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
SparkQA removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770565143 **[Test build #134705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134705/testReport)** for PR 30363 at commit [`378983e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
SparkQA commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770621624 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39296/ -

[GitHub] [spark] AmplabJenkins commented on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770620720 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134705/ -

[GitHub] [spark] SparkQA commented on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
SparkQA commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770620010 **[Test build #134705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134705/testReport)** for PR 30363 at commit [`378983e`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31024: [SPARK-33979][SQL] Reorder predicate

2021-01-31 Thread GitBox
SparkQA commented on pull request #31024: URL: https://github.com/apache/spark/pull/31024#issuecomment-770618033 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39295/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770617558 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134712/ -

[GitHub] [spark] SparkQA commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
SparkQA commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770617537 **[Test build #134712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134712/testReport)** for PR 31413 at commit [`3b72a6b`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
SparkQA commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770616369 **[Test build #134712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134712/testReport)** for PR 31413 at commit [`3b72a6b`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770615882 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39291/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31273: [WIP][Spark-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31273: URL: https://github.com/apache/spark/pull/31273#issuecomment-770615880 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39293/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31258: [SPARK-34168] [SQL] Support DPP in AQE when the join is Broadcast hash join at the beginning

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31258: URL: https://github.com/apache/spark/pull/31258#issuecomment-770615879 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134700/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770615881 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134706/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-770615877 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39288/ -

[GitHub] [spark] maropu commented on a change in pull request #31213: [SPARK-34141][SQL] Remove side effect from ExtractGenerator

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31213: URL: https://github.com/apache/spark/pull/31213#discussion_r567594297 ## File path: sql/catalyst/src/test/scala-2.12/org/apache/spark/sql/catalyst/analysis/ExtractGeneratorSuite.scala ## @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] [spark] SparkQA commented on pull request #31407: [SPARK-34233][SPARK-33990][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
SparkQA commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770614370 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39297/ -

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

2021-01-31 Thread GitBox
SparkQA commented on pull request #31409: URL: https://github.com/apache/spark/pull/31409#issuecomment-770612070 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39294/ -

[GitHub] [spark] SparkQA commented on pull request #31258: [SPARK-34168] [SQL] Support DPP in AQE when the join is Broadcast hash join at the beginning

2021-01-31 Thread GitBox
SparkQA commented on pull request #31258: URL: https://github.com/apache/spark/pull/31258#issuecomment-770611008 **[Test build #134700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134700/testReport)** for PR 31258 at commit [`b72830e`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31273: [WIP][Spark-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

2021-01-31 Thread GitBox
SparkQA commented on pull request #31273: URL: https://github.com/apache/spark/pull/31273#issuecomment-770609908 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39293/ ---

[GitHub] [spark] linhongliu-db commented on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
linhongliu-db commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770608632 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #31273: [WIP][Spark-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

2021-01-31 Thread GitBox
SparkQA commented on pull request #31273: URL: https://github.com/apache/spark/pull/31273#issuecomment-770607734 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39293/ -

[GitHub] [spark] c21 commented on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
c21 commented on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770606852 cc @cloud-fan and @maropu could you guys take a look when you have time? Thanks. This is an automated message from

[GitHub] [spark] c21 commented on a change in pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
c21 commented on a change in pull request #31413: URL: https://github.com/apache/spark/pull/31413#discussion_r567589223 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/DisableUnnecessaryBucketedScanSuite.scala ## @@ -95,7 +95,7 @@ abstract class DisableUnnec

[GitHub] [spark] HyukjinKwon commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
HyukjinKwon commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770606219 Yeah, that should be decided case by case. I think this one is pretty clear though. This is an automated me

[GitHub] [spark] c21 opened a new pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-01-31 Thread GitBox
c21 opened a new pull request #31413: URL: https://github.com/apache/spark/pull/31413 ### What changes were proposed in this pull request? As a followup from discussion in https://github.com/apache/spark/pull/29804#discussion_r493100510 . Currently in data source v1 file sca

[GitHub] [spark] sarutak opened a new pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema

2021-01-31 Thread GitBox
sarutak opened a new pull request #31412: URL: https://github.com/apache/spark/pull/31412 ### What changes were proposed in this pull request? Similar to SPARK-33690, this PR improves the output layout of `printSchema` for the case column names contain meta characters. Here is an

[GitHub] [spark] yaooqinn commented on pull request #31411: [SPARK-33990][SQL][TESTS][3.1] Remove partition data by v2 `ALTER TABLE .. DROP PARTITION`

2021-01-31 Thread GitBox
yaooqinn commented on pull request #31411: URL: https://github.com/apache/spark/pull/31411#issuecomment-770604737 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [spark] MaxGekk commented on pull request #31407: [SPARK-34233][SPARK-33990][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
MaxGekk commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770602961 Here is the backport https://github.com/apache/spark/pull/31411 of https://github.com/apache/spark/pull/31014 to `branch-3.1`. -

[GitHub] [spark] MaxGekk opened a new pull request #31411: [SPARK-33990][SQL][TESTS][3.1] Remove partition data by v2 `ALTER TABLE .. DROP PARTITION`

2021-01-31 Thread GitBox
MaxGekk opened a new pull request #31411: URL: https://github.com/apache/spark/pull/31411 ### What changes were proposed in this pull request? Remove partition data by `ALTER TABLE .. DROP PARTITION` in V2 table catalog used in tests. ### Why are the changes needed? This is a b

[GitHub] [spark] beliefer commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
beliefer commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770602297 Yeah. But I still don't know how to distinguish common and uncommon functions. This is an automated message fr

[GitHub] [spark] SparkQA commented on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

2021-01-31 Thread GitBox
SparkQA commented on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-770601809 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39288/ ---

[GitHub] [spark] HyukjinKwon removed a comment on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
HyukjinKwon removed a comment on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770600520 That one was added before we discuss https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L41-L59, and we keep it

[GitHub] [spark] HyukjinKwon commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
HyukjinKwon commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770600767 That one was added before we discuss https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L41-L59, and it's kept mainly f

[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567585448 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -113,6 +113,16 @@ object functions { */ def lit(literal: Any): Colu

[GitHub] [spark] HyukjinKwon commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
HyukjinKwon commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770600520 That one was added before we discuss https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L41-L59, and we keep it mainly

[GitHub] [spark] SparkQA removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
SparkQA removed a comment on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770594532 **[Test build #134706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134706/testReport)** for PR 31408 at commit [`a1b682a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
SparkQA commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770600258 **[Test build #134706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134706/testReport)** for PR 31408 at commit [`a1b682a`](https://github.co

[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567584080 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -123,9 +133,9 @@ object functions { * can handle parameterized scala t

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

2021-01-31 Thread GitBox
SparkQA commented on pull request #31409: URL: https://github.com/apache/spark/pull/31409#issuecomment-770597884 **[Test build #134709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134709/testReport)** for PR 31409 at commit [`097d1f9`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
HyukjinKwon commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567583763 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -113,6 +113,16 @@ object functions { */ def lit(literal: Any):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
HyukjinKwon commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567583279 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -123,9 +133,9 @@ object functions { * can handle parameterized sc

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
HyukjinKwon commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567583279 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -123,9 +133,9 @@ object functions { * can handle parameterized sc

[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
SparkQA commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770596916 **[Test build #134710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134710/testReport)** for PR 31408 at commit [`bb23512`](https://github.com

[GitHub] [spark] beliefer commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
beliefer commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770596964 Why preserved `bitwiseNOT` ? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567583045 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -113,6 +113,16 @@ object functions { */ def lit(literal: Any): Colu

[GitHub] [spark] HyukjinKwon commented on pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
HyukjinKwon commented on pull request #31410: URL: https://github.com/apache/spark/pull/31410#issuecomment-770596025 cc @beliefer and @cloud-fan This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] HyukjinKwon opened a new pull request #31410: [SPARK-33245][SQL][FOLLOW-UP] Remove bitwiseGet in Scala functions API

2021-01-31 Thread GitBox
HyukjinKwon opened a new pull request #31410: URL: https://github.com/apache/spark/pull/31410 ### What changes were proposed in this pull request? This PR is a followup that removes `bitwiseGet` in functions API. This is mainly for SQL compliance, and arguably not very much commonly

[GitHub] [spark] SparkQA commented on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-01-31 Thread GitBox
SparkQA commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770595763 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39291/ ---

[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
maropu commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r567582370 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -123,9 +133,9 @@ object functions { * can handle parameterized scala t

[GitHub] [spark] SparkQA commented on pull request #31273: [WIP][Spark-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

2021-01-31 Thread GitBox
SparkQA commented on pull request #31273: URL: https://github.com/apache/spark/pull/31273#issuecomment-770594667 **[Test build #134707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134707/testReport)** for PR 31273 at commit [`a0ba508`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
SparkQA commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770594532 **[Test build #134706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134706/testReport)** for PR 31408 at commit [`a1b682a`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-770594177 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39292/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31407: [SPARK-34233][SPARK-33990][SQL][3.1] FIX NPE for char padding in binary comparison

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770588052 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39289/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-770588055 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39287/

[GitHub] [spark] SparkQA commented on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

2021-01-31 Thread GitBox
SparkQA commented on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-770593699 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39290/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

2021-01-31 Thread GitBox
AmplabJenkins removed a comment on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-770593719 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39290/

[GitHub] [spark] AmplabJenkins commented on pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

2021-01-31 Thread GitBox
AmplabJenkins commented on pull request #31316: URL: https://github.com/apache/spark/pull/31316#issuecomment-770593719 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39290/ -

  1   2   3   >