SparkQA commented on pull request #31245:
URL: https://github.com/apache/spark/pull/31245#issuecomment-773869378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cloud-fan commented on a change in pull request #30902:
URL: https://github.com/apache/spark/pull/30902#discussion_r569992961
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##
@@ -408,6 +421,23 @@ object JdbcUtils extends
AmplabJenkins commented on pull request #31484:
URL: https://github.com/apache/spark/pull/31484#issuecomment-773897293
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39499/
AmplabJenkins removed a comment on pull request #31464:
URL: https://github.com/apache/spark/pull/31464#issuecomment-773081377
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #31464:
URL: https://github.com/apache/spark/pull/31464#issuecomment-773031370
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #31384:
URL: https://github.com/apache/spark/pull/31384#issuecomment-773389086
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Ngone51 commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r570234278
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala
##
@@ -44,8 +44,19 @@ case class BatchScanExec(
maropu commented on pull request #31449:
URL: https://github.com/apache/spark/pull/31449#issuecomment-773705201
Thanks~, @HeartSaVioR
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA removed a comment on pull request #31471:
URL: https://github.com/apache/spark/pull/31471#issuecomment-773187923
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773900126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Ngone51 commented on pull request #31470:
URL: https://github.com/apache/spark/pull/31470#issuecomment-773151888
cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log
SparkQA removed a comment on pull request #31466:
URL: https://github.com/apache/spark/pull/31466#issuecomment-773016444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #31437:
URL: https://github.com/apache/spark/pull/31437#issuecomment-773395117
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xkrogen commented on pull request #31133:
URL: https://github.com/apache/spark/pull/31133#issuecomment-773571759
Thanks for the clarification @dongjoon-hyun ! I understand your concern now.
New plan sounds good to me as well.
sririshindra commented on a change in pull request #31477:
URL: https://github.com/apache/spark/pull/31477#discussion_r570672502
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##
@@ -89,13 +90,20 @@ case class
AmplabJenkins removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-772912593
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773111769
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xinrong-databricks commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773712671
Thank you for your reviews!
@srowen I don't see other instances so far. I've marked the PR as non-draft.
SparkQA commented on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773150220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773065658
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zhengruifeng closed pull request #31469:
URL: https://github.com/apache/spark/pull/31469
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
maropu commented on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773786201
The current approach itself looks fine.
This is an automated message from the Apache Git Service.
To respond to
AngersZh commented on a change in pull request #30957:
URL: https://github.com/apache/spark/pull/30957#discussion_r570797337
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##
@@ -220,6 +226,9 @@ trait
SparkQA removed a comment on pull request #31466:
URL: https://github.com/apache/spark/pull/31466#issuecomment-773773261
**[Test build #134907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134907/testReport)**
for PR 31466 at commit
AmplabJenkins removed a comment on pull request #29185:
URL: https://github.com/apache/spark/pull/29185#issuecomment-773222385
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #31483:
URL: https://github.com/apache/spark/pull/31483#issuecomment-773839682
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn commented on pull request #31460:
URL: https://github.com/apache/spark/pull/31460#issuecomment-773740286
OK, it's my pleasure
This is an automated message from the Apache Git Service.
To respond to the message,
maropu commented on a change in pull request #31413:
URL: https://github.com/apache/spark/pull/31413#discussion_r570645480
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##
@@ -591,20 +590,41 @@ case class FileSourceScanExec(
AmplabJenkins removed a comment on pull request #31467:
URL: https://github.com/apache/spark/pull/31467#issuecomment-773111772
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29210:
URL: https://github.com/apache/spark/pull/29210#issuecomment-773469611
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on pull request #31476:
URL: https://github.com/apache/spark/pull/31476#issuecomment-773564872
cc @rdblue @Ngone51 @cloud-fan @sunchao @dongjoon-hyun this is separated
from #31451 and only includes interface changes.
cloud-fan commented on a change in pull request #31466:
URL: https://github.com/apache/spark/pull/31466#discussion_r570210410
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -260,9 +260,6 @@ class SQLQueryTestSuite extends QueryTest
wangyum commented on pull request #31258:
URL: https://github.com/apache/spark/pull/31258#issuecomment-773886254
@JkSelf @cloud-fan This implementation can not reuse `BroadcastExchange` if
BHJ after SMJ. For example:
```SQL
SELECT count(*)
FROM (SELECT c.c_customer_sk,
WamBamBoozle edited a comment on pull request #31162:
URL: https://github.com/apache/spark/pull/31162#issuecomment-772732386
@srowen, you write
> I dont' know much about R - why does this help improve performance?
It is like moving the invariant expression out of the loop. It
SparkQA commented on pull request #28885:
URL: https://github.com/apache/spark/pull/28885#issuecomment-773455991
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA removed a comment on pull request #31472:
URL: https://github.com/apache/spark/pull/31472#issuecomment-773239575
**[Test build #134869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134869/testReport)**
for PR 31472 at commit
AmplabJenkins commented on pull request #31480:
URL: https://github.com/apache/spark/pull/31480#issuecomment-773813064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon closed pull request #31464:
URL: https://github.com/apache/spark/pull/31464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhengruifeng commented on pull request #31472:
URL: https://github.com/apache/spark/pull/31472#issuecomment-773203630
```
scala> val df =
spark.read.format("libsvm").load("/d0/Dev/Opensource/spark/data/mllib/sample_multiclass_classification_data.txt").withColumn("probability",
viirya commented on pull request #31468:
URL: https://github.com/apache/spark/pull/31468#issuecomment-773508769
`org.apache.spark.sql.CachedTableSuite.SPARK-34269: cache lookup with ORDER
BY / LIMIT clause` failed more than one time. But seems it passed without this
change?
AngersZh commented on pull request #29087:
URL: https://github.com/apache/spark/pull/29087#issuecomment-773142558
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29210:
URL: https://github.com/apache/spark/pull/29210#issuecomment-773499544
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #31471:
URL: https://github.com/apache/spark/pull/31471#issuecomment-773255967
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on pull request #31455:
URL: https://github.com/apache/spark/pull/31455#issuecomment-773686640
LGTM except for the @MaxGekk comment.
This is an automated message from the Apache Git Service.
To respond to
SparkQA commented on pull request #31470:
URL: https://github.com/apache/spark/pull/31470#issuecomment-773155684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #31448:
URL: https://github.com/apache/spark/pull/31448#issuecomment-773097354
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins commented on pull request #31478:
URL: https://github.com/apache/spark/pull/31478#issuecomment-773684374
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #31258:
URL: https://github.com/apache/spark/pull/31258#issuecomment-773146054
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #31476:
URL: https://github.com/apache/spark/pull/31476#issuecomment-773579295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #31486:
URL: https://github.com/apache/spark/pull/31486#issuecomment-773877044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cloud-fan commented on a change in pull request #31258:
URL: https://github.com/apache/spark/pull/31258#discussion_r570002134
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##
@@ -156,7 +157,7 @@ case class
AmplabJenkins commented on pull request #28885:
URL: https://github.com/apache/spark/pull/28885#issuecomment-773499553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773256704
This is an automated message from the Apache Git Service.
To respond to the message, please log on
srowen commented on pull request #31461:
URL: https://github.com/apache/spark/pull/31461#issuecomment-773360047
It does sound like ideally the API would be refactored. @viirya I didn't see
pushback on your redesign.
We can just open this up, which at least re-enables the current
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773306832
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #31477:
URL: https://github.com/apache/spark/pull/31477#issuecomment-773692087
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
saikocat commented on a change in pull request #30902:
URL: https://github.com/apache/spark/pull/30902#discussion_r569983009
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##
@@ -408,6 +421,23 @@ object JdbcUtils extends
rahij commented on pull request #29625:
URL: https://github.com/apache/spark/pull/29625#issuecomment-773412026
@c21 I wanted to ask if you were planning on continuing this PR now that
https://github.com/apache/spark/pull/29804/files has been merged?
SparkQA removed a comment on pull request #29185:
URL: https://github.com/apache/spark/pull/29185#issuecomment-773152387
**[Test build #134866 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134866/testReport)**
for PR 29185 at commit
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773256704
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #31394:
URL: https://github.com/apache/spark/pull/31394#issuecomment-773155810
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #31456:
URL: https://github.com/apache/spark/pull/31456#issuecomment-773580714
**[Test build #134887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134887/testReport)**
for PR 31456 at commit
AmplabJenkins commented on pull request #31460:
URL: https://github.com/apache/spark/pull/31460#issuecomment-773087469
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773752115
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AngersZh commented on pull request #31378:
URL: https://github.com/apache/spark/pull/31378#issuecomment-773380494
ping @cloud-fan Any more update on this?
This is an automated message from the Apache Git Service.
To
JkSelf commented on pull request #31258:
URL: https://github.com/apache/spark/pull/31258#issuecomment-773889572
@wangyum Yes. This implementation only is the first PR to support the join
is bhj before apply AQE rules. We will support the join is smj and then convert
to bhj use case in the
AngersZh opened a new pull request #31485:
URL: https://github.com/apache/spark/pull/31485
### What changes were proposed in this pull request?
When explain SQL with cost, treeString about subquery won't show it's
statistics:
How to reproduce:
```
spark.sql("create
AmplabJenkins commented on pull request #31384:
URL: https://github.com/apache/spark/pull/31384#issuecomment-773460643
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #31464:
URL: https://github.com/apache/spark/pull/31464#issuecomment-773698884
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HeartSaVioR commented on pull request #31471:
URL: https://github.com/apache/spark/pull/31471#issuecomment-773858199
OK. I'll leave this till early next week and merge if there's no further
comment.
This is an automated
cloud-fan closed pull request #31440:
URL: https://github.com/apache/spark/pull/31440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
AmplabJenkins commented on pull request #31479:
URL: https://github.com/apache/spark/pull/31479#issuecomment-773790360
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sririshindra commented on pull request #31477:
URL: https://github.com/apache/spark/pull/31477#issuecomment-773638159
Could you please take a look at this PR. cc: @maropu @dongjoon-hyun
This is an automated message from the
SparkQA removed a comment on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773900126
**[Test build #134927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134927/testReport)**
for PR 30869 at commit
HyukjinKwon commented on a change in pull request #31471:
URL: https://github.com/apache/spark/pull/31471#discussion_r570179196
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##
@@ -217,8 +217,11 @@ object
cloud-fan opened a new pull request #31486:
URL: https://github.com/apache/spark/pull/31486
This backports https://github.com/apache/spark/pull/31474 to 3.1/3.0
### What changes were proposed in this pull request?
This is a followup of
AngersZh commented on a change in pull request #30957:
URL: https://github.com/apache/spark/pull/30957#discussion_r570723751
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
##
@@ -174,6 +174,7 @@ object
SparkQA removed a comment on pull request #31471:
URL: https://github.com/apache/spark/pull/31471#issuecomment-773773238
**[Test build #134906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134906/testReport)**
for PR 31471 at commit
SparkQA commented on pull request #31487:
URL: https://github.com/apache/spark/pull/31487#issuecomment-773902011
**[Test build #134929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134929/testReport)**
for PR 31487 at commit
SparkQA commented on pull request #31482:
URL: https://github.com/apache/spark/pull/31482#issuecomment-773861703
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39500/
AmplabJenkins removed a comment on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773901509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134927/
cloud-fan commented on pull request #31486:
URL: https://github.com/apache/spark/pull/31486#issuecomment-773870656
@HyukjinKwon @dongjoon-hyun @maropu
This is an automated message from the Apache Git Service.
To respond to
maropu commented on a change in pull request #30957:
URL: https://github.com/apache/spark/pull/30957#discussion_r570776893
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala
##
@@ -471,6 +473,126 @@ abstract class
LuciferYang opened a new pull request #31487:
URL: https://github.com/apache/spark/pull/31487
### What changes were proposed in this pull request?
`Mockito.initMocks(Object)` is a deprecated api, should use
`Mockito.openMocks(Object)` instead.
### Why are the changes needed?
SparkQA removed a comment on pull request #31479:
URL: https://github.com/apache/spark/pull/31479#issuecomment-773776064
**[Test build #134904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134904/testReport)**
for PR 31479 at commit
cloud-fan commented on a change in pull request #31245:
URL: https://github.com/apache/spark/pull/31245#discussion_r570789600
##
File path: docs/sql-migration-guide.md
##
@@ -40,6 +40,10 @@ license: |
- In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no
SparkQA commented on pull request #29087:
URL: https://github.com/apache/spark/pull/29087#issuecomment-773907871
**[Test build #134928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134928/testReport)**
for PR 29087 at commit
SparkQA commented on pull request #30650:
URL: https://github.com/apache/spark/pull/30650#issuecomment-773876021
**[Test build #134923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134923/testReport)**
for PR 30650 at commit
AmplabJenkins removed a comment on pull request #31476:
URL: https://github.com/apache/spark/pull/31476#issuecomment-773632690
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan closed pull request #31478:
URL: https://github.com/apache/spark/pull/31478
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
AmplabJenkins commented on pull request #31483:
URL: https://github.com/apache/spark/pull/31483#issuecomment-773867181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134920/
HeartSaVioR edited a comment on pull request #31471:
URL: https://github.com/apache/spark/pull/31471#issuecomment-773744959
Actually I have been thinking about this - while I think this helps to track
down the elapsed time on committing job, there's still another problem end
users confuse
xkrogen commented on a change in pull request #31133:
URL: https://github.com/apache/spark/pull/31133#discussion_r570355910
##
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
##
@@ -388,6 +394,9 @@ private[hive] object HiveTableUtil {
wzhfy edited a comment on pull request #30965:
URL: https://github.com/apache/spark/pull/30965#issuecomment-773864841
@tanelk Hi, sorry to see this so late.
IIRC the reason to use a relative value for rowCount and size, is to
normalize them to a similar scale while comparing cost.
SparkQA commented on pull request #31483:
URL: https://github.com/apache/spark/pull/31483#issuecomment-773869613
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39503/
wzhfy edited a comment on pull request #30965:
URL: https://github.com/apache/spark/pull/30965#issuecomment-773864841
@tanelk Hi, sorry to see this so late.
IIRC the reason to use a relative value for rowCount and size, is to
normalize them to a similar scale while comparing cost.
SparkQA commented on pull request #31245:
URL: https://github.com/apache/spark/pull/31245#issuecomment-773869378
**[Test build #134922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134922/testReport)**
for PR 31245 at commit
SparkQA removed a comment on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773900126
**[Test build #134927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134927/testReport)**
for PR 30869 at commit
AmplabJenkins commented on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773901509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134927/
SparkQA commented on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773901491
**[Test build #134927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134927/testReport)**
for PR 30869 at commit
501 - 600 of 775 matches
Mail list logo