AmplabJenkins commented on pull request #29210:
URL: https://github.com/apache/spark/pull/29210#issuecomment-773499544
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan closed pull request #31473:
URL: https://github.com/apache/spark/pull/31473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SparkQA commented on pull request #31133:
URL: https://github.com/apache/spark/pull/31133#issuecomment-773582316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sunchao commented on a change in pull request #31476:
URL: https://github.com/apache/spark/pull/31476#discussion_r570505479
##
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/CustomMetric.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache
saikocat commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773235806
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
beliefer commented on pull request #31448:
URL: https://github.com/apache/spark/pull/31448#issuecomment-773760880
cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log
viirya commented on pull request #31451:
URL: https://github.com/apache/spark/pull/31451#issuecomment-773564010
> I think that this could use some tests. It would be easier to add tests if
it were split to add the interfaces, a batch implementation (with tests), and a
stream
SparkQA removed a comment on pull request #31258:
URL: https://github.com/apache/spark/pull/31258#issuecomment-773092921
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhengruifeng edited a comment on pull request #31472:
URL: https://github.com/apache/spark/pull/31472#issuecomment-773203630
in 3.0.1 and master
```
scala> val df =
SparkQA commented on pull request #31467:
URL: https://github.com/apache/spark/pull/31467#issuecomment-773083370
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA removed a comment on pull request #31478:
URL: https://github.com/apache/spark/pull/31478#issuecomment-773691454
**[Test build #134894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134894/testReport)**
for PR 31478 at commit
maropu commented on pull request #31468:
URL: https://github.com/apache/spark/pull/31468#issuecomment-773688646
The fix itself looks fine.
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #31481:
URL: https://github.com/apache/spark/pull/31481#issuecomment-773813067
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39492/
AmplabJenkins removed a comment on pull request #31455:
URL: https://github.com/apache/spark/pull/31455#issuecomment-773393046
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773150220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhengruifeng commented on a change in pull request #31472:
URL: https://github.com/apache/spark/pull/31472#discussion_r570108063
##
File path:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala
##
@@ -223,6 +223,13 @@ class OneVsRestSuite extends
maropu commented on a change in pull request #31455:
URL: https://github.com/apache/spark/pull/31455#discussion_r570631170
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##
@@ -298,11 +298,21 @@ case class Literal (value:
HyukjinKwon commented on a change in pull request #31466:
URL: https://github.com/apache/spark/pull/31466#discussion_r570176457
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -260,9 +260,6 @@ class SQLQueryTestSuite extends QueryTest
HyukjinKwon edited a comment on pull request #31460:
URL: https://github.com/apache/spark/pull/31460#issuecomment-773711647
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the
zhengruifeng commented on pull request #31468:
URL: https://github.com/apache/spark/pull/31468#issuecomment-773112265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30650:
URL: https://github.com/apache/spark/pull/30650#issuecomment-773876021
**[Test build #134923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134923/testReport)**
for PR 30650 at commit
viirya commented on pull request #31461:
URL: https://github.com/apache/spark/pull/31461#issuecomment-773084514
> So what about #16478 @viirya ? is that still a sound proposal for
refactoring the interface? That seems more ideal to add first.
Hm, yea, the refactoring is trying to
AmplabJenkins removed a comment on pull request #31460:
URL: https://github.com/apache/spark/pull/31460#issuecomment-773087469
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AngersZh commented on a change in pull request #30957:
URL: https://github.com/apache/spark/pull/30957#discussion_r570795335
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##
@@ -47,7 +47,13 @@ trait
SparkQA commented on pull request #31482:
URL: https://github.com/apache/spark/pull/31482#issuecomment-773819012
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cloud-fan commented on pull request #31468:
URL: https://github.com/apache/spark/pull/31468#issuecomment-773128349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
AmplabJenkins commented on pull request #31477:
URL: https://github.com/apache/spark/pull/31477#issuecomment-773574298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #31476:
URL: https://github.com/apache/spark/pull/31476#issuecomment-773579295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zhengruifeng commented on pull request #29185:
URL: https://github.com/apache/spark/pull/29185#issuecomment-773135060
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
cloud-fan commented on pull request #31440:
URL: https://github.com/apache/spark/pull/31440#issuecomment-773475101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
beliefer commented on pull request #31466:
URL: https://github.com/apache/spark/pull/31466#issuecomment-773140157
cc @cloud-fan @wangyum @maropu
This is an automated message from the Apache Git Service.
To respond to the
Ngone51 commented on a change in pull request #31348:
URL: https://github.com/apache/spark/pull/31348#discussion_r570796853
##
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##
@@ -550,6 +502,55 @@ private[deploy] class Master(
} else {
viirya commented on a change in pull request #31476:
URL: https://github.com/apache/spark/pull/31476#discussion_r570503897
##
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/CustomMetric.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache
AmplabJenkins removed a comment on pull request #31478:
URL: https://github.com/apache/spark/pull/31478#issuecomment-773684374
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #31475:
URL: https://github.com/apache/spark/pull/31475#issuecomment-773379588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on pull request #31477:
URL: https://github.com/apache/spark/pull/31477#issuecomment-773574298
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on pull request #31460:
URL: https://github.com/apache/spark/pull/31460#issuecomment-773127405
Hi @dongjoon-hyun , do you have more concerns about this fix?
This is an automated message from the Apache
SparkQA removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773743657
**[Test build #134900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134900/testReport)**
for PR 31463 at commit
srowen commented on pull request #31372:
URL: https://github.com/apache/spark/pull/31372#issuecomment-773362443
Fair enough, but it exists and already purports to provide a `.sql` method.
You're already proposing a different/better `.sql` representation. Why wouldn't
it be the natural
mridulm edited a comment on pull request #30650:
URL: https://github.com/apache/spark/pull/30650#issuecomment-773512448
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
beliefer commented on a change in pull request #31474:
URL: https://github.com/apache/spark/pull/31474#discussion_r570697714
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -3069,6 +3069,15 @@ object SQLConf {
.booleanConf
SparkQA commented on pull request #31472:
URL: https://github.com/apache/spark/pull/31472#issuecomment-773877317
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39501/
SparkQA removed a comment on pull request #31204:
URL: https://github.com/apache/spark/pull/31204#issuecomment-773796762
**[Test build #134911 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134911/testReport)**
for PR 31204 at commit
AmplabJenkins removed a comment on pull request #31456:
URL: https://github.com/apache/spark/pull/31456#issuecomment-773603415
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #31394:
URL: https://github.com/apache/spark/pull/31394#issuecomment-773155810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #31445:
URL: https://github.com/apache/spark/pull/31445#issuecomment-773417127
This is an automated message from the Apache Git Service.
To respond to the message, please log on
razajafri commented on a change in pull request #31284:
URL: https://github.com/apache/spark/pull/31284#discussion_r570430807
##
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##
@@ -145,7 +146,24 @@ public
SparkQA removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773306832
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #31486:
URL: https://github.com/apache/spark/pull/31486#issuecomment-773877044
**[Test build #134924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134924/testReport)**
for PR 31486 at commit
SparkQA removed a comment on pull request #31413:
URL: https://github.com/apache/spark/pull/31413#issuecomment-773056185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AngersZh commented on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773141579
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on pull request #31179:
URL: https://github.com/apache/spark/pull/31179#issuecomment-773131159
how big is the overhead? I had an impression that auto stats update is very
expensive and not many people are using it...
SparkQA commented on pull request #31466:
URL: https://github.com/apache/spark/pull/31466#issuecomment-773878017
**[Test build #134907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134907/testReport)**
for PR 31466 at commit
SparkQA removed a comment on pull request #31483:
URL: https://github.com/apache/spark/pull/31483#issuecomment-773851149
**[Test build #134920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134920/testReport)**
for PR 31483 at commit
holdenk commented on a change in pull request #31427:
URL: https://github.com/apache/spark/pull/31427#discussion_r570428856
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -2100,8 +2100,7 @@ class DataSourceV2SQLSuite
SparkQA commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-773753068
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #31471:
URL: https://github.com/apache/spark/pull/31471#issuecomment-773187923
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on pull request #31258:
URL: https://github.com/apache/spark/pull/31258#issuecomment-773146054
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tgravescs commented on pull request #31437:
URL: https://github.com/apache/spark/pull/31437#issuecomment-773366575
ok, please update the description with those details.
maybe cluster mode doesn't matter here because application master would be
killed anyway.
The original change I
rdblue commented on a change in pull request #31476:
URL: https://github.com/apache/spark/pull/31476#discussion_r570608230
##
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/Scan.java
##
@@ -102,4 +102,13 @@ default MicroBatchStream
dongjoon-hyun commented on a change in pull request #31476:
URL: https://github.com/apache/spark/pull/31476#discussion_r570572005
##
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/CustomMetric.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache
AmplabJenkins commented on pull request #31470:
URL: https://github.com/apache/spark/pull/31470#issuecomment-773222379
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #31468:
URL: https://github.com/apache/spark/pull/31468#issuecomment-773118983
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
srowen commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773356694
Seems fine - are there other instances?
You can mark it as non-WIP / not draft.
This is an automated message
SparkQA commented on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773148826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on pull request #31437:
URL: https://github.com/apache/spark/pull/31437#issuecomment-773395117
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29185:
URL: https://github.com/apache/spark/pull/29185#issuecomment-773152387
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
attilapiros commented on pull request #31133:
URL: https://github.com/apache/spark/pull/31133#issuecomment-773570005
@dongjoon-hyun this sound good to me.
Here I will use explicitly
`AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName()` and for the
rest I will open separate
gaborgsomogyi commented on a change in pull request #31384:
URL: https://github.com/apache/spark/pull/31384#discussion_r570119198
##
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/README.md
##
@@ -0,0 +1,81 @@
+---
+license: |
+ Licensed to the Apache Software
SparkQA commented on pull request #31474:
URL: https://github.com/apache/spark/pull/31474#issuecomment-773388356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on pull request #31479:
URL: https://github.com/apache/spark/pull/31479#issuecomment-773790360
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AngersZh edited a comment on pull request #29087:
URL: https://github.com/apache/spark/pull/29087#issuecomment-773142558
ping @HyukjinKwon @cloud-fan @viirya Can you take a look about this pr's
current change.
This is
attilapiros commented on a change in pull request #31445:
URL: https://github.com/apache/spark/pull/31445#discussion_r570299313
##
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##
@@ -223,14
SparkQA removed a comment on pull request #31460:
URL: https://github.com/apache/spark/pull/31460#issuecomment-773056155
**[Test build #134856 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134856/testReport)**
for PR 31460 at commit
AmplabJenkins removed a comment on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-773813065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134902/
SparkQA removed a comment on pull request #31469:
URL: https://github.com/apache/spark/pull/31469#issuecomment-773148826
**[Test build #134864 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134864/testReport)**
for PR 31469 at commit
AmplabJenkins removed a comment on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773222390
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MaxGekk commented on pull request #31478:
URL: https://github.com/apache/spark/pull/31478#issuecomment-773816713
@cloud-fan @gengliangwang @HyukjinKwon Could you review this PR.
This is an automated message from the Apache
AmplabJenkins commented on pull request #30869:
URL: https://github.com/apache/spark/pull/30869#issuecomment-773901509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134927/
HeartSaVioR commented on pull request #31464:
URL: https://github.com/apache/spark/pull/31464#issuecomment-773072398
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
AmplabJenkins commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773111769
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #31475:
URL: https://github.com/apache/spark/pull/31475#issuecomment-773460642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] closed pull request #29185:
URL: https://github.com/apache/spark/pull/29185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
viirya commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r569995302
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##
@@ -909,12 +909,12 @@ class SessionCatalog(
SparkQA commented on pull request #31456:
URL: https://github.com/apache/spark/pull/31456#issuecomment-773574181
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #31488:
URL: https://github.com/apache/spark/pull/31488#issuecomment-773914040
**[Test build #134931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134931/testReport)**
for PR 31488 at commit
cloud-fan commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773470315
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #31484:
URL: https://github.com/apache/spark/pull/31484#issuecomment-773897293
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39499/
AmplabJenkins commented on pull request #31448:
URL: https://github.com/apache/spark/pull/31448#issuecomment-773111773
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773916553
**[Test build #134912 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134912/testReport)**
for PR 30957 at commit
SparkQA removed a comment on pull request #30957:
URL: https://github.com/apache/spark/pull/30957#issuecomment-773792948
**[Test build #134912 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134912/testReport)**
for PR 30957 at commit
SparkQA commented on pull request #31481:
URL: https://github.com/apache/spark/pull/31481#issuecomment-773916759
**[Test build #134909 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134909/testReport)**
for PR 31481 at commit
SparkQA commented on pull request #31484:
URL: https://github.com/apache/spark/pull/31484#issuecomment-773875198
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39499/
SparkQA removed a comment on pull request #31467:
URL: https://github.com/apache/spark/pull/31467#issuecomment-773056148
**[Test build #134855 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134855/testReport)**
for PR 31467 at commit
AmplabJenkins removed a comment on pull request #31133:
URL: https://github.com/apache/spark/pull/31133#issuecomment-773608335
This is an automated message from the Apache Git Service.
To respond to the message, please log on
LuciferYang commented on a change in pull request #31471:
URL: https://github.com/apache/spark/pull/31471#discussion_r570096278
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##
@@ -217,8 +217,11 @@ object
cloud-fan commented on a change in pull request #31245:
URL: https://github.com/apache/spark/pull/31245#discussion_r570793713
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala
##
@@ -119,6 +102,34 @@ trait
SparkQA commented on pull request #31485:
URL: https://github.com/apache/spark/pull/31485#issuecomment-773909514
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39506/
yaooqinn commented on pull request #31482:
URL: https://github.com/apache/spark/pull/31482#issuecomment-773910641
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
SparkQA commented on pull request #31486:
URL: https://github.com/apache/spark/pull/31486#issuecomment-773906733
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39507/
601 - 700 of 775 matches
Mail list logo