[GitHub] [spark] SparkQA commented on pull request #31575: [SPARK-34450][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. RENAME tests

2021-02-21 Thread GitBox
SparkQA commented on pull request #31575: URL: https://github.com/apache/spark/pull/31575#issuecomment-783165664 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39915/

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

2021-02-21 Thread GitBox
SparkQA commented on pull request #31596: URL: https://github.com/apache/spark/pull/31596#issuecomment-783162075 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39914/

[GitHub] [spark] SparkQA removed a comment on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA removed a comment on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783088733 **[Test build #135332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135332/testReport)** for PR 31607 at commit

[GitHub] [spark] SparkQA commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783161551 **[Test build #135332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135332/testReport)** for PR 31607 at commit

[GitHub] [spark] SparkQA commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
SparkQA commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-783161224 **[Test build #135337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135337/testReport)** for PR 31349 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
SparkQA removed a comment on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783040423 **[Test build #135329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135329/testReport)** for PR 29695 at commit

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31609: [SPARK-34496][BUILD] Upgrade ZSTD-JNI to 1.4.8-5 for better API compatibility

2021-02-21 Thread GitBox
dongjoon-hyun edited a comment on pull request #31609: URL: https://github.com/apache/spark/pull/31609#issuecomment-783158745 Hi, @wangyum . ZSTD JNI API compatability is improved at 1.4.8-5. Could you check this PR if this is helpful for SPARK-34479 (Add zstandard codec to

[GitHub] [spark] SparkQA commented on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
SparkQA commented on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783159807 **[Test build #135329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135329/testReport)** for PR 29695 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #31609: [SPARK-34496][BUILD] Upgrade ZSTD-JNI to 1.4.8-5 for better API compatibility

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31609: URL: https://github.com/apache/spark/pull/31609#issuecomment-783158745 Hi, @wangyum . ZSTD JNI API compatability is improved at 1.4.8-5. Could you check this PR if this is helpful for SPARK-34479?

[GitHub] [spark] gengliangwang commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
gengliangwang commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r580033792 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out ## @@ -289,25 +290,28 @@ trim -- !query SELECT

[GitHub] [spark] c21 commented on a change in pull request #31595: [SPARK-34474][SQL] Remove unnecessary Union under Distinct like operators

2021-02-21 Thread GitBox
c21 commented on a change in pull request #31595: URL: https://github.com/apache/spark/pull/31595#discussion_r580032618 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -492,12 +492,43 @@ object RemoveRedundantAliases

[GitHub] [spark] SparkQA removed a comment on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
SparkQA removed a comment on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783149101 **[Test build #135336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135336/testReport)** for PR 31608 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783156378 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135336/

[GitHub] [spark] dongjoon-hyun opened a new pull request #31609: [SPARK-34496][BUILD] Upgrade ZSTD-JNI to 1.4.8-5 to API compatibility

2021-02-21 Thread GitBox
dongjoon-hyun opened a new pull request #31609: URL: https://github.com/apache/spark/pull/31609 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] SparkQA commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
SparkQA commented on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783156147 **[Test build #135336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135336/testReport)** for PR 31608 at commit

[GitHub] [spark] c21 commented on a change in pull request #31595: [SPARK-34474][SQL] Remove unnecessary Union under Distinct like operators

2021-02-21 Thread GitBox
c21 commented on a change in pull request #31595: URL: https://github.com/apache/spark/pull/31595#discussion_r580030375 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -492,12 +492,43 @@ object RemoveRedundantAliases

[GitHub] [spark] SparkQA commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783154582 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39913/

[GitHub] [spark] beliefer commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
beliefer commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r580029869 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out ## @@ -289,25 +290,28 @@ trim -- !query SELECT

[GitHub] [spark] gengliangwang commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
gengliangwang commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r580028151 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out ## @@ -289,25 +290,28 @@ trim -- !query SELECT

[GitHub] [spark] gengliangwang commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
gengliangwang commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r580027883 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/union.sql.out ## @@ -682,10 +682,10 @@ struct -- !query SELECT cast('3.4'

[GitHub] [spark] beliefer commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
beliefer commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r580027418 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/union.sql.out ## @@ -682,10 +682,10 @@ struct -- !query SELECT cast('3.4' as

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783116314 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
SparkQA commented on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783149101 **[Test build #135336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135336/testReport)** for PR 31608 at commit

[GitHub] [spark] SparkQA commented on pull request #31575: [SPARK-34450][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. RENAME tests

2021-02-21 Thread GitBox
SparkQA commented on pull request #31575: URL: https://github.com/apache/spark/pull/31575#issuecomment-783148659 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39915/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783147472 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39912/

[GitHub] [spark] AmplabJenkins commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783147472 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39912/

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

2021-02-21 Thread GitBox
SparkQA commented on pull request #31596: URL: https://github.com/apache/spark/pull/31596#issuecomment-783146768 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39914/

[GitHub] [spark] gengliangwang commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-21 Thread GitBox
gengliangwang commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r580023282 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/union.sql.out ## @@ -682,10 +682,10 @@ struct -- !query SELECT cast('3.4'

[GitHub] [spark] dongjoon-hyun commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783141847 Thank you! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon closed pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
HyukjinKwon closed pull request #31607: URL: https://github.com/apache/spark/pull/31607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
HyukjinKwon commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783139874 Related tests. Let me merge this in. Merged to master. This is an automated message from the Apache

[GitHub] [spark] wangyum commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
wangyum commented on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783138283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] wangyum commented on a change in pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
wangyum commented on a change in pull request #31608: URL: https://github.com/apache/spark/pull/31608#discussion_r580018130 ## File path: docs/sql-migration-guide.md ## @@ -89,7 +89,7 @@ license: | - In Spark 3.0, `SHOW TBLPROPERTIES` throws `AnalysisException` if the

[GitHub] [spark] SparkQA commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783134993 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39912/

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

2021-02-21 Thread GitBox
SparkQA commented on pull request #31596: URL: https://github.com/apache/spark/pull/31596#issuecomment-783128287 **[Test build #135334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135334/testReport)** for PR 31596 at commit

[GitHub] [spark] SparkQA commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783127167 **[Test build #135333 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135333/testReport)** for PR 31607 at commit

[GitHub] [spark] SparkQA commented on pull request #31575: [SPARK-34450][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. RENAME tests

2021-02-21 Thread GitBox
SparkQA commented on pull request #31575: URL: https://github.com/apache/spark/pull/31575#issuecomment-783120465 **[Test build #135335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135335/testReport)** for PR 31575 at commit

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783119022 @gengliangwang Let us ignore the return type of btrim. In Postgresql, Vertica, Redshift, Druid, Greenplum, btrim is used to remove the leading and trailing space

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783119022 @gengliangwang Let us ignore the return type of btrim. In Postgresql, Vertica, Redshift, Druid, Greenplum, btrim is used to remove the leading and trailing space

[GitHub] [spark] beliefer commented on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer commented on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783119022 @gengliangwang Let us ignore the return type of btrim. In Postgresql, Vertica, Redshift, Druid, Greenplum, btrim is used to remove the leading and trailing space characters

[GitHub] [spark] SparkQA commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783117425 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39912/

[GitHub] [spark] gengliangwang commented on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
gengliangwang commented on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783116851 @beliefer From the first link you provide in PR description: > https://www.postgresql.org/docs/11/functions-binarystring.html I thought that the function is for

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783116149 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39907/

[GitHub] [spark] AmplabJenkins commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #31608: URL: https://github.com/apache/spark/pull/31608#issuecomment-783116314 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31448: [SPARK-28137][SQL] Data Type Formatting Functions: `to_number`.

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31448: URL: https://github.com/apache/spark/pull/31448#issuecomment-783116150 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39911/

[GitHub] [spark] AmplabJenkins commented on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783116149 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39907/

[GitHub] [spark] AmplabJenkins commented on pull request #31448: [SPARK-28137][SQL] Data Type Formatting Functions: `to_number`.

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #31448: URL: https://github.com/apache/spark/pull/31448#issuecomment-783116150 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39911/

[GitHub] [spark] hiboyang commented on pull request #30004: [SPARK-33114][CORE] Add metadata in MapStatus to support custom shuffle manager

2021-02-21 Thread GitBox
hiboyang commented on pull request #30004: URL: https://github.com/apache/spark/pull/30004#issuecomment-783112879 Cool, thanks @attilapiros for the update! Hi @viirya @Ngone51, would you help to review the PR here?

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783108294 @gengliangwang btrim means trim from leading and trailing. not binary. You can reference all the database show in PR's description.

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783108294 @gengliangwang btrim means trim from leading and trailing. not binary This is an automated message from

[GitHub] [spark] beliefer commented on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer commented on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783108294 @btrim means trim from leading and trailing. not binary This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
SparkQA commented on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783108012 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39907/

[GitHub] [spark] Karl-WangSK opened a new pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

2021-02-21 Thread GitBox
Karl-WangSK opened a new pull request #31608: URL: https://github.com/apache/spark/pull/31608 ### What changes were proposed in this pull request? add `table_identifier` in sql-migration-guide.md ### Why are the changes needed? fix doc ### Does this PR

[GitHub] [spark] MaxGekk commented on pull request #31499: [SPARK-31891][SQL] Support `MSCK REPAIR TABLE .. [{ADD|DROP|SYNC} PARTITIONS]`

2021-02-21 Thread GitBox
MaxGekk commented on pull request #31499: URL: https://github.com/apache/spark/pull/31499#issuecomment-783098295 @dongjoon-hyun Could you take a look at this PR one more time, please. This is an automated message from the

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
HyukjinKwon commented on a change in pull request #31607: URL: https://github.com/apache/spark/pull/31607#discussion_r579994363 ## File path: .github/workflows/build_and_test.yml ## @@ -65,7 +65,7 @@ jobs: java: 8 hadoop: hadoop3.2 hive:

[GitHub] [spark] MaxGekk commented on pull request #31605: [SPARK-34290][SQL] Support v2 `TRUNCATE TABLE`

2021-02-21 Thread GitBox
MaxGekk commented on pull request #31605: URL: https://github.com/apache/spark/pull/31605#issuecomment-783097231 @cloud-fan @HyukjinKwon Could you review this PR, please. This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
HyukjinKwon commented on a change in pull request #31607: URL: https://github.com/apache/spark/pull/31607#discussion_r579994253 ## File path: .github/workflows/build_and_test.yml ## @@ -65,7 +65,7 @@ jobs: java: 8 hadoop: hadoop3.2 hive:

[GitHub] [spark] gengliangwang commented on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
gengliangwang commented on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783096639 As per https://www.postgresql.org/docs/11/functions-binarystring.html, the result type of `btrim` should be of binary type instead of string type. @beliefer cloud you

[GitHub] [spark] MaxGekk commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

2021-02-21 Thread GitBox
MaxGekk commented on pull request #31596: URL: https://github.com/apache/spark/pull/31596#issuecomment-783094003 @HyukjinKwon @cloud-fan @dongjoon-hyun Can this be merged to `branch-3.1`? Most (or all) of the nodes were added after 3.0, and they haven't released yet.

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31600: [SPARK-34482][SS] Correct the active SparkSession for streaming query

2021-02-21 Thread GitBox
HeartSaVioR edited a comment on pull request #31600: URL: https://github.com/apache/spark/pull/31600#issuecomment-783057670 Given we assume that the code might have a bug, it may not be safe if we try to answer the question based on current code. Probably we'd need to try to ask and

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31600: [SPARK-34482][SS] Correct the active SparkSession for streaming query

2021-02-21 Thread GitBox
HeartSaVioR edited a comment on pull request #31600: URL: https://github.com/apache/spark/pull/31600#issuecomment-783057670 Given we assume that the code might have a bug, it may not be safe if we try to answer the question based on current code. Probably we'd need to try to ask and

[GitHub] [spark] SparkQA commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
SparkQA commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783088733 **[Test build #135332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135332/testReport)** for PR 31607 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31593: URL: https://github.com/apache/spark/pull/31593#issuecomment-783087251 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39910/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783087252 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39909/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31606: [SPARK-34490][SQL] Analysis should fail if the view refers a dropped table

2021-02-21 Thread GitBox
AmplabJenkins removed a comment on pull request #31606: URL: https://github.com/apache/spark/pull/31606#issuecomment-783087253 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135328/

[GitHub] [spark] AmplabJenkins commented on pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #31593: URL: https://github.com/apache/spark/pull/31593#issuecomment-783087251 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39910/

[GitHub] [spark] AmplabJenkins commented on pull request #31606: [SPARK-34490][SQL] Analysis should fail if the view refers a dropped table

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #31606: URL: https://github.com/apache/spark/pull/31606#issuecomment-783087253 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135328/

[GitHub] [spark] AmplabJenkins commented on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
AmplabJenkins commented on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783087252 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39909/

[GitHub] [spark] gengliangwang commented on a change in pull request #31318: [SPARK-34222][SQL] Enhance boolean simplification rule

2021-02-21 Thread GitBox
gengliangwang commented on a change in pull request #31318: URL: https://github.com/apache/spark/pull/31318#discussion_r579986647 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -366,22 +367,34 @@ object

[GitHub] [spark] dongjoon-hyun commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783083499 Thank you for your advice, @HyukjinKwon . This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

2021-02-21 Thread GitBox
SparkQA commented on pull request #31593: URL: https://github.com/apache/spark/pull/31593#issuecomment-783083457 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39910/

[GitHub] [spark] SparkQA removed a comment on pull request #31606: [SPARK-34490][SQL] Analysis should fail if the view refers a dropped table

2021-02-21 Thread GitBox
SparkQA removed a comment on pull request #31606: URL: https://github.com/apache/spark/pull/31606#issuecomment-783055906 **[Test build #135328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135328/testReport)** for PR 31606 at commit

[GitHub] [spark] SparkQA commented on pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

2021-02-21 Thread GitBox
SparkQA commented on pull request #31593: URL: https://github.com/apache/spark/pull/31593#issuecomment-783081906 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39910/

[GitHub] [spark] HyukjinKwon commented on pull request #31603: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-02-21 Thread GitBox
HyukjinKwon commented on pull request #31603: URL: https://github.com/apache/spark/pull/31603#issuecomment-783080342 Sure thanks @dongjoon-hyun for addressing my comment! This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #31606: [SPARK-34490][SQL] Analysis should fail if the view refers a dropped table

2021-02-21 Thread GitBox
SparkQA commented on pull request #31606: URL: https://github.com/apache/spark/pull/31606#issuecomment-783079679 **[Test build #135328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135328/testReport)** for PR 31606 at commit

[GitHub] [spark] cloud-fan commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-21 Thread GitBox
cloud-fan commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-783077901 Since Spark can't write such parquet files, it's a compatibility improvement, so I didn't backport. This is

[GitHub] [spark] cloud-fan closed pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-21 Thread GitBox
cloud-fan closed pull request #31284: URL: https://github.com/apache/spark/pull/31284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-21 Thread GitBox
cloud-fan commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-783077541 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31600: [SPARK-34482][SS] Correct the active SparkSession for streaming query

2021-02-21 Thread GitBox
HeartSaVioR edited a comment on pull request #31600: URL: https://github.com/apache/spark/pull/31600#issuecomment-783057670 Given we assume that the code might have a bug, it may not be safe if we try to answer the question based on current code. Probably we'd need to try to ask and

[GitHub] [spark] cloud-fan commented on pull request #31575: [SPARK-34450][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. RENAME tests

2021-02-21 Thread GitBox
cloud-fan commented on pull request #31575: URL: https://github.com/apache/spark/pull/31575#issuecomment-783075589 https://github.com/apache/spark/pull/31594 is merged, @MaxGekk can you adjust this PR? This is an automated

[GitHub] [spark] cloud-fan closed pull request #31594: [SPARK-34468][SQL] Rename v2 table in place if new name has single part

2021-02-21 Thread GitBox
cloud-fan closed pull request #31594: URL: https://github.com/apache/spark/pull/31594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31594: [SPARK-34468][SQL] Rename v2 table in place if new name has single part

2021-02-21 Thread GitBox
cloud-fan commented on pull request #31594: URL: https://github.com/apache/spark/pull/31594#issuecomment-783075322 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #31448: [SPARK-28137][SQL] Data Type Formatting Functions: `to_number`.

2021-02-21 Thread GitBox
SparkQA commented on pull request #31448: URL: https://github.com/apache/spark/pull/31448#issuecomment-783075049 **[Test build #135331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135331/testReport)** for PR 31448 at commit

[GitHub] [spark] cloud-fan closed pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs

2021-02-21 Thread GitBox
cloud-fan closed pull request #31592: URL: https://github.com/apache/spark/pull/31592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs

2021-02-21 Thread GitBox
cloud-fan commented on pull request #31592: URL: https://github.com/apache/spark/pull/31592#issuecomment-783074887 thanks, merging to 3.0! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
SparkQA commented on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783074054 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39909/

[GitHub] [spark] cloud-fan commented on a change in pull request #31594: [SPARK-34468][SQL] Rename v2 table in place if new name has single part

2021-02-21 Thread GitBox
cloud-fan commented on a change in pull request #31594: URL: https://github.com/apache/spark/pull/31594#discussion_r579980038 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/RenameTableExec.scala ## @@ -43,12 +43,20 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #31318: [SPARK-34222][SQL] Enhance boolean simplification rule

2021-02-21 Thread GitBox
cloud-fan commented on a change in pull request #31318: URL: https://github.com/apache/spark/pull/31318#discussion_r579979610 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -366,22 +367,34 @@ object

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

2021-02-21 Thread GitBox
dongjoon-hyun commented on a change in pull request #31593: URL: https://github.com/apache/spark/pull/31593#discussion_r579979434 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala ## @@ -64,8 +64,10 @@ final class DataStreamReader

[GitHub] [spark] SparkQA commented on pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

2021-02-21 Thread GitBox
SparkQA commented on pull request #31593: URL: https://github.com/apache/spark/pull/31593#issuecomment-783072520 **[Test build #135330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135330/testReport)** for PR 31593 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31318: [SPARK-34222][SQL] Enhance boolean simplification rule

2021-02-21 Thread GitBox
cloud-fan commented on a change in pull request #31318: URL: https://github.com/apache/spark/pull/31318#discussion_r579979106 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -345,17 +345,18 @@ object

[GitHub] [spark] cloud-fan closed pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-21 Thread GitBox
cloud-fan closed pull request #31524: URL: https://github.com/apache/spark/pull/31524 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-21 Thread GitBox
cloud-fan commented on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-783071133 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31607: URL: https://github.com/apache/spark/pull/31607#issuecomment-783070966 cc @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun opened a new pull request #31607: [SPARK-34495][TESTS] Add `DedicatedJVMTest` test tag

2021-02-21 Thread GitBox
dongjoon-hyun opened a new pull request #31607: URL: https://github.com/apache/spark/pull/31607 ### What changes were proposed in this pull request? This PR aims to add a test tag, `DedicatedJVMTest`, and replace `SecurityTest` with this. ### Why are the changes needed?

[GitHub] [spark] dongjoon-hyun commented on pull request #31603: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31603: URL: https://github.com/apache/spark/pull/31603#issuecomment-783069153 BTW, I'll create a new JIRA issue for `DedicatedJVMTest`. This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun commented on pull request #31603: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31603: URL: https://github.com/apache/spark/pull/31603#issuecomment-783068598 BTW, I considered to put all security tests into this `SecurityTest` tag, but `DedicatedJVM` sounds useful because we are ignoring all dedicated JVM tests currently in

[GitHub] [spark] SparkQA commented on pull request #29695: [SPARK-22390][SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2021-02-21 Thread GitBox
SparkQA commented on pull request #29695: URL: https://github.com/apache/spark/pull/29695#issuecomment-783067698 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39907/

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31603: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-02-21 Thread GitBox
dongjoon-hyun edited a comment on pull request #31603: URL: https://github.com/apache/spark/pull/31603#issuecomment-783066869 Hi, @HyukjinKwon . This is a security feature and Apache ORC

[GitHub] [spark] dongjoon-hyun commented on pull request #31603: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

2021-02-21 Thread GitBox
dongjoon-hyun commented on pull request #31603: URL: https://github.com/apache/spark/pull/31603#issuecomment-783066869 Hi, @HyukjinKwon . This is a security feature and Apache ORC

  1   2   3   >