[GitHub] [spark] sadhen commented on a change in pull request #32026: [SPARK-34771] Support UDT for Pandas/Spark conversion with Arrow support Enabled

2021-04-01 Thread GitBox
sadhen commented on a change in pull request #32026: URL: https://github.com/apache/spark/pull/32026#discussion_r60566 ## File path: python/pyspark/sql/pandas/types.py ## @@ -346,3 +348,29 @@ def _convert_dict_to_map_items(s): :return: pandas.Series of lists of (key,

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811911181 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41396/ --

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605655077 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] tgravescs commented on pull request #31942: [SPARK-34834][NETWORK] Fix a potential Netty memory leak in TransportResponseHandler.

2021-04-01 Thread GitBox
tgravescs commented on pull request #31942: URL: https://github.com/apache/spark/pull/31942#issuecomment-811904755 Not all the cases have a body to them. I guess perhaps you can check the isBodyInFrame() to see which ones do. The particular thing he is trying to fix here try-catch

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh edited a comment on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811904168 ping @MaxGekk Updated, current code should be ok since `InsertIntoHadoopFsRelationCommand` only used in DsV1 or convert from hive related command. and I have

[GitHub] [spark] AngersZhuuuu commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811904168 ping @MaxGekk Updated, current code should be ok since `InsertIntoHadoopFsRelationCommand` only used in DsV1 or convert from hive related command. -- This is an

[GitHub] [spark] AngersZhuuuu commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811902232 > DSv2 impl should handle `null` itself. So, we shouldn't replace it by `__HIVE_DEFAULT_PARTITION__`. I know Why I am confused, I test this in spark 3.0, this

[GitHub] [spark] cloud-fan commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605645416 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] AngersZhuuuu commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811899072 > > There are many testing SQL in SQLQueryTestSuite like this, should we rewrite it? > > It's better to rewrite them to avoid warning messages. Can you help with it

[GitHub] [spark] cloud-fan commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
cloud-fan commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811897765 > There are many testing SQL in SQLQueryTestSuite like this, should we rewrite it? It's better to rewrite them to avoid warning messages. Can you help with it later?

[GitHub] [spark] cloud-fan commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605645033 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-811889230 **[Test build #136815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136815/testReport)** for PR 30145 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
HyukjinKwon commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811887668 Some benchmarks are already broken ... let me fix them together while I'm here. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #32026: [SPARK-34771] Support UDT for Pandas/Spark conversion with Arrow support Enabled

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32026: URL: https://github.com/apache/spark/pull/32026#issuecomment-811887267 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811886851 **[Test build #136814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136814/testReport)** for PR 31908 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605634358 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1951,39 @@ class Analyzer(override

[GitHub] [spark] SparkQA commented on pull request #32026: [SPARK-34771] Support UDT for Pandas/Spark conversion with Arrow support Enabled

2021-04-01 Thread GitBox
SparkQA commented on pull request #32026: URL: https://github.com/apache/spark/pull/32026#issuecomment-811886707 **[Test build #136813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136813/testReport)** for PR 32026 at commit

[GitHub] [spark] wangyum commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
wangyum commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811885819 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] sadhen opened a new pull request #32026: [SPARK-34771] Support UDT for Pandas/Spark conversion with Arrow support Enabled

2021-04-01 Thread GitBox
sadhen opened a new pull request #32026: URL: https://github.com/apache/spark/pull/32026 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [spark] dbaliafroozeh commented on pull request #31932: [SPARK-34906] Refactor TreeNode's children handling methods into specialized traits

2021-04-01 Thread GitBox
dbaliafroozeh commented on pull request #31932: URL: https://github.com/apache/spark/pull/31932#issuecomment-811884973 @MaxGekk @cloud-fan I'll do your suggestions in a follow up PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
maropu commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811883369 cc: @wzhfy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] AmplabJenkins commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811882395 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41395/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811882395 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41395/

[GitHub] [spark] AmplabJenkins commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811882397 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136806/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811882397 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136806/

[GitHub] [spark] maropu commented on a change in pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
maropu commented on a change in pull request #32014: URL: https://github.com/apache/spark/pull/32014#discussion_r605628437 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala ## @@ -349,11 +349,14 @@ object

[GitHub] [spark] SparkQA commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
SparkQA commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811879585 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41395/ -- This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811756696 **[Test build #136806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136806/testReport)** for PR 31908 at commit

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811877966 **[Test build #136806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136806/testReport)** for PR 31908 at commit

[GitHub] [spark] SparkQA commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
SparkQA commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811876744 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41395/ -- This is an automated message from the Apache

[GitHub] [spark] maropu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
maropu commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605606388 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -658,14 +658,15 @@ class Analyzer(override val

[GitHub] [spark] maropu commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
maropu commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605602643 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] SparkQA commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
SparkQA commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811852723 **[Test build #136812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136812/testReport)** for PR 30144 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811851334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811851340 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41394/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811851338 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136799/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811851336 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136805/

[GitHub] [spark] AmplabJenkins commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811851336 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136805/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811851334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811851338 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136799/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811851340 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41394/ --

[GitHub] [spark] SparkQA removed a comment on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811686050 **[Test build #136799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136799/testReport)** for PR 32014 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811756628 **[Test build #136805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136805/testReport)** for PR 32015 at commit

[GitHub] [spark] SparkQA commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
SparkQA commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811849057 **[Test build #136805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136805/testReport)** for PR 32015 at commit

[GitHub] [spark] SparkQA commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
SparkQA commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811848992 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41394/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
SparkQA commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811848343 **[Test build #136799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136799/testReport)** for PR 32014 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811792782 **[Test build #136810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136810/testReport)** for PR 32022 at commit

[GitHub] [spark] SparkQA commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
SparkQA commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811846690 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41394/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811846381 **[Test build #136810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136810/testReport)** for PR 32022 at commit

[GitHub] [spark] yaooqinn edited a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
yaooqinn edited a comment on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811840988 cc @cloud-fan @maropu thanks for reviewing, I guess later we can make a document for reserved properties for DDL pages to refer -- This is an automated message from

[GitHub] [spark] yaooqinn commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
yaooqinn commented on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811840988 cc @cloud-fan @maropu thanks for reviewing, I guess we can make a document for reserved properties for DDL pages to refer -- This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811840271 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41393/ -- This is an automated message from the

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605575398 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -88,6 +89,41 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605575398 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -88,6 +89,41 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605573083 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -88,6 +89,41 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811825648 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41392/

[GitHub] [spark] AmplabJenkins commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811825648 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41392/ --

[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
SparkQA commented on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811825619 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41392/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811824678 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136797/

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811824743 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41393/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
SparkQA commented on pull request #30144: URL: https://github.com/apache/spark/pull/30144#issuecomment-811824813 **[Test build #136811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136811/testReport)** for PR 30144 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811824678 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136797/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811665027 **[Test build #136797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136797/testReport)** for PR 32019 at commit

[GitHub] [spark] SparkQA commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811823721 **[Test build #136797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136797/testReport)** for PR 32019 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811822930 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136796/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-811823133 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41391/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811822936 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41390/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811822938 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136801/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811822939 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41389/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-811822934 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136800/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811822937 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136794/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811822932 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136795/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811822940 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136798/

[GitHub] [spark] AmplabJenkins commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-811823133 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41391/ --

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-811823102 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41391/ --

[GitHub] [spark] AmplabJenkins commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811822936 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41390/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811822937 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136794/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811822932 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136795/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811822938 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136801/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811822930 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136796/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811822939 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41389/ --

[GitHub] [spark] AmplabJenkins commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-811822934 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136800/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811822940 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136798/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811662206 **[Test build #136796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136796/testReport)** for PR 32017 at commit

[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
SparkQA commented on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811821764 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41392/ -- This is an automated message from the Apache

[GitHub] [spark] AngersZhuuuu commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811820792 There are many testing SQL in SQLQueryTestSuite like this, should we rewrite it? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
SparkQA commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811819111 **[Test build #136796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136796/testReport)** for PR 32017 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605551784 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -212,3 +212,27 @@ object GroupingID {

[GitHub] [spark] SparkQA removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811659269 **[Test build #136795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136795/testReport)** for PR 31179 at commit

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811816383 **[Test build #136795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136795/testReport)** for PR 31179 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-811717497 **[Test build #136800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136800/testReport)** for PR 31204 at commit

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-04-01 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-811814053 **[Test build #136800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136800/testReport)** for PR 31204 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811718956 **[Test build #136801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136801/testReport)** for PR 32021 at commit

[GitHub] [spark] SparkQA commented on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
SparkQA commented on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811811054 **[Test build #136801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136801/testReport)** for PR 32021 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811658915 **[Test build #136794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136794/testReport)** for PR 32010 at commit

[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
SparkQA commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811808958 **[Test build #136794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136794/testReport)** for PR 32010 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811685983 **[Test build #136798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136798/testReport)** for PR 32020 at commit

[GitHub] [spark] SparkQA commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
SparkQA commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811807347 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41390/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
SparkQA commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811807137 **[Test build #136798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136798/testReport)** for PR 32020 at commit

[GitHub] [spark] SparkQA commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
SparkQA commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811802897 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41390/ -- This is an automated message from the Apache

<    1   2   3   4   5   6   >