[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811802077 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41389/ -- This is an automated message from the

[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605527431 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -212,3 +212,27 @@ object GroupingID { if

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811797610 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41389/ -- This is an automated message from the Apache

[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605527431 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -212,3 +212,27 @@ object GroupingID { if

[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605527431 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -212,3 +212,27 @@ object GroupingID { if

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811795336 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41388/

[GitHub] [spark] AmplabJenkins commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811795336 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41388/ --

[GitHub] [spark] SparkQA commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
SparkQA commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811795291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811792782 **[Test build #136810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136810/testReport)** for PR 32022 at commit

[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties

2021-04-01 Thread GitBox
SparkQA commented on pull request #32025: URL: https://github.com/apache/spark/pull/32025#issuecomment-811792687 **[Test build #136809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136809/testReport)** for PR 32025 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811791017 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136793/

[GitHub] [spark] AmplabJenkins commented on pull request #32024: [SPARK-34934] Fix race condition while adding/removing sources in MetricsSystem

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32024: URL: https://github.com/apache/spark/pull/32024#issuecomment-811791404 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811791013 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136791/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32023: URL: https://github.com/apache/spark/pull/32023#issuecomment-811791016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811791014 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136792/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811791018 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41385/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811791015 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136807/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811791026 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41384/

[GitHub] [spark] AmplabJenkins commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811791013 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136791/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811791017 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136793/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811791014 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136792/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811791018 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41385/ --

[GitHub] [spark] AmplabJenkins commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811791015 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136807/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811791026 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41384/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32023: URL: https://github.com/apache/spark/pull/32023#issuecomment-811791016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811634186 **[Test build #136791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136791/testReport)** for PR 31179 at commit

[GitHub] [spark] SparkQA commented on pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
SparkQA commented on pull request #32023: URL: https://github.com/apache/spark/pull/32023#issuecomment-811789556 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41386/ --

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605518637 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override

[GitHub] [spark] yaooqinn opened a new pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved properties of tables

2021-04-01 Thread GitBox
yaooqinn opened a new pull request #32025: URL: https://github.com/apache/spark/pull/32025 … ### What changes were proposed in this pull request? CREATE TABLE LIKE should respect the reserved properties of tables and fail if specified, using

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811786741 **[Test build #136791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136791/testReport)** for PR 31179 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605512700 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] cloud-fan commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605511048 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605510571 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,19 @@ class AstBuilder extends

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605509697 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -29,8 +29,7 @@ When a FILTER clause is attached to an aggregate function, only the

[GitHub] [spark] AngersZhuuuu commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AngersZh commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811780148 Nice Idea! I want to do like this for a long time. Without this we can make code more simpler. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] HyukjinKwon closed pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
HyukjinKwon closed pull request #32021: URL: https://github.com/apache/spark/pull/32021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] BOOTMGR opened a new pull request #32024: [SPARK-34934] Fix race condition while adding/removing sources in MetricsSystem

2021-04-01 Thread GitBox
BOOTMGR opened a new pull request #32024: URL: https://github.com/apache/spark/pull/32024 ### What changes were proposed in this pull request? Synchronise access to `registerSource` and `removeSource` method since underlying `ArrayBuffer` is not thread safe. ###

[GitHub] [spark] SparkQA removed a comment on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811634985 **[Test build #136792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136792/testReport)** for PR 32019 at commit

[GitHub] [spark] SparkQA commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811777682 **[Test build #136792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136792/testReport)** for PR 32019 at commit

[GitHub] [spark] SparkQA commented on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
SparkQA commented on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811777582 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41384/ -- This is an automated message from the

[GitHub] [spark] ulysses-you commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
ulysses-you commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811773818 thanks for merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA removed a comment on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811635030 **[Test build #136793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136793/testReport)** for PR 31989 at commit

[GitHub] [spark] SparkQA commented on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-04-01 Thread GitBox
SparkQA commented on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811773041 **[Test build #136793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136793/testReport)** for PR 31989 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32023: URL: https://github.com/apache/spark/pull/32023#issuecomment-811756532 **[Test build #136803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136803/testReport)** for PR 32023 at commit

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811768548 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41385/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
SparkQA commented on pull request #32023: URL: https://github.com/apache/spark/pull/32023#issuecomment-811768207 **[Test build #136803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136803/testReport)** for PR 32023 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811757067 **[Test build #136807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136807/testReport)** for PR 31010 at commit

[GitHub] [spark] SparkQA commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
SparkQA commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811767555 **[Test build #136807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136807/testReport)** for PR 31010 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811763586 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41387/

[GitHub] [spark] sadhen commented on a change in pull request #31735: [SPARK-34799][PYTHON][SQL] Return User-defined types from Pandas UDF

2021-04-01 Thread GitBox
sadhen commented on a change in pull request #31735: URL: https://github.com/apache/spark/pull/31735#discussion_r605490951 ## File path: python/pyspark/sql/pandas/serializers.py ## @@ -183,30 +193,59 @@ def create_array(s, t): raise e return

[GitHub] [spark] AmplabJenkins commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811763586 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41387/ --

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811763569 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41387/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811763008 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136804/

[GitHub] [spark] SparkQA removed a comment on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811756568 **[Test build #136804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136804/testReport)** for PR 32022 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811763008 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136804/ -- This

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811762956 **[Test build #136804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136804/testReport)** for PR 32022 at commit

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811762746 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41385/ -- This is an automated message from the Apache

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605486875 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-811759537 **[Test build #136808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136808/testReport)** for PR 30145 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605484868 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override

[GitHub] [spark] SparkQA commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
SparkQA commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811757067 **[Test build #136807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136807/testReport)** for PR 31010 at commit

[GitHub] [spark] SparkQA commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
SparkQA commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811756628 **[Test build #136805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136805/testReport)** for PR 32015 at commit

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811756696 **[Test build #136806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136806/testReport)** for PR 31908 at commit

[GitHub] [spark] SparkQA commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
SparkQA commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811756568 **[Test build #136804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136804/testReport)** for PR 32022 at commit

[GitHub] [spark] SparkQA commented on pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
SparkQA commented on pull request #32023: URL: https://github.com/apache/spark/pull/32023#issuecomment-811756532 **[Test build #136803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136803/testReport)** for PR 32023 at commit

[GitHub] [spark] SparkQA commented on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
SparkQA commented on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811755218 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41384/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811754100 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41382/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811754098 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136802/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811754099 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136790/

[GitHub] [spark] AmplabJenkins commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811754098 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136802/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811754100 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41382/ --

[GitHub] [spark] AmplabJenkins commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811754099 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136790/ -- This

[GitHub] [spark] cloud-fan commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605480941 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605480675 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override val

[GitHub] [spark] AngersZhuuuu commented on pull request #31010: [SPARK-33976][SQL] Spark script TRANSFORM related change doc

2021-04-01 Thread GitBox
AngersZh commented on pull request #31010: URL: https://github.com/apache/spark/pull/31010#issuecomment-811753198 ping @maropu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] cloud-fan commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
cloud-fan commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811752818 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] viirya commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
viirya commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811751626 Thanks @HyukjinKwon @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] viirya commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
viirya commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605478162 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -84,7 +84,7 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605477279 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-analytics.sql ## @@ -59,4 +59,12 @@ SELECT course, year FROM courseSales GROUP BY

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605476505 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -84,7 +84,7 @@ object

[GitHub] [spark] HyukjinKwon closed pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
HyukjinKwon closed pull request #32020: URL: https://github.com/apache/spark/pull/32020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] HyukjinKwon commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
HyukjinKwon commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811748467 Merged to branch-2.4. All related tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] cloud-fan commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605473810 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -88,6 +89,41 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE

[GitHub] [spark] sarutak opened a new pull request #32023: [SPARK-34933][DOC][SQL] Remove the description that || and && can be used as logical operators from the document

2021-04-01 Thread GitBox
sarutak opened a new pull request #32023: URL: https://github.com/apache/spark/pull/32023 ### What changes were proposed in this pull request? This PR removes the description that `||` and `&&` can be used as logical operators from the migration guide. ### Why are the changes

[GitHub] [spark] SparkQA removed a comment on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811719082 **[Test build #136802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136802/testReport)** for PR 31908 at commit

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811745461 **[Test build #136802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136802/testReport)** for PR 31908 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #32022: URL: https://github.com/apache/spark/pull/32022#discussion_r605472098 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -914,19 +914,18 @@ class AstBuilder extends

[GitHub] [spark] SparkQA removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811619794 **[Test build #136790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136790/testReport)** for PR 31179 at commit

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811742515 **[Test build #136790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136790/testReport)** for PR 31179 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30144: [SPARK-33229][SQL] Support partial grouping analytics and concatenated grouping analytics

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r605469239 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -88,6 +89,41 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605461126 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -45,7 +45,7 @@ object

[GitHub] [spark] cloud-fan commented on pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
cloud-fan commented on pull request #32022: URL: https://github.com/apache/spark/pull/32022#issuecomment-811739874 cc @AngersZh @maropu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan opened a new pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

2021-04-01 Thread GitBox
cloud-fan opened a new pull request #32022: URL: https://github.com/apache/spark/pull/32022 ### What changes were proposed in this pull request? According to the code comment ``` // `GROUP BY warehouse, product GROUPING SETS((warehouse, producets), (warehouse))` is//

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605461126 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -45,7 +45,7 @@ object

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #32015: URL: https://github.com/apache/spark/pull/32015#discussion_r605461126 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -45,7 +45,7 @@ object

[GitHub] [spark] AngersZhuuuu commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811731723 > > which case the path will be null and which case it can be **HIVE_DEFAULT_PARTITION**? > > The `null` partition value should be replaced to

[GitHub] [spark] HyukjinKwon edited a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
HyukjinKwon edited a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811064987 Note that I tested subset of benchmarks, verified that it works, and now I am waiting for the final results of running all benchmarks: - [Run benchmarks: * (JDK

[GitHub] [spark] SparkQA commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
SparkQA commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811729225 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41382/ -- This is an automated message from the

[GitHub] [spark] MaxGekk commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
MaxGekk commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811727039 > which case the path will be null and which case it can be __HIVE_DEFAULT_PARTITION__? The `null` partition value should be replaced to `__HIVE_DEFAULT_PARTITION__` if

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31941: [SPARK-34637][SQL] Improve the performance of AQE and DPP through logical optimization.

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31941: URL: https://github.com/apache/spark/pull/31941#issuecomment-811689970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    1   2   3   4   5   6   >