[GitHub] [spark] AngersZhuuuu commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811719759 What confused me is that ``` spark-sql> CREATE TABLE t(i STRING, c string) USING PARQUET PARTITIONED BY (c); Time taken: 2.12 seconds spark-sql> INSERT

[GitHub] [spark] SparkQA commented on pull request #31941: [SPARK-34637][SQL] Improve the performance of AQE and DPP through logical optimization.

2021-04-01 Thread GitBox
SparkQA commented on pull request #31941: URL: https://github.com/apache/spark/pull/31941#issuecomment-811719222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #31941: [SPARK-34637][SQL] Improve the performance of AQE and DPP through logical optimization.

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31941: URL: https://github.com/apache/spark/pull/31941#issuecomment-811719260 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41383/ --

[GitHub] [spark] SparkQA commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
SparkQA commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811719082 **[Test build #136802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136802/testReport)** for PR 31908 at commit

[GitHub] [spark] SparkQA commented on pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
SparkQA commented on pull request #32021: URL: https://github.com/apache/spark/pull/32021#issuecomment-811718956 **[Test build #136801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136801/testReport)** for PR 32021 at commit

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh edited a comment on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811718199 > I am not sure that it is right fix. I guess, `null` should be replaced by `"__HIVE_DEFAULT_PARTITION__"` like: > >

[GitHub] [spark] AngersZhuuuu commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AngersZh commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811718199 > I am not sure that it is right fix. I guess, `null` should be replaced by `"__HIVE_DEFAULT_PARTITION__"` like: > >

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-04-01 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-811717497 **[Test build #136800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136800/testReport)** for PR 31204 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811716911 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41377/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811716908 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136787/

[GitHub] [spark] AmplabJenkins commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811716908 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136787/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811716911 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41377/ --

[GitHub] [spark] wangyum commented on pull request #31908: [SPARK-34808][SQL] Removes outer join if it only has DISTINCT on streamed side

2021-04-01 Thread GitBox
wangyum commented on pull request #31908: URL: https://github.com/apache/spark/pull/31908#issuecomment-811713982 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] HyukjinKwon closed pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
HyukjinKwon closed pull request #32010: URL: https://github.com/apache/spark/pull/32010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] HyukjinKwon commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
HyukjinKwon commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811710229 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] MaxGekk closed pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

2021-04-01 Thread GitBox
MaxGekk closed pull request #32016: URL: https://github.com/apache/spark/pull/32016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] MaxGekk commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

2021-04-01 Thread GitBox
MaxGekk commented on pull request #32016: URL: https://github.com/apache/spark/pull/32016#issuecomment-811706658 Merging to master. Failed GAs are not related to changes. Thank you @yaooqinn @cloud-fan for your review. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon opened a new pull request #32021: [WIP][SPARK-34931][INFRA] Recover lint-r job in GitHub Actions workflow

2021-04-01 Thread GitBox
HyukjinKwon opened a new pull request #32021: URL: https://github.com/apache/spark/pull/32021 ### What changes were proposed in this pull request? TBD ### Why are the changes needed? TBD ### Does this PR introduce _any_ user-facing change? TBD ###

[GitHub] [spark] sadhen commented on a change in pull request #31735: [SPARK-34799][PYTHON][SQL] Return User-defined types from Pandas UDF

2021-04-01 Thread GitBox
sadhen commented on a change in pull request #31735: URL: https://github.com/apache/spark/pull/31735#discussion_r605425007 ## File path: python/pyspark/sql/pandas/serializers.py ## @@ -183,30 +193,62 @@ def create_array(s, t): raise e return

[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
SparkQA commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811697938 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41377/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
SparkQA commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811697091 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41382/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811597991 **[Test build #136787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136787/testReport)** for PR 32018 at commit

[GitHub] [spark] SparkQA commented on pull request #32018: [SPARK-34926][SQL] ExternalCatalogUtils.escapePathName should support null

2021-04-01 Thread GitBox
SparkQA commented on pull request #32018: URL: https://github.com/apache/spark/pull/32018#issuecomment-811696620 **[Test build #136787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136787/testReport)** for PR 32018 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29851: [WIP][SPARK-22674][PYTHON] Removed namedtuple hack and made cloudpickle the default serializer

2021-04-01 Thread GitBox
HyukjinKwon commented on pull request #29851: URL: https://github.com/apache/spark/pull/29851#issuecomment-811696358 Hey, yeah we should remove this away since cloudpickle is now backed by C-pickle (Python 3.8+) which is as fast as the regular pickle. I think we can switch to use

[GitHub] [spark] cloud-fan commented on a change in pull request #31653: [SPARK-33832][SQL] v2. move OptimzieSkewedJoin to query stage preparation

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #31653: URL: https://github.com/apache/spark/pull/31653#discussion_r605420767 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala ## @@ -251,48 +253,129 @@ object

[GitHub] [spark] hauntsaninja commented on pull request #29851: [WIP][SPARK-22674][PYTHON] Removed namedtuple hack and made cloudpickle the default serializer

2021-04-01 Thread GitBox
hauntsaninja commented on pull request #29851: URL: https://github.com/apache/spark/pull/29851#issuecomment-811693712 Hello! I recently got bitten by the monkeypatching of namedtuple. Anything I can do to help move this along? :-) -- This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan closed pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
cloud-fan closed pull request #32012: URL: https://github.com/apache/spark/pull/32012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] cloud-fan commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
cloud-fan commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811692808 The GA failure seems unrelated, I'm merging it to master, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
SparkQA commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811691474 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41381/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811691491 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41381/

[GitHub] [spark] AmplabJenkins commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811691491 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41381/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811690140 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41380/

[GitHub] [spark] AmplabJenkins commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811690140 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41380/ --

[GitHub] [spark] SparkQA commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811690111 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41380/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #31941: [SPARK-34637][SQL] Improve the performance of AQE and DPP through logical optimization.

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31941: URL: https://github.com/apache/spark/pull/31941#issuecomment-811689970 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] sadhen commented on a change in pull request #31735: [SPARK-34799][PYTHON][SQL] Return User-defined types from Pandas UDF

2021-04-01 Thread GitBox
sadhen commented on a change in pull request #31735: URL: https://github.com/apache/spark/pull/31735#discussion_r605415479 ## File path: python/pyspark/sql/tests/test_pandas_udf_scalar.py ## @@ -1109,6 +1109,99 @@ def f3i(it): self.assertEqual(expected,

[GitHub] [spark] gengliangwang closed pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
gengliangwang closed pull request #32019: URL: https://github.com/apache/spark/pull/32019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] gengliangwang commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
gengliangwang commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811687636 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
SparkQA commented on pull request #32019: URL: https://github.com/apache/spark/pull/32019#issuecomment-811687524 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41380/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
SparkQA commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811687254 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41381/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #31451: [SPARK-34338][SQL] Report metrics from Datasource v2 scan

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #31451: URL: https://github.com/apache/spark/pull/31451#discussion_r605413557 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/PartitionReader.java ## @@ -51,7 +51,8 @@ T get(); /** - *

[GitHub] [spark] SparkQA commented on pull request #32014: [SPARK-34922][SQL] Use a relative cost comparison function in the CBO

2021-04-01 Thread GitBox
SparkQA commented on pull request #32014: URL: https://github.com/apache/spark/pull/32014#issuecomment-811686050 **[Test build #136799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136799/testReport)** for PR 32014 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811685523 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41378/

[GitHub] [spark] SparkQA commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
SparkQA commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811685983 **[Test build #136798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136798/testReport)** for PR 32020 at commit

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811685509 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41378/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811685523 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41378/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811685409 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41379/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811685410 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136786/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811685412 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136789/

[GitHub] [spark] AmplabJenkins commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811685410 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136786/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811685412 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136789/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
AmplabJenkins commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811685409 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41379/ --

[GitHub] [spark] viirya commented on a change in pull request #30965: [SPARK-33935][SQL] Fix CBO cost function

2021-04-01 Thread GitBox
viirya commented on a change in pull request #30965: URL: https://github.com/apache/spark/pull/30965#discussion_r605407491 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q19.sf100/simplified.txt ## @@ -6,71 +6,71 @@ TakeOrderedAndProject

[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions

2021-04-01 Thread GitBox
SparkQA commented on pull request #32010: URL: https://github.com/apache/spark/pull/32010#issuecomment-811682724 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41377/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

2021-04-01 Thread GitBox
SparkQA commented on pull request #32017: URL: https://github.com/apache/spark/pull/32017#issuecomment-811681919 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41379/ --

[GitHub] [spark] SparkQA commented on pull request #31179: [SPARK-34113][SQL] Use metric data update metadata statistic's size and rowCount

2021-04-01 Thread GitBox
SparkQA commented on pull request #31179: URL: https://github.com/apache/spark/pull/31179#issuecomment-811681712 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41378/ -- This is an automated message from the Apache

[GitHub] [spark] viirya commented on pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
viirya commented on pull request #32020: URL: https://github.com/apache/spark/pull/32020#issuecomment-811680562 cc @HyukjinKwon @cloud-fan @tanelk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] viirya commented on a change in pull request #30965: [SPARK-33935][SQL] Fix CBO cost function

2021-04-01 Thread GitBox
viirya commented on a change in pull request #30965: URL: https://github.com/apache/spark/pull/30965#discussion_r605407491 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q19.sf100/simplified.txt ## @@ -6,71 +6,71 @@ TakeOrderedAndProject

[GitHub] [spark] viirya opened a new pull request #32020: Revert "[SPARK-33935][SQL][2.4] Fix CBO cost function"

2021-04-01 Thread GitBox
viirya opened a new pull request #32020: URL: https://github.com/apache/spark/pull/32020 This reverts commit 3e6a6b76ef1b25f80133e6cb8561ba943f3b29de. ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does

[GitHub] [spark] SparkQA removed a comment on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811617005 **[Test build #136789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136789/testReport)** for PR 32015 at commit

[GitHub] [spark] SparkQA commented on pull request #32015: [SPARK-34821][INFRA] Set up a workflow for developers to run benchmark in their fork

2021-04-01 Thread GitBox
SparkQA commented on pull request #32015: URL: https://github.com/apache/spark/pull/32015#issuecomment-811675412 **[Test build #136789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136789/testReport)** for PR 32015 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
SparkQA removed a comment on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811578298 **[Test build #136786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136786/testReport)** for PR 32012 at commit

[GitHub] [spark] SparkQA commented on pull request #32012: [SPARK-34919][SQL] Change partitioning to SinglePartition if partition number is 1

2021-04-01 Thread GitBox
SparkQA commented on pull request #32012: URL: https://github.com/apache/spark/pull/32012#issuecomment-811673632 **[Test build #136786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136786/testReport)** for PR 32012 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30965: [SPARK-33935][SQL] Fix CBO cost function

2021-04-01 Thread GitBox
cloud-fan commented on a change in pull request #30965: URL: https://github.com/apache/spark/pull/30965#discussion_r605399463 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q19.sf100/simplified.txt ## @@ -6,71 +6,71 @@ TakeOrderedAndProject

[GitHub] [spark] viirya commented on a change in pull request #30965: [SPARK-33935][SQL] Fix CBO cost function

2021-04-01 Thread GitBox
viirya commented on a change in pull request #30965: URL: https://github.com/apache/spark/pull/30965#discussion_r605399096 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q19.sf100/simplified.txt ## @@ -6,71 +6,71 @@ TakeOrderedAndProject

[GitHub] [spark] AngersZhuuuu commented on pull request #31992: [SPARK-34898][CORE] We should send SparkListenerExecutorMetricsUpdateEventLog of `driver` appropriately

2021-04-01 Thread GitBox
AngersZh commented on pull request #31992: URL: https://github.com/apache/spark/pull/31992#issuecomment-811668969 ping @mridulm Any more update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32019: [SPARK-34881][SQL][FOLLOW-UP] Use multiline string for TryCast' expression description

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #32019: URL: https://github.com/apache/spark/pull/32019#discussion_r605393073 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryCast.scala ## @@ -30,10 +30,12 @@ import

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30965: [SPARK-33935][SQL] Fix CBO cost function

2021-04-01 Thread GitBox
HyukjinKwon commented on a change in pull request #30965: URL: https://github.com/apache/spark/pull/30965#discussion_r605396265 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q19.sf100/simplified.txt ## @@ -6,71 +6,71 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31989: [SPARK-34891][SS] Introduce state store manager for session window in streaming query

2021-04-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31989: URL: https://github.com/apache/spark/pull/31989#issuecomment-811665311 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41375/

<    1   2   3   4   5   6