[GitHub] [spark] SparkQA removed a comment on pull request #31666: [SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #31666: URL: https://github.com/apache/spark/pull/31666#issuecomment-814553582 **[Test build #136979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136979/testReport)** for PR 31666 at commit [`f665030`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814630929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32059: [SPARK-34963][SQL] Fix nested column pruning for extracting case-insensitive struct field from array of struct

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #32059: URL: https://github.com/apache/spark/pull/32059#issuecomment-814571064 **[Test build #136983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136983/testReport)** for PR 32059 at commit [`15bdcd6`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814568115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32074: [SPARK-34977][SQL] LIST FILES/JARS/ARCHIVES cannot handle multiple arguments properly when at least one path is quoted

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #32074: URL: https://github.com/apache/spark/pull/32074#issuecomment-814630805 **[Test build #136998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136998/testReport)** for PR 32074 at commit [`c5a6345`](https://gi

[GitHub] [spark] gengliangwang commented on a change in pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
gengliangwang commented on a change in pull request #32060: URL: https://github.com/apache/spark/pull/32060#discussion_r608387726 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeInSuite.scala ## @@ -169,24 +169,33 @@ class OptimizeInSu

[GitHub] [spark] SparkQA commented on pull request #31666: [SPARK-34527][SQL] Resolve duplicated common columns from USING/NATURAL JOIN

2021-04-06 Thread GitBox
SparkQA commented on pull request #31666: URL: https://github.com/apache/spark/pull/31666#issuecomment-814655701 **[Test build #136979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136979/testReport)** for PR 31666 at commit [`f665030`](https://github.co

[GitHub] [spark] gengliangwang commented on a change in pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
gengliangwang commented on a change in pull request #32060: URL: https://github.com/apache/spark/pull/32060#discussion_r608386417 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Ap

[GitHub] [spark] SparkQA commented on pull request #32059: [SPARK-34963][SQL] Fix nested column pruning for extracting case-insensitive struct field from array of struct

2021-04-06 Thread GitBox
SparkQA commented on pull request #32059: URL: https://github.com/apache/spark/pull/32059#issuecomment-814654543 **[Test build #136983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136983/testReport)** for PR 32059 at commit [`15bdcd6`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
SparkQA commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814654514 **[Test build #136985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136985/testReport)** for PR 32060 at commit [`0b8de69`](https://github.co

[GitHub] [spark] grarkydev opened a new pull request #32077: [SPARK-33357][Kubernetes] Support Spark application managing with SparkAppHandle on Kubernetes

2021-04-06 Thread GitBox
grarkydev opened a new pull request #32077: URL: https://github.com/apache/spark/pull/32077 ### What changes were proposed in this pull request? Supporting `SparkAppHandle` object to be able to manage a running Spark application on Kubernetes. It can be used to monitor the application ch

[GitHub] [spark] gengliangwang commented on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
gengliangwang commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814653571 Overall LGTM. This is an amazing framework! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [spark] gengliangwang commented on a change in pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
gengliangwang commented on a change in pull request #32060: URL: https://github.com/apache/spark/pull/32060#discussion_r608384606 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Ap

[GitHub] [spark] gengliangwang commented on a change in pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
gengliangwang commented on a change in pull request #32060: URL: https://github.com/apache/spark/pull/32060#discussion_r608384606 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Ap

[GitHub] [spark] gengliangwang commented on a change in pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
gengliangwang commented on a change in pull request #32060: URL: https://github.com/apache/spark/pull/32060#discussion_r608359329 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -26,6 +26,7 @@ import org.apache.spark.

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814645200 **[Test build #137005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137005/testReport)** for PR 32053 at commit [`c5a6c10`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
SparkQA commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814643917 **[Test build #136980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136980/testReport)** for PR 32060 at commit [`cc0c629`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32074: [SPARK-34977][SQL] LIST FILES/JARS/ARCHIVES cannot handle multiple arguments properly when at least one path is quoted

2021-04-06 Thread GitBox
SparkQA commented on pull request #32074: URL: https://github.com/apache/spark/pull/32074#issuecomment-814643086 **[Test build #136998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136998/testReport)** for PR 32074 at commit [`c5a6345`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31974: [SPARK-34877][CORE][YARN]Add the code change for adding the Spark AM log link in spark UI

2021-04-06 Thread GitBox
SparkQA commented on pull request #31974: URL: https://github.com/apache/spark/pull/31974#issuecomment-814642447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] MaxGekk commented on a change in pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
MaxGekk commented on a change in pull request #32053: URL: https://github.com/apache/spark/pull/32053#discussion_r608374307 ## File path: examples/src/main/scala/org/apache/spark/examples/sql/SQLDataSourceExample.scala ## @@ -309,6 +310,53 @@ object SQLDataSourceExample {

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814641239 **[Test build #137000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137000/testReport)** for PR 32053 at commit [`4256bfa`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814640898 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41572/ -- T

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814640853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] MaxGekk commented on a change in pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
MaxGekk commented on a change in pull request #32053: URL: https://github.com/apache/spark/pull/32053#discussion_r608371924 ## File path: docs/sql-data-sources-text.md ## @@ -0,0 +1,40 @@ +--- +layout: global +title: Text Files +displayTitle: Text Files +license: | + Licensed

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608371608 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,36 @@ class Analyzer(override v

[GitHub] [spark] MaxGekk commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
MaxGekk commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814638077 @itholic Could update PR's description and make new screenshot. Currently, it doesn't match to text, for instance it doesn't contain "When reading a text file, each line becomes

[GitHub] [spark] SparkQA commented on pull request #32075: [SPARK-34922][SQL][3.1] Use a relative cost comparison function in the CBO

2021-04-06 Thread GitBox
SparkQA commented on pull request #32075: URL: https://github.com/apache/spark/pull/32075#issuecomment-814637629 **[Test build #137008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137008/testReport)** for PR 32075 at commit [`051e091`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32076: [SPARK-34922][SQL][3.0] Use a relative cost comparison function in the CBO

2021-04-06 Thread GitBox
SparkQA commented on pull request #32076: URL: https://github.com/apache/spark/pull/32076#issuecomment-814637577 **[Test build #137007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137007/testReport)** for PR 32076 at commit [`a5b33bd`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #32061: [WIP][SPARK-32833][SQL] JDBC V2 Datasource aggregate push down

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32061: URL: https://github.com/apache/spark/pull/32061#issuecomment-814636967 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41568/ -- T

[GitHub] [spark] SparkQA commented on pull request #32061: [WIP][SPARK-32833][SQL] JDBC V2 Datasource aggregate push down

2021-04-06 Thread GitBox
SparkQA commented on pull request #32061: URL: https://github.com/apache/spark/pull/32061#issuecomment-814636925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] tanelk opened a new pull request #32076: [SPARK-34922][SQL][3.0] Use a relative cost comparison function in the CBO

2021-04-06 Thread GitBox
tanelk opened a new pull request #32076: URL: https://github.com/apache/spark/pull/32076 ### What changes were proposed in this pull request? Changed the cost comparison function of the CBO to use the ratios of row counts and sizes in bytes. ### Why are the changes nee

[GitHub] [spark] tanelk opened a new pull request #32075: [SPARK-34922][SQL][3.1] Use a relative cost comparison function in the CBO

2021-04-06 Thread GitBox
tanelk opened a new pull request #32075: URL: https://github.com/apache/spark/pull/32075 ### What changes were proposed in this pull request? Changed the cost comparison function of the CBO to use the ratios of row counts and sizes in bytes. ### Why are the changes nee

[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command

2021-04-06 Thread GitBox
SparkQA commented on pull request #31548: URL: https://github.com/apache/spark/pull/31548#issuecomment-814636104 **[Test build #137006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137006/testReport)** for PR 31548 at commit [`add16cb`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AngersZh commented on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814635381 > @AngersZh please describe why we should rename. The change look incomplete and I can't follow why we should rename. Done -- This is an automated message from

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608367608 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -26,7 +26,7 @@ import org.apache.spark.sql.

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814634141 **[Test build #137005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137005/testReport)** for PR 32053 at commit [`c5a6c10`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
SparkQA commented on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814634059 **[Test build #137004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137004/testReport)** for PR 32073 at commit [`3eb088f`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
AmplabJenkins removed a comment on pull request #32032: URL: https://github.com/apache/spark/pull/32032#issuecomment-814632132 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41569/

[GitHub] [spark] SparkQA commented on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
SparkQA commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814632546 **[Test build #137003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137003/testReport)** for PR 32060 at commit [`082f8af`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32032: URL: https://github.com/apache/spark/pull/32032#issuecomment-814632132 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41569/ -- T

[GitHub] [spark] sarutak commented on a change in pull request #32074: [SPARK-34977][SQL] LIST FILES/JARS/ARCHIVES cannot handle multiple arguments properly when at least one path is quoted

2021-04-06 Thread GitBox
sarutak commented on a change in pull request #32074: URL: https://github.com/apache/spark/pull/32074#discussion_r608354674 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -952,6 +952,72 @@ class HiveQuerySuite extends HiveC

[GitHub] [spark] SparkQA commented on pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
SparkQA commented on pull request #32032: URL: https://github.com/apache/spark/pull/32032#issuecomment-814632105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] itholic commented on a change in pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
itholic commented on a change in pull request #32053: URL: https://github.com/apache/spark/pull/32053#discussion_r608365419 ## File path: docs/sql-data-sources-text.md ## @@ -0,0 +1,40 @@ +--- +layout: global +title: Text Files +displayTitle: Text Files +license: | + Licensed

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608365384 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -26,7 +26,7 @@ import org.apache.spark.sql.

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608365069 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -145,7 +148,7 @@ object GroupingSets { d

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-814631379 **[Test build #137002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137002/testReport)** for PR 30145 at commit [`5cfae7a`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608364894 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -106,34 +106,37 @@ object GroupingSet {

[GitHub] [spark] imback82 commented on a change in pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
imback82 commented on a change in pull request #32032: URL: https://github.com/apache/spark/pull/32032#discussion_r608364601 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Command.scala ## @@ -37,3 +38,35 @@ trait Command extends LogicalP

[GitHub] [spark] SparkQA commented on pull request #32037: [SPARK-34944][SQL][TESTS] Employ correct data type for web_returns and store_returns in TPCDS tests

2021-04-06 Thread GitBox
SparkQA commented on pull request #32037: URL: https://github.com/apache/spark/pull/32037#issuecomment-814630940 **[Test build #137001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137001/testReport)** for PR 32037 at commit [`44a09c7`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814630929 **[Test build #137000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137000/testReport)** for PR 32053 at commit [`4256bfa`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
SparkQA commented on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814630837 **[Test build #136999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136999/testReport)** for PR 32073 at commit [`2995aee`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32074: [SPARK-34977][SQL] LIST FILES/JARS/ARCHIVES cannot handle multiple arguments properly when at least one path is quoted

2021-04-06 Thread GitBox
SparkQA commented on pull request #32074: URL: https://github.com/apache/spark/pull/32074#issuecomment-814630805 **[Test build #136998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136998/testReport)** for PR 32074 at commit [`c5a6345`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
AmplabJenkins removed a comment on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814630319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
AmplabJenkins removed a comment on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814630324 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41564/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AmplabJenkins removed a comment on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-814630318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-814630320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins commented on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814630324 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41564/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814630319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] cloud-fan commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608363378 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,36 @@ class Analyzer(override val

[GitHub] [spark] baohe-zhang commented on pull request #31871: [SPARK-34779][CORE] ExecutorMetricsPoller should keep stage entry in stageTCMP until a heartbeat occurs

2021-04-06 Thread GitBox
baohe-zhang commented on pull request #31871: URL: https://github.com/apache/spark/pull/31871#issuecomment-814627595 Yeah, it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [spark] cloud-fan commented on a change in pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #32032: URL: https://github.com/apache/spark/pull/32032#discussion_r608361130 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Command.scala ## @@ -37,3 +38,35 @@ trait Command extends Logical

[GitHub] [spark] cloud-fan commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608360273 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -26,7 +26,7 @@ import org.apache.spark.sql.typ

[GitHub] [spark] HyukjinKwon commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
HyukjinKwon commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814624945 Looks pretty good otherwise. Make sure updating PR description up to date. I will leave it to @srowen, @MaxGekk and @maropu since they are reviewing this. -- This is an au

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32053: URL: https://github.com/apache/spark/pull/32053#discussion_r608359236 ## File path: docs/sql-data-sources-text.md ## @@ -0,0 +1,40 @@ +--- +layout: global +title: Text Files +displayTitle: Text Files +license: | + Licen

[GitHub] [spark] itholic commented on a change in pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
itholic commented on a change in pull request #32053: URL: https://github.com/apache/spark/pull/32053#discussion_r608358810 ## File path: docs/sql-data-sources.md ## @@ -47,6 +47,7 @@ goes into specific options that are available for the built-in data sources. * [ORC Files](s

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32053: URL: https://github.com/apache/spark/pull/32053#discussion_r608358436 ## File path: docs/sql-data-sources.md ## @@ -47,6 +47,7 @@ goes into specific options that are available for the built-in data sources. * [ORC File

[GitHub] [spark] sigmod commented on pull request #32060: [SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
sigmod commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814622504 @dbaliafroozeh @hvanhovell @maryannxue @gengliangwang: this PR is ready for review. Let me know if you have any questions. Thanks! -- This is an automated message from the Apac

[GitHub] [spark] cloud-fan closed pull request #31791: [SPARK-34678][SQL] Add table function registry

2021-04-06 Thread GitBox
cloud-fan closed pull request #31791: URL: https://github.com/apache/spark/pull/31791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [spark] cloud-fan commented on pull request #31791: [SPARK-34678][SQL] Add table function registry

2021-04-06 Thread GitBox
cloud-fan commented on pull request #31791: URL: https://github.com/apache/spark/pull/31791#issuecomment-814620919 The Github Action failures are unrelated and the jenkins passes, I'm merging it to master, thanks! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814620180 **[Test build #136997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136997/testReport)** for PR 32053 at commit [`0415cd8`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814610651 **[Test build #136997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136997/testReport)** for PR 32053 at commit [`0415cd8`](https://gi

[GitHub] [spark] HyukjinKwon commented on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
HyukjinKwon commented on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814619990 @AngersZh please describe why we should rename. The change look incomplete and I can't follow why we should rename. -- This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608355354 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -26,7 +26,7 @@ import org.apache.spark.sql.t

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608354977 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -26,7 +26,7 @@ import org.apache.spark.sql.t

[GitHub] [spark] sarutak commented on a change in pull request #32074: [SPARK-34977][SQL] LIST FILES/JARS/ARCHIVES cannot handle multiple arguments properly when at least one path is quoted

2021-04-06 Thread GitBox
sarutak commented on a change in pull request #32074: URL: https://github.com/apache/spark/pull/32074#discussion_r608354674 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -952,6 +952,72 @@ class HiveQuerySuite extends HiveC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608354526 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -106,34 +106,37 @@ object GroupingSet { }

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608354425 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -145,7 +148,7 @@ object GroupingSets { de

[GitHub] [spark] imback82 commented on a change in pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
imback82 commented on a change in pull request #32032: URL: https://github.com/apache/spark/pull/32032#discussion_r608354169 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Command.scala ## @@ -37,3 +38,35 @@ trait Command extends LogicalP

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
HyukjinKwon commented on a change in pull request #32073: URL: https://github.com/apache/spark/pull/32073#discussion_r608354243 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -106,34 +106,37 @@ object GroupingSet { }

[GitHub] [spark] SparkQA commented on pull request #32060: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
SparkQA commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814617613 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41564/ -- This is an automated message from the A

[GitHub] [spark] sarutak opened a new pull request #32074: [SPARK-34977][SQL] LIST FILES/JARS/ARCHIVES cannot handle multiple arguments properly when at least one path is quoted

2021-04-06 Thread GitBox
sarutak opened a new pull request #32074: URL: https://github.com/apache/spark/pull/32074 ### What changes were proposed in this pull request? This PR fixes an issue that `LIST {FILES/JARS/ARCHIVES} path1, path2, ...` cannot list all paths if at least one path is quoted. An exampl

[GitHub] [spark] SparkQA removed a comment on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814609011 **[Test build #136995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136995/testReport)** for PR 32053 at commit [`f6198b7`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32053: [SPARK-34493][DOCS] Add "TEXT Files" page for Data Source documents

2021-04-06 Thread GitBox
SparkQA commented on pull request #32053: URL: https://github.com/apache/spark/pull/32053#issuecomment-814617263 **[Test build #136995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136995/testReport)** for PR 32053 at commit [`f6198b7`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #31791: [SPARK-34678][SQL] Add table function registry

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #31791: URL: https://github.com/apache/spark/pull/31791#discussion_r608353136 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -83,15 +85,94 @@ trait FunctionRegistry {

[GitHub] [spark] cloud-fan commented on a change in pull request #32054: [SPARK-34946][SQL] Block unsupported correlated scalar subquery in Aggregate

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #32054: URL: https://github.com/apache/spark/pull/32054#discussion_r608352820 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala ## @@ -1765,4 +1765,35 @@ class SubquerySuite extends QueryTest with Sha

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352704 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -598,8 +598,8 @@ class Analyzer(override val c

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352609 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,41 @@ class Analyzer(override v

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352564 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,41 @@ class Analyzer(override v

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352335 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -144,12 +147,12 @@ case class GroupingSets(

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-814615642 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41571/ -- This

[GitHub] [spark] SparkQA commented on pull request #32060: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the transform family for early stopping

2021-04-06 Thread GitBox
SparkQA commented on pull request #32060: URL: https://github.com/apache/spark/pull/32060#issuecomment-814615001 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41564/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
SparkQA removed a comment on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-814609505 **[Test build #136996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136996/testReport)** for PR 30145 at commit [`ff6794e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

2021-04-06 Thread GitBox
SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-814612779 **[Test build #136996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136996/testReport)** for PR 30145 at commit [`ff6794e`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #32066: [SPARK-34970][SQL][SERCURITY] Redact map-type options in the output of explain()

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32066: URL: https://github.com/apache/spark/pull/32066#issuecomment-814612482 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41563/ -- T

[GitHub] [spark] SparkQA commented on pull request #32066: [SPARK-34970][SQL][SERCURITY] Redact map-type options in the output of explain()

2021-04-06 Thread GitBox
SparkQA commented on pull request #32066: URL: https://github.com/apache/spark/pull/32066#issuecomment-814612454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] cloud-fan commented on a change in pull request #32070: [SPARK-34668][SQL] Support casting of day-time intervals to strings

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #32070: URL: https://github.com/apache/spark/pull/32070#discussion_r608349143 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -818,6 +818,31 @@ abstract class CastSuiteBas

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AmplabJenkins removed a comment on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814611799 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41567/

[GitHub] [spark] SparkQA commented on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
SparkQA commented on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814611787 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41567/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32073: [SPARK-34976][SQL] Rename GroupingSet to GroupingAnalytic

2021-04-06 Thread GitBox
AmplabJenkins commented on pull request #32073: URL: https://github.com/apache/spark/pull/32073#issuecomment-814611799 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41567/ -- T

[GitHub] [spark] cloud-fan commented on a change in pull request #32032: [SPARK-34701][SQL] Introduce AnalysisOnlyCommand that allows its children to be removed once the command is marked as analyzed.

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #32032: URL: https://github.com/apache/spark/pull/32032#discussion_r608348517 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Command.scala ## @@ -37,3 +38,35 @@ trait Command extends Logical

  1   2   3   4   5   6   7   8   >