[GitHub] [spark] AmplabJenkins commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839571721 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42959/ -- T

[GitHub] [spark] yaooqinn commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r630826789 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -894,7 +894,7 @@ object SparkSession extends Logging { *

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839569781 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42956/ -- This is an automated message from the Apache

[GitHub] [spark] maropu commented on a change in pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
maropu commented on a change in pull request #32482: URL: https://github.com/apache/spark/pull/32482#discussion_r630805446 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1090,6 +1090,17 @@ object SQLConf { .booleanConf

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839569207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] SparkQA commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
SparkQA commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839568788 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42960/ -- This

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r630821525 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache So

[GitHub] [spark] SparkQA removed a comment on pull request #32506: [SPARK-35374][SQL] Add string-to-number conversion support to JacksonParser

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32506: URL: https://github.com/apache/spark/pull/32506#issuecomment-839403661 **[Test build #138418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138418/testReport)** for PR 32506 at commit [`4cf72e8`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32506: [SPARK-35374][SQL] Add string-to-number conversion support to JacksonParser

2021-05-12 Thread GitBox
SparkQA commented on pull request #32506: URL: https://github.com/apache/spark/pull/32506#issuecomment-839559042 **[Test build #138418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138418/testReport)** for PR 32506 at commit [`4cf72e8`](https://github.co

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
HyukjinKwon commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r630815881 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -894,7 +894,7 @@ object SparkSession extends Logging { *

[GitHub] [spark] HeartSaVioR commented on pull request #32433: [SPARK-35311][SS][UI][DOCS] Structured Streaming Web UI state information documentation

2021-05-12 Thread GitBox
HeartSaVioR commented on pull request #32433: URL: https://github.com/apache/spark/pull/32433#issuecomment-839555989 Thanks for the update! Looks great. @viirya Could you please go through the next round of reviews? If there's no additional feedback I'll merge this at the end of the

[GitHub] [spark] gaborgsomogyi commented on pull request #32433: [SPARK-35311][SS][UI][DOCS] Structured Streaming Web UI state information documentation

2021-05-12 Thread GitBox
gaborgsomogyi commented on pull request #32433: URL: https://github.com/apache/spark/pull/32433#issuecomment-839554452 The alternative was to zoom out in the screen but then the UI was super tiny, hard to read and just ugly. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] gaborgsomogyi commented on pull request #32433: [SPARK-35311][SS][UI][DOCS] Structured Streaming Web UI state information documentation

2021-05-12 Thread GitBox
gaborgsomogyi commented on pull request #32433: URL: https://github.com/apache/spark/pull/32433#issuecomment-839551950 @HeartSaVioR @viirya till now I was fighting to make a screenshot from the whole UI part but I don't have such big screen so I've added an additional image where the rest

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839550680 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42955/ -- This

[GitHub] [spark] HyukjinKwon commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32517: URL: https://github.com/apache/spark/pull/32517#issuecomment-839549861 Merged to master and branch-3.1! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] HyukjinKwon closed pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
HyukjinKwon closed pull request #32517: URL: https://github.com/apache/spark/pull/32517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [spark] beliefer commented on pull request #32513: [SPARK-35378][SQL] Convert LeafRunnableCommand to LocalRelation when query with CTE

2021-05-12 Thread GitBox
beliefer commented on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-839547899 ping @cloud-fan @wangyum @maropu @viirya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] HyukjinKwon commented on pull request #32483: [SPARK-35355][SQL] In the case of insert with limit, improve execution performance

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32483: URL: https://github.com/apache/spark/pull/32483#issuecomment-839546746 The tests failed. can you fix the test failures https://github.com/yikf/spark/runs/2547699446?check_suite_focus=true? Also you might have to provide some numbers with benchm

[GitHub] [spark] SparkQA removed a comment on pull request #32513: [SPARK-35378][SQL] Convert LeafRunnableCommand to LocalRelation when query with CTE

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-839403607 **[Test build #138416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138416/testReport)** for PR 32513 at commit [`40cea6b`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32513: [SPARK-35378][SQL] Convert LeafRunnableCommand to LocalRelation when query with CTE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32513: URL: https://github.com/apache/spark/pull/32513#issuecomment-839545178 **[Test build #138416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138416/testReport)** for PR 32513 at commit [`40cea6b`](https://github.co

[GitHub] [spark] HyukjinKwon commented on pull request #32468: [SPARK-35335][SQL] Improve CoalesceShufflePartitions to avoid generating small files

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32468: URL: https://github.com/apache/spark/pull/32468#issuecomment-839544452 cc @maryannxue FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [spark] SparkQA commented on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
SparkQA commented on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839540813 **[Test build #138442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138442/testReport)** for PR 32503 at commit [`d35f9a6`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
cloud-fan commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839540450 ah, somehow I misremember this. Anyway it's better to throw exception manually with an explicit exception type. -- This is an automated message from the Apache Git Service.

[GitHub] [spark] maropu commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-12 Thread GitBox
maropu commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r630797948 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -88,9 +88,18 @@ object U

[GitHub] [spark] SparkQA removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839530512 **[Test build #138434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138434/testReport)** for PR 32515 at commit [`4e84a6f`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32031: [WIP] Initial work of Remote Shuffle Service on Kubernetes

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32031: URL: https://github.com/apache/spark/pull/32031#issuecomment-839533740 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42953/

[GitHub] [spark] viirya commented on a change in pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
viirya commented on a change in pull request #32519: URL: https://github.com/apache/spark/pull/32519#discussion_r630797150 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -151,7 +151,7 @@ trait InvokeLike extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839535887 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138434/ -

[GitHub] [spark] maropu commented on a change in pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
maropu commented on a change in pull request #32519: URL: https://github.com/apache/spark/pull/32519#discussion_r630794492 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -151,7 +151,7 @@ trait InvokeLike extends

[GitHub] [spark] AmplabJenkins commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839535887 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138434/ -- This

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839535824 **[Test build #138434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138434/testReport)** for PR 32515 at commit [`4e84a6f`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839535644 **[Test build #138441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138441/testReport)** for PR 32478 at commit [`170aff2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32031: [WIP] Initial work of Remote Shuffle Service on Kubernetes

2021-05-12 Thread GitBox
SparkQA commented on pull request #32031: URL: https://github.com/apache/spark/pull/32031#issuecomment-839533691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] AmplabJenkins commented on pull request #32031: [WIP] Initial work of Remote Shuffle Service on Kubernetes

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32031: URL: https://github.com/apache/spark/pull/32031#issuecomment-839533740 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42953/ -- T

[GitHub] [spark] viirya commented on a change in pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
viirya commented on a change in pull request #32519: URL: https://github.com/apache/spark/pull/32519#discussion_r630791547 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -151,7 +151,7 @@ trait InvokeLike extends

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839533096 **[Test build #138440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138440/testReport)** for PR 32452 at commit [`ff94039`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839530602 **[Test build #138435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138435/testReport)** for PR 32478 at commit [`0df9e2f`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839531738 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138435/ -

[GitHub] [spark] viirya edited a comment on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
viirya edited a comment on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839531906 > I don't think this is true though .. it's just a short cut of `java.lang.RuntimeException`. Oh, yea, you're right. cc @cloud-fan ```scala package object

[GitHub] [spark] viirya commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
viirya commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839531906 > I don't think this is true though .. it's just a short cut of `java.lang.RuntimeException`. Oh, yea, you're right. ```scala package object sys { /** Throw

[GitHub] [spark] AmplabJenkins commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839531738 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138435/ -- This

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839531701 **[Test build #138435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138435/testReport)** for PR 32478 at commit [`0df9e2f`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
SparkQA commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839530771 **[Test build #138439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138439/testReport)** for PR 32439 at commit [`5027ebc`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839530690 **[Test build #138438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138438/testReport)** for PR 32452 at commit [`b455c8d`](https://github.com

[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839530699 cc @cloud-fan @MrPowers @HyukjinKwon @maropu thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [spark] SparkQA commented on pull request #32457: [SPARK-35329][SQL] Split generated switch code into pieces in ExpandExec

2021-05-12 Thread GitBox
SparkQA commented on pull request #32457: URL: https://github.com/apache/spark/pull/32457#issuecomment-839530666 **[Test build #138437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138437/testReport)** for PR 32457 at commit [`9e74ca6`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839530602 **[Test build #138435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138435/testReport)** for PR 32478 at commit [`0df9e2f`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
SparkQA commented on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839530616 **[Test build #138436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138436/testReport)** for PR 32476 at commit [`429edcc`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
SparkQA commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839530467 **[Test build #138433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138433/testReport)** for PR 32519 at commit [`1bcc512`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839530512 **[Test build #138434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138434/testReport)** for PR 32515 at commit [`4e84a6f`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32517: URL: https://github.com/apache/spark/pull/32517#issuecomment-839529065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839529064 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42951/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32512: [SPARK-35377][INFRA] Add JS linter to GA

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32512: URL: https://github.com/apache/spark/pull/32512#issuecomment-839529061 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138425/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32517: URL: https://github.com/apache/spark/pull/32517#issuecomment-839529206 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42952/ -- T

[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
SparkQA commented on pull request #32517: URL: https://github.com/apache/spark/pull/32517#issuecomment-839529172 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42952/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #32512: [SPARK-35377][INFRA] Add JS linter to GA

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32512: URL: https://github.com/apache/spark/pull/32512#issuecomment-839529061 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138425/ -- This

[GitHub] [spark] maropu commented on a change in pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
maropu commented on a change in pull request #32519: URL: https://github.com/apache/spark/pull/32519#discussion_r630787080 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -151,7 +151,7 @@ trait InvokeLike extends

[GitHub] [spark] AmplabJenkins commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32517: URL: https://github.com/apache/spark/pull/32517#issuecomment-839529065 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138431/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839529064 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42951/ -- T

[GitHub] [spark] c21 commented on a change in pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
c21 commented on a change in pull request #32476: URL: https://github.com/apache/spark/pull/32476#discussion_r630782343 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -431,6 +433,68 @@ case class SortMergeJoinExec(

[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs

2021-05-12 Thread GitBox
SparkQA commented on pull request #32517: URL: https://github.com/apache/spark/pull/32517#issuecomment-839525302 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42952/ -- This is an automated message from the Apache

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839522797 Thanks. Let me retrgger that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] HyukjinKwon edited a comment on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
HyukjinKwon edited a comment on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839522351 > sys.error which crashes the driver JVM. I don't think this is true though .. it's just a short cut of `java.lang.RuntimeException`. -- This is an automated

[GitHub] [spark] HyukjinKwon commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839522351 > sys.error which crashes the driver JVM. I don't think this is true though .. it's just a short cut of `java.lang.RuntimeException`. -- This is an automated message fr

[GitHub] [spark] SparkQA commented on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
SparkQA commented on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839521181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] HyukjinKwon commented on pull request #32514: [SPARK-35379][SQL]Improve InferFiltersFromConstraints rule performance when parsing spark sql

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32514: URL: https://github.com/apache/spark/pull/32514#issuecomment-839519921 Can you help reviews on #30894 since the PR is already open and in progress? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839519387 That's fixed in the upstream. Can you sync with the latest master branch of Apache Spark repo by rebasing/merging? -- This is an automated message from the Apache Git Serv

[GitHub] [spark] wankunde commented on pull request #32514: [SPARK-35379][SQL]Improve InferFiltersFromConstraints rule performance when parsing spark sql

2021-05-12 Thread GitBox
wankunde commented on pull request #32514: URL: https://github.com/apache/spark/pull/32514#issuecomment-839519209 It seems to be a duplicate of #30894 , which has not been merged. @tanelk @maropu @HyukjinKwon @gengliangwang -- This is an automated message from the Apache Git Serv

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839517711 Hi @HyukjinKwon All the tests are passing. Seems Linters, Licence job is failing. But that is unrelated to the PR. Is it a known failure? ![Screenshot 2021-05-12 at 12 30 0

[GitHub] [spark] HyukjinKwon closed pull request #32512: [SPARK-35377][INFRA] Add JS linter to GA

2021-05-12 Thread GitBox
HyukjinKwon closed pull request #32512: URL: https://github.com/apache/spark/pull/32512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [spark] HyukjinKwon commented on pull request #32512: [SPARK-35377][INFRA] Add JS linter to GA

2021-05-12 Thread GitBox
HyukjinKwon commented on pull request #32512: URL: https://github.com/apache/spark/pull/32512#issuecomment-839517205 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

<    3   4   5   6   7   8