[GitHub] [spark] c21 commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
c21 commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631610336 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -724,9 +749,32 @@ case class SortMergeJoinExec(

[GitHub] [spark] c21 commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
c21 commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631610541 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -424,8 +424,18 @@ case class SortMergeJoinExec(

[GitHub] [spark] c21 commented on pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
c21 commented on pull request #32528: URL: https://github.com/apache/spark/pull/32528#issuecomment-840363206 To ease for review, the change for all plan files is used by followed command: ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStabilitySuite" SPARK_GENE

[GitHub] [spark] dongjoon-hyun commented on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
dongjoon-hyun commented on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840363273 The Python module UT failure is SPARK-35392 and will be fixed in master branch via https://github.com/apache/spark/pull/32533 . -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
SparkQA commented on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840365448 **[Test build #138491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138491/testReport)** for PR 32531 at commit [`c6ce0b7`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840290823 **[Test build #138491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138491/testReport)** for PR 32531 at commit [`c6ce0b7`](https://gi

[GitHub] [spark] dongjoon-hyun commented on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
dongjoon-hyun commented on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840365894 Hi, @HyukjinKwon . Could you review this PR please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [spark] SparkQA commented on pull request #32532: [SPARK-35384][SQL][FOLLOWUP] Move `HashMap.get` out of `InvokeLike.invoke`

2021-05-13 Thread GitBox
SparkQA commented on pull request #32532: URL: https://github.com/apache/spark/pull/32532#issuecomment-840373603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] SparkQA commented on pull request #32533: [SPARK-35392][ML][PYTHON] Remove Flaky GMM Test in ml/clustering.py

2021-05-13 Thread GitBox
SparkQA commented on pull request #32533: URL: https://github.com/apache/spark/pull/32533#issuecomment-840373369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] cloud-fan commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631619359 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -679,60 +704,124 @@ case class SortMergeJoinEx

[GitHub] [spark] AmplabJenkins commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840374735 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138482/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840374732 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138491/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32532: [SPARK-35384][SQL][FOLLOWUP] Move `HashMap.get` out of `InvokeLike.invoke`

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32532: URL: https://github.com/apache/spark/pull/32532#issuecomment-840374733 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43019/ -- T

[GitHub] [spark] cloud-fan commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631620203 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -679,60 +704,124 @@ case class SortMergeJoinEx

[GitHub] [spark] AmplabJenkins commented on pull request #32533: [SPARK-35392][ML][PYTHON] Remove Flaky GMM Test in ml/clustering.py

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32533: URL: https://github.com/apache/spark/pull/32533#issuecomment-840374731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32533: [SPARK-35392][ML][PYTHON] Remove Flaky GMM Test in ml/clustering.py

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32533: URL: https://github.com/apache/spark/pull/32533#issuecomment-840374731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32532: [SPARK-35384][SQL][FOLLOWUP] Move `HashMap.get` out of `InvokeLike.invoke`

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32532: URL: https://github.com/apache/spark/pull/32532#issuecomment-840374733 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43019/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840374732 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138491/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840374735 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138482/ -

[GitHub] [spark] cloud-fan commented on pull request #32411: [SPARK-28551][SQL] CTAS with LOCATION should not allow to a non-empty directory.

2021-05-13 Thread GitBox
cloud-fan commented on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-840376552 The new behavior makes sense to me. I'm wondering what shall we do for data source tables. e.g. ``` CREATE TABLE t USING jdbc OPTIONS (... dbtable="foo") AS SELECT ...

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840376956 **[Test build #138501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138501/testReport)** for PR 32478 at commit [`4509cbb`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
SparkQA commented on pull request #32528: URL: https://github.com/apache/spark/pull/32528#issuecomment-840376871 **[Test build #138500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138500/testReport)** for PR 32528 at commit [`979c759`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-13 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-840377216 **[Test build #138502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138502/testReport)** for PR 32292 at commit [`91bdc4c`](https://github.com

[GitHub] [spark] vinodkc commented on a change in pull request #32411: [SPARK-28551][SQL] CTAS with LOCATION should not allow to a non-empty directory.

2021-05-13 Thread GitBox
vinodkc commented on a change in pull request #32411: URL: https://github.com/apache/spark/pull/32411#discussion_r631622569 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala ## @@ -96,4 +98,23 @@ object DataWritingCommand {

[GitHub] [spark] cloud-fan commented on a change in pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32496: URL: https://github.com/apache/spark/pull/32496#discussion_r631622732 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala ## @@ -369,11 +369,25 @@ abstract class HashExpression[E

[GitHub] [spark] cloud-fan commented on a change in pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32496: URL: https://github.com/apache/spark/pull/32496#discussion_r631622732 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala ## @@ -369,11 +369,25 @@ abstract class HashExpression[E

[GitHub] [spark] cloud-fan commented on a change in pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32496: URL: https://github.com/apache/spark/pull/32496#discussion_r631623223 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -654,4 +654,30 @@ class WholeStageCodegenSuite

[GitHub] [spark] SparkQA commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-13 Thread GitBox
SparkQA commented on pull request #32410: URL: https://github.com/apache/spark/pull/32410#issuecomment-840378127 **[Test build #138496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138496/testReport)** for PR 32410 at commit [`4bca8ec`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32410: URL: https://github.com/apache/spark/pull/32410#issuecomment-840310594 **[Test build #138496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138496/testReport)** for PR 32410 at commit [`4bca8ec`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32410: URL: https://github.com/apache/spark/pull/32410#issuecomment-840378916 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138496/ -- This

[GitHub] [spark] cloud-fan commented on a change in pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32482: URL: https://github.com/apache/spark/pull/32482#discussion_r631624087 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ## @@ -1554,4 +1554,65 @@ class CachedTableSuite extends QueryTest wit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32410: URL: https://github.com/apache/spark/pull/32410#issuecomment-840378916 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138496/ -

[GitHub] [spark] cloud-fan commented on a change in pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-13 Thread GitBox
cloud-fan commented on a change in pull request #32482: URL: https://github.com/apache/spark/pull/32482#discussion_r631624820 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ## @@ -1554,4 +1554,65 @@ class CachedTableSuite extends QueryTest wit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32365: [SPARK-35228][SQL] Add expression ToPrettyString for keep consistent between hive/spark format in df.show and transform

2021-05-13 Thread GitBox
AngersZh commented on a change in pull request #32365: URL: https://github.com/apache/spark/pull/32365#discussion_r631625554 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -2649,3 +2652,78 @@ case class Sen

[GitHub] [spark] dongjoon-hyun commented on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
dongjoon-hyun commented on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840382268 Oh, thank you so much, @viirya ! Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] dongjoon-hyun closed pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
dongjoon-hyun closed pull request #32531: URL: https://github.com/apache/spark/pull/32531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] xuechendi opened a new pull request #32534: [WIP][SPARK-35396]Add AutoCloseable close to BlockManager and InMemoryRelation

2021-05-13 Thread GitBox
xuechendi opened a new pull request #32534: URL: https://github.com/apache/spark/pull/32534 This PR is proposing a add-on to support to manual close entries in MemoryStore and InMemoryRelation ### What changes were proposed in this pull request? Currently: MemoryStore uses

[GitHub] [spark] AmplabJenkins commented on pull request #32534: [WIP][SPARK-35396]Add AutoCloseable close to BlockManager and InMemoryRelation

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32534: URL: https://github.com/apache/spark/pull/32534#issuecomment-840383881 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] viirya opened a new pull request #32535: [SPARK-35397][SQL] Replace sys.err usage with explicit exception type

2021-05-13 Thread GitBox
viirya opened a new pull request #32535: URL: https://github.com/apache/spark/pull/32535 ### What changes were proposed in this pull request? This patch replaces `sys.err` usages with explicit exception types. ### Why are the changes needed? Motivated by

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32532: [SPARK-35384][SQL][FOLLOWUP] Move `HashMap.get` out of `InvokeLike.invoke`

2021-05-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #32532: URL: https://github.com/apache/spark/pull/32532#discussion_r631629800 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -145,12 +151,7 @@ trait InvokeLike

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32535: [SPARK-35397][SQL] Replace sys.err usage with explicit exception type

2021-05-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #32535: URL: https://github.com/apache/spark/pull/32535#discussion_r631630221 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3338,7 +3338,8 @@ class Analyzer(override va

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-13 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-840387634 **[Test build #138494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138494/testReport)** for PR 32498 at commit [`b7a6cc7`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-840310425 **[Test build #138494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138494/testReport)** for PR 32498 at commit [`b7a6cc7`](https://gi

[GitHub] [spark] YuzhouSun commented on pull request #32207: [SPARK-35106] Avoid failing rename in HadoopMapReduceCommitProtocol with dynamic partition overwrite

2021-05-13 Thread GitBox
YuzhouSun commented on pull request #32207: URL: https://github.com/apache/spark/pull/32207#issuecomment-840387892 Created https://github.com/apache/spark/pull/32530. @cloud-fan Could you review it? Thanks! -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-13 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-840388226 **[Test build #138485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138485/testReport)** for PR 32498 at commit [`1cf79bf`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-840264723 **[Test build #138485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138485/testReport)** for PR 32498 at commit [`1cf79bf`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-13 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-840389098 **[Test build #138486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138486/testReport)** for PR 32494 at commit [`bd838ac`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-840264760 **[Test build #138486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138486/testReport)** for PR 32494 at commit [`bd838ac`](https://gi

[GitHub] [spark] fhygh commented on a change in pull request #32501: [SPARK-35359][SQL] Insert data with char/varchar datatype will fail when data length exceed length limitation

2021-05-13 Thread GitBox
fhygh commented on a change in pull request #32501: URL: https://github.com/apache/spark/pull/32501#discussion_r631638329 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java ## @@ -26,7 +27,7 @@ private static UTF8String tri

[GitHub] [spark] SparkQA commented on pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
SparkQA commented on pull request #32528: URL: https://github.com/apache/spark/pull/32528#issuecomment-840401476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] c21 commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
c21 commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631646593 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -679,60 +704,124 @@ case class SortMergeJoinExec(

[GitHub] [spark] HyukjinKwon commented on pull request #32531: [SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file

2021-05-13 Thread GitBox
HyukjinKwon commented on pull request #32531: URL: https://github.com/apache/spark/pull/32531#issuecomment-840403834 LGTM2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32528: URL: https://github.com/apache/spark/pull/32528#issuecomment-840404809 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43020/

[GitHub] [spark] AmplabJenkins commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-840404805 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138486/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32528: URL: https://github.com/apache/spark/pull/32528#issuecomment-840404809 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43020/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-840404805 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138486/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-840404804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-840404804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-840405169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43022/ -- T

[GitHub] [spark] SparkQA commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-13 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-840405132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-840405169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43022/

[GitHub] [spark] SparkQA commented on pull request #32535: [SPARK-35397][SQL] Replace sys.err usage with explicit exception type

2021-05-13 Thread GitBox
SparkQA commented on pull request #32535: URL: https://github.com/apache/spark/pull/32535#issuecomment-840406769 **[Test build #138503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138503/testReport)** for PR 32535 at commit [`122d853`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840406845 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43021/ -- This is an automated message from the Apache

[GitHub] [spark] yaooqinn closed pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
yaooqinn closed pull request #32515: URL: https://github.com/apache/spark/pull/32515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840410375 Thanks for the help ~ @dongjoon-hyun @HyukjinKwon @cloud-fan +1 for myself. merged to master -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840410483 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43021/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840410504 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43021/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840410504 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43021/

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840414987 **[Test build #138489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138489/testReport)** for PR 32515 at commit [`ad18acc`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840286591 **[Test build #138489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138489/testReport)** for PR 32515 at commit [`ad18acc`](https://gi

[GitHub] [spark] ulysses-you commented on a change in pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-13 Thread GitBox
ulysses-you commented on a change in pull request #32482: URL: https://github.com/apache/spark/pull/32482#discussion_r631671896 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ## @@ -1554,4 +1554,65 @@ class CachedTableSuite extends QueryTest w

[GitHub] [spark] SparkQA commented on pull request #32535: [SPARK-35397][SQL] Replace sys.err usage with explicit exception type

2021-05-13 Thread GitBox
SparkQA commented on pull request #32535: URL: https://github.com/apache/spark/pull/32535#issuecomment-840429681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] SparkQA commented on pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-13 Thread GitBox
SparkQA commented on pull request #32204: URL: https://github.com/apache/spark/pull/32204#issuecomment-840430061 **[Test build #138492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138492/testReport)** for PR 32204 at commit [`a386788`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32204: URL: https://github.com/apache/spark/pull/32204#issuecomment-840291088 **[Test build #138492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138492/testReport)** for PR 32204 at commit [`a386788`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840430677 **[Test build #138501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138501/testReport)** for PR 32478 at commit [`4509cbb`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840376956 **[Test build #138501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138501/testReport)** for PR 32478 at commit [`4509cbb`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32204: URL: https://github.com/apache/spark/pull/32204#issuecomment-840436292 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138492/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32535: [SPARK-35397][SQL] Replace sys.err usage with explicit exception type

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32535: URL: https://github.com/apache/spark/pull/32535#issuecomment-840436294 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43023/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840436297 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138501/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
AmplabJenkins commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840436293 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138489/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-840436297 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138501/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840436293 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138489/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32535: [SPARK-35397][SQL] Replace sys.err usage with explicit exception type

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32535: URL: https://github.com/apache/spark/pull/32535#issuecomment-840436294 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43023/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32204: [SPARK-34494][SQL][DOCS] Move JSON data source options from Python and Scala into a single page

2021-05-13 Thread GitBox
AmplabJenkins removed a comment on pull request #32204: URL: https://github.com/apache/spark/pull/32204#issuecomment-840436292 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138492/ -

[GitHub] [spark] SparkQA commented on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-13 Thread GitBox
SparkQA commented on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-840438115 **[Test build #138504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138504/testReport)** for PR 32482 at commit [`2e8492b`](https://github.com

[GitHub] [spark] LuciferYang opened a new pull request #32536: Spark 35253 followup

2021-05-13 Thread GitBox
LuciferYang opened a new pull request #32536: URL: https://github.com/apache/spark/pull/32536 ### What changes were proposed in this pull request? SPARK-35253 upgraded janino from 3.0.16 to 3.1.4, `ClassBodyEvaluator` provides the `getBytecodes` method to get the mapping from `ClassF

[GitHub] [spark] SparkQA commented on pull request #32536: [SPARK-35253][SQL][FOLLOWUP] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-13 Thread GitBox
SparkQA commented on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-840440073 **[Test build #138505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138505/testReport)** for PR 32536 at commit [`738bdc6`](https://github.com

[GitHub] [spark] LuciferYang commented on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-13 Thread GitBox
LuciferYang commented on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-840441694 Waiting for CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [spark] LuciferYang commented on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-13 Thread GitBox
LuciferYang commented on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-840441827 cc @maropu @srowen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] xuanyuanking commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-13 Thread GitBox
xuanyuanking commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r631688986 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed

[GitHub] [spark] xuanyuanking commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-13 Thread GitBox
xuanyuanking commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r631689200 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala ## @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] [spark] xuanyuanking commented on a change in pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-13 Thread GitBox
xuanyuanking commented on a change in pull request #32272: URL: https://github.com/apache/spark/pull/32272#discussion_r631689463 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala ## @@ -0,0 +1,165 @@ +/* + * Licensed

[GitHub] [spark] SparkQA commented on pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
SparkQA commented on pull request #32528: URL: https://github.com/apache/spark/pull/32528#issuecomment-840444115 **[Test build #138506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138506/testReport)** for PR 32528 at commit [`6282a09`](https://github.com

[GitHub] [spark] c21 commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
c21 commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631690259 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -679,60 +704,124 @@ case class SortMergeJoinExec(

[GitHub] [spark] c21 commented on a change in pull request #32528: [SPARK-35350][SQL] Add code-gen for left semi sort merge join

2021-05-13 Thread GitBox
c21 commented on a change in pull request #32528: URL: https://github.com/apache/spark/pull/32528#discussion_r631690259 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala ## @@ -679,60 +704,124 @@ case class SortMergeJoinExec(

[GitHub] [spark] SparkQA commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-13 Thread GitBox
SparkQA commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-84023 **[Test build #138507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138507/testReport)** for PR 32272 at commit [`3b91a26`](https://github.com

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

2021-05-13 Thread GitBox
xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-840445866 ``` there're some sorts of uncertainty during reviewing as there's no reference PR. In other words, we are reviewing methods which we don't have idea how these methods w

[GitHub] [spark] SparkQA removed a comment on pull request #32161: [SPARK-35025][SQL][PYTHON][DOCS] Move Parquet data source options from Python and Scala into a single page.

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32161: URL: https://github.com/apache/spark/pull/32161#issuecomment-840310729 **[Test build #138497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138497/testReport)** for PR 32161 at commit [`bb5cd45`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32161: [SPARK-35025][SQL][PYTHON][DOCS] Move Parquet data source options from Python and Scala into a single page.

2021-05-13 Thread GitBox
SparkQA commented on pull request #32161: URL: https://github.com/apache/spark/pull/32161#issuecomment-840451449 **[Test build #138497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138497/testReport)** for PR 32161 at commit [`bb5cd45`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
SparkQA removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840310366 **[Test build #138493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138493/testReport)** for PR 32515 at commit [`b8b54ea`](https://gi

  1   2   3   4   5   6   7   8   >