[GitHub] [spark] viirya commented on pull request #32559: [SPARK-35410][SQL] SubExpr elimination should not include redundant children exprs in conditional expression

2021-05-18 Thread GitBox
viirya commented on pull request #32559: URL: https://github.com/apache/spark/pull/32559#issuecomment-843648970 > I did actually hit a bug today where the when value was being evaluated even though the condition was false. I wasn't able to find the exact root cause yet but turning off

[GitHub] [spark] xinrong-databricks opened a new pull request #32584: Test pandas nondeterministic return values

2021-05-18 Thread GitBox
xinrong-databricks opened a new pull request #32584: URL: https://github.com/apache/spark/pull/32584 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843646341 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43214/

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843646330 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43214/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843646341 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43214/ --

[GitHub] [spark] SparkQA commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843638317 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43215/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843616675 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43212/

[GitHub] [spark] SparkQA commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843618436 **[Test build #138694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138694/testReport)** for PR 32469 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843616675 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43212/ --

[GitHub] [spark] xinrong-databricks commented on a change in pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
xinrong-databricks commented on a change in pull request #32469: URL: https://github.com/apache/spark/pull/32469#discussion_r634796966 ## File path: python/pyspark/pandas/data_type_ops/num_ops.py ## @@ -0,0 +1,304 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843612406 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43214/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843602645 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43212/ -- This is an automated message from the

[GitHub] [spark] ueshin commented on a change in pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-18 Thread GitBox
ueshin commented on a change in pull request #32516: URL: https://github.com/apache/spark/pull/32516#discussion_r634788357 ## File path: python/pyspark/pandas/tests/test_dataframe_conversion.py ## @@ -101,69 +101,69 @@ def test_to_excel(self): koalas_location =

[GitHub] [spark] ueshin commented on a change in pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-18 Thread GitBox
ueshin commented on a change in pull request #32516: URL: https://github.com/apache/spark/pull/32516#discussion_r634775772 ## File path: python/pyspark/pandas/tests/test_indexing.py ## @@ -34,6 +34,10 @@ def pdf(self): {"month": [1, 4, 7, 10], "year": [2012, 2014,

[GitHub] [spark] xinrong-databricks edited a comment on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-18 Thread GitBox
xinrong-databricks edited a comment on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-843596633 python/pyspark/pandas/tests/test_utils.py has some variables named `koalas`. Shall we rename them as well? Or we may adjust them later in a separate PR.

[GitHub] [spark] xinrong-databricks commented on pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-18 Thread GitBox
xinrong-databricks commented on pull request #32516: URL: https://github.com/apache/spark/pull/32516#issuecomment-843596633 python/pyspark/pandas/tests/test_utils.py has some variables named `koalas`. Shall we rename them as well? Or we may adjust them later in a separate PR. -- This is

[GitHub] [spark] xinrong-databricks commented on a change in pull request #32516: [SPARK-35364][PYTHON] Renaming the existing Koalas related codes

2021-05-18 Thread GitBox
xinrong-databricks commented on a change in pull request #32516: URL: https://github.com/apache/spark/pull/32516#discussion_r63486 ## File path: python/pyspark/pandas/tests/test_dataframe_conversion.py ## @@ -101,69 +101,69 @@ def test_to_excel(self):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843585334 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138689/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843585332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843586584 **[Test build #138693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138693/testReport)** for PR 32498 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843585332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843585334 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138689/ -- This

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843584291 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43212/ -- This is an automated message from the Apache

[GitHub] [spark] viirya commented on pull request #32195: [SPARK-35093] [SQL] AQE now uses newQueryStage plan as key for looking up cached exchanges for re-use

2021-05-18 Thread GitBox
viirya commented on pull request #32195: URL: https://github.com/apache/spark/pull/32195#issuecomment-843572577 Not only here, I also saw other PRs their label pull requests are queued too. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] SparkQA removed a comment on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843361599 **[Test build #138689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138689/testReport)** for PR 32301 at commit

[GitHub] [spark] SparkQA commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
SparkQA commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843568889 **[Test build #138689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138689/testReport)** for PR 32301 at commit

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843566696 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43213/ --

[GitHub] [spark] SparkQA removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843560298 **[Test build #138692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138692/testReport)** for PR 32498 at commit

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843564494 **[Test build #138692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138692/testReport)** for PR 32498 at commit

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r634731522 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -81,40 +91,76 @@

[GitHub] [spark] shahidki31 commented on a change in pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32498: URL: https://github.com/apache/spark/pull/32498#discussion_r634746436 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -789,6 +797,39 @@ case class

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-843560298 **[Test build #138692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138692/testReport)** for PR 32498 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843399879 **[Test build #138690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138690/testReport)** for PR 32389 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843549102 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138690/

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843551331 **[Test build #138691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138691/testReport)** for PR 32494 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843549102 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138690/ -- This

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r634733473 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -81,40 +91,76 @@

[GitHub] [spark] tgravescs commented on pull request #32195: [SPARK-35093] [SQL] AQE now uses newQueryStage plan as key for looking up cached exchanges for re-use

2021-05-18 Thread GitBox
tgravescs commented on pull request #32195: URL: https://github.com/apache/spark/pull/32195#issuecomment-843545267 I'm not sure why the label pull requests check isn't running here. Anyone know? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r634731522 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -81,40 +91,76 @@

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r634731283 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -70,8 +68,20 @@

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r634731034 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -70,8 +68,20 @@

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r634731160 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -81,40 +91,76 @@

[GitHub] [spark] andygrove commented on pull request #32195: [SPARK-35093] [SQL] AQE now uses newQueryStage plan as key for looking up cached exchanges for re-use

2021-05-18 Thread GitBox
andygrove commented on pull request #32195: URL: https://github.com/apache/spark/pull/32195#issuecomment-843541449 I applied this patch to the latest in branch-3.0 and branch-3.1 and ran manual tests to confirm that this fixes the issue for us in those releases. -- This is an automated

[GitHub] [spark] SparkQA commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
SparkQA commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843538579 **[Test build #138690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138690/testReport)** for PR 32389 at commit

[GitHub] [spark] karenfeng commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
karenfeng commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843511836 @cloud-fan and @viirya, could you take another look? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843503770 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43211/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843503769 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138688/

[GitHub] [spark] AmplabJenkins commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843503770 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43211/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843503769 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138688/ -- This

[GitHub] [spark] SparkQA commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
SparkQA commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843489993 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43211/ -- This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843352361 **[Test build #138688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138688/testReport)** for PR 32469 at commit

[GitHub] [spark] SparkQA commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843472487 **[Test build #138688 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138688/testReport)** for PR 32469 at commit

[GitHub] [spark] ueshin commented on a change in pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
ueshin commented on a change in pull request #32469: URL: https://github.com/apache/spark/pull/32469#discussion_r634683423 ## File path: python/pyspark/pandas/data_type_ops/num_ops.py ## @@ -0,0 +1,304 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [spark] SparkQA commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
SparkQA commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843456226 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43211/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843444367 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138687/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843444366 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43209/

[GitHub] [spark] AmplabJenkins commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843444367 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138687/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843444366 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43209/ --

[GitHub] [spark] dongjoon-hyun commented on pull request #32572: [SPARK-35305][BUILD] Upgrade Zookeeper to 3.7.0

2021-05-18 Thread GitBox
dongjoon-hyun commented on pull request #32572: URL: https://github.com/apache/spark/pull/32572#issuecomment-843428994 Thank you for closing, @lipzhu . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] SparkQA removed a comment on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843295727 **[Test build #138687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138687/testReport)** for PR 32563 at commit

[GitHub] [spark] SparkQA commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
SparkQA commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843418929 **[Test build #138687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138687/testReport)** for PR 32563 at commit

[GitHub] [spark] SparkQA commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843414055 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43209/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843410544 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43210/

[GitHub] [spark] AmplabJenkins commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843410544 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43210/ --

[GitHub] [spark] SparkQA commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
SparkQA commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843410516 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43210/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843398502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA removed a comment on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843243715 **[Test build #138685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138685/testReport)** for PR 32582 at commit

[GitHub] [spark] SparkQA commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
SparkQA commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843399879 **[Test build #138690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138690/testReport)** for PR 32389 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843399497 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138685/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843398502 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43206/ --

[GitHub] [spark] SparkQA commented on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
SparkQA commented on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843397521 **[Test build #138685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138685/testReport)** for PR 32582 at commit

[GitHub] [spark] SparkQA commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843392095 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43209/ -- This is an automated message from the Apache

[GitHub] [spark] otterc commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
otterc commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r634587251 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,47 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #32566: [SPARK-35418][SQL] Add sentences function to functions.{scala,py}

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32566: URL: https://github.com/apache/spark/pull/32566#issuecomment-843367277 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138683/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32566: [SPARK-35418][SQL] Add sentences function to functions.{scala,py}

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32566: URL: https://github.com/apache/spark/pull/32566#issuecomment-843367277 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138683/

[GitHub] [spark] SparkQA commented on pull request #32566: [SPARK-35418][SQL] Add sentences function to functions.{scala,py}

2021-05-18 Thread GitBox
SparkQA commented on pull request #32566: URL: https://github.com/apache/spark/pull/32566#issuecomment-843365691 **[Test build #138683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138683/testReport)** for PR 32566 at commit

[GitHub] [spark] Kimahriman commented on a change in pull request #32448: [SPARK-35290][SQL] Use StructType merging for unionByName with null filling

2021-05-18 Thread GitBox
Kimahriman commented on a change in pull request #32448: URL: https://github.com/apache/spark/pull/32448#discussion_r634588583 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -743,17 +777,59 @@ class

[GitHub] [spark] SparkQA removed a comment on pull request #32566: [SPARK-35418][SQL] Add sentences function to functions.{scala,py}

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32566: URL: https://github.com/apache/spark/pull/32566#issuecomment-843140519 **[Test build #138683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138683/testReport)** for PR 32566 at commit

[GitHub] [spark] viirya commented on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
viirya commented on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843377733 Thanks @dongjoon-hyun. I'll look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] c21 commented on pull request #32547: [SPARK-35351][SQL] Add code-gen for left anti sort merge join

2021-05-18 Thread GitBox
c21 commented on pull request #32547: URL: https://github.com/apache/spark/pull/32547#issuecomment-843374463 Thank you @maropu and @cloud-fan for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r634595619 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,47 @@ class

[GitHub] [spark] SparkQA commented on pull request #32582: [WIP][SPARK-35436] RocksDBFileManager - save checkpoint to DFS

2021-05-18 Thread GitBox
SparkQA commented on pull request #32582: URL: https://github.com/apache/spark/pull/32582#issuecomment-843370665 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43206/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32581: [SPARK-35434][BUILD] Upgrade scalatestplus artifacts to 3.2.9.0

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32581: URL: https://github.com/apache/spark/pull/32581#issuecomment-843347624 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138684/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843355925 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43208/

[GitHub] [spark] SparkQA commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
SparkQA commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843355903 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43208/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843355925 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43208/ --

[GitHub] [spark] SparkQA commented on pull request #32469: [SPARK-35338][PYTHON] Separate arithmetic operations into data type based structures

2021-05-18 Thread GitBox
SparkQA commented on pull request #32469: URL: https://github.com/apache/spark/pull/32469#issuecomment-843352361 **[Test build #138688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138688/testReport)** for PR 32469 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32581: [SPARK-35434][BUILD] Upgrade scalatestplus artifacts to 3.2.9.0

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32581: URL: https://github.com/apache/spark/pull/32581#issuecomment-843347624 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138684/ -- This

[GitHub] [spark] sumeetgajjar commented on pull request #32576: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs

2021-05-18 Thread GitBox
sumeetgajjar commented on pull request #32576: URL: https://github.com/apache/spark/pull/32576#issuecomment-843344239 Thanks for the quick response @dongjoon-hyun. Thanks for the info @wangyum. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #32195: [SPARK-35093] [SQL] AQE now uses newQueryStage plan as key for looking up cached exchanges for re-use

2021-05-18 Thread GitBox
dongjoon-hyun commented on pull request #32195: URL: https://github.com/apache/spark/pull/32195#issuecomment-843342661 Yes, please backport this to the old branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] dongjoon-hyun closed pull request #32579: [SPARK-35425][BUILD][3.0] Pin jinja2 in spark-rm/Dockerfile and add as a required dependency in the release README.md

2021-05-18 Thread GitBox
dongjoon-hyun closed pull request #32579: URL: https://github.com/apache/spark/pull/32579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] dongjoon-hyun closed pull request #32580: [SPARK-35425][BUILD][3.1] Pin jinja2 in spark-rm/Dockerfile and add as a required dependency in the release README.md

2021-05-18 Thread GitBox
dongjoon-hyun closed pull request #32580: URL: https://github.com/apache/spark/pull/32580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] dongjoon-hyun closed pull request #32581: [SPARK-35434][BUILD] Upgrade scalatestplus artifacts to 3.2.9.0

2021-05-18 Thread GitBox
dongjoon-hyun closed pull request #32581: URL: https://github.com/apache/spark/pull/32581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] cloud-fan commented on a change in pull request #32448: [SPARK-35290][SQL] Use StructType merging for unionByName with null filling

2021-05-18 Thread GitBox
cloud-fan commented on a change in pull request #32448: URL: https://github.com/apache/spark/pull/32448#discussion_r634542944 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -743,17 +777,59 @@ class

[GitHub] [spark] SparkQA removed a comment on pull request #32581: [SPARK-35434][BUILD] Upgrade scalatestplus artifacts to 3.2.9.0

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32581: URL: https://github.com/apache/spark/pull/32581#issuecomment-843188984 **[Test build #138684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138684/testReport)** for PR 32581 at commit

[GitHub] [spark] SparkQA commented on pull request #32581: [SPARK-35434][BUILD] Upgrade scalatestplus artifacts to 3.2.9.0

2021-05-18 Thread GitBox
SparkQA commented on pull request #32581: URL: https://github.com/apache/spark/pull/32581#issuecomment-843315426 **[Test build #138684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138684/testReport)** for PR 32581 at commit

[GitHub] [spark] mridulm commented on a change in pull request #32534: [WIP][SPARK-35396]Add AutoCloseable close to BlockManager and InMemoryRelation

2021-05-18 Thread GitBox
mridulm commented on a change in pull request #32534: URL: https://github.com/apache/spark/pull/32534#discussion_r634533375 ## File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ## @@ -405,6 +427,22 @@ private[spark] class MemoryStore( def

[GitHub] [spark] mridulm commented on a change in pull request #32534: [WIP][SPARK-35396]Add AutoCloseable close to BlockManager and InMemoryRelation

2021-05-18 Thread GitBox
mridulm commented on a change in pull request #32534: URL: https://github.com/apache/spark/pull/32534#discussion_r634532032 ## File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ## @@ -387,6 +388,14 @@ private[spark] class MemoryStore( def

[GitHub] [spark] andygrove commented on pull request #32195: [SPARK-35093] [SQL] AQE now uses newQueryStage plan as key for looking up cached exchanges for re-use

2021-05-18 Thread GitBox
andygrove commented on pull request #32195: URL: https://github.com/apache/spark/pull/32195#issuecomment-843307877 @cloud-fan @tgravescs I updated the title and description. Let me know if this is still not clear. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` meth

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-843302517 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138682/

<    1   2   3   4   5   6   >