[GitHub] [spark] imback82 commented on pull request #32542: [SPARK-35403][SQL] Migrate ALTER TABLE commands that alter columns to use UnresolvedTable to resolve the identifier

2021-05-18 Thread GitBox
imback82 commented on pull request #32542: URL: https://github.com/apache/spark/pull/32542#issuecomment-843702839 > 1. Have a single `AlterTable` logical plan, which has 2 members: `table: LogicalPlan` and `changes: Seq[TableChange]`. We also have a single `AlterTableExec` physical plan.

[GitHub] [spark] AngersZhuuuu commented on pull request #32365: [SPARK-35228][SQL] Add expression ToPrettyString for keep consistent between hive/spark format in df.show and transform

2021-05-18 Thread GitBox
AngersZh commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-843702945 ping @MaxGekk @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [spark] SparkQA commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
SparkQA commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843703128 **[Test build #138698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138698/testReport)** for PR 32563 at commit [`8c1e5ce`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32552: [SPARK-34819][SQL] MapType supports comparable semantics

2021-05-18 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-843703118 **[Test build #138699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138699/testReport)** for PR 32552 at commit [`877af88`](https://github.com

[GitHub] [spark] huaxingao commented on a change in pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-18 Thread GitBox
huaxingao commented on a change in pull request #32049: URL: https://github.com/apache/spark/pull/32049#discussion_r634877198 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownAggregates.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to th

[GitHub] [spark] Ngone51 commented on pull request #31876: [SPARK-34942][API][CORE] Abstract Location in MapStatus to enable support for custom storage

2021-05-18 Thread GitBox
Ngone51 commented on pull request #31876: URL: https://github.com/apache/spark/pull/31876#issuecomment-843704131 @mridulm Sorry, missed your last comment... I think we can go ahead to update to the latest as long as we can put SPARK-35188 aside for now. -- This is an automated message fr

[GitHub] [spark] huaxingao commented on a change in pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-18 Thread GitBox
huaxingao commented on a change in pull request #32049: URL: https://github.com/apache/spark/pull/32049#discussion_r634877439 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownAggregates.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to th

[GitHub] [spark] huaxingao commented on a change in pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-18 Thread GitBox
huaxingao commented on a change in pull request #32049: URL: https://github.com/apache/spark/pull/32049#discussion_r634877762 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/aggregates.scala ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [spark] huaxingao commented on a change in pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-18 Thread GitBox
huaxingao commented on a change in pull request #32049: URL: https://github.com/apache/spark/pull/32049#discussion_r634878055 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -102,6 +102,7 @@ case class RowDataSourceScanExec(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32585: [SPARK-35438][SQL][DOCS] Minor documentation fix for window physical operator

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32585: URL: https://github.com/apache/spark/pull/32585#issuecomment-843702426 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43216/

[GitHub] [spark] huaxingao commented on a change in pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-18 Thread GitBox
huaxingao commented on a change in pull request #32049: URL: https://github.com/apache/spark/pull/32049#discussion_r634879199 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/aggregates.scala ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [spark] huaxingao commented on a change in pull request #32049: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-05-18 Thread GitBox
huaxingao commented on a change in pull request #32049: URL: https://github.com/apache/spark/pull/32049#discussion_r634879276 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ## @@ -17,19 +17,130 @@ package org

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843708314 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43218/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843708329 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43218/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843708329 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43218/

[GitHub] [spark] SparkQA commented on pull request #32584: Test pandas nondeterministic return values

2021-05-18 Thread GitBox
SparkQA commented on pull request #32584: URL: https://github.com/apache/spark/pull/32584#issuecomment-843709302 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43217/ -- This is an automated message from the A

[GitHub] [spark] asfgit closed pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
asfgit closed pull request #32389: URL: https://github.com/apache/spark/pull/32389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] mridulm commented on pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
mridulm commented on pull request #32389: URL: https://github.com/apache/spark/pull/32389#issuecomment-843721497 Merging to master, thanks @xkrogen. Thanks for the reviews @Ngone51 , @otterc ! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] SparkQA commented on pull request #32552: [SPARK-34819][SQL] MapType supports comparable semantics

2021-05-18 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-843721808 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43220/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
SparkQA commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843722159 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43219/ -- This is an automated message from the Apache

[GitHub] [spark] Ngone51 commented on pull request #32385: [WIP][SPARK-35275][CORE] Add checksum for shuffle blocks and diagnose corruption

2021-05-18 Thread GitBox
Ngone51 commented on pull request #32385: URL: https://github.com/apache/spark/pull/32385#issuecomment-843722683 @tgravescs Thanks for the good points! I did find some perf regression by benchmarking with the change. I'll double-check it for sure and try to get rid of it if possible.

[GitHub] [spark] viirya opened a new pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya opened a new pull request #32586: URL: https://github.com/apache/spark/pull/32586 ### What changes were proposed in this pull request? This patch replaces `HashMap` with `LinkedHashMap` as the map of equivalent expressions in `EquivalentExpressions` used for subexp

[GitHub] [spark] viirya commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843723648 cc @cloud-fan @maropu @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins commented on pull request #32584: Test pandas nondeterministic return values

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32584: URL: https://github.com/apache/spark/pull/32584#issuecomment-843724112 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43217/ -- T

[GitHub] [spark] SparkQA commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
SparkQA commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843724540 **[Test build #138700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138700/testReport)** for PR 32586 at commit [`7b6b589`](https://github.com

[GitHub] [spark] cfmcgrady commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In predicate

2021-05-18 Thread GitBox
cfmcgrady commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r634893337 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -121,6 +129,24 @@ object Unw

[GitHub] [spark] cfmcgrady commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In predicate

2021-05-18 Thread GitBox
cfmcgrady commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r634893418 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -121,6 +129,24 @@ object Unw

[GitHub] [spark] sarutak commented on a change in pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
sarutak commented on a change in pull request #32570: URL: https://github.com/apache/spark/pull/32570#discussion_r634894308 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -120,20 +122,22 @@ class DataSourceV

[GitHub] [spark] SparkQA commented on pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32570: URL: https://github.com/apache/spark/pull/32570#issuecomment-843725725 **[Test build #138701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138701/testReport)** for PR 32570 at commit [`4574440`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32584: Test pandas nondeterministic return values

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32584: URL: https://github.com/apache/spark/pull/32584#issuecomment-843724112 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43217/

[GitHub] [spark] maropu closed pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
maropu closed pull request #32536: URL: https://github.com/apache/spark/pull/32536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] maropu commented on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
maropu commented on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-843728916 Thank you, @LuciferYang . Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] maropu commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
maropu commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843730003 The fix looks fine. Is it difficult to add some tests for that case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] SparkQA commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
SparkQA commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843731519 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43219/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32552: [SPARK-34819][SQL] MapType supports comparable semantics

2021-05-18 Thread GitBox
SparkQA commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-843732045 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43220/ -- This is an automated message from the A

[GitHub] [spark] viirya commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843733300 Let me put it in draft first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] viirya edited a comment on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya edited a comment on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843733300 Sorry I misread the code, looks like we add parent expression first into the map and traverse to its children expressions. Let me put it in draft first. -- This is an au

[GitHub] [spark] SparkQA commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
SparkQA commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843740202 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43221/ -- This is an automated message from the Apache

[GitHub] [spark] viirya edited a comment on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya edited a comment on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843733300 Sorry I misread the code, looks like we add parent expression first into the map and traverse to its children expressions. Let me put it in draft first. -- This is an a

[GitHub] [spark] viirya commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843741600 I figured out this change makes sense. But the description is not correct. I will update it later. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [spark] SparkQA commented on pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32570: URL: https://github.com/apache/spark/pull/32570#issuecomment-843742102 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43222/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843742973 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43219/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32552: [SPARK-34819][SQL] MapType supports comparable semantics

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-843742972 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43220/ -- T

[GitHub] [spark] viirya commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843743329 > The fix looks fine. Is it difficult to add some tests for that case? I don't come out a test that fails before but succeeds after this. I think the retrieving order is ok

[GitHub] [spark] viirya removed a comment on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya removed a comment on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843733300 Sorry I misread the code, looks like we add parent expression first into the map and traverse to its children expressions. Let me put it in draft first. -- This is an

[GitHub] [spark] SparkQA commented on pull request #32585: [SPARK-35438][SQL][DOCS] Minor documentation fix for window physical operator

2021-05-18 Thread GitBox
SparkQA commented on pull request #32585: URL: https://github.com/apache/spark/pull/32585#issuecomment-843745233 **[Test build #138695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138695/testReport)** for PR 32585 at commit [`9b07938`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32585: [SPARK-35438][SQL][DOCS] Minor documentation fix for window physical operator

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32585: URL: https://github.com/apache/spark/pull/32585#issuecomment-843663224 **[Test build #138695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138695/testReport)** for PR 32585 at commit [`9b07938`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32563: URL: https://github.com/apache/spark/pull/32563#issuecomment-843742973 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43219/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32552: [SPARK-34819][SQL] MapType supports comparable semantics

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32552: URL: https://github.com/apache/spark/pull/32552#issuecomment-843742972 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43220/

[GitHub] [spark] AmplabJenkins commented on pull request #32585: [SPARK-35438][SQL][DOCS] Minor documentation fix for window physical operator

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32585: URL: https://github.com/apache/spark/pull/32585#issuecomment-843745981 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138695/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32585: [SPARK-35438][SQL][DOCS] Minor documentation fix for window physical operator

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32585: URL: https://github.com/apache/spark/pull/32585#issuecomment-843745981 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138695/ -

[GitHub] [spark] linhongliu-db opened a new pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-18 Thread GitBox
linhongliu-db opened a new pull request #32587: URL: https://github.com/apache/spark/pull/32587 ### What changes were proposed in this pull request? Add the language, such as "scala", "python", "java", "hive", "built-in" to the `ExpressionInfo` for UDF. ### Why are the changes nee

[GitHub] [spark] SparkQA commented on pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-18 Thread GitBox
SparkQA commented on pull request #32587: URL: https://github.com/apache/spark/pull/32587#issuecomment-843746961 **[Test build #138702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138702/testReport)** for PR 32587 at commit [`3aa2124`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
SparkQA commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843751331 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43221/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32570: URL: https://github.com/apache/spark/pull/32570#issuecomment-843753601 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43222/ -- This is an automated message from the A

[GitHub] [spark] cloud-fan commented on pull request #32542: [SPARK-35403][SQL] Migrate ALTER TABLE commands that alter columns to use UnresolvedTable to resolve the identifier

2021-05-18 Thread GitBox
cloud-fan commented on pull request #32542: URL: https://github.com/apache/spark/pull/32542#issuecomment-843759217 I see, then option 1 is not valid. Can you open a new PR to try option 2? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] LuciferYang commented on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang commented on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-843759422 thx all ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [spark] wangyum commented on a change in pull request #32563: [SPARK-35415][SQL] Change `information` to map type for SHOW TABLE EXTENDED command

2021-05-18 Thread GitBox
wangyum commented on a change in pull request #32563: URL: https://github.com/apache/spark/pull/32563#discussion_r634924338 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -580,41 +587,52 @@ case class RenameTable(

[GitHub] [spark] SparkQA commented on pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-18 Thread GitBox
SparkQA commented on pull request #32587: URL: https://github.com/apache/spark/pull/32587#issuecomment-843764594 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43223/ -- This is an automated message from the Apache

[GitHub] [spark] viirya commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
viirya commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843764793 Hmm, I found corner case that LinkedHashMap doesn't work here. Going to update and adding test case. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins commented on pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32570: URL: https://github.com/apache/spark/pull/32570#issuecomment-843765326 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43222/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843765325 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43221/ -- T

[GitHub] [spark] SparkQA commented on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
SparkQA commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843766768 **[Test build #138703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138703/testReport)** for PR 32586 at commit [`f777855`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843765325 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43221/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32570: URL: https://github.com/apache/spark/pull/32570#issuecomment-843765326 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43222/

[GitHub] [spark] viirya commented on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
viirya commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843769636 Please take another look. I found corner case and added a test case. cc @cloud-fan @maropu @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respon

[GitHub] [spark] viirya edited a comment on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
viirya edited a comment on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843769636 Please take another look. I found corner case and added a test case. Thanks. cc @cloud-fan @maropu @dongjoon-hyun -- This is an automated message from the Apache Git Ser

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843771022 **[Test build #138697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138697/testReport)** for PR 32494 at commit [`3afaf32`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
SparkQA removed a comment on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843683480 **[Test build #138697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138697/testReport)** for PR 32494 at commit [`3afaf32`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843772061 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138697/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-843772061 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138697/ -

[GitHub] [spark] cloud-fan commented on pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
cloud-fan commented on pull request #32570: URL: https://github.com/apache/spark/pull/32570#issuecomment-843780188 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan closed pull request #32570: [SPARK-35421][SS] Remove redundant ProjectExec from streaming queries with V2Relation

2021-05-18 Thread GitBox
cloud-fan closed pull request #32570: URL: https://github.com/apache/spark/pull/32570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [spark] SparkQA commented on pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-18 Thread GitBox
SparkQA commented on pull request #32587: URL: https://github.com/apache/spark/pull/32587#issuecomment-843780127 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43223/ -- This is an automated message from the A

[GitHub] [spark] cloud-fan commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In predicate

2021-05-18 Thread GitBox
cloud-fan commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r634943062 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -121,6 +129,24 @@ object Unw

[GitHub] [spark] SparkQA commented on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
SparkQA commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843788740 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43224/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32587: URL: https://github.com/apache/spark/pull/32587#issuecomment-843796556 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43223/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
AmplabJenkins commented on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843796559 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43224/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32587: [SPARK-35440][SQL] Add language type to `ExpressionInfo` for UDF

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32587: URL: https://github.com/apache/spark/pull/32587#issuecomment-843796556 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43223/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32586: [SPARK-35439][SQL] Children subexpr should come first than parent subexpr

2021-05-18 Thread GitBox
AmplabJenkins removed a comment on pull request #32586: URL: https://github.com/apache/spark/pull/32586#issuecomment-843796559 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43224/

<    1   2   3   4   5