[GitHub] [spark] SparkQA commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851701092 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43644/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851699655 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139120/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851699655 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139120/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851617138 **[Test build #139120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139120/testReport)** for PR 32714 at commit [`aa78690`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851699181 **[Test build #139120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139120/testReport)** for PR 32714 at commit [`aa78690`](https://github.co

[GitHub] [spark] dongjoon-hyun commented on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
dongjoon-hyun commented on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851696374 Merged to master. Could you make a backport PR, @gengliangwang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
dongjoon-hyun edited a comment on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851696374 Merged to master. There is a conflict. Could you make a backport PR, @gengliangwang ? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [spark] dongjoon-hyun closed pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
dongjoon-hyun closed pull request #32712: URL: https://github.com/apache/spark/pull/32712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] viirya commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
viirya commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851694903 Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] SparkQA commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851693837 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43644/ -- This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
dongjoon-hyun commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851692122 Thank you so much, @cloud-fan ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [spark] AmplabJenkins commented on pull request #32114: [SPARK-35011][CORE] Avoid Block Manager registrations when StopExecutor msg is in-flight

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-851683239 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43643/ -- T

[GitHub] [spark] SparkQA commented on pull request #32114: [SPARK-35011][CORE] Avoid Block Manager registrations when StopExecutor msg is in-flight

2021-05-31 Thread GitBox
SparkQA commented on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-851683229 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43643/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851678599 **[Test build #139124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139124/testReport)** for PR 32714 at commit [`33b5ce3`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851678049 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139119/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851678048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851678049 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139119/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851678048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] MaxGekk commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
MaxGekk commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851676205 @cloud-fan @HyukjinKwon FYI, I did't add new tests because special values in typed literals are tested in `date.sql`/`timestamp.sql`. -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32114: [SPARK-35011][CORE] Avoid Block Manager registrations when StopExecutor msg is in-flight

2021-05-31 Thread GitBox
SparkQA commented on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-851674791 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43643/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851674281 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43642/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851617313 **[Test build #139121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139121/testReport)** for PR 32298 at commit [`100cb9c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851672223 **[Test build #139121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139121/testReport)** for PR 32298 at commit [`100cb9c`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851571920 **[Test build #139119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139119/testReport)** for PR 32716 at commit [`baf9690`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
SparkQA commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851666286 **[Test build #139119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139119/testReport)** for PR 32716 at commit [`baf9690`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32114: [SPARK-35011][CORE] Avoid Block Manager registrations when StopExecutor msg is in-flight

2021-05-31 Thread GitBox
SparkQA commented on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-851655230 **[Test build #139123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139123/testReport)** for PR 32114 at commit [`2c7a439`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851654123 **[Test build #139122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139122/testReport)** for PR 32298 at commit [`9d8dd6b`](https://github.com

[GitHub] [spark] attilapiros commented on pull request #32114: [SPARK-35011][CORE] Avoid Block Manager registrations when StopExecutor msg is in-flight

2021-05-31 Thread GitBox
attilapiros commented on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-851653789 jenkins retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851652954 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43641/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851652953 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43640/

[GitHub] [spark] AmplabJenkins commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851652954 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43641/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851652953 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43640/ -- T

[GitHub] [spark] SparkQA commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851643034 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43641/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851641287 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43640/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851631733 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43641/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851631266 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43640/ -- This is an automated message from the Apache

[GitHub] [spark] viirya commented on pull request #32702: [SPARK-35565][SS] Add config for ignoring metadata directory of FileStreamSink

2021-05-31 Thread GitBox
viirya commented on pull request #32702: URL: https://github.com/apache/spark/pull/32702#issuecomment-851618733 @HeartSaVioR Does it sound okay for you? If okay, still prefer an option over config? If so, please let me know so I can change to use option. -- This is an automated message f

[GitHub] [spark] SparkQA commented on pull request #32298: [WIP][SPARK-34079][SQL] Merge non-correlated scalar subqueries to multi-column scalar subqueries for better reuse

2021-05-31 Thread GitBox
SparkQA commented on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-851617313 **[Test build #139121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139121/testReport)** for PR 32298 at commit [`100cb9c`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851617138 **[Test build #139120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139120/testReport)** for PR 32714 at commit [`aa78690`](https://github.com

[GitHub] [spark] viirya commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
viirya commented on a change in pull request #32709: URL: https://github.com/apache/spark/pull/32709#discussion_r642620515 ## File path: R/pkg/tests/fulltests/test_sparkSQL.R ## @@ -1451,7 +1451,7 @@ test_that("column functions", { expect_equal(collect(df2)[[3, 2]], TRUE)

[GitHub] [spark] viirya commented on a change in pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
viirya commented on a change in pull request #32709: URL: https://github.com/apache/spark/pull/32709#discussion_r642620155 ## File path: R/pkg/tests/fulltests/test_sparkSQL.R ## @@ -1451,7 +1451,7 @@ test_that("column functions", { expect_equal(collect(df2)[[3, 2]], TRUE)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851615947 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43639/

[GitHub] [spark] AmplabJenkins commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851615947 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43639/ -- T

[GitHub] [spark] viirya commented on a change in pull request #32699: [SPARK-35560][SQL] Remove redundant subexpression evaluation in nested subexpressions

2021-05-31 Thread GitBox
viirya commented on a change in pull request #32699: URL: https://github.com/apache/spark/pull/32699#discussion_r642617321 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ## @@ -1039,21 +1039,25 @@ class CodegenCo

[GitHub] [spark] shahidki31 commented on pull request #32704: [SPARK-35567][SQL] Fix: Explain cost is not showing statistics for all the nodes

2021-05-31 Thread GitBox
shahidki31 commented on pull request #32704: URL: https://github.com/apache/spark/pull/32704#issuecomment-851608659 Thanks a lot @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [spark] huskysun commented on pull request #32701: [SPARK-35562][DOC] Fix docs about Kubernetes and Yarn

2021-05-31 Thread GitBox
huskysun commented on pull request #32701: URL: https://github.com/apache/spark/pull/32701#issuecomment-851608498 Thank you! @dongjoon-hyun @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [spark] SparkQA commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
SparkQA commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851603246 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43639/ -- This is an automated message from the A

[GitHub] [spark] cloud-fan edited a comment on pull request #32704: [SPARK-35567][SQL] Fix: Explain cost is not showing statistics for all the nodes

2021-05-31 Thread GitBox
cloud-fan edited a comment on pull request #32704: URL: https://github.com/apache/spark/pull/32704#issuecomment-851597160 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan closed pull request #32704: [SPARK-35567][SQL] Fix: Explain cost is not showing statistics for all the nodes

2021-05-31 Thread GitBox
cloud-fan closed pull request #32704: URL: https://github.com/apache/spark/pull/32704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [spark] cloud-fan commented on pull request #32704: [SPARK-35567][SQL] Fix: Explain cost is not showing statistics for all the nodes

2021-05-31 Thread GitBox
cloud-fan commented on pull request #32704: URL: https://github.com/apache/spark/pull/32704#issuecomment-851597160 thanks, merging to master/3.1! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] cloud-fan commented on a change in pull request #32602: [SPARK-35455][SQL] Unify empty relation optimization between normal and AQE optimizer

2021-05-31 Thread GitBox
cloud-fan commented on a change in pull request #32602: URL: https://github.com/apache/spark/pull/32602#discussion_r642596841 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEOptimizer.scala ## @@ -27,7 +28,9 @@ import org.apache.spark.util.Util

[GitHub] [spark] SparkQA commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
SparkQA commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851590580 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43639/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In/InSet predicate

2021-05-31 Thread GitBox
cloud-fan commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r642581845 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -121,6 +131,77 @@ object Unw

[GitHub] [spark] cloud-fan commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In/InSet predicate

2021-05-31 Thread GitBox
cloud-fan commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r642580843 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -121,6 +131,77 @@ object Unw

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851575611 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139113/ -

[GitHub] [spark] cloud-fan commented on a change in pull request #32488: [SPARK-35316][SQL] UnwrapCastInBinaryComparison support In/InSet predicate

2021-05-31 Thread GitBox
cloud-fan commented on a change in pull request #32488: URL: https://github.com/apache/spark/pull/32488#discussion_r642579960 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -121,6 +131,77 @@ object Unw

[GitHub] [spark] AmplabJenkins commented on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851575611 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139113/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851436903 **[Test build #139113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139113/testReport)** for PR 32558 at commit [`361ed49`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
SparkQA commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851574524 **[Test build #139113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139113/testReport)** for PR 32558 at commit [`361ed49`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
SparkQA commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851571920 **[Test build #139119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139119/testReport)** for PR 32716 at commit [`baf9690`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851570866 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139098/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851571163 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139111/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32700: [SPARK-35558] Optimizes for multi-quantile retrieval

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32700: URL: https://github.com/apache/spark/pull/32700#issuecomment-851570868 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43638/

[GitHub] [spark] AmplabJenkins commented on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851571163 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139111/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851549644 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139110/ -

[GitHub] [spark] AmplabJenkins commented on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851570866 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139098/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32700: [SPARK-35558] Optimizes for multi-quantile retrieval

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32700: URL: https://github.com/apache/spark/pull/32700#issuecomment-851570868 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43638/ -- T

[GitHub] [spark] SparkQA removed a comment on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851413527 **[Test build #139111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139111/testReport)** for PR 32712 at commit [`6716d54`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
SparkQA commented on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851570104 **[Test build #139111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139111/testReport)** for PR 32712 at commit [`6716d54`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851247187 **[Test build #139098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139098/testReport)** for PR 32558 at commit [`c743739`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
SparkQA commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851557465 **[Test build #139098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139098/testReport)** for PR 32558 at commit [`c743739`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32700: [SPARK-35558] Optimizes for multi-quantile retrieval

2021-05-31 Thread GitBox
SparkQA commented on pull request #32700: URL: https://github.com/apache/spark/pull/32700#issuecomment-851557044 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43638/ -- This is an automated message from the A

[GitHub] [spark] cloud-fan commented on a change in pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
cloud-fan commented on a change in pull request #32716: URL: https://github.com/apache/spark/pull/32716#discussion_r642559066 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala ## @@ -558,6 +558,53 @@ class CodeGenerat

[GitHub] [spark] cloud-fan commented on pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
cloud-fan commented on pull request #32716: URL: https://github.com/apache/spark/pull/32716#issuecomment-851554841 cc @maropu @kiszk @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan opened a new pull request #32716: [SPARK-35578][SQL][TEST] Add a test case for a bug in janino

2021-05-31 Thread GitBox
cloud-fan opened a new pull request #32716: URL: https://github.com/apache/spark/pull/32716 ### What changes were proposed in this pull request? This PR adds a unit test to show a bug in the latest janino version which fails to compile valid Java code. Unfortunately, I can't

[GitHub] [spark] AmplabJenkins commented on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851549644 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139110/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851406618 **[Test build #139110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139110/testReport)** for PR 32712 at commit [`a691720`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32712: [SPARK-35576][SQL] Redact the sensitive info in the result of Set command

2021-05-31 Thread GitBox
SparkQA commented on pull request #32712: URL: https://github.com/apache/spark/pull/32712#issuecomment-851548409 **[Test build #139110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139110/testReport)** for PR 32712 at commit [`a691720`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851539680 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139115/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32709: URL: https://github.com/apache/spark/pull/32709#issuecomment-851539682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32710: [SPARK-35574][BUILD] Add a compile arg to turn compilation warnings related to `procedure syntax` to compilation errors in Scal

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32710: URL: https://github.com/apache/spark/pull/32710#issuecomment-851539678 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139112/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32715: [SPARK-35577][TESTS] Allow to log container output for docker integration tests

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32715: URL: https://github.com/apache/spark/pull/32715#issuecomment-851539683 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43634/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851539684 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43633/

[GitHub] [spark] AmplabJenkins commented on pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32558: URL: https://github.com/apache/spark/pull/32558#issuecomment-851539684 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43633/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32715: [SPARK-35577][TESTS] Allow to log container output for docker integration tests

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32715: URL: https://github.com/apache/spark/pull/32715#issuecomment-851539683 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43634/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32709: URL: https://github.com/apache/spark/pull/32709#issuecomment-851539686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins commented on pull request #32710: [SPARK-35574][BUILD] Add a compile arg to turn compilation warnings related to `procedure syntax` to compilation errors in Scala 2.13

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32710: URL: https://github.com/apache/spark/pull/32710#issuecomment-851539678 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139112/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
AmplabJenkins commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851539680 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139115/ -- This

[GitHub] [spark] SparkQA commented on pull request #32700: [SPARK-35558] Optimizes for multi-quantile retrieval

2021-05-31 Thread GitBox
SparkQA commented on pull request #32700: URL: https://github.com/apache/spark/pull/32700#issuecomment-851539136 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43638/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
SparkQA commented on pull request #32709: URL: https://github.com/apache/spark/pull/32709#issuecomment-851538106 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43637/ -- This

[GitHub] [spark] ivoson commented on pull request #32713: [SPARK-35411][SQL][FOLLOWUP] Handle Currying Product while serializing TreeNode to JSON

2021-05-31 Thread GitBox
ivoson commented on pull request #32713: URL: https://github.com/apache/spark/pull/32713#issuecomment-851538084 Thanks for reviewing. @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] gengliangwang commented on a change in pull request #32686: [SPARK-35544][SQL] Add tree pattern pruning to Analyzer rules

2021-05-31 Thread GitBox
gengliangwang commented on a change in pull request #32686: URL: https://github.com/apache/spark/pull/32686#discussion_r642492873 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -423,7 +424,9 @@ class Analyzer(override val

[GitHub] [spark] hvanhovell commented on pull request #32686: [SPARK-35544][SQL] Add tree pattern pruning to Analyzer rules

2021-05-31 Thread GitBox
hvanhovell commented on pull request #32686: URL: https://github.com/apache/spark/pull/32686#issuecomment-851535158 One small ergonomic comment. I would be great if we can create some shorthand for the function closures. I would probably make the in individual value be matcher for itself (

[GitHub] [spark] SparkQA removed a comment on pull request #32710: [SPARK-35574][BUILD] Add a compile arg to turn compilation warnings related to `procedure syntax` to compilation errors in Scala 2.13

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32710: URL: https://github.com/apache/spark/pull/32710#issuecomment-851436763 **[Test build #139112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139112/testReport)** for PR 32710 at commit [`841afd1`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32709: URL: https://github.com/apache/spark/pull/32709#issuecomment-851510697 **[Test build #139117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139117/testReport)** for PR 32709 at commit [`97f3c0e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32710: [SPARK-35574][BUILD] Add a compile arg to turn compilation warnings related to `procedure syntax` to compilation errors in Scala 2.13

2021-05-31 Thread GitBox
SparkQA commented on pull request #32710: URL: https://github.com/apache/spark/pull/32710#issuecomment-851531226 **[Test build #139112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139112/testReport)** for PR 32710 at commit [`841afd1`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32709: [SPARK-35573][R][TESTS] Make SparkR tests pass with R 4.1+

2021-05-31 Thread GitBox
SparkQA commented on pull request #32709: URL: https://github.com/apache/spark/pull/32709#issuecomment-851530788 **[Test build #139117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139117/testReport)** for PR 32709 at commit [`97f3c0e`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA removed a comment on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851470598 **[Test build #139115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139115/testReport)** for PR 32714 at commit [`193eeef`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32714: [WIP][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
SparkQA commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851529568 **[Test build #139115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139115/testReport)** for PR 32714 at commit [`193eeef`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32715: [SPARK-35577][TESTS] Allow to log container output for docker integration tests

2021-05-31 Thread GitBox
SparkQA commented on pull request #32715: URL: https://github.com/apache/spark/pull/32715#issuecomment-851525327 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43634/ -- This is an automated message from the A

<    1   2   3   4   5   6   >