[GitHub] [spark] SparkQA commented on pull request #32742: [SPARK-35608][SQL] Support AQE optimizer side transformUpWithPruning

2021-06-15 Thread GitBox
SparkQA commented on pull request #32742: URL: https://github.com/apache/spark/pull/32742#issuecomment-861375276 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44334/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32742: [SPARK-35608][SQL] Support AQE optimizer side transformUpWithPruning

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32742: URL: https://github.com/apache/spark/pull/32742#issuecomment-861375308 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44334/

[GitHub] [spark] dgd-contributor commented on pull request #32916: [WIP][SPARK-35064][SQL] Group error in spark-catalyst

2021-06-15 Thread GitBox
dgd-contributor commented on pull request #32916: URL: https://github.com/apache/spark/pull/32916#issuecomment-861384645 > We no need to group assert-like error like `IllegalArgumentException` or `IllegalStateException`. I found there are many this kind of error in QueryExecutionError.sc

[GitHub] [spark] dgd-contributor commented on pull request #32916: [WIP][SPARK-35064][SQL] Group error in spark-catalyst

2021-06-15 Thread GitBox
dgd-contributor commented on pull request #32916: URL: https://github.com/apache/spark/pull/32916#issuecomment-861385361 > @dgd-contributor Do you check all the `Exception` in package `sql/catalyst/src/main/scala/org/apache/spark/sql` ? yes, I'm working on checking file by file in th

[GitHub] [spark] SparkQA commented on pull request #32909: [WIP][SPARK-35680][SQL] Add fields to `YearMonthIntervalType`

2021-06-15 Thread GitBox
SparkQA commented on pull request #32909: URL: https://github.com/apache/spark/pull/32909#issuecomment-861386227 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44331/ -- This is an automated message from the A

[GitHub] [spark] dgd-contributor edited a comment on pull request #32916: [WIP][SPARK-35064][SQL] Group error in spark-catalyst

2021-06-15 Thread GitBox
dgd-contributor edited a comment on pull request #32916: URL: https://github.com/apache/spark/pull/32916#issuecomment-861384645 > We no need to group assert-like error like `IllegalArgumentException` or `IllegalStateException`. I found there are many this kind of error in QueryExecut

[GitHub] [spark] SparkQA commented on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
SparkQA commented on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861390217 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44333/ -- This is an automated message from the A

[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

2021-06-15 Thread GitBox
cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r651669404 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -73,7 +73,9 @@ case class HashAggregateExe

[GitHub] [spark] SparkQA commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
SparkQA commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861396144 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44332/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps and make `isnull` method data-type-based

2021-06-15 Thread GitBox
SparkQA commented on pull request #32821: URL: https://github.com/apache/spark/pull/32821#issuecomment-861398379 **[Test build #139801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139801/testReport)** for PR 32821 at commit [`bca1d84`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps and make `isnull` method data-type-based

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32821: URL: https://github.com/apache/spark/pull/32821#issuecomment-861279903 **[Test build #139801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139801/testReport)** for PR 32821 at commit [`bca1d84`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
SparkQA commented on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861401001 **[Test build #139806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139806/testReport)** for PR 32845 at commit [`f3ec9a3`](https://github.co

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
AngersZh commented on a change in pull request #32645: URL: https://github.com/apache/spark/pull/32645#discussion_r651678916 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala ## @@ -345,6 +346,66 @@ case class Mak

[GitHub] [spark] SparkQA removed a comment on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861321691 **[Test build #139806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139806/testReport)** for PR 32845 at commit [`f3ec9a3`](https://gi

[GitHub] [spark] peter-toth commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

2021-06-15 Thread GitBox
peter-toth commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r651679641 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -73,7 +73,9 @@ case class HashAggregateEx

[GitHub] [spark] AmplabJenkins commented on pull request #32909: [WIP][SPARK-35680][SQL] Add fields to `YearMonthIntervalType`

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32909: URL: https://github.com/apache/spark/pull/32909#issuecomment-861401815 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44331/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps and make `isnull` method data-type-based

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32821: URL: https://github.com/apache/spark/pull/32821#issuecomment-861401818 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139801/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861401821 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44332/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861401816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861401816 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44333/

[GitHub] [spark] SparkQA commented on pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

2021-06-15 Thread GitBox
SparkQA commented on pull request #32470: URL: https://github.com/apache/spark/pull/32470#issuecomment-861402281 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44335/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32909: [WIP][SPARK-35680][SQL] Add fields to `YearMonthIntervalType`

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32909: URL: https://github.com/apache/spark/pull/32909#issuecomment-861401815 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44331/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861401821 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44332/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps and make `isnull` method data-type-based

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32821: URL: https://github.com/apache/spark/pull/32821#issuecomment-861401818 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139801/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861401900 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139806/ -

[GitHub] [spark] HyukjinKwon commented on pull request #32904: [SPARK-33122][FOLLOWUP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861403736 from a cursory look, the test failures look related since you're fixing aggregation and test failure is from state store in SS -- This is an automated message from the Apa

[GitHub] [spark] SparkQA commented on pull request #32901: [SPARK-35753][R][INFRA] Increase stacksize in Maven for AppVeyor build

2021-06-15 Thread GitBox
SparkQA commented on pull request #32901: URL: https://github.com/apache/spark/pull/32901#issuecomment-861403818 **[Test build #139809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139809/testReport)** for PR 32901 at commit [`2e5d1be`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #32904: [SPARK-33122][FOLLOWUP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861404131 can you rerun the GA tests? https://github.com/tanelk/spark/actions/runs/935534402 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861404157 **[Test build #139810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139810/testReport)** for PR 32645 at commit [`677960e`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
SparkQA commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861408675 **[Test build #139805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139805/testReport)** for PR 32881 at commit [`65346ab`](https://github.co

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOWUP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651686837 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861409520 **[Test build #139811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139811/testReport)** for PR 32645 at commit [`108d79e`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861409646 @tanelk, the changes look good but I think it's better to file a separate JIRA. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861409816 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139805/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861321549 **[Test build #139805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139805/testReport)** for PR 32881 at commit [`65346ab`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-861409816 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139805/ -

[GitHub] [spark] tanelk commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
tanelk commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651689815 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveRedund

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651690380 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651690380 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651690380 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] HyukjinKwon commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32912: URL: https://github.com/apache/spark/pull/32912#issuecomment-861413128 cc @srowen too fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861413425 **[Test build #139811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139811/testReport)** for PR 32645 at commit [`108d79e`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861409520 **[Test build #139811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139811/testReport)** for PR 32645 at commit [`108d79e`](https://gi

[GitHub] [spark] HyukjinKwon commented on pull request #32917: [SPARK-35758][DOCS] Update the document about building Spark with Hadoop for Hadoop 2.x and 3.x

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32917: URL: https://github.com/apache/spark/pull/32917#issuecomment-861414042 Merged to master and branch-3.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] HyukjinKwon closed pull request #32917: [SPARK-35758][DOCS] Update the document about building Spark with Hadoop for Hadoop 2.x and 3.x

2021-06-15 Thread GitBox
HyukjinKwon closed pull request #32917: URL: https://github.com/apache/spark/pull/32917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [spark] tanelk commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
tanelk commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651693288 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveRedund

[GitHub] [spark] tanelk commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
tanelk commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651693288 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveRedund

[GitHub] [spark] HyukjinKwon commented on pull request #32914: [SPARK-35763][SS] Add a new copy method to StateStoreCustomMetric

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32914: URL: https://github.com/apache/spark/pull/32914#issuecomment-861416640 cc @HeartSaVioR @xuanyuanking FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651696949 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651698103 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] beliefer commented on pull request #32916: [WIP][SPARK-35064][SQL] Group error in spark-catalyst

2021-06-15 Thread GitBox
beliefer commented on pull request #32916: URL: https://github.com/apache/spark/pull/32916#issuecomment-861421431 > > We no need to group assert-like error like `IllegalArgumentException` or `IllegalStateException`. > > I found there are many this kind of error in QueryExecutionError

[GitHub] [spark] zinking commented on a change in pull request #32914: [SPARK-35763][SS] Add a new copy method to StateStoreCustomMetric

2021-06-15 Thread GitBox
zinking commented on a change in pull request #32914: URL: https://github.com/apache/spark/pull/32914#discussion_r651701263 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala ## @@ -319,15 +319,7 @@ class Sy

[GitHub] [spark] tanelk commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
tanelk commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651701796 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveRedund

[GitHub] [spark] tanelk commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
tanelk commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651701796 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveRedund

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651702739 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32904: [SPARK-33122][FOLLOW-UP][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #32904: URL: https://github.com/apache/spark/pull/32904#discussion_r651702821 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala ## @@ -67,4 +67,8 @@ object RemoveR

[GitHub] [spark] SparkQA commented on pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

2021-06-15 Thread GitBox
SparkQA commented on pull request #32470: URL: https://github.com/apache/spark/pull/32470#issuecomment-861423115 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44335/ -- This is an automated message from the A

[GitHub] [spark] zinking commented on pull request #32911: [SPARK-35760][SQL] Fix the max rows check for broadcast exchange

2021-06-15 Thread GitBox
zinking commented on pull request #32911: URL: https://github.com/apache/spark/pull/32911#issuecomment-861425261 tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32901: [SPARK-35753][R][INFRA] Increase stacksize in Maven for AppVeyor build

2021-06-15 Thread GitBox
SparkQA commented on pull request #32901: URL: https://github.com/apache/spark/pull/32901#issuecomment-861427005 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44336/ -- This

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861429835 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44337/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861431983 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44338/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
SparkQA commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861435726 **[Test build #139799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139799/testReport)** for PR 32904 at commit [`3f0cdae`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861238629 **[Test build #139799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139799/testReport)** for PR 32904 at commit [`3f0cdae`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861437556 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139799/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32901: [SPARK-35753][R][INFRA] Increase stacksize in Maven for AppVeyor build

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32901: URL: https://github.com/apache/spark/pull/32901#issuecomment-861437557 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44336/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32470: URL: https://github.com/apache/spark/pull/32470#issuecomment-861437561 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44335/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861437558 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139811/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32470: URL: https://github.com/apache/spark/pull/32470#issuecomment-861437561 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44335/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32901: [SPARK-35753][R][INFRA] Increase stacksize in Maven for AppVeyor build

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32901: URL: https://github.com/apache/spark/pull/32901#issuecomment-861437557 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44336/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861437558 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139811/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861437556 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139799/ -

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861443706 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44339/ -- This is an automated message from the Apache

[GitHub] [spark] Pverheijen commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2021-06-15 Thread GitBox
Pverheijen commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-861449072 Can this be pulled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861450661 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44337/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861450698 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44337/ -- T

[GitHub] [spark] srowen commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs

2021-06-15 Thread GitBox
srowen commented on pull request #32912: URL: https://github.com/apache/spark/pull/32912#issuecomment-861451097 So hadoop-2.7 still works because it will pull it in transitively via hadoop-2.7 dependencies? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] vkorukanti commented on a change in pull request #32914: [SPARK-35763][SS] Add a new copy method to StateStoreCustomMetric

2021-06-15 Thread GitBox
vkorukanti commented on a change in pull request #32914: URL: https://github.com/apache/spark/pull/32914#discussion_r651734966 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala ## @@ -319,15 +319,7 @@ class

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861452725 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44338/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861453755 **[Test build #139802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139802/testReport)** for PR 32645 at commit [`06c908b`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861280008 **[Test build #139802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139802/testReport)** for PR 32645 at commit [`06c908b`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861459111 **[Test build #139810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139810/testReport)** for PR 32645 at commit [`677960e`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861404157 **[Test build #139810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139810/testReport)** for PR 32645 at commit [`677960e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
SparkQA commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861468757 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44339/ -- This is an automated message from the A

[GitHub] [spark] tanelk commented on pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
tanelk commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861473080 All GA tests also passed on a rerun: https://github.com/tanelk/spark/actions/runs/935534402 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [spark] AmplabJenkins commented on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861476537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins commented on pull request #32915: [SPARK-35764][SQL] Assign pretty names to TimestampWithoutTZType

2021-06-15 Thread GitBox
AmplabJenkins commented on pull request #32915: URL: https://github.com/apache/spark/pull/32915#issuecomment-861476536 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139800/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32915: [SPARK-35764][SQL] Assign pretty names to TimestampWithoutTZType

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32915: URL: https://github.com/apache/spark/pull/32915#issuecomment-861476536 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139800/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32645: [SPARK-35129][SQL] Construct year-month interval column from integral fields

2021-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #32645: URL: https://github.com/apache/spark/pull/32645#issuecomment-861450698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] cloud-fan commented on pull request #32899: [SPARK-35652][SQL] joinWith on two table generated from same one

2021-06-15 Thread GitBox
cloud-fan commented on pull request #32899: URL: https://github.com/apache/spark/pull/32899#issuecomment-861487513 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32899: [SPARK-35652][SQL] joinWith on two table generated from same one

2021-06-15 Thread GitBox
SparkQA commented on pull request #32899: URL: https://github.com/apache/spark/pull/32899#issuecomment-861488447 **[Test build #139812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139812/testReport)** for PR 32899 at commit [`b5c7706`](https://github.com

[GitHub] [spark] sarutak commented on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
sarutak commented on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861489278 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [spark] SparkQA removed a comment on pull request #32909: [WIP][SPARK-35680][SQL] Add fields to `YearMonthIntervalType`

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32909: URL: https://github.com/apache/spark/pull/32909#issuecomment-861321432 **[Test build #139804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139804/testReport)** for PR 32909 at commit [`efe001c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32909: [WIP][SPARK-35680][SQL] Add fields to `YearMonthIntervalType`

2021-06-15 Thread GitBox
SparkQA commented on pull request #32909: URL: https://github.com/apache/spark/pull/32909#issuecomment-861490894 **[Test build #139804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139804/testReport)** for PR 32909 at commit [`efe001c`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32845: [SPARK-35691][CORE] addFile/addJar/addDirectory should put CanonicalFile

2021-06-15 Thread GitBox
SparkQA commented on pull request #32845: URL: https://github.com/apache/spark/pull/32845#issuecomment-861491653 **[Test build #139813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139813/testReport)** for PR 32845 at commit [`f3ec9a3`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32742: [SPARK-35608][SQL] Support AQE optimizer side transformUpWithPruning

2021-06-15 Thread GitBox
SparkQA commented on pull request #32742: URL: https://github.com/apache/spark/pull/32742#issuecomment-861493941 **[Test build #139807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139807/testReport)** for PR 32742 at commit [`1a770bb`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32742: [SPARK-35608][SQL] Support AQE optimizer side transformUpWithPruning

2021-06-15 Thread GitBox
SparkQA removed a comment on pull request #32742: URL: https://github.com/apache/spark/pull/32742#issuecomment-861321820 **[Test build #139807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139807/testReport)** for PR 32742 at commit [`1a770bb`](https://gi

[GitHub] [spark] HyukjinKwon commented on pull request #32901: [SPARK-35753][R][INFRA] Increase stacksize in Maven for AppVeyor build

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32901: URL: https://github.com/apache/spark/pull/32901#issuecomment-861494832 I'm gonna drop this PR for now. Changing stacksize apparently doesn't affect the build being flaky. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] HyukjinKwon closed pull request #32901: [SPARK-35753][R][INFRA] Increase stacksize in Maven for AppVeyor build

2021-06-15 Thread GitBox
HyukjinKwon closed pull request #32901: URL: https://github.com/apache/spark/pull/32901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [spark] HyukjinKwon commented on pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon commented on pull request #32904: URL: https://github.com/apache/spark/pull/32904#issuecomment-861495353 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] HyukjinKwon closed pull request #32904: [SPARK-35765][SQL] Distinct aggs are not duplicate sensitive

2021-06-15 Thread GitBox
HyukjinKwon closed pull request #32904: URL: https://github.com/apache/spark/pull/32904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

<    1   2   3   4   5   6   7   >