[GitHub] [spark] SparkQA commented on pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
SparkQA commented on pull request #32960: URL: https://github.com/apache/spark/pull/32960#issuecomment-877574759 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45386/ -- This is an automated message from the Apache

[GitHub] [spark] sigmod commented on a change in pull request #33170: [SPARK-35967][SQL] Update nullability based on column statistics

2021-07-09 Thread GitBox
sigmod commented on a change in pull request #33170: URL: https://github.com/apache/spark/pull/33170#discussion_r667294064 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala ## @@ -81,6 +81,14 @@ object LogicalRelation {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #32960: URL: https://github.com/apache/spark/pull/32960#issuecomment-877570945 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140875/

[GitHub] [spark] SparkQA removed a comment on pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #32960: URL: https://github.com/apache/spark/pull/32960#issuecomment-877569385 **[Test build #140875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140875/testReport)** for PR 32960 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #32960: URL: https://github.com/apache/spark/pull/32960#issuecomment-877570945 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140875/ -- This

[GitHub] [spark] SparkQA commented on pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
SparkQA commented on pull request #32960: URL: https://github.com/apache/spark/pull/32960#issuecomment-877570894 **[Test build #140875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140875/testReport)** for PR 32960 at commit

[GitHub] [spark] SparkQA commented on pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
SparkQA commented on pull request #32960: URL: https://github.com/apache/spark/pull/32960#issuecomment-877569385 **[Test build #140875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140875/testReport)** for PR 32960 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877568810 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140874/

[GitHub] [spark] AmplabJenkins commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877568810 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140874/ -- This

[GitHub] [spark] sarutak commented on pull request #33277: [SPARK-36068][BUILD][TEST] No tests in hadoop-cloud run unless hadoop-3.2 profile is activated explicitly

2021-07-09 Thread GitBox
sarutak commented on pull request #33277: URL: https://github.com/apache/spark/pull/33277#issuecomment-877566034 > I don't think any of the tests do anything useful until that 3.2 profile is in, so the fact they don't run isn't necessarily that important. hadoop-3.2 profile is

[GitHub] [spark] wangyum commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
wangyum commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877565938 Can we also update the nullability based on column statistics: https://github.com/apache/spark/pull/33170/files -- This is an automated message from the Apache Git Service.

[GitHub] [spark] SparkQA removed a comment on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877519007 **[Test build #140874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140874/testReport)** for PR 33284 at commit

[GitHub] [spark] SparkQA commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877565018 **[Test build #140874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140874/testReport)** for PR 33284 at commit

[GitHub] [spark] ulysses-you commented on a change in pull request #32960: [SPARK-35813][SQL][DOCS] Add new adaptive config into sql-performance-tuning docs

2021-07-09 Thread GitBox
ulysses-you commented on a change in pull request #32960: URL: https://github.com/apache/spark/pull/32960#discussion_r667287305 ## File path: docs/sql-performance-tuning.md ## @@ -273,7 +273,32 @@ This feature coalesces the post shuffle partitions based on the map output

[GitHub] [spark] ulysses-you commented on a change in pull request #33211: [SPARK-36014][K8S] Use uuid as app id in kubernetes client mode

2021-07-09 Thread GitBox
ulysses-you commented on a change in pull request #33211: URL: https://github.com/apache/spark/pull/33211#discussion_r667287003 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala ## @@

[GitHub] [spark] ulysses-you commented on a change in pull request #33211: [SPARK-36014][K8S] Use uuid as app id in kubernetes client mode

2021-07-09 Thread GitBox
ulysses-you commented on a change in pull request #33211: URL: https://github.com/apache/spark/pull/33211#discussion_r667286922 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala ## @@ -225,6 +225,9 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877547678 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140872/

[GitHub] [spark] AmplabJenkins commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877547678 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140872/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877503672 **[Test build #140872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140872/testReport)** for PR 33286 at commit

[GitHub] [spark] SparkQA commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
SparkQA commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877543641 **[Test build #140872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140872/testReport)** for PR 33286 at commit

[GitHub] [spark] kiszk commented on pull request #33260: [SPARK-36047][CORE] Replace the handwriting compare methods with static compare methods in Java code

2021-07-09 Thread GitBox
kiszk commented on pull request #33260: URL: https://github.com/apache/spark/pull/33260#issuecomment-877538349 @rednaxelafx Good points (@_@) For the 1st item, the leaf method (in particular, `compare`) will be executed frequently. So, we could ignore it. For the 2nd item, it is a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877532188 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45385/

[GitHub] [spark] SparkQA commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877532179 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45385/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877532188 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45385/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877529872 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140871/

[GitHub] [spark] AmplabJenkins commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877529872 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140871/ -- This

[GitHub] [spark] SparkQA commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877526647 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45385/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877484072 **[Test build #140871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140871/testReport)** for PR 33251 at commit

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877522844 **[Test build #140871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140871/testReport)** for PR 33251 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877521094 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45384/

[GitHub] [spark] AmplabJenkins commented on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877521094 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45384/ --

[GitHub] [spark] SparkQA commented on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877521086 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45384/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877519007 **[Test build #140874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140874/testReport)** for PR 33284 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877518308 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140873/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877518307 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45383/

[GitHub] [spark] AmplabJenkins commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877518307 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45383/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877518308 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140873/ -- This

[GitHub] [spark] SparkQA commented on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877513592 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45384/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
SparkQA commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877512836 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45383/ --

[GitHub] [spark] sunchao commented on pull request #33276: [SPARK-36067][BUILD][TEST][YARN] YarnClusterSuite fails due to NoClassDefFoundError unless hadoop-3.2 profile is activated explicitly

2021-07-09 Thread GitBox
sunchao commented on pull request #33276: URL: https://github.com/apache/spark/pull/33276#issuecomment-877512333 Yeah IMHO it looks be OK since `hadoop-3.2` is implicitly configured as the default profile unless `hadoop-2.7` is explicitly specified right now, so it's probably good to make

[GitHub] [spark] ekoifman commented on a change in pull request #32872: [SPARK-35639][SQL] Make hasCoalescedPartition return true if something was actually coalesced

2021-07-09 Thread GitBox
ekoifman commented on a change in pull request #32872: URL: https://github.com/apache/spark/pull/32872#discussion_r667255858 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1582,7 +1582,7 @@ class

[GitHub] [spark] SparkQA removed a comment on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877503704 **[Test build #140873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140873/testReport)** for PR 33285 at commit

[GitHub] [spark] SparkQA commented on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877508937 **[Test build #140873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140873/testReport)** for PR 33285 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877507289 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45381/

[GitHub] [spark] AmplabJenkins commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877507289 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45381/ --

[GitHub] [spark] SparkQA commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
SparkQA commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877507277 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45381/ -- This is an automated message from the

[GitHub] [spark] sigmod commented on pull request #33286: [SPARK-36079][SQL] Null-based filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
sigmod commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877507170 LGTM. @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877506986 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45382/

[GitHub] [spark] AmplabJenkins commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877506986 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45382/ --

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877506976 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45382/ -- This is an automated message from the

[GitHub] [spark] sunchao commented on pull request #33271: [SPARK-36056][SQL] Combine readBatch and readIntegers in VectorizedRleValuesReader

2021-07-09 Thread GitBox
sunchao commented on pull request #33271: URL: https://github.com/apache/spark/pull/33271#issuecomment-877505474 cc @viirya @cloud-fan @dongjoon-hyun could you take a look? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #33286: [SPARK-36079][SQL] Filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
SparkQA commented on pull request #33286: URL: https://github.com/apache/spark/pull/33286#issuecomment-877503672 **[Test build #140872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140872/testReport)** for PR 33286 at commit

[GitHub] [spark] SparkQA commented on pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33285: URL: https://github.com/apache/spark/pull/33285#issuecomment-877503704 **[Test build #140873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140873/testReport)** for PR 33285 at commit

[GitHub] [spark] ueshin commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
ueshin commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877503299 I fixed some issues, could you take another look please? @HyukjinKwon @xinrong-databricks @Yikun -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877502760 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140870/

[GitHub] [spark] AmplabJenkins commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877502760 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140870/ -- This

[GitHub] [spark] srowen commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
srowen commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667248983 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java ## @@ -27,12 +27,10 @@ */ public interface

[GitHub] [spark] karenfeng opened a new pull request #33286: [SPARK-36079][SQL] Filter estimate should always be in the range [0, 1]

2021-07-09 Thread GitBox
karenfeng opened a new pull request #33286: URL: https://github.com/apache/spark/pull/33286 ### What changes were proposed in this pull request? Forces the selectivity estimate for null-based filters to be in the range `[0,1]`. ### Why are the changes needed? I noticed

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877497079 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45382/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
SparkQA commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877497038 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45381/ -- This is an automated message from the Apache

[GitHub] [spark] xinrong-databricks opened a new pull request #33285: [SPARK-36003][PYTHON] Implement unary operator `invert` of integral ps.Series/Index.

2021-07-09 Thread GitBox
xinrong-databricks opened a new pull request #33285: URL: https://github.com/apache/spark/pull/33285 ### What changes were proposed in this pull request? Implement unary operator `invert` of integral ps.Series/Index. ### Why are the changes needed? Currently, unary operator

[GitHub] [spark] SparkQA removed a comment on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877483996 **[Test build #140870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140870/testReport)** for PR 33275 at commit

[GitHub] [spark] SparkQA commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
SparkQA commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877492906 **[Test build #140870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140870/testReport)** for PR 33275 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-877489514 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140863/

[GitHub] [spark] AmplabJenkins commented on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-877489514 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140863/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-877368863 **[Test build #140863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140863/testReport)** for PR 32949 at commit

[GitHub] [spark] SparkQA commented on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-09 Thread GitBox
SparkQA commented on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-877488853 **[Test build #140863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140863/testReport)** for PR 32949 at commit

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877484072 **[Test build #140871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140871/testReport)** for PR 33251 at commit

[GitHub] [spark] SparkQA commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
SparkQA commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877483996 **[Test build #140870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140870/testReport)** for PR 33275 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877482827 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45380/

[GitHub] [spark] AmplabJenkins commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877482827 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45380/ --

[GitHub] [spark] dtarima commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
dtarima commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667233077 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java ## @@ -27,12 +27,10 @@ */ public interface

[GitHub] [spark] dtarima commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
dtarima commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667232206 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java ## @@ -26,22 +26,14 @@ * which ensures data is

[GitHub] [spark] dtarima commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
dtarima commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667227483 ## File path: common/network-common/pom.xml ## @@ -22,7 +22,7 @@ org.apache.spark spark-parent_2.12 -3.3.0-SNAPSHOT +spark-755999

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877473821 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45380/ --

[GitHub] [spark] rdblue commented on pull request #32875: [WIP][SPARK-35703] Remove HashClusteredDistribution and relax constraint for bucket join

2021-07-09 Thread GitBox
rdblue commented on pull request #32875: URL: https://github.com/apache/spark/pull/32875#issuecomment-877470113 @sunchao, do both changes in this PR need to be done together? If not, then you may want to separate them into different PRs. If they are tied together, then noting why this

[GitHub] [spark] dtarima commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
dtarima commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667220922 ## File path: common/network-common/pom.xml ## @@ -22,7 +22,7 @@ org.apache.spark spark-parent_2.12 -3.3.0-SNAPSHOT +spark-755999

[GitHub] [spark] AmplabJenkins commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-87748 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45379/ --

[GitHub] [spark] SparkQA commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-09 Thread GitBox
SparkQA commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-877466659 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45379/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877465146 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140869/

[GitHub] [spark] SparkQA removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877459760 **[Test build #140869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140869/testReport)** for PR 33251 at commit

[GitHub] [spark] srowen commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
srowen commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667219025 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java ## @@ -26,22 +26,14 @@ * which ensures data is

[GitHub] [spark] AmplabJenkins commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877465146 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140869/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877464451 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140864/

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877465105 **[Test build #140869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140869/testReport)** for PR 33251 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877375220 **[Test build #140864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140864/testReport)** for PR 33284 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877464451 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140864/ -- This

[GitHub] [spark] SparkQA commented on pull request #33284: [SPARK-36063][SQL] Optimize OneRowRelation subqueries

2021-07-09 Thread GitBox
SparkQA commented on pull request #33284: URL: https://github.com/apache/spark/pull/33284#issuecomment-877464107 **[Test build #140864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140864/testReport)** for PR 33284 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-876571225 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] SparkQA commented on pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
SparkQA commented on pull request #33251: URL: https://github.com/apache/spark/pull/33251#issuecomment-877459760 **[Test build #140869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140869/testReport)** for PR 33251 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33261: [SPARK-35334][K8S] Make Spark more resilient to intermittent K8s flakiness

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33261: URL: https://github.com/apache/spark/pull/33261#issuecomment-877458467 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45377/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877458466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33263: [SPARK-35027][CORE] Close the inputStream in FileAppender when writin…

2021-07-09 Thread GitBox
AmplabJenkins removed a comment on pull request #33263: URL: https://github.com/apache/spark/pull/33263#issuecomment-877458468 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140865/

[GitHub] [spark] AmplabJenkins commented on pull request #33263: [SPARK-35027][CORE] Close the inputStream in FileAppender when writin…

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33263: URL: https://github.com/apache/spark/pull/33263#issuecomment-877458468 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140865/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33261: [SPARK-35334][K8S] Make Spark more resilient to intermittent K8s flakiness

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33261: URL: https://github.com/apache/spark/pull/33261#issuecomment-877458467 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45377/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
AmplabJenkins commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877458466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] dtarima commented on a change in pull request #33251: [SPARK-36036] [CORE] Fix cleanup of DownloadFile resources.

2021-07-09 Thread GitBox
dtarima commented on a change in pull request #33251: URL: https://github.com/apache/spark/pull/33251#discussion_r667207892 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -2010,10 +2012,12 @@ private[spark] object BlockManager {

[GitHub] [spark] SparkQA commented on pull request #33275: [SPARK-36064][PYTHON] Manage InternalField more in DataTypeOps

2021-07-09 Thread GitBox
SparkQA commented on pull request #33275: URL: https://github.com/apache/spark/pull/33275#issuecomment-877452140 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45378/ --

[GitHub] [spark] SparkQA commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-07-09 Thread GitBox
SparkQA commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-877452053 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45379/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #33263: [SPARK-35027][CORE] Close the inputStream in FileAppender when writin…

2021-07-09 Thread GitBox
SparkQA removed a comment on pull request #33263: URL: https://github.com/apache/spark/pull/33263#issuecomment-877375248 **[Test build #140865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140865/testReport)** for PR 33263 at commit

  1   2   3   4   5   >