[GitHub] [spark] HyukjinKwon opened a new pull request #33608: [SPARK-36379][SQL] Null at root level of a JSON array causes the parsing failure (w/ permissive mode)

2021-08-02 Thread GitBox
HyukjinKwon opened a new pull request #33608: URL: https://github.com/apache/spark/pull/33608 ### What changes were proposed in this pull request? This PR proposes to fail properly so JSON parser can proceed and parse the input with the permissive mode. Previously, we passed

[GitHub] [spark] HyukjinKwon commented on pull request #33608: [SPARK-36379][SQL] Null at root level of a JSON array causes the parsing failure (w/ permissive mode)

2021-08-02 Thread GitBox
HyukjinKwon commented on pull request #33608: URL: https://github.com/apache/spark/pull/33608#issuecomment-890784288 cc @MaxGekk and @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] LuciferYang commented on a change in pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
LuciferYang commented on a change in pull request #33556: URL: https://github.com/apache/spark/pull/33556#discussion_r680707160 ## File path: core/benchmarks/DiskBlockObjectWriterCloseMethodBenchmark-results.txt ## @@ -0,0 +1,48 @@

[GitHub] [spark] LuciferYang commented on a change in pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
LuciferYang commented on a change in pull request #33556: URL: https://github.com/apache/spark/pull/33556#discussion_r680707160 ## File path: core/benchmarks/DiskBlockObjectWriterCloseMethodBenchmark-results.txt ## @@ -0,0 +1,48 @@

[GitHub] [spark] LuciferYang commented on a change in pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
LuciferYang commented on a change in pull request #33556: URL: https://github.com/apache/spark/pull/33556#discussion_r680706523 ## File path: core/benchmarks/DiskBlockObjectWriterCloseMethodBenchmark-results.txt ## @@ -0,0 +1,48 @@

[GitHub] [spark] eejbyfeldt commented on pull request #33316: [WIP][SPARK-20384][SQL] Support value classes and always encoded as underlying type

2021-08-02 Thread GitBox
eejbyfeldt commented on pull request #33316: URL: https://github.com/apache/spark/pull/33316#issuecomment-890778829 Closing and hoping we can have: https://github.com/apache/spark/pull/33205 merged instead. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] eejbyfeldt closed pull request #33316: [WIP][SPARK-20384][SQL] Support value classes and always encoded as underlying type

2021-08-02 Thread GitBox
eejbyfeldt closed pull request #33316: URL: https://github.com/apache/spark/pull/33316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] LuciferYang commented on a change in pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
LuciferYang commented on a change in pull request #33556: URL: https://github.com/apache/spark/pull/33556#discussion_r680704249 ## File path: core/src/test/scala/org/apache/spark/storage/DiskBlockObjectWriterCloseMethodBenchmark.scala ## @@ -0,0 +1,158 @@ +/* + * Licensed to

[GitHub] [spark] LuciferYang commented on a change in pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
LuciferYang commented on a change in pull request #33556: URL: https://github.com/apache/spark/pull/33556#discussion_r680702762 ## File path: core/src/test/scala/org/apache/spark/storage/DiskBlockObjectWriterCloseMethodBenchmark.scala ## @@ -0,0 +1,158 @@ +/* + * Licensed to

[GitHub] [spark] LuciferYang commented on a change in pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
LuciferYang commented on a change in pull request #33556: URL: https://github.com/apache/spark/pull/33556#discussion_r680702762 ## File path: core/src/test/scala/org/apache/spark/storage/DiskBlockObjectWriterCloseMethodBenchmark.scala ## @@ -0,0 +1,158 @@ +/* + * Licensed to

[GitHub] [spark] SparkQA commented on pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-02 Thread GitBox
SparkQA commented on pull request #33556: URL: https://github.com/apache/spark/pull/33556#issuecomment-890774871 **[Test build #141946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141946/testReport)** for PR 33556 at commit

[GitHub] [spark] gengliangwang commented on a change in pull request #33607: [SPARK-36175][SQL][FOLLOWUP] Improve the comments for AvroDeserializer/AvroSerializer

2021-08-02 Thread GitBox
gengliangwang commented on a change in pull request #33607: URL: https://github.com/apache/spark/pull/33607#discussion_r680702128 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ## @@ -180,8 +180,8 @@ private[sql] class

[GitHub] [spark] gengliangwang commented on a change in pull request #33607: [SPARK-36175][SQL][FOLLOWUP] Improve the comments for AvroDeserializer/AvroSerializer

2021-08-02 Thread GitBox
gengliangwang commented on a change in pull request #33607: URL: https://github.com/apache/spark/pull/33607#discussion_r680700678 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala ## @@ -148,9 +148,9 @@ private[sql] class

[GitHub] [spark] SparkQA commented on pull request #33607: [SPARK-36175][SQL][FOLLOWUP] Improve the comments for AvroDeserializer/AvroSerializer

2021-08-02 Thread GitBox
SparkQA commented on pull request #33607: URL: https://github.com/apache/spark/pull/33607#issuecomment-890770491 **[Test build #141945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141945/testReport)** for PR 33607 at commit

[GitHub] [spark] beliefer commented on pull request #33607: [SPARK-36175][SQL][FOLLOWUP] Improve the comments for AvroDeserializer/AvroSerializer

2021-08-02 Thread GitBox
beliefer commented on pull request #33607: URL: https://github.com/apache/spark/pull/33607#issuecomment-890770051 ping @cloud-fan @gengliangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] beliefer opened a new pull request #33607: [SPARK-36175][SQL][FOLLOWUP] Improve the comments for AvroDeserializer/AvroSerializer

2021-08-02 Thread GitBox
beliefer opened a new pull request #33607: URL: https://github.com/apache/spark/pull/33607 ### What changes were proposed in this pull request? This PR follows up https://github.com/apache/spark/pull/33413 and just improve the comments for `AvroDeserializer`/`AvroSerializer`.

[GitHub] [spark] attilapiros commented on pull request #32793: [SPARK-35430][K8S] Switch on "PVs with local storage" integration test on Docker driver

2021-08-02 Thread GitBox
attilapiros commented on pull request #32793: URL: https://github.com/apache/spark/pull/32793#issuecomment-890769566 > thanks for pointing out this bit of the doc... i need to update it to reflect that use the docker (default) drivers now! On Linux. But on Mac because of the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890768577 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141939/

[GitHub] [spark] SparkQA removed a comment on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
SparkQA removed a comment on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890710848 **[Test build #141939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141939/testReport)** for PR 33583 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
AmplabJenkins commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890768577 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141939/ -- This

[GitHub] [spark] SparkQA commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
SparkQA commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890768213 **[Test build #141939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141939/testReport)** for PR 33583 at commit

[GitHub] [spark] SparkQA commented on pull request #33451: [SPARK-36206][CORE] Support shuffle data corruption diagnosis via shuffle checksum

2021-08-02 Thread GitBox
SparkQA commented on pull request #33451: URL: https://github.com/apache/spark/pull/33451#issuecomment-890767059 **[Test build #141944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141944/testReport)** for PR 33451 at commit

[GitHub] [spark] SparkQA commented on pull request #33588: [WIP][SPARK-36346][SQL] Support TimestampNTZ type in Orc file source

2021-08-02 Thread GitBox
SparkQA commented on pull request #33588: URL: https://github.com/apache/spark/pull/33588#issuecomment-890766894 **[Test build #141943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141943/testReport)** for PR 33588 at commit

[GitHub] [spark] SparkQA commented on pull request #33606: [SPARK-35815][SQL][FOLLOWUP] Add test considering the case spark.sql.legacy.interval.enabled is true

2021-08-02 Thread GitBox
SparkQA commented on pull request #33606: URL: https://github.com/apache/spark/pull/33606#issuecomment-890766862 **[Test build #141942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141942/testReport)** for PR 33606 at commit

[GitHub] [spark] sarutak commented on a change in pull request #33599: [SPARK-36371][SQL] Support raw string literal

2021-08-02 Thread GitBox
sarutak commented on a change in pull request #33599: URL: https://github.com/apache/spark/pull/33599#discussion_r680694174 ## File path: docs/sql-ref-literals.md ## @@ -47,6 +47,10 @@ A string literal is used to specify a character string value. To represent unicode

[GitHub] [spark] sarutak commented on a change in pull request #33599: [SPARK-36371][SQL] Support raw string literal

2021-08-02 Thread GitBox
sarutak commented on a change in pull request #33599: URL: https://github.com/apache/spark/pull/33599#discussion_r680694174 ## File path: docs/sql-ref-literals.md ## @@ -47,6 +47,10 @@ A string literal is used to specify a character string value. To represent unicode

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33544: [SPARK-34927][INFRA] Support TPCDSQueryBenchmark in Benchmarks

2021-08-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33544: URL: https://github.com/apache/spark/pull/33544#issuecomment-890765818 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141933/

[GitHub] [spark] AmplabJenkins commented on pull request #33544: [SPARK-34927][INFRA] Support TPCDSQueryBenchmark in Benchmarks

2021-08-02 Thread GitBox
AmplabJenkins commented on pull request #33544: URL: https://github.com/apache/spark/pull/33544#issuecomment-890765818 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141933/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33605: [SPARK-32923][FOLLOW-UP] Clean up older shuffleMergeId shuffle files when finalize request for higher shuffleMergeId is receive

2021-08-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33605: URL: https://github.com/apache/spark/pull/33605#issuecomment-890765819 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46450/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
AmplabJenkins removed a comment on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890765820 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46449/

[GitHub] [spark] AmplabJenkins commented on pull request #33605: [SPARK-32923][FOLLOW-UP] Clean up older shuffleMergeId shuffle files when finalize request for higher shuffleMergeId is received

2021-08-02 Thread GitBox
AmplabJenkins commented on pull request #33605: URL: https://github.com/apache/spark/pull/33605#issuecomment-890765819 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46450/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
AmplabJenkins commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890765820 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46449/ --

[GitHub] [spark] SparkQA commented on pull request #33605: [SPARK-32923][FOLLOW-UP] Clean up older shuffleMergeId shuffle files when finalize request for higher shuffleMergeId is received

2021-08-02 Thread GitBox
SparkQA commented on pull request #33605: URL: https://github.com/apache/spark/pull/33605#issuecomment-890764945 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46450/ --

[GitHub] [spark] sarutak opened a new pull request #33606: [SPARK-35815][SQL][FOLLOWUP] Add test considering the case spark.sql.legacy.interval.enabled is true

2021-08-02 Thread GitBox
sarutak opened a new pull request #33606: URL: https://github.com/apache/spark/pull/33606 ### What changes were proposed in this pull request? This PR adds test considering the case `spark.sql.legacy.interval.enabled` is `true` for SPARK-35815. ### Why are the changes needed?

[GitHub] [spark] beliefer commented on a change in pull request #33413: [SPARK-36175][SQL] Support TimestampNTZ in Avro data source

2021-08-02 Thread GitBox
beliefer commented on a change in pull request #33413: URL: https://github.com/apache/spark/pull/33413#discussion_r680687870 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala ## @@ -147,6 +147,21 @@ private[sql] class

[GitHub] [spark] SparkQA commented on pull request #33561: [SPARK-36332][SHUFFLE] Cleanup RemoteBlockPushResolver log messages

2021-08-02 Thread GitBox
SparkQA commented on pull request #33561: URL: https://github.com/apache/spark/pull/33561#issuecomment-890758459 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46451/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #33544: [SPARK-34927][INFRA] Support TPCDSQueryBenchmark in Benchmarks

2021-08-02 Thread GitBox
SparkQA removed a comment on pull request #33544: URL: https://github.com/apache/spark/pull/33544#issuecomment-890592936 **[Test build #141933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141933/testReport)** for PR 33544 at commit

[GitHub] [spark] SparkQA commented on pull request #33544: [SPARK-34927][INFRA] Support TPCDSQueryBenchmark in Benchmarks

2021-08-02 Thread GitBox
SparkQA commented on pull request #33544: URL: https://github.com/apache/spark/pull/33544#issuecomment-890753661 **[Test build #141933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141933/testReport)** for PR 33544 at commit

[GitHub] [spark] SparkQA commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-02 Thread GitBox
SparkQA commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-890752753 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46449/ -- This is an automated message from the

<    1   2   3   4   5   6