vinodkc commented on PR #39449:
URL: https://github.com/apache/spark/pull/39449#issuecomment-1399417725
@dtenedor @srielau , Could please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gengliangwang closed pull request #39696: [SPARK-42153][UI] Handle null string
values in PairStrings/RDDOperationNode/RDDOperationClusterWrapper
URL: https://github.com/apache/spark/pull/39696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
gengliangwang commented on PR #39696:
URL: https://github.com/apache/spark/pull/39696#issuecomment-1399399512
@dongjoon-hyun @LuciferYang Thanks for the review.
Merging this one to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mridulm commented on PR #39674:
URL: https://github.com/apache/spark/pull/39674#issuecomment-1399398921
Merged to master.
Thanks for working on this @LuciferYang !
Thanks for the review @tgravescs, and discussion @dongjoon-hyun,
@HyukjinKwon :-)
--
This is an automated message from
mridulm closed pull request #39674: [SPARK-42149][YARN] Remove the env
`SPARK_USE_CONC_INCR_GC` used to enable CMS GC for Yarn AM
URL: https://github.com/apache/spark/pull/39674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mridulm commented on code in PR #39674:
URL: https://github.com/apache/spark/pull/39674#discussion_r1083387253
##
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
##
@@ -1005,26 +1005,6 @@ private[spark] class Client(
val tmpDir = new Path(En
mridulm commented on PR #39190:
URL: https://github.com/apache/spark/pull/39190#issuecomment-1399397779
Late LGTM.
Thanks for fixing this @kuwii !
Thanks for merging it @srowen :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
LuciferYang commented on PR #39642:
URL: https://github.com/apache/spark/pull/39642#issuecomment-1399397643
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
LuciferYang commented on PR #39683:
URL: https://github.com/apache/spark/pull/39683#issuecomment-1399397574
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
LuciferYang commented on PR #39682:
URL: https://github.com/apache/spark/pull/39682#issuecomment-1399397378
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
LuciferYang commented on PR #39688:
URL: https://github.com/apache/spark/pull/39688#issuecomment-1399396999
Thanks @gengliangwang @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
gengliangwang closed pull request #39688: [SPARK-42146][CORE] Refactor
`Utils#setStringField` to make maven build pass when sql module use this method
URL: https://github.com/apache/spark/pull/39688
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gengliangwang commented on PR #39688:
URL: https://github.com/apache/spark/pull/39688#issuecomment-1399396937
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
LuciferYang commented on PR #39688:
URL: https://github.com/apache/spark/pull/39688#issuecomment-1399396145
should we merge this one?I need rebase others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhengruifeng opened a new pull request, #39699:
URL: https://github.com/apache/spark/pull/39699
### What changes were proposed in this pull request?
Fix incorrect column name in `withField`'s doctest
```
pyspark.sql.connect.column.Column.withField
Failed example:
df.wit
HyukjinKwon commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1083382917
##
python/pyspark/sql/connect/udf.py:
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreement
HyukjinKwon commented on PR #39692:
URL: https://github.com/apache/spark/pull/39692#issuecomment-1399391123
These aren't API. Configuration is supposed to be internal, and
SparkConnectPlanner isn't also supposed to be exposed to the end users, and we
don't keep the binary compatibility ther
zhengruifeng opened a new pull request, #39698:
URL: https://github.com/apache/spark/pull/39698
### What changes were proposed in this pull request?
`array_append` was recently added in SQL and PySpark, this PR adds it to
Connect.
### Why are the changes needed?
For parity
zhengruifeng commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1083380299
##
python/pyspark/sql/connect/udf.py:
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreemen
zhengruifeng closed pull request #39692: [SPARK-41629][CONNECT][FOLLOW] Enable
access to SparkSession from Plugin
URL: https://github.com/apache/spark/pull/39692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
zhengruifeng commented on PR #39692:
URL: https://github.com/apache/spark/pull/39692#issuecomment-1399382836
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dongjoon-hyun opened a new pull request, #39697:
URL: https://github.com/apache/spark/pull/39697
…
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
xinrong-meng commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1083373417
##
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##
@@ -217,6 +218,28 @@ message Expression {
bool is_user_defined_function = 4;
dongjoon-hyun closed pull request #39690: [SPARK-42150][K8S][DOCS] Upgrade
`Volcano` to 1.7.0
URL: https://github.com/apache/spark/pull/39690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dongjoon-hyun commented on PR #39690:
URL: https://github.com/apache/spark/pull/39690#issuecomment-1399366517
Thank you so much, @gengliangwang . Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dongjoon-hyun commented on code in PR #39690:
URL: https://github.com/apache/spark/pull/39690#discussion_r1083372057
##
resource-managers/kubernetes/integration-tests/README.md:
##
@@ -364,13 +360,5 @@ You can also specify `volcano` tag to only run Volcano
test:
## Cleanup V
gengliangwang commented on code in PR #39690:
URL: https://github.com/apache/spark/pull/39690#discussion_r1083371912
##
resource-managers/kubernetes/integration-tests/README.md:
##
@@ -364,13 +360,5 @@ You can also specify `volcano` tag to only run Volcano
test:
## Cleanup V
dongjoon-hyun commented on PR #39690:
URL: https://github.com/apache/spark/pull/39690#issuecomment-1399364776
Could you review this, @gengliangwang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gengliangwang commented on PR #39696:
URL: https://github.com/apache/spark/pull/39696#issuecomment-1399364595
cc @LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
gengliangwang opened a new pull request, #39696:
URL: https://github.com/apache/spark/pull/39696
### What changes were proposed in this pull request?
Similar to #39666, this PR handles null string values in
PairStrings/RDDOperationNode/RDDOperationClusterWrapper
### Why are the cha
vinodkc commented on code in PR #38419:
URL: https://github.com/apache/spark/pull/38419#discussion_r1083371035
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala:
##
@@ -937,4 +937,135 @@ class MathExpressionsSuite extends SparkFu
vinodkc commented on code in PR #38419:
URL: https://github.com/apache/spark/pull/38419#discussion_r1083371035
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala:
##
@@ -937,4 +937,135 @@ class MathExpressionsSuite extends SparkFu
dongjoon-hyun commented on PR #39690:
URL: https://github.com/apache/spark/pull/39690#issuecomment-1399359006
Could you review this when you have some time, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gengliangwang commented on PR #39686:
URL: https://github.com/apache/spark/pull/39686#issuecomment-1399358487
@dongjoon-hyun @LuciferYang Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
gengliangwang commented on PR #39685:
URL: https://github.com/apache/spark/pull/39685#issuecomment-1399358483
@dongjoon-hyun @LuciferYang Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
gengliangwang closed pull request #39684: [SPARK-42140][CORE] Handle null
string values in ApplicationEnvironmentInfoWrapper/ApplicationInfoWrapper
URL: https://github.com/apache/spark/pull/39684
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
gengliangwang commented on PR #39684:
URL: https://github.com/apache/spark/pull/39684#issuecomment-1399354886
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
grundprinzip commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1083341487
##
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##
@@ -217,6 +218,28 @@ message Expression {
bool is_user_defined_function = 4;
grundprinzip opened a new pull request, #39695:
URL: https://github.com/apache/spark/pull/39695
### What changes were proposed in this pull request?
To support retryable errors either produced by Spark directly or an
intermediate proxy, the Spark Connect client can now properly handle tho
tedyu commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399341276
@dongjoon-hyun @srowen @mridulm
Thanks for reviewing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
srowen closed pull request #39654: [MINOR][SHUFFLE] Include IOException in
warning log of finalizeShuffleMerge
URL: https://github.com/apache/spark/pull/39654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
srowen commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399340205
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dongjoon-hyun closed pull request #39668: [WIP] Test 3.4.0 tagging
URL: https://github.com/apache/spark/pull/39668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
dongjoon-hyun commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399336797
I'll leave this to the other committers, @tedyu .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dongjoon-hyun commented on PR #39690:
URL: https://github.com/apache/spark/pull/39690#issuecomment-1399336416
Since this is a doc-only PR, GitHub action result is irrelevant.
cc @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dongjoon-hyun commented on PR #39686:
URL: https://github.com/apache/spark/pull/39686#issuecomment-1399336316
Merged to master, @gengliangwang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dongjoon-hyun closed pull request #39686: [SPARK-42143][UI] Handle null string
values in RDDStorageInfo/RDDDataDistribution/RDDPartitionInfo
URL: https://github.com/apache/spark/pull/39686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on PR #39685:
URL: https://github.com/apache/spark/pull/39685#issuecomment-1399336202
Merged to master, @gengliangwang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dongjoon-hyun closed pull request #39685: [SPARK-42142][UI] Handle null string
values in CachedQuantile/ExecutorSummary/PoolData
URL: https://github.com/apache/spark/pull/39685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
RyanBerti commented on PR #39678:
URL: https://github.com/apache/spark/pull/39678#issuecomment-1399332706
Hi @dtenedor and @huaxingao
Thanks for the input! I agree with you both that migrating Spark's existing
HLL++ implementation to use the Apache Datasketches library would be ideal
dongjoon-hyun closed pull request #39689: [SPARK-42148][K8S][BUILD] Upgrade
`kubernetes-client` to 6.4.0
URL: https://github.com/apache/spark/pull/39689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on PR #39689:
URL: https://github.com/apache/spark/pull/39689#issuecomment-1399323248
Thank you. Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
tedyu commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399319165
@dongjoon-hyun
Do you think this PR is in mergeable state ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tedyu commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399319090
@srowen @mridulm
Tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
LuciferYang opened a new pull request, #39694:
URL: https://github.com/apache/spark/pull/39694
### What changes were proposed in this pull request?
This pr aims change to use `_` instead of `-` in `shadedPattern` for
relocation package name.
### Why are the changes needed?
J
itholic commented on code in PR #39693:
URL: https://github.com/apache/spark/pull/39693#discussion_r1083316715
##
python/pyspark/errors/exceptions.py:
##
@@ -288,7 +291,57 @@ class UnknownException(CapturedException):
class SparkUpgradeException(CapturedException):
"""
-
itholic opened a new pull request, #39693:
URL: https://github.com/apache/spark/pull/39693
### What changes were proposed in this pull request?
This PR proposes to migrate the Spark Connect errors into PySpark error
framework.
Also introducing 5 exceptions to handle
grundprinzip commented on PR #39692:
URL: https://github.com/apache/spark/pull/39692#issuecomment-1399287673
R: @HyukjinKwon @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
wangyum commented on PR #39691:
URL: https://github.com/apache/spark/pull/39691#issuecomment-1399282308
cc @xinrong-meng @MaxGekk @gengliangwang @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
grundprinzip opened a new pull request, #39692:
URL: https://github.com/apache/spark/pull/39692
### What changes were proposed in this pull request?
This patch allows the planner and command plugins for Spark Connect to
access the Spark Session and let other consumers access the configura
wangyum commented on PR #39691:
URL: https://github.com/apache/spark/pull/39691#issuecomment-1399281359
In fact databricks also supports this clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wangyum opened a new pull request, #39691:
URL: https://github.com/apache/spark/pull/39691
### What changes were proposed in this pull request?
The `QUALIFY` clause is used to filter the results of [window
functions](https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-windo
dongjoon-hyun opened a new pull request, #39690:
URL: https://github.com/apache/spark/pull/39690
### What changes were proposed in this pull request?
This PR aims to upgrade `Volcano` from 1.5.1 to 1.7.0.
### Why are the changes needed?
Volcano 1.7.0 finally provides `mul
LuciferYang commented on PR #39679:
URL: https://github.com/apache/spark/pull/39679#issuecomment-1399278365
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
LuciferYang commented on PR #39684:
URL: https://github.com/apache/spark/pull/39684#issuecomment-1399275488
Yeah, this one GA passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
LuciferYang commented on code in PR #39688:
URL: https://github.com/apache/spark/pull/39688#discussion_r1083302432
##
core/src/main/scala/org/apache/spark/status/protobuf/Utils.scala:
##
@@ -17,16 +17,18 @@
package org.apache.spark.status.protobuf
-import com.google.protobu
srowen commented on code in PR #39688:
URL: https://github.com/apache/spark/pull/39688#discussion_r1083302080
##
core/src/main/scala/org/apache/spark/status/protobuf/Utils.scala:
##
@@ -17,16 +17,18 @@
package org.apache.spark.status.protobuf
-import com.google.protobuf.Mes
srowen commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399271648
Yeah looks fine, just rerun tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
srowen commented on PR #39190:
URL: https://github.com/apache/spark/pull/39190#issuecomment-1399271485
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
srowen closed pull request #39190: [SPARK-41683][CORE] Fix issue of getting
incorrect property numActiveStages in jobs API
URL: https://github.com/apache/spark/pull/39190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
HyukjinKwon closed pull request #39638:
[SPARK-42082][SPARK-41598][PYTHON][CONNECT] Introduce `PySparkValueError` and
`PySparkTypeError`
URL: https://github.com/apache/spark/pull/39638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
HyukjinKwon commented on PR #39638:
URL: https://github.com/apache/spark/pull/39638#issuecomment-1399243499
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
tedyu commented on PR #39654:
URL: https://github.com/apache/spark/pull/39654#issuecomment-1399242161
Test failures were not related to the PR.
https://github.com/tedyu/spark/actions/runs/3973317986/jobs/6811901738#step:9:23488
```
Error: Exception in thread "streaming-job-executor-
HyukjinKwon commented on PR #39674:
URL: https://github.com/apache/spark/pull/39674#issuecomment-1399234450
I would defer to either @tgravescs or @mridulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
LuciferYang commented on PR #39674:
URL: https://github.com/apache/spark/pull/39674#issuecomment-1399233117
Updated pr description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
yabola commented on PR #39687:
URL: https://github.com/apache/spark/pull/39687#issuecomment-1399232731
@sunchao @aokolnychyi Please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LuciferYang commented on PR #39688:
URL: https://github.com/apache/spark/pull/39688#issuecomment-1399230015
GA failed case:
https://github.com/LuciferYang/spark/actions/runs/3973073352/jobs/6811519184
--
This is an automated message from the Apache Git Service.
To respond to the message,
dongjoon-hyun opened a new pull request, #39689:
URL: https://github.com/apache/spark/pull/39689
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### H
LuciferYang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083274700
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala:
##
@@ -23,17 +23,17 @@ import collection.JavaConverters._
imp
LuciferYang opened a new pull request, #39688:
URL: https://github.com/apache/spark/pull/39688
### What changes were proposed in this pull request?
This pr aims refactor input parameter type of `Utils#setStringField`
function to make maven build pass when sql module use this functions.
yabola commented on PR #39687:
URL: https://github.com/apache/spark/pull/39687#issuecomment-1399219285
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yabola opened a new pull request, #39687:
URL: https://github.com/apache/spark/pull/39687
…uld assume InternalRow implements equals and hashCode
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR i
LuciferYang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083268932
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala:
##
@@ -23,17 +23,17 @@ import collection.JavaConverters._
imp
LuciferYang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083268583
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala:
##
@@ -23,17 +23,17 @@ import collection.JavaConverters._
imp
kuwii commented on PR #39190:
URL: https://github.com/apache/spark/pull/39190#issuecomment-1399216960
Tried the example code in the
[JIRA](https://issues.apache.org/jira/browse/SPARK-24415), and it is not
affected by this change. Tasks showed in the stage are the same before and
after this
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1399216750
Thank you for the reviews @dongjoon-hyun , I believe I've addressed your
comments! Tomorrow is also the Chinese New Year, I wish you a happy Chinese New
Year.
--
This is an automat
itholic commented on code in PR #39543:
URL: https://github.com/apache/spark/pull/39543#discussion_r1083266330
##
core/src/main/resources/error/error-classes.json:
##
@@ -1592,7 +1592,7 @@
},
"MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY" : {
"message" : [
-
itholic commented on code in PR #39543:
URL: https://github.com/apache/spark/pull/39543#discussion_r1083266330
##
core/src/main/resources/error/error-classes.json:
##
@@ -1592,7 +1592,7 @@
},
"MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY" : {
"message" : [
-
itholic commented on code in PR #39638:
URL: https://github.com/apache/spark/pull/39638#discussion_r1083264192
##
python/pyspark/sql/tests/test_functions.py:
##
@@ -763,25 +798,55 @@ def test_higher_order_function_failures(self):
from pyspark.sql.functions import col, t
peter-toth commented on PR #39676:
URL: https://github.com/apache/spark/pull/39676#issuecomment-1399207914
Thanks for the quik review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
LuciferYang commented on code in PR #39674:
URL: https://github.com/apache/spark/pull/39674#discussion_r1083262519
##
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
##
@@ -1005,26 +1005,6 @@ private[spark] class Client(
val tmpDir = new Pat
LuciferYang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083262236
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala:
##
@@ -23,17 +23,17 @@ import collection.JavaConverters._
imp
gengliangwang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083262127
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala:
##
@@ -23,17 +23,17 @@ import collection.JavaConverters._
i
LuciferYang commented on code in PR #39683:
URL: https://github.com/apache/spark/pull/39683#discussion_r1083261992
##
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##
@@ -495,9 +495,10 @@ message RDDOperationGraphWrapper {
}
message StreamingQuer
LuciferYang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083261688
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala:
##
@@ -23,17 +23,17 @@ import collection.JavaConverters._
imp
LuciferYang commented on code in PR #39682:
URL: https://github.com/apache/spark/pull/39682#discussion_r1083259668
##
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLPlanMetricSerializer.scala:
##
@@ -19,18 +19,24 @@ package org.apache.spark.status.protobuf.sql
96 matches
Mail list logo
