[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732154701 This PR is irrelevant from CI result. So, please note that I stopped the runnjng pipelines on this PR manually to unblock my other PRs. -- This is an automated message from the Ap

[GitHub] [spark] mridulm commented on pull request #42685: [WIP][SPARK-44937][CORE] Add SSL/TLS support for RPC and Shuffle communications

mridulm commented on PR #42685: URL: https://github.com/apache/spark/pull/42685#issuecomment-1732173622 Thanks for working on this @hasnain-db , this is a very nice adding to spark ! Given the size of the PR, can we split this up to make it easier to review ? -- This is an automated me

[GitHub] [spark] dongjoon-hyun closed pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

dongjoon-hyun closed pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork URL: https://github.com/apache/spark/pull/43053 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] dongjoon-hyun commented on pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

dongjoon-hyun commented on PR #43053: URL: https://github.com/apache/spark/pull/43053#issuecomment-1732185291 Merged to master for Apache Spark 4.0.0. Thank you, @yaooqinn and all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334908931 ## core/benchmarks/ZStandardBenchmark-results.txt: ## @@ -2,26 +2,26 @@ Benchmark ZStandardCompressionCodec =

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334909865 ## sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt: ## @@ -1,10 +1,10 @@ -OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure -Intel(R)

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334909906 ## sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt: ## @@ -1,10 +1,10 @@ -OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure -Intel(R)

[GitHub] [spark] LuciferYang commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

LuciferYang commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732191440 late LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [spark] LuciferYang commented on pull request #43060: [SPARK-45284][R] Update SparkR minimum SystemRequirements to Java 17

LuciferYang commented on PR #43060: URL: https://github.com/apache/spark/pull/43060#issuecomment-1732191906 > Thank you. I checked now. Spark doc is updated with Java 17. So, we don't need to mention here. It seems that we need to fix it from `Java 17` to `Java17/21`. I'll handle it indepen

[GitHub] [spark] dongjoon-hyun opened a new pull request, #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

dongjoon-hyun opened a new pull request, #43069: URL: https://github.com/apache/spark/pull/43069 ### What changes were proposed in this pull request? This PR aims to update K8s doc to recommend K8s 1.26+ for Apache Spark 4.0.0. ### Why are the changes needed? **1. Default

[GitHub] [spark] LuciferYang closed pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

LuciferYang closed pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt` URL: https://github.com/apache/spark/pull/43066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] LuciferYang commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

LuciferYang commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732193237 Merged into master for Apache Spark 4.0, thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

dongjoon-hyun commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334911491 ## core/benchmarks/ZStandardBenchmark-results.txt: ## @@ -2,26 +2,26 @@ Benchmark ZStandardCompressionCodec ===

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

dongjoon-hyun commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334911535 ## sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt: ## @@ -1,10 +1,10 @@ -OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure -Intel(R

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732193905 Thank you, @LuciferYang . Now, the PR is ready by adding AnsiIntervalSortBenchmark (Java17/21). -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [spark] dongjoon-hyun commented on pull request #43066: [SPARK-45288][TESTS] Remove outdated benchmark result files, `*-jdk1[17]*results.txt`

dongjoon-hyun commented on PR #43066: URL: https://github.com/apache/spark/pull/43066#issuecomment-1732193985 Thank you, @LuciferYang ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] dongjoon-hyun commented on pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

dongjoon-hyun commented on PR #43069: URL: https://github.com/apache/spark/pull/43069#issuecomment-1732194064 Could you review this doc-only PR, @LuciferYang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [spark] yaooqinn commented on pull request #43053: [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork

yaooqinn commented on PR #43053: URL: https://github.com/apache/spark/pull/43053#issuecomment-1732198539 Thank you all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [spark] dongjoon-hyun commented on pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

dongjoon-hyun commented on PR #43069: URL: https://github.com/apache/spark/pull/43069#issuecomment-1732200263 Thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [spark] dongjoon-hyun closed pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

dongjoon-hyun closed pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support URL: https://github.com/apache/spark/pull/43069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #43069: [SPARK-44119][K8S][DOCS] Drop K8s v1.25 and lower version support

dongjoon-hyun commented on PR #43069: URL: https://github.com/apache/spark/pull/43069#issuecomment-1732200379 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

LuciferYang commented on code in PR #43065: URL: https://github.com/apache/spark/pull/43065#discussion_r1334916319 ## sql/core/benchmarks/SortBenchmark-results.txt: ## @@ -2,15 +2,15 @@ radix sort ===

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732206126 Thank you for thorough reviews. Ya, we should catch up them one by one after having this. This helps us be in the same page and monitor this. -- This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

dongjoon-hyun commented on PR #43065: URL: https://github.com/apache/spark/pull/43065#issuecomment-1732206610 I'll merge this because this PR doesn't touch any code. These are purely generated files as the snapshot. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] dongjoon-hyun closed pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones

dongjoon-hyun closed pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones URL: https://github.com/apache/spark/pull/43065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] hasnain-db commented on pull request #42685: [WIP][SPARK-44937][CORE] Add SSL/TLS support for RPC and Shuffle communications

hasnain-db commented on PR #42685: URL: https://github.com/apache/spark/pull/42685#issuecomment-1732226082 Thanks @mridulm ! Happy to do that. I can think of a nice split in line with the bullet points listed in the summary here. Just to confirm (since I'm not sure this repo has suppo

<    1   2