Re: [PR] [SPARK-45636][BUILD] Upgrade jersey to 2.41 [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43490: URL: https://github.com/apache/spark/pull/43490#issuecomment-1783714574 https://github.com/apache/spark/assets/1475305/b83a6a63-402e-4f78-9546-c7a5aa1061d6;> GA passed -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-45678][CORE] Cover BufferReleasingInputStream.available/reset under tryOrFetchFailedException [spark]

2023-10-27 Thread via GitHub
viirya commented on PR #43543: URL: https://github.com/apache/spark/pull/43543#issuecomment-1783692434 Thank you @dongjoon-hyun ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-10-27 Thread via GitHub
dengziming commented on PR #43567: URL: https://github.com/apache/spark/pull/43567#issuecomment-1783686054 The use of the 4 similar errors is a bit confusing, we have separate errors for flatten/concat/union, but we are using `CREATE_XXX` for array_repeat/array_insert/array_distinct/...

[PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-10-27 Thread via GitHub
dengziming opened a new pull request, #43567: URL: https://github.com/apache/spark/pull/43567 ### What changes were proposed in this pull request? The 4 errors are `[CONCAT/FLATTEN/CREATE/UNION]_ARRAYS_WITH_ELEMENTS_EXCEED_LIMIT`, CONCAT_XXX is used in concat/array_insert;

Re: [PR] [SPARK-45678][CORE] Cover BufferReleasingInputStream.available/reset under tryOrFetchFailedException [spark]

2023-10-27 Thread via GitHub
dongjoon-hyun commented on PR #43543: URL: https://github.com/apache/spark/pull/43543#issuecomment-1783677610 +1, late LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-45678][CORE] Cover BufferReleasingInputStream.available/reset under tryOrFetchFailedException [spark]

2023-10-27 Thread via GitHub
viirya commented on PR #43543: URL: https://github.com/apache/spark/pull/43543#issuecomment-1783669458 Thank you @mridulm @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-45678][CORE] Cover BufferReleasingInputStream.available/reset under tryOrFetchFailedException [spark]

2023-10-27 Thread via GitHub
sunchao commented on PR #43543: URL: https://github.com/apache/spark/pull/43543#issuecomment-1783669073 Merged to master/branch-3.4/branch-3.5. Thanks @viirya @mridulm ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-45711][SQL] Introduce a mapper for avro compression codecs [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on code in PR #43562: URL: https://github.com/apache/spark/pull/43562#discussion_r1375149364 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala: ## @@ -680,18 +680,24 @@ abstract class AvroSuite val zstandardDir =

Re: [PR] [SPARK-45678][CORE] Cover BufferReleasingInputStream.available/reset under tryOrFetchFailedException [spark]

2023-10-27 Thread via GitHub
sunchao closed pull request #43543: [SPARK-45678][CORE] Cover BufferReleasingInputStream.available/reset under tryOrFetchFailedException URL: https://github.com/apache/spark/pull/43543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-45705][TESTS] Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43554: URL: https://github.com/apache/spark/pull/43554#issuecomment-1783667850 late LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45705][TESTS] Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED [spark]

2023-10-27 Thread via GitHub
ulysses-you closed pull request #43554: [SPARK-45705][TESTS] Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED URL: https://github.com/apache/spark/pull/43554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-45705][TESTS] Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED [spark]

2023-10-27 Thread via GitHub
ulysses-you commented on PR #43554: URL: https://github.com/apache/spark/pull/43554#issuecomment-1783667616 thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-44385][SQL] Use PartitionEvaluator API in MergingSessionsExec & UpdatingSessionsExec [spark]

2023-10-27 Thread via GitHub
github-actions[bot] closed pull request #41957: [SPARK-44385][SQL] Use PartitionEvaluator API in MergingSessionsExec & UpdatingSessionsExec URL: https://github.com/apache/spark/pull/41957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-44386][SQL] Use PartitionEvaluator API in HashAggregateExec, ObjectHashAggregateExec, SortAggregateExec [spark]

2023-10-27 Thread via GitHub
github-actions[bot] closed pull request #41958: [SPARK-44386][SQL] Use PartitionEvaluator API in HashAggregateExec, ObjectHashAggregateExec, SortAggregateExec URL: https://github.com/apache/spark/pull/41958 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-44414][SQL] Fixed matching check for CharType/VarcharType [spark]

2023-10-27 Thread via GitHub
github-actions[bot] closed pull request #41993: [SPARK-44414][SQL] Fixed matching check for CharType/VarcharType URL: https://github.com/apache/spark/pull/41993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [WIP][DO NOT REVIEW] Testing stuff [spark]

2023-10-27 Thread via GitHub
github-actions[bot] commented on PR #42078: URL: https://github.com/apache/spark/pull/42078#issuecomment-1783631439 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-32268][SQL][FOLLOWUP] Filter creation side size threshold judgment should prun column in injectBloomFilter [spark]

2023-10-27 Thread via GitHub
github-actions[bot] closed pull request #41978: [SPARK-32268][SQL][FOLLOWUP] Filter creation side size threshold judgment should prun column in injectBloomFilter URL: https://github.com/apache/spark/pull/41978 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-44447][SQL] Use PartitionEvaluator API in FlatMapGroupsInPandasExec, FlatMapCoGroupsInPandasExec [spark]

2023-10-27 Thread via GitHub
github-actions[bot] closed pull request #42025: [SPARK-7][SQL] Use PartitionEvaluator API in FlatMapGroupsInPandasExec, FlatMapCoGroupsInPandasExec URL: https://github.com/apache/spark/pull/42025 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [SPARK-44362][SQL] Use PartitionEvaluator API in AggregateInPandasExec and AttachDistributedSequenceExec [spark]

2023-10-27 Thread via GitHub
github-actions[bot] closed pull request #42029: [SPARK-44362][SQL] Use PartitionEvaluator API in AggregateInPandasExec and AttachDistributedSequenceExec URL: https://github.com/apache/spark/pull/42029 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] [SPARK-45713][PYTHON] Support registering Python data sources [spark]

2023-10-27 Thread via GitHub
allisonwang-db opened a new pull request, #43566: URL: https://github.com/apache/spark/pull/43566 ### What changes were proposed in this pull request? This PR adds support for registering Python data sources. Users can register a Python data source using the class:

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1783572221 Awesome!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45674][CONNECT][PYTHON] Improve error message for JVM-dependent attributes on Spark Connect. [spark]

2023-10-27 Thread via GitHub
allisonwang-db commented on code in PR #43537: URL: https://github.com/apache/spark/pull/43537#discussion_r1375068730 ## python/pyspark/sql/connect/dataframe.py: ## @@ -1639,13 +1639,11 @@ def sampleBy( sampleBy.__doc__ = PySparkDataFrame.sampleBy.__doc__ def

Re: [PR] [WIP] [spark]

2023-10-27 Thread via GitHub
zeruibao closed pull request #43518: [WIP] URL: https://github.com/apache/spark/pull/43518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-38723][SS][TEST][FOLLOWUP] Deflake the newly added test in QueryExecutionErrorsSuite [spark]

2023-10-27 Thread via GitHub
WweiL commented on PR #43565: URL: https://github.com/apache/spark/pull/43565#issuecomment-1783368727 @HyukjinKwon Also the test should have failed in previous CI because the parameter wasn't provided in the checkError method. Could this be a build issue (like the test isn't ran..? --

Re: [PR] [SPARK-38723][SS][TEST][FOLLOWUP] Deflake the newly added test in QueryExecutionErrorsSuite [spark]

2023-10-27 Thread via GitHub
WweiL commented on PR #43565: URL: https://github.com/apache/spark/pull/43565#issuecomment-1783364239 cc @HeartSaVioR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [SPARK-38723][SS][TEST][FOLLOWUP] Deflake the newly added test in QueryExecutionErrorsSuite [spark]

2023-10-27 Thread via GitHub
WweiL opened a new pull request, #43565: URL: https://github.com/apache/spark/pull/43565 ### What changes were proposed in this pull request? The newly added test in https://github.com/apache/spark/commit/7d7afb06f682c10f3900eb8adeab9fad6d49cb24 could be flaky, this change

Re: [PR] [SPARK-45544][CORE] Integrate SSL support into TransportContext [spark]

2023-10-27 Thread via GitHub
hasnain-db commented on code in PR #43541: URL: https://github.com/apache/spark/pull/43541#discussion_r1374880822 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ShuffleTransportContextSuite.java: ## @@ -90,15 +94,22 @@ private ByteBuf

Re: [PR] [SPARK-45022][SQL] Provide context for dataset API errors [spark]

2023-10-27 Thread via GitHub
MaxGekk commented on code in PR #43334: URL: https://github.com/apache/spark/pull/43334#discussion_r1374906918 ## connector/connect/common/src/main/protobuf/spark/connect/base.proto: ## @@ -841,6 +848,12 @@ message FetchErrorDetailsResponse { // The corresponding

Re: [PR] [SPARK-45022][SQL] Provide context for dataset API errors [spark]

2023-10-27 Thread via GitHub
MaxGekk commented on code in PR #43334: URL: https://github.com/apache/spark/pull/43334#discussion_r1374904453 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -508,9 +508,11 @@ class Dataset[T] private[sql]( * @group basic * @since 3.4.0 */ -

Re: [PR] [SPARK-45684][SQL][MLLIB] Clean up the deprecated API usage related to `SeqOps` [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43564: URL: https://github.com/apache/spark/pull/43564#issuecomment-1783148598 Test first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [SPARK-45684][SQL][MLLIB] Clean up the deprecated API usage related to `SeqOps` [spark]

2023-10-27 Thread via GitHub
LuciferYang opened a new pull request, #43564: URL: https://github.com/apache/spark/pull/43564 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

Re: [PR] [SPARK-45696][CORE] Fix method tryCompleteWith in trait Promise is deprecated [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43556: URL: https://github.com/apache/spark/pull/43556#issuecomment-1783063056 Can you make the GA operate normally? For example, by rebasing the code? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-45685][CORE][SQL] Use `LazyList` instead of `Stream` [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43563: URL: https://github.com/apache/spark/pull/43563#issuecomment-1783060645 Test first, will update pr description later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [SPARK-45685][CORE][SQL] Use `LazyList` instead of `Stream` [spark]

2023-10-27 Thread via GitHub
LuciferYang opened a new pull request, #43563: URL: https://github.com/apache/spark/pull/43563 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

Re: [PR] [SPARK-45698][CORE][SQL][SS] Clean up the deprecated API usage related to `Buffer` [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43551: URL: https://github.com/apache/spark/pull/43551#issuecomment-1783043394 Thanks @MaxGekk @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-44307][SQL] Add Bloom filter for left outer join even if the left side table is smaller than broadcast threshold. [spark]

2023-10-27 Thread via GitHub
maheshk114 commented on code in PR #41860: URL: https://github.com/apache/spark/pull/41860#discussion_r1374631624 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -18,10 +18,10 @@ package

Re: [PR] [SPARK-45649][SQL] Unify the prepare framework for `OffsetWindowFunctionFrame` [spark]

2023-10-27 Thread via GitHub
cloud-fan closed pull request #43507: [SPARK-45649][SQL] Unify the prepare framework for `OffsetWindowFunctionFrame` URL: https://github.com/apache/spark/pull/43507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-45649][SQL] Unify the prepare framework for `OffsetWindowFunctionFrame` [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on PR #43507: URL: https://github.com/apache/spark/pull/43507#issuecomment-1782942277 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374601778 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +80,103 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r137450 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,17 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374596994 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,17 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374595749 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala: ## @@ -404,6 +404,17 @@ class DataSourceV2Strategy(session:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374587818 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -2785,4 +2785,11 @@ private[sql] object QueryExecutionErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374586437 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -2785,4 +2785,11 @@ private[sql] object QueryExecutionErrors extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374584553 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ## @@ -884,19 +884,39 @@ object ShowTables { } /** - * The logical

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374574757 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-44307][SQL] Add Bloom filter for left outer join even if the left side table is smaller than broadcast threshold. [spark]

2023-10-27 Thread via GitHub
beliefer commented on code in PR #41860: URL: https://github.com/apache/spark/pull/41860#discussion_r1374532388 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ## @@ -18,10 +18,10 @@ package

Re: [PR] [SPARK-45022][SQL] Provide context for dataset API errors [spark]

2023-10-27 Thread via GitHub
heyihong commented on code in PR #43334: URL: https://github.com/apache/spark/pull/43334#discussion_r1374510895 ## connector/connect/common/src/main/protobuf/spark/connect/base.proto: ## @@ -841,6 +848,12 @@ message FetchErrorDetailsResponse { // The corresponding

Re: [PR] [SPARK-45022][SQL] Provide context for dataset API errors [spark]

2023-10-27 Thread via GitHub
heyihong commented on code in PR #43334: URL: https://github.com/apache/spark/pull/43334#discussion_r1374509141 ## connector/connect/common/src/main/protobuf/spark/connect/base.proto: ## @@ -841,6 +848,12 @@ message FetchErrorDetailsResponse { // The corresponding

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782829446 All green: https://github.com/apache/spark/actions/runs/6665603078 :tada: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-45706][PYTHON][DOCS] Makes entire Binder build fails fast during setting up [spark]

2023-10-27 Thread via GitHub
HyukjinKwon closed pull request #43553: [SPARK-45706][PYTHON][DOCS] Makes entire Binder build fails fast during setting up URL: https://github.com/apache/spark/pull/43553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-45706][PYTHON][DOCS] Makes entire Binder build fails fast during setting up [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43553: URL: https://github.com/apache/spark/pull/43553#issuecomment-1782821971 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-45709][BUILD] Deploy packages when all packages are built [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43561: URL: https://github.com/apache/spark/pull/43561#issuecomment-1782801137 CC @HyukjinKwon @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [SPARK-45709][BUILD] Deploy packages when all packages are built [spark]

2023-10-27 Thread via GitHub
EnricoMi opened a new pull request, #43561: URL: https://github.com/apache/spark/pull/43561 ### What changes were proposed in this pull request? Packages are deployed after all packages have been built. Currently, individual packages are deployed once they are built. ### Why are

Re: [PR] [SPARK-45707][SQL] Simplify `DataFrameStatFunctions.countMinSketch` with `CountMinSketchAgg` [spark]

2023-10-27 Thread via GitHub
beliefer commented on code in PR #43560: URL: https://github.com/apache/spark/pull/43560#discussion_r1374467471 ## sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala: ## @@ -483,7 +482,9 @@ final class DataFrameStatFunctions private[sql](df: DataFrame) {

Re: [PR] [SPARK-45708][BUILD] Retry mvn deploy [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43559: URL: https://github.com/apache/spark/pull/43559#issuecomment-1782784993 CC @LuciferYang @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782777583 Let's retry few times and see if it actually works first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

2023-10-27 Thread via GitHub
panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374453999 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

[PR] [SPARK-45707][SQL] Simplify `DataFrameStatFunctions. countMinSketch` with `CountMinSketchAgg` [spark]

2023-10-27 Thread via GitHub
zhengruifeng opened a new pull request, #43560: URL: https://github.com/apache/spark/pull/43560 ### What changes were proposed in this pull request? Simplify `DataFrameStatFunctions. countMinSketch` with `CountMinSketchAgg` ### Why are the changes needed? to make it

[PR] [BUILD] Retry mvn deploy [spark]

2023-10-27 Thread via GitHub
EnricoMi opened a new pull request, #43559: URL: https://github.com/apache/spark/pull/43559 ### What changes were proposed in this pull request? Retry uploading artifacts to the Apache repository as often as possible (default is `1`). ### Why are the changes needed? It is

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782722490 I think a better alternative is to retry: https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html#retryfaileddeploymentcount -- This is an automated message from the

Re: [PR] [SPARK-45705][TESTS] Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED [spark]

2023-10-27 Thread via GitHub
yaooqinn commented on PR #43554: URL: https://github.com/apache/spark/pull/43554#issuecomment-1782713634 cc @LuciferYang @HyukjinKwon @dongjoon-hyun thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] 3.2.0 kylin 4.6.16.0.1 hotfix 1027 [spark]

2023-10-27 Thread via GitHub
Mrhs121 closed pull request #43558: 3.2.0 kylin 4.6.16.0.1 hotfix 1027 URL: https://github.com/apache/spark/pull/43558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] 3.2.0 kylin 4.6.16.0.1 hotfix 1027 [spark]

2023-10-27 Thread via GitHub
Mrhs121 opened a new pull request, #43558: URL: https://github.com/apache/spark/pull/43558 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

Re: [PR] [SPARK-45696][CORE] Fix method tryCompleteWith in trait Promise is deprecated [spark]

2023-10-27 Thread via GitHub
zhaomin1423 commented on PR #43556: URL: https://github.com/apache/spark/pull/43556#issuecomment-1782655682 > Is there only one relevant case? only found it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [SPARK-43380][SQL][FOLLOWUP] Deprecate toSqlType(avroSchema: Schema, …useStableIdForUnionType: Boolean): SchemaType [spark]

2023-10-27 Thread via GitHub
beliefer opened a new pull request, #43557: URL: https://github.com/apache/spark/pull/43557 ### What changes were proposed in this pull request? https://github.com/apache/spark/pull/43530 provides a new method: ``` /** * Converts an Avro schema to a corresponding Spark SQL

Re: [PR] [SPARK-45328][DOCS][FOLLOWUP] Update docs for Hive metastore supported versions [spark]

2023-10-27 Thread via GitHub
MaxGekk commented on PR #43552: URL: https://github.com/apache/spark/pull/43552#issuecomment-1782644395 +1, LGTM. Merging to master. Thank you, @pan3793 and @yaooqinn @ulysses-you for review. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [SPARK-45328][DOCS][FOLLOWUP] Update docs for Hive metastore supported versions [spark]

2023-10-27 Thread via GitHub
MaxGekk closed pull request #43552: [SPARK-45328][DOCS][FOLLOWUP] Update docs for Hive metastore supported versions URL: https://github.com/apache/spark/pull/43552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-45696][CORE] Fix method tryCompleteWith in trait Promise is deprecated [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43556: URL: https://github.com/apache/spark/pull/43556#issuecomment-1782643371 Is there only one relevant case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-45696][CORE] Fix method tryCompleteWith in trait Promise is deprecated [spark]

2023-10-27 Thread via GitHub
zhaomin1423 closed pull request #43556: [SPARK-45696][CORE] Fix method tryCompleteWith in trait Promise is deprecated URL: https://github.com/apache/spark/pull/43556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-45698][CORE][SQL][SS] Clean up the deprecated API usage related to `Buffer` [spark]

2023-10-27 Thread via GitHub
MaxGekk commented on PR #43551: URL: https://github.com/apache/spark/pull/43551#issuecomment-1782638556 +1, LGTM. Merging to master. Thank you, @LuciferYang and @HyukjinKwon for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-45698][CORE][SQL][SS] Clean up the deprecated API usage related to `Buffer` [spark]

2023-10-27 Thread via GitHub
MaxGekk closed pull request #43551: [SPARK-45698][CORE][SQL][SS] Clean up the deprecated API usage related to `Buffer` URL: https://github.com/apache/spark/pull/43551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK][CORE] Fix method tryCompleteWith in trait Promise is deprecated [spark]

2023-10-27 Thread via GitHub
zhaomin1423 closed pull request #43556: [SPARK][CORE] Fix method tryCompleteWith in trait Promise is deprecated URL: https://github.com/apache/spark/pull/43556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [SPARK][CORE] Fix method tryCompleteWith in trait Promise is deprecated [spark]

2023-10-27 Thread via GitHub
zhaomin1423 opened a new pull request, #43556: URL: https://github.com/apache/spark/pull/43556 ### What changes were proposed in this pull request? scala.concurrent.Promise#tryCompleteWith is deprecated since scala_2.13 ### Why are the changes needed? replace

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782621404 Btw., when some publish snapshot job fails on that timeout, manually trigger the whole workflow is not needed, simply rerun the failed jobs. -- This is an automated message from the

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782618863 Merged into master. Thank you very, very much @EnricoMi ~ Thanks @HyukjinKwon ~ -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782619384 Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
LuciferYang closed pull request #43555: [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow URL: https://github.com/apache/spark/pull/43555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782615289 OK, let me merge this one ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-44751][SQL][FOLLOWUP] Change `xmlExpressions.scala` package name [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43102: URL: https://github.com/apache/spark/pull/43102#issuecomment-1782614836 > We should fix https://github.com/apache/spark/actions/workflows/publish_snapshot.yml The issue has been fixed by #43538, thanks! -- This is an automated message from the

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782613411 @LuciferYang would you mind helping merging this? (I'm outside now ;-)..) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782613227 Looks like a known unrelated issue, workaround here: https://github.com/kiegroup/kie-wb-common/pull/3416/files -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782607346 Same HTTP timeout: ``` 2023-10-27T00:46:23.1689370Z mem: top - 00:46:23 up 7 min, 0 users, load average: 0.86, 0.96, 0.50 2023-10-27T00:46:23.1690374Z mem: Tasks: 129

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43555: URL: https://github.com/apache/spark/pull/43555#issuecomment-1782606364 I triggered one more time at https://github.com/apache/spark/actions/runs/6661389655 and that failed too. Was that also false alarm? -- This is an automated message from the

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782600145 (sorry it's my phone now so can't properly check the logs on my own) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782598957 I manually triggered once more at https://github.com/apache/spark/actions/runs/6661389655 and it failed too. Is that also unrelated? -- This is an automated message from the

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782599348 Revived in #43555. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782599355 If that's the case we can get this in again and see if it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi opened a new pull request, #43555: URL: https://github.com/apache/spark/pull/43555 ### What changes were proposed in this pull request? This re-does #43538, which has [falsely been reverted](https://github.com/apache/spark/pull/43538#issuecomment-1782568332). Limit max

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782580570 The mem statistics with `2g` are MiB Mem : 6922.0 total,579.9 free, 5634.8 used,707.2 buff/cache MiB Swap: 4096.0 total, 2069.7 free, 2026.2 used.

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782571084 Yes, please! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
LuciferYang commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782569044 Shall we revive this pr and give it another try ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782568332 In fact, you manually triggered the publish, and it worked perfectly fine for `master`: https://github.com/apache/spark/actions/runs/6661389655/job/18104176828 Branch

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782565642 That workflow run did not pick up the changes of this PR: https://github.com/apache/spark/actions/runs/6661131541/workflow -- This is an automated message from the Apache

Re: [PR] [SPARK-45706][PYTHON][DOCS] Makes entire Binder build fails fast during setting up [spark]

2023-10-27 Thread via GitHub
HyukjinKwon commented on PR #43553: URL: https://github.com/apache/spark/pull/43553#issuecomment-1782544206 Still need to test both below too: - https://mybinder.org/v2/gh/HyukjinKwon/spark/ce5ddad9903?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_connect.ipynb -

[PR] [SPARK-45705][TESTS] Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED [spark]

2023-10-27 Thread via GitHub
yaooqinn opened a new pull request, #43554: URL: https://github.com/apache/spark/pull/43554 ### What changes were proposed in this pull request? Fix flaky test: Status of a failed DDL/DML with no jobs should be FAILED ### Why are the changes needed?

Re: [PR] [SPARK-45651][BUILD][FOLLOWUP] Reduce mvn -Xmx option to 2g in publish_snapshot workflow [spark]

2023-10-27 Thread via GitHub
EnricoMi commented on PR #43538: URL: https://github.com/apache/spark/pull/43538#issuecomment-1782542097 > Seems not working (https://github.com/apache/spark/actions/runs/6661131541/job/18103495351). I reverted this for now. The problem was unrelated: 408 Request Timeout

[PR] [SPARK-45706][PYTHON][DOCS] Makes entire Binder build fails fast during setting up [spark]

2023-10-27 Thread via GitHub
HyukjinKwon opened a new pull request, #43553: URL: https://github.com/apache/spark/pull/43553 ### What changes were proposed in this pull request? This PR proposes to make entire Binder build fails fast during setting up to prevent the Binder image to be successfully built which it

Re: [PR] [SPARK-45328][DOCS][FOLLOWUP] Update docs for Hive metastore supported versions [spark]

2023-10-27 Thread via GitHub
pan3793 commented on PR #43552: URL: https://github.com/apache/spark/pull/43552#issuecomment-1782504457 cc @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [SPARK-45328][DOCS][FOLLOWUP] Update docs for Hive metastore supported versions [spark]

2023-10-27 Thread via GitHub
pan3793 opened a new pull request, #43552: URL: https://github.com/apache/spark/pull/43552 ### What changes were proposed in this pull request? A minor follow-up of https://github.com/apache/spark/pull/43116 ### Why are the changes needed? Correct the docs of

  1   2   >