anishshri-db commented on PR #45360:
URL: https://github.com/apache/spark/pull/45360#issuecomment-1974249820
@sahnib @HeartSaVioR - PTAL, thx !
@HeartSaVioR - let me know if you are ok with the proposed dir layout
changes and also if you prefer them in a separate PR. Thanks
--
LuciferYang commented on PR #45352:
URL: https://github.com/apache/spark/pull/45352#issuecomment-1974248899
Thanks @MaxGekk and @dongjoon-hyun ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
parthchandra commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1974173364
Yes there is no good way to test this in ci. Let me try it out and make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wForget commented on PR #45353:
URL: https://github.com/apache/spark/pull/45353#issuecomment-1974158003
> Thank yo ufor the fix @wForget. Can you re-run ci? The failures do not
appear to be related.
thanks for your review, ci has passed
--
This is an automated message from the
itholic commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1974134659
Thanks for the review, @MaxGekk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #43956:
URL: https://github.com/apache/spark/pull/43956#issuecomment-1974121074
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
github-actions[bot] closed pull request #43808: [SPARK-45926][SQL] Implementing
equals and hashCode which takes into account pushed runtime filters , in
InMemoryTable related scans
URL: https://github.com/apache/spark/pull/43808
--
This is an automated message from the Apache Git Service.
github-actions[bot] closed pull request #43064: [SPARK-45265][SQL][WIP]
Supporting Hive 4.0 metastore
URL: https://github.com/apache/spark/pull/43064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] closed pull request #43231: [SPARK-45417][PYTHON] Make
InheritableThread inherit the active session
URL: https://github.com/apache/spark/pull/43231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nchammas commented on code in PR #45236:
URL: https://github.com/apache/spark/pull/45236#discussion_r1509657863
##
python/pyspark/pandas/supported_api_gen.py:
##
@@ -38,7 +38,7 @@
MAX_MISSING_PARAMS_SIZE = 5
COMMON_PARAMETER_SET = {"kwargs", "args", "cls"}
MODULE_GROUP_MATCH
erenavsarogullari commented on code in PR #45234:
URL: https://github.com/apache/spark/pull/45234#discussion_r1509646119
##
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala:
##
@@ -198,10 +221,18 @@ case class ShuffleQueryStageExec(
anton5798 commented on code in PR #45133:
URL: https://github.com/apache/spark/pull/45133#discussion_r1509548922
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##
@@ -248,24 +248,72 @@ object RewritePredicateSubquery extends
jchen5 commented on code in PR #45133:
URL: https://github.com/apache/spark/pull/45133#discussion_r1509535334
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##
@@ -248,24 +248,72 @@ object RewritePredicateSubquery extends
jchen5 commented on code in PR #45133:
URL: https://github.com/apache/spark/pull/45133#discussion_r1509535334
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##
@@ -248,24 +248,72 @@ object RewritePredicateSubquery extends
anton5798 commented on PR #45133:
URL: https://github.com/apache/spark/pull/45133#issuecomment-1973897479
@cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dongjoon-hyun commented on PR #45292:
URL: https://github.com/apache/spark/pull/45292#issuecomment-1973849084
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ueshin opened a new pull request, #45361:
URL: https://github.com/apache/spark/pull/45361
### What changes were proposed in this pull request?
Blocks invalid types from the `args` argument for `sql` command.
Additionally, uses a `PySparkValueError` instead of assertions.
MaxGekk closed pull request #45244: [SPARK-47158][SQL] Assign proper name and
`sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)`
URL: https://github.com/apache/spark/pull/45244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
MaxGekk commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1973827372
+1, LGTM. Merging to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MaxGekk closed pull request #45347: [SPARK-47237][BUILD] Upgrade xmlschema-core
to 2.3.1
URL: https://github.com/apache/spark/pull/45347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
MaxGekk commented on PR #45347:
URL: https://github.com/apache/spark/pull/45347#issuecomment-1973821219
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
avikbesu commented on PR #42574:
URL: https://github.com/apache/spark/pull/42574#issuecomment-1973820070
in which spark version, this issue would be fixed ? latest 3.5.1 also
persists same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dongjoon-hyun commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1973807623
To @SteNicholas , for this kind of PR, we can use simply `[BUILD]` tag like
GitHub Action bot suggested.
![Screenshot 2024-03-01 at 11 39
MaxGekk closed pull request #45339: [SPARK-47227][FOLLOW][DOCS] Improve Spark
Connect Documentation
URL: https://github.com/apache/spark/pull/45339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MaxGekk commented on PR #45339:
URL: https://github.com/apache/spark/pull/45339#issuecomment-1973806289
+1, LGTM. Merging to master.
Thank you, @grundprinzip and @xinrong-meng @nchammas for review.
--
This is an automated message from the Apache Git Service.
To respond to the message,
MaxGekk closed pull request #45322: [SPARK-47216][DOCS] Refine layout of SQL
performance tuning page
URL: https://github.com/apache/spark/pull/45322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MaxGekk commented on PR #45322:
URL: https://github.com/apache/spark/pull/45322#issuecomment-1973801912
+1, LGTM. Merging to master.
Thank you, @nchammas and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xinrong-meng commented on PR #45354:
URL: https://github.com/apache/spark/pull/45354#issuecomment-1973796476
Just curious do we consider such changes as "user-facing" considering users
may import those methods in their existing code?
--
This is an automated message from the Apache Git
xinrong-meng commented on PR #45354:
URL: https://github.com/apache/spark/pull/45354#issuecomment-1973796427
LGTM, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xinrong-meng commented on PR #45339:
URL: https://github.com/apache/spark/pull/45339#issuecomment-1973783953
LGTM, thank you! Looks much clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xinrong-meng commented on code in PR #45339:
URL: https://github.com/apache/spark/pull/45339#discussion_r1509439684
##
docs/spark-connect-overview.md:
##
@@ -67,8 +67,8 @@ that developers need to be aware of when using Spark Connect:
the execution environment. In
MaxGekk closed pull request #45352: [SPARK-47243][SS] Correct the package name
of `StateMetadataSource.scala`
URL: https://github.com/apache/spark/pull/45352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
MaxGekk commented on PR #45352:
URL: https://github.com/apache/spark/pull/45352#issuecomment-1973763967
+1, LGTM. Merging to master.
Thank you, @LuciferYang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
caldempsey commented on PR #52:
URL: https://github.com/apache/spark-docker/pull/52#issuecomment-1973756934
Also running into this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
anton5798 commented on PR #45133:
URL: https://github.com/apache/spark/pull/45133#issuecomment-1973748999
Changed the approach to wrap into max(). Ideally we'd use any_value(), but
it is not working well in Spark.
--
This is an automated message from the Apache Git Service.
To respond
ericm-db commented on PR #45359:
URL: https://github.com/apache/spark/pull/45359#issuecomment-1973745035
cc @HeartSaVioR @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
anishshri-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1509393780
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3320,6 +3320,13 @@
],
"sqlState" : "42802"
},
+
anishshri-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1509389021
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase
anishshri-db commented on code in PR #45359:
URL: https://github.com/apache/spark/pull/45359#discussion_r1509389021
##
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##
@@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends
DataTypeErrorsBase
ericm-db opened a new pull request, #45359:
URL: https://github.com/apache/spark/pull/45359
### What changes were proposed in this pull request?
Setting the processorHandle as a part of the statefulProcessor, so that the
user doesn't have to explicitly keep track of it, and
ericm-db closed pull request #45002: [SPARK-46961][SS] Using ProcessorContext
to store and retrieve handle
URL: https://github.com/apache/spark/pull/45002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
parthchandra commented on PR #45353:
URL: https://github.com/apache/spark/pull/45353#issuecomment-1973626210
Thank yo ufor the fix @wForget. Can you re-run ci? The failures do not
appear to be related.
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on PR #45342:
URL: https://github.com/apache/spark/pull/45342#issuecomment-1973541527
Thank you for updates for both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vicennial commented on PR #45358:
URL: https://github.com/apache/spark/pull/45358#issuecomment-1973540664
cc @juliuszsompolski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vicennial opened a new pull request, #45358:
URL: https://github.com/apache/spark/pull/45358
### What changes were proposed in this pull request?
Adds a guard to check if the execution was abandoned before putting it into
the `abandonedTombstones` cache
### Why are the
robreeves commented on PR #40812:
URL: https://github.com/apache/spark/pull/40812#issuecomment-1973502406
@liuzqt another idea for a narrow explain utils fix is to move the
`QueryPlan.OP_ID_TAG` currently stored in the `TreeNode.tags` into a thread
local map maintained in explain utils.
dbatomic commented on code in PR #45285:
URL: https://github.com/apache/spark/pull/45285#discussion_r1509146815
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala:
##
@@ -40,6 +41,11 @@ import org.apache.spark.sql.types._
stefankandic commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1509122961
##
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala:
##
@@ -293,4 +293,29 @@ private[spark] object SchemaUtils {
* @return The escaped
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509069300
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509083011
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509076371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509076371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509076371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509075313
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -61,6 +61,5 @@ class StringType private(val collationId: Int) extends
AtomicType with
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509069300
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
dbatomic commented on code in PR #45290:
URL: https://github.com/apache/spark/pull/45290#discussion_r1509062803
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -33,6 +33,14 @@ class StringType private(val collationId: Int) extends
AtomicType with
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1509062485
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##
@@ -279,4 +279,23 @@ object DataSourceUtils extends PredicateHelper {
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1509060591
##
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala:
##
@@ -293,4 +293,29 @@ private[spark] object SchemaUtils {
* @return The escaped
cloud-fan closed pull request #45259: [SPARK-47167][SQL] Add concrete class for
JDBC anonymous relation
URL: https://github.com/apache/spark/pull/45259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on PR #45259:
URL: https://github.com/apache/spark/pull/45259#issuecomment-1973264143
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
grundprinzip commented on PR #45150:
URL: https://github.com/apache/spark/pull/45150#issuecomment-1973223167
Any chance to get some more feedback here? @HyukjinKwon or @hvanhovell ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508983490
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -497,10 +497,33 @@ case class Lower(child: Expression)
cloud-fan commented on PR #45357:
URL: https://github.com/apache/spark/pull/45357#issuecomment-1973167129
fine-grained reduce ratio looks nice, but it needs a lot of tuning, and more
or less based on experience. I don't think fixed reduce ratios work for all the
cases and we probably need
cloud-fan commented on code in PR #45290:
URL: https://github.com/apache/spark/pull/45290#discussion_r1508938251
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -33,6 +33,14 @@ class StringType private(val collationId: Int) extends
AtomicType with
cloud-fan commented on code in PR #45285:
URL: https://github.com/apache/spark/pull/45285#discussion_r1508931880
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##
@@ -592,3 +593,28 @@ case class QualifyLocationWithWarehouse(catalog:
cloud-fan commented on code in PR #45285:
URL: https://github.com/apache/spark/pull/45285#discussion_r1508930731
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##
@@ -592,3 +593,28 @@ case class QualifyLocationWithWarehouse(catalog:
cloud-fan commented on code in PR #45285:
URL: https://github.com/apache/spark/pull/45285#discussion_r1508927759
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##
@@ -592,3 +593,18 @@ case class QualifyLocationWithWarehouse(catalog:
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508925352
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508922010
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508920123
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -497,10 +497,33 @@ case class Lower(child: Expression)
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508917781
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -61,6 +61,5 @@ class StringType private(val collationId: Int) extends
AtomicType with
JacobZheng0927 commented on code in PR #45327:
URL: https://github.com/apache/spark/pull/45327#discussion_r1508908677
##
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala:
##
@@ -1737,3 +1738,33 @@ class JoinSuite extends QueryTest with
SharedSparkSession with
dbatomic commented on code in PR #45104:
URL: https://github.com/apache/spark/pull/45104#discussion_r1508901070
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -2304,6 +2304,12 @@
},
"sqlState" : "22023"
},
+ "INVALID_PARTITION_COLUMN_DATA_TYPE"
mridulm commented on code in PR #45266:
URL: https://github.com/apache/spark/pull/45266#discussion_r1508881617
##
core/src/main/scala/org/apache/spark/Dependency.scala:
##
@@ -206,6 +206,21 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
finalizeTask =
mridulm commented on code in PR #45266:
URL: https://github.com/apache/spark/pull/45266#discussion_r1508881617
##
core/src/main/scala/org/apache/spark/Dependency.scala:
##
@@ -206,6 +206,21 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
finalizeTask =
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508881751
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -586,9 +608,21 @@ object ContainsExpressionBuilder extends
mridulm commented on code in PR #45266:
URL: https://github.com/apache/spark/pull/45266#discussion_r1508881617
##
core/src/main/scala/org/apache/spark/Dependency.scala:
##
@@ -206,6 +206,21 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
finalizeTask =
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508881130
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +343,21 @@ public boolean contains(final UTF8String substring) {
return
mridulm commented on code in PR #45327:
URL: https://github.com/apache/spark/pull/45327#discussion_r1508880886
##
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala:
##
@@ -1737,3 +1738,33 @@ class JoinSuite extends QueryTest with
SharedSparkSession with
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508873927
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -586,9 +608,21 @@ object ContainsExpressionBuilder extends
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508872841
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508868584
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508867241
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +343,21 @@ public boolean contains(final UTF8String substring) {
panbingkun commented on PR #45292:
URL: https://github.com/apache/spark/pull/45292#issuecomment-1973018722
> Let me try to submit an issue to the log4j community.
An issue has been submitted to the log4j2 community:
https://github.com/apache/logging-log4j2/issues/2337
The
dbatomic commented on code in PR #45290:
URL: https://github.com/apache/spark/pull/45290#discussion_r1508848081
##
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashMapGenerator.scala:
##
@@ -173,7 +173,10 @@ abstract class HashMapGenerator(
panbingkun commented on PR #45326:
URL: https://github.com/apache/spark/pull/45326#issuecomment-1972974328
Just as a record
- log4j2 version 2.22.1
cloud-fan commented on PR #45357:
URL: https://github.com/apache/spark/pull/45357#issuecomment-1972942423
cc @yaooqinn @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cloud-fan opened a new pull request, #45357:
URL: https://github.com/apache/spark/pull/45357
### What changes were proposed in this pull request?
This PR changes the target partition size of AQE partition coalescing from
`spark.sql.adaptive.advisoryPartitionSizeInBytes`
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508803718
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -585,10 +604,23 @@ object ContainsExpressionBuilder extends
peter-toth closed pull request #45231: [WIP] DeduplicateRelations keeps
original expressions if possible
URL: https://github.com/apache/spark/pull/45231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andrej-db commented on code in PR #45293:
URL: https://github.com/apache/spark/pull/45293#discussion_r1508757748
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala:
##
@@ -122,11 +122,14 @@ class SubstituteExecuteImmediate(val
urosstan-db commented on code in PR #45259:
URL: https://github.com/apache/spark/pull/45259#discussion_r1508739221
##
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCV1CompatibleRelation.scala:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
LuciferYang opened a new pull request, #45356:
URL: https://github.com/apache/spark/pull/45356
### What changes were proposed in this pull request?
This PR changes the use of `InternalRow.fromSeq` in the following scenarios
to directly construct `GenericInternalRow` to save a collection
MaxGekk closed pull request #45302: [SPARK-43255][SQL] Replace the error class
_LEGACY_ERROR_TEMP_2020 by an internal error
URL: https://github.com/apache/spark/pull/45302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
MaxGekk commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1972809205
+1, LGTM. Merging to master.
Thank you, @JinHelin404 and @eejbyfeldt @amaliujia for review.
--
This is an automated message from the Apache Git Service.
To respond to the message,
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508704687
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
JinHelin404 commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1972782237
> @JinHelin404 Do you have an account at OSS JIRA:
https://issues.apache.org/jira/browse/SPARK-43255? If so, please, leave a
comment in the ticket (I will assign it to you) otherwise
stefankandic opened a new pull request, #45355:
URL: https://github.com/apache/spark/pull/45355
### What changes were proposed in this pull request?
Improving the error code for error class
`INVALID_PARTITION_COLUMN_DATA_TYPE`.
### Why are the changes needed?
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508674676
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508674676
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
1 - 100 of 106 matches
Mail list logo
