cloud-fan closed pull request #46156: [SPARK-47927][SQL]: Fix nullability
attribute in UDF decoder
URL: https://github.com/apache/spark/pull/46156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan commented on PR #46156:
URL: https://github.com/apache/spark/pull/46156#issuecomment-2081341603
thanks, merging to master/3.5/3.4!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
cloud-fan commented on PR #46156:
URL: https://github.com/apache/spark/pull/46156#issuecomment-2081341418
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
cloud-fan commented on PR #46240:
URL: https://github.com/apache/spark/pull/46240#issuecomment-2081340902
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
WweiL commented on PR #46237:
URL: https://github.com/apache/spark/pull/46237#issuecomment-2081327432
@HyukjinKwon I think we can merge this now : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
WweiL commented on PR #46260:
URL: https://github.com/apache/spark/pull/46260#issuecomment-2081317940
CC @HeartSaVioR PTAL, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
WweiL opened a new pull request, #46260:
URL: https://github.com/apache/spark/pull/46260
### What changes were proposed in this pull request?
Additional null check to the `safeMapToJValue`. Normally we won't create a
`StreamingQueryProgress` with map fields as null. It is also
panbingkun commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081311526
> We can manually verify it through Maven test `build/mvn test -pl
mllib-local`:
>
> Before
>
>
there is a WARNI
cloud-fan closed pull request #46254: [SPARK-48019] Fix incorrect behavior in
ColumnVector/ColumnarArray with dictionary and nulls
URL: https://github.com/apache/spark/pull/46254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
cloud-fan commented on PR #46254:
URL: https://github.com/apache/spark/pull/46254#issuecomment-2081305430
thanks, merging to master/3.5!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
LuciferYang commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081303527
Yes, we should keep `JavaModuleOptions`, `extraTestJavaArgs` in
`SparkBuild.scala`, and `extraTestJavaArgs` in `pom.xml` consistent.
--
This is an automated message from the Apache
panbingkun commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081303045
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
panbingkun commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2081300766
> @panbingkun we should add `--add-modules=jdk.incubator.vector` to
`extraJavaTestArgs ` in `pom.xml` too
>
>
https://github.com/apache/spark/blob/64d321926bbcede05d1c145405d503
LuciferYang commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2081298871
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
LuciferYang commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2081298219
@panbingkun we should add `--add-modules=jdk.incubator.vector` to `pom.xml`
too
https://github.com/apache/spark/blob/64d321926bbcede05d1c145405d503b3431f185b/pom.xml#L305-L
panbingkun opened a new pull request, #46258:
URL: https://github.com/apache/spark/pull/46258
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
panbingkun commented on PR #45659:
URL: https://github.com/apache/spark/pull/45659#issuecomment-2081287287
> @panbingkun
>
> Hi, bingkun, when rebuild the image in
https://github.com/zhengruifeng/spark/actions/runs/8857365994/job/24324764602
>
> I see such warnings:
>
>
zhengruifeng opened a new pull request, #46257:
URL: https://github.com/apache/spark/pull/46257
### What changes were proposed in this pull request?
Enable `UDFParityTests.test_udf_timestamp_ntz`
### Why are the changes needed?
for test coverage
### Does this PR in
dongjoon-hyun commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2081266374
Merged to master. Thank you, @panbingkun and all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dongjoon-hyun closed pull request #46246: [SPARK-48021][ML][BUILD] Add
`--add-modules=jdk.incubator.vector` to `JavaModuleOptions`
URL: https://github.com/apache/spark/pull/46246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
dongjoon-hyun commented on PR #46256:
URL: https://github.com/apache/spark/pull/46256#issuecomment-2081265499
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zhengruifeng commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2081262259
also cc @WeichenXu123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] commented on PR #44769:
URL: https://github.com/apache/spark/pull/44769#issuecomment-2081261642
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
github-actions[bot] commented on PR #42296:
URL: https://github.com/apache/spark/pull/42296#issuecomment-2081261651
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
zhengruifeng commented on PR #46256:
URL: https://github.com/apache/spark/pull/46256#issuecomment-2081261491
thank you @yaooqinn and @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
panbingkun commented on PR #46252:
URL: https://github.com/apache/spark/pull/46252#issuecomment-2081261447
> The below MR may give some hints also to this ticket, bumping Jersey to
v3.1.x requires all Spark to comply with EE10 standards, as I have tried during
the Jetty 12 upgrade. #45500
HiuKwok commented on PR #46252:
URL: https://github.com/apache/spark/pull/46252#issuecomment-2081188223
The below MR may give some hints also to this ticket, bumping Jersey to
v3.1.x requires all Spark to comply with EE10 standards, as I have tried during
the Jetty 12 upgrade.
https://gi
panbingkun commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2080865185
> Thank you for looking into that! Let me know what I should do to update
dev.ludovic.netlib further for the needs of Spark
Thank all for writing in such `detail` in the previous
yaooqinn closed pull request #46256: [SPARK-48020][INFRA][PYTHON] Pin
'pandas==2.2.2'
URL: https://github.com/apache/spark/pull/46256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
yaooqinn commented on PR #46256:
URL: https://github.com/apache/spark/pull/46256#issuecomment-2080844028
Thank you @zhengruifeng @HyukjinKwon
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
luhenry commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2080831209
Thank you for looking into that! Let me know what I should do to update
dev.ludovic.netlib further for the needs of Spark
--
This is an automated message from the Apache Git Service.
T
panbingkun commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2080813720
> Before this flag was gated on Java 21 - it's OK to set this on earlier
versions? OK if so
Yes, the JDK version of the above manual test environment (local) is `17`.
https://
srowen commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2080797254
Before this flag was gated on Java 21 - it's OK to set this on earlier
versions? OK if so
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
panbingkun commented on PR #46246:
URL: https://github.com/apache/spark/pull/46246#issuecomment-2080762133
cc @luhenry @srowen @zhengruifeng @dongjoon-hyun @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jshmchenxi commented on code in PR #46149:
URL: https://github.com/apache/spark/pull/46149#discussion_r1581765866
##
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala:
##
@@ -35,7 +35,9 @@ import org.apache.sp
jshmchenxi commented on PR #46149:
URL: https://github.com/apache/spark/pull/46149#issuecomment-2080412508
It's been a busy week, sorry for the delay. I'll address your comments
today, thanks! @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the m
37 matches
Mail list logo
