Github user ChorPangChan closed the pull request at:
https://github.com/apache/spark/pull/16000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@uncleGen
apologize for interrupted your work,
I dont know the story at that time.
@vanzin
its true that i havent consider that.
but anyway, I have no plan to implement
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
> What is the real problem with it?
actually I dont have any problem with it
I just think its is already a new version and that's not this PR nor I
means to do
anot
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
I could not agree with "The API should be one" yet
what is the benefit of force they as one API beside "it sounds correct"?
as i mention before, i can no
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
I understand its possible,
and actually I agree having a hooking mechanism is a better approach as
well in turns of programing and if we really need streaming to support history
server
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@vanzin
I undertstand the story now, but im afraid i cant help to accomplish that
story.
as my first comment state,
this implementation is base on the current REST
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r91014959
--- Diff:
streaming/src/main/java/org/apache/spark/streaming/status/api/v1/BatchStatus.java
---
@@ -0,0 +1,30 @@
+/*
+ * Licensed
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r90976630
--- Diff:
streaming/src/main/java/org/apache/spark/streaming/status/api/v1/BatchStatus.java
---
@@ -0,0 +1,30 @@
+/*
+ * Licensed
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
`[error] * method
onStreamingStarted(org.apache.spark.streaming.scheduler.StreamingListenerStreamingStarted)Unit
in trait org.apache.spark.streaming.scheduler.StreamingListener is present
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@vanzin
sorry, I think I remove some empty line accidently
the Scala style problem should be fixed now.
---
If your project is set up for it, you can reply to this email and have your
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
@ajbozarth
sorry, just in case you didn't noticed
I had make the change to handle the startTime
how do you think?
@srowen
hello,
I also think we need someone
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
startTime will record in StreamingContext and pass to listener through
StreamingStarted event.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r89945721
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -145,6 +146,10 @@ private[ui] class StreamingPage(parent
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r89917919
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -145,6 +146,10 @@ private[ui] class StreamingPage(parent
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r89905857
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -145,6 +146,10 @@ private[ui] class StreamingPage(parent
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
if there is no other comment,
i believe this PR is ready to go.
@ajbozarth
please forgive me if its not appropriate to ask
but will you please take a look on the code
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r89563670
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/status/api/v1/JacksonMessageWriter.scala
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed
Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r89558292
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/status/api/v1/JacksonMessageWriter.scala
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/16000
hi @vanzin
new PR against master is ready.
please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user ChorPangChan opened a pull request:
https://github.com/apache/spark/pull/16000
[SPARK-18537][Web UI]Add a REST api to spark streaming
a new PR for https://github.com/apache/spark/pull/15974 against master
## What changes were proposed in this pull request
Github user ChorPangChan closed the pull request at:
https://github.com/apache/spark/pull/15974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/15974
@uncleGen Thankyou
@vanzin OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/15974
hey @uncleGen
I think we need to settle this down in order to make progress.
I had a quick look in your code, as i said above,
modifying spark-core is no a good idea
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/15974
I stay adding a new package to streaming is a better structure then modify
the spark-core.
can we make the decision for which implementation to use first
---
If your project is set up
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/15974
It require manual merge if I do it against master.
should I just PR with conflicts or rebase to master before PR?
btw those conflicts are just versions from the pom file.
---
If your
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/15974
I think what we trying to do is duplicated. I do believe create a new
package under streaming is better then modify the spark-core package.
the reason for merging this to 1.6 is just
Github user ChorPangChan commented on the issue:
https://github.com/apache/spark/pull/15974
hi @tdas
pre our conversation in spark-dev channel, I have done the implementation.
can you please have a look on this please?
---
If your project is set up for it, you can reply
GitHub user ChorPangChan opened a pull request:
https://github.com/apache/spark/pull/15974
[SPARK-18537] Add a REST api to spark streaming
## What changes were proposed in this pull request?
1. implement a package(org.apache.spark.streaming.status.api.v1) that serve
28 matches
Mail list logo
