Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r92595845
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2067,8 +2067,8 @@ class SparkContext(config: SparkConf) extends Logging
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
I addressed the feedback about the things that are left to modify. Thank
you for taking your time to review this PR, I learnt a lot in terms of your
expectations of what is useful and what isn'
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91949350
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1038,6 +1059,13 @@ class SparkContext(config: SparkConf) extends
Logging
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91906441
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1949,20 +2038,35 @@ class SparkContext(config: SparkConf) extends
Logging
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
I removed all trivial (unhelpful) additions and expended javadoc where it
didn't add any value to the method signature. I payed special attention to all
your previous comments and reflected th
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
Right, I see what you are referring to. I will apply those ones to a
greater degree than before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
@srowen
> I don't think most of my comment were addressed. This will be easier if
you try to respond to each of them and apply them across your change at each
round.
I g
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91856040
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -956,24 +976,24 @@ class SparkContext(config: SparkConf) extends Logging
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
@srowen I fixed everything. All comments are squashed, please review the
current one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
@srowen I see that my rebase didn't go well, sorry for that. Is there a way
to revert the last push or it would be better to create another pull request
and close this one?
---
If your proje
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
@srowen I reversed obvious comments as well as some minor changes (such as
capitalizing). I only left javadoc for some of the non-trivial public api. I
can reverse changes for comments where the
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91015596
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1144,13 +1218,19 @@ class SparkContext(config: SparkConf) extends
Logging
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91013560
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1144,13 +1218,19 @@ class SparkContext(config: SparkConf) extends
Logging
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91009631
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1417,27 +1551,31 @@ class SparkContext(config: SparkConf) extends
Logging
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91009155
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1401,8 +1532,11 @@ class SparkContext(config: SparkConf) extends
Logging
Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
Hi @srowen , it's quite hard to directly jump on something like
"refactoring core scheduling logic", I thought fixing small things would be a
good start. To make it simple I limited
GitHub user Mironor opened a pull request:
https://github.com/apache/spark/pull/16137
[SPARK-18708][CORE] Improvement/improve docs in spark context file
## What changes were proposed in this pull request?
SparkContext.scala was created a long time ago and contains several
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/15213#discussion_r80265346
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2105,6 +2109,54 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/15213#discussion_r80264096
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2105,6 +2109,54 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user Mironor commented on a diff in the pull request:
https://github.com/apache/spark/pull/15174#discussion_r80003353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -342,6 +342,7 @@ trait CheckAnalysis extends
20 matches
Mail list logo
