Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110839571
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,69 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110839623
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,69 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110671916
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,68 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110669561
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,68 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110667171
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,68 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110664282
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -360,6 +360,55 @@ class PrefixSpanSuite extends SparkFunSuite
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110662589
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -360,6 +360,55 @@ class PrefixSpanSuite extends SparkFunSuite
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110662506
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,68 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110661717
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,68 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on a diff in the pull request:
https://github.com/apache/spark/pull/17575#discussion_r110661386
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -232,6 +200,68 @@ class PrefixSpan private (
object PrefixSpan extends
Github user Syrux commented on the issue:
https://github.com/apache/spark/pull/17575
Yo Sean, I already pushed the requested changes in case it's the correct
place to do so.
(I can just revert them, if not)
I added two new methods to allow tests. First a method which
Github user Syrux commented on the issue:
https://github.com/apache/spark/pull/17575
Ok, should I create a new Jira and push there the additionnal tests ?
Or is here completly fine, since it's related to the current change
Tell me, and I will get the change done asap
Github user Syrux commented on the issue:
https://github.com/apache/spark/pull/17575
Yes exactly, the current implementation adds too much unnecessary
delimiters. We this one line change, delimiter are only placed where needed.
Currently there are no tests to verify
GitHub user Syrux opened a pull request:
https://github.com/apache/spark/pull/17575
[SPARK-20265][MLlib] Improve Prefix'span pre-processing efficiency
## What changes were proposed in this pull request?
Improve PrefixSpan pre-processing efficency by preventing sequences
14 matches
Mail list logo
