[GitHub] spark issue #21449: [SPARK-24385][SQL] Resolve self-join condition ambiguity...

2018-06-21 Thread WenboZhao
Github user WenboZhao commented on the issue: https://github.com/apache/spark/pull/21449 I like the proposal by @daniel-shields. If we could get it fixed soon, we will be able to catch up the Spark 2.3.2 release

[GitHub] spark pull request #21593: [SPARK-24578][Core] Cap sub-region's size of retu...

2018-06-20 Thread WenboZhao
Github user WenboZhao commented on a diff in the pull request: https://github.com/apache/spark/pull/21593#discussion_r196939992 --- Diff: common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java --- @@ -137,30 +137,15 @@ protected void

[GitHub] spark pull request #21593: [SPARK-24578][Core] Cap sub-region's size of retu...

2018-06-20 Thread WenboZhao
Github user WenboZhao commented on a diff in the pull request: https://github.com/apache/spark/pull/21593#discussion_r196761978 --- Diff: common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java --- @@ -137,30 +137,15 @@ protected void

[GitHub] spark pull request #21593: [SPARK-24578][Core] Cap sub-region's size of retu...

2018-06-19 Thread WenboZhao
GitHub user WenboZhao opened a pull request: https://github.com/apache/spark/pull/21593 [SPARK-24578][Core] Cap sub-region's size of returned nio buffer ## What changes were proposed in this pull request? This PR tries to fix the performance regression introduced by SPARK-

[GitHub] spark pull request #21432: [SPARK-24373][SQL] Add AnalysisBarrier to Relatio...

2018-05-29 Thread WenboZhao
Github user WenboZhao commented on a diff in the pull request: https://github.com/apache/spark/pull/21432#discussion_r191441199 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -63,17 +63,17 @@ class RelationalGroupedDataset protected

[GitHub] spark pull request #21432: [SPARK-24373][SQL] Add AnalysisBarrier to Relatio...

2018-05-29 Thread WenboZhao
Github user WenboZhao commented on a diff in the pull request: https://github.com/apache/spark/pull/21432#discussion_r191428684 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -63,17 +63,17 @@ class RelationalGroupedDataset protected