[GitHub] spark pull request #15543: [SPARK-18001] [Document] fix broke link to SparkD...

2016-10-18 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/15543 [SPARK-18001] [Document] fix broke link to SparkDataFrame ## What changes were proposed in this pull request? In http://spark.apache.org/docs/latest/sql-programming-guide.html, Section

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-23 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-18721 @mengxr @srowen Can you add me to white list ? or help to launch a jenkins test for this? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-21 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-187047801 @yanboliang I complete this pr, please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-15 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-184131612 @yanboliang OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-14 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-184090963 @yanboliang @mengxr Done for this PR. Please help review and launch test. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-06 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-180884960 @srowen i add a comment in jira , which user name is Tommy Yu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-06 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-180721101 @srowen ready to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-05 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-180361789 ping @srowen @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13153][PySpark] ML persistence failed w...

2016-02-02 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11043#issuecomment-179007203 It's OK now and ready to launch test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-02 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-178975120 I need do a minor change for this PR after 13153 get resoved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13153][PySpark] ML persistence failed w...

2016-02-02 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/11043 [SPARK-13153][PySpark] ML persistence failed when handle no default value parameter Fix this defect by check default value exist or not. @yanboliang Please help to review. You can merge

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-02 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-178970906 Sure, good catch. I have submit a jira 13153 and submit a pr later --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-02 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-178953997 Sure, I will submit a jira, I thought we need fix it in scala side that ensure all parameter has default value. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-01 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-178381846 @yanboliang Sorry for last PR that I didn't check scala side. For regression, there are only three algorithm support MLRead/MLWrite: LinearRegre

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-01 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/11000 [SPARK-13033][ML][PySpark] Add import/export for ml.regression Add export/import for all estimators and transformers(which have Scala implementation) under pyspark/ml/regression.py

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-01 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-177832923 @srowen @SparkQA Can you launch test again, doc change shouldn't break spark unit test. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-01-28 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-176531765 @srowen Can you launch test again, not sure why but get exception below: java.lang.NullPointerException at org.apache.spark.SparkFiles$.getRootDirectory

[GitHub] spark pull request: [SPARK-13032] [ML] [PySpark] PySpark support m...

2016-01-27 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10469#issuecomment-175631491 HI I raise a common issues here when I start look pyspark. I found there is only one test.py to test basic RDD and spark submit related api. There is no ml & m

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-01-27 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-175615313 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-01-26 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-175007432 @srowen done for scala and python's collectAsMap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-01-25 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-174825559 @holdenk I add note for Java API, and change "array" to "Pandas's DataFrame" for toPandas function, pls review this change. :-) --- If your

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-01-25 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-174532835 @srowen Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-01-25 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-174512459 @srowen Finish task. pls help to review and launch test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5865] [WIP] [API DOC] Add doc warnings ...

2016-01-21 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/10874 [SPARK-5865] [WIP] [API DOC] Add doc warnings for methods that return local data structures @rxin @srowen I work out note message for rdd.take function, please help to review. If it&#

[GitHub] spark pull request: [SPARK-10264][Documentation] Added @Since to m...

2016-01-18 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10756#issuecomment-172532760 Thanks @srowen. I will take a try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10264][Documentation] Added @Since to m...

2016-01-17 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10756#issuecomment-172409558 I guess @mengxr take a long vocation those days. Just guess from his github contribute status. :-) --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10264][Documentation] Added Since annot...

2016-01-13 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/10756 [SPARK-10264][Documentation] Added Since annotation for ml.recomendation I create new pr since original pr long time no update. Please help to review. @srowen You can merge this pull

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-12 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170847516 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-11 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170756165 Same error with #10685. Wait hot fix #10704 take effect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-11 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170541326 @srowen Do you know what happened? I check the failed log but don't know why. EVN issues? --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-10 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170423933 Thank you @srowen, I refine parameter explanation base on your suggestion. Pls take a look. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-07 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169839655 @srowen it pass test now. ready for merge. Thanks for review. Wenpei --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-07 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169615279 Fix it. But I found for jenkins result, line number did not march with correct line. For example, jenkins result [error] /home/jenkins/workspace

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-06 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169542618 Fix scala style test failed. Please test again, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...

2016-01-06 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169315605 thanks,@srowen @rxin There is no Jenkins report, anything need for me? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explaination...

2016-01-05 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169202207 Thanks, @srowen I will try to add parameter explain to fold. But for treeAggregate, it has comments like below to refer to Aggregate function. I thought it's e

[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explaination...

2016-01-04 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/10587 [SPARK-12638] [API DOC] Parameter explaination not very accurate for rdd function "aggregate" Currently, RDD function aggregate's parameter doesn't explain well, especially

[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function

2015-12-16 Thread Wenpei
Github user Wenpei closed the pull request at: https://github.com/apache/spark/pull/10245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function

2015-12-10 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10245#issuecomment-163863199 Should I cc someone to review it? @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function

2015-12-09 Thread Wenpei
GitHub user Wenpei opened a pull request: https://github.com/apache/spark/pull/10245 [SPARK] [API DOC] rdd's aggregate function More accurate for RDD's aggregate function, especially for zeroValue parameter. In old version, people may misunderstand and thought zer