[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-08 Thread achanda
Github user achanda closed the pull request at: https://github.com/apache/spark/pull/5115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-07 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-90794051 @srowen I could not make any progress on this. I think I will close this PR and let someone else work on this. Sorry this took so long. Thanks for taking time to review

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-01 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88661009 @srowen I'm not sure if these failures are legit. The first run failed at `StreamingContextSuite`, which my code does touch. However, that suit passed the second ru

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-31 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88225481 @srowen sorry, my bad. Fixed all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-31 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88221413 @srowen done both --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-30 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-87791582 @srowen please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-27 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-87016816 Yes, give me a few hours. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-23 Thread achanda
Github user achanda commented on a diff in the pull request: https://github.com/apache/spark/pull/5115#discussion_r27002784 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -792,6 +793,11 @@ private[spark] object Utils extends Logging { lazy val

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-21 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-84503301 @srowen @nyaapa did that now, please check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-21 Thread achanda
Github user achanda commented on a diff in the pull request: https://github.com/apache/spark/pull/5115#discussion_r26897085 --- Diff: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala --- @@ -17,10 +17,13 @@ package org.apache.spark.deploy

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-21 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-84452168 @srowen I understand your concern, and I agree. This patch should be a bit better. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-21 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-84283232 @nyaapa, sorry, I did not realize you were working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-21 Thread achanda
Github user achanda commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-84283201 This will return a formatted IPv6 host address to be used in a URI, that will look like `[2001:db8::1]`. The caller can then stitch that to a whole URI. The behavior

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-03-21 Thread achanda
GitHub user achanda opened a pull request: https://github.com/apache/spark/pull/5115 [SPARK-6440][CORE]Handle IPv6 addresses properly when constructing URI The toUriString() method in guava takes care of properly formatting IPv4 and v6 addresses to a URI You can merge this pull