Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/14398
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/15378
[SPARK-17803][TESTS] Upgrade docker-client dependency
[SPARK-17803: Docker integration tests don't run with "Docker for
Mac"](https://issues.apache.org/jira/browse/SPARK-17803)
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/15378
Thanks @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/13652#discussion_r67270245
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -503,5 +510,26 @@ class DateTimeUtilsSuite extends
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/13652
I think this is a good "best effort" fix for the round-trip conversion
```int -> java.sql.Date -> int```.
It may also be worth testing the round-trip conversion ```java.
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/13785
[SPARK-15613] set correct TimeZone in test cases "to UTC timestamp" and
"from UTC tâ¦
## What changes were proposed in this pull request?
setting the correct time zone in tes
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/13783
I (also) just created a [PR](https://github.com/apache/spark/pull/13785) to
fix the two test cases ```from UTC timestamp``` and ```to UTC timestap``` to
respect the time zones that are supposed to
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/13652
I (also) just created a [PR](https://github.com/apache/spark/pull/13785) to
fix the two test cases ```from UTC timestamp``` and ```to UTC timestap``` to
respect the time zones that are supposed to
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/13652
@davies ...just to confirm the desired behavior of these two test cases
```from UTC timestamp``` and ```to UTC timestamp```. We are contending with 3
time zones:
* we are parsing
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/13785
Closing this PR since another more comprehensive fix was committed from PR
#13784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ckadner closed the pull request at:
https://github.com/apache/spark/pull/13785
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ckadner commented on the issue:
https://github.com/apache/spark/pull/14398
@holdenk @davies
I agree that date, time, and timezone handling is best left to the experts
and leveraging [JSR-310](http://www.threeten.org/threetenbp/)
([SPARK-16788](https
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/14398#discussion_r72876907
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -875,11 +877,11 @@ object DateTimeUtils
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/14398#discussion_r72877468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -875,11 +877,11 @@ object DateTimeUtils
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/14398#discussion_r72880137
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -875,11 +877,12 @@ object DateTimeUtils
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r66765611
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -48,4 +49,41 @@ class DateTimeUtilsSuite extends
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r66860325
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -48,4 +49,41 @@ class DateTimeUtilsSuite extends
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/7563
[SPARK-9211][SQL] normalize line separators before generating MD5 hash
The golden answer file names for the existing Hive comparison tests were
generated using a MD5 hash of the query text which
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/6983
[SPARK-6785][SQL] fix DateTimeUtils for dates before 1970
Hi Michael,
this Pull-Request is a follow-up to
[PR-6242](https://github.com/apache/spark/pull/6242). I removed the two
obsolete test
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-114838546
I opened a new pull-request
[PR-6983](https://github.com/apache/spark/pull/6983)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6983#issuecomment-116861479
@marmbrus - Hi Michael, please let me know when you have time to review my
pull-request. This PR no longer merges, so I would close this and create a new
PR on top of
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6983#issuecomment-116955196
@squito - thx 4 your comments! :+1:
@marmbrus - back to you -- thx
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6983#issuecomment-11732
Thanks Michael!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/7144
[SPARK-8746][SQL] update download link for Hive 0.13.1
updated the [Hive 0.13.1](https://archive.apache.org/dist/hive/hive-0.13.1)
download link in `sql/README.md`
You can merge this pull request
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/7144#issuecomment-117820180
@JoshRosen -- Hi Josh, thanks for kicking of the tests. Can you help me
make sense of the test results?
I only changed a markdown file, no test cases should be
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/6236
SPARK-6785: fix DateUtils.fromJavaDate(java.util.Date) for Dates before 1970
BUG: With the current implementation, the from-to-Java date conversion will
be off by one day for Dates before 1970
Github user ckadner closed the pull request at:
https://github.com/apache/spark/pull/6236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6236#issuecomment-103181201
somehow I ended up with more than my intended commit in the PullRequest --
I need to fix that, sorry!!!
---
If your project is set up for it, you can reply to this
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/6242
SPARK-6785: fix DateUtils.fromJavaDate(java.util.Date) for Dates before 1970
BUG: With the current implementation, the from-to-Java date conversion will
be off by one day for Dates before 1970
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-114348584
Hi Michael,
for the failing hive comparison tests `"Date cast"` & `"Date comparison
test 2"` I will add equivalent test cases to `SQLQuery
Github user ckadner closed the pull request at:
https://github.com/apache/spark/pull/6242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-114682713
Thanks Michael, I will open a new PR with a cleaned up version of my fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103284421
Thanks for your review Davies! I corrected the title and split the
offending long line of code in 2.
---
If your project is set up for it, you can reply to this email
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103297075
Apologies for missing the explicit method return type. I just corrected
that.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103336818
Thank you Davies for hanging in there with me. And apologies that I did not
catch this one myself. I just fixed the unit test and the remaining unit tests
in Catalyst
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103608631
Hi Reynold (@rxin)
can you help me make sense of the last build log? **_...fails MiMa tests_**
Does this look like a configuration error? I do not readily see a
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103670515
@srowen ...so far I have no luck with running ./dev/mima
@davies ...I propose to remove the test case _"Date comparison test 2"_
since the express
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103715610
@srowen, @davies, thank you for your pointers! I will work further on to
this tomorrow.
---
If your project is set up for it, you can reply to this email and have
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-105704064
Sorry, it took me some time to get back.
Turns out Hive suffers from the same bug
([HIVE-10178](https://issues.apache.org/jira/browse/HIVE-10178)) which causes
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-106140810
@srowen, thanks for your advice!
I modified the `HiveQuerySuite` to execute different test cases based on
the version of Hive that is used internally by Spark
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42717075
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42723887
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/9291
[SPARK-11338][WebUI] Prepend app links on HistoryPage with uiRoot path
- `HistoryPage.scala` ...prepending all page links with the web proxy
(`uiRoot`) path
- `HistoryServerSuite.scala
GitHub user ckadner opened a pull request:
https://github.com/apache/spark/pull/9345
[SPARK-10890][SQL] don't log expected JdbcSQLException during incompatible
Insert test
The `org.h2.jdbc.JdbcSQLException` is logged by
`org.apache.spark.executor.Executor` and aga
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9291#issuecomment-152273087
@holdenk @vanzin, thank you for your comments! I just pushed an update to
my fix.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9345#issuecomment-152357861
@**Rick**, I was running the `JDBCWriteSuite` in IntelliJ and each test
case got setup with log `Level.DEBUG`, even if an unexpected `Exception`
prevented resetting the
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9345#issuecomment-152362181
+1 @JoshRosen -- Good suggestion! I pushed a new version.
Could you kick of a test build :mans_shoe:
Thank you!
---
If your project is set up for it, you can
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9345#issuecomment-152400158
Hi @JoshRosen, the failing unit test `"Single command with -e"` in
`CliSuite` should not be impacted by my changes. On my machine I get the
timeouts with or
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9291#issuecomment-152689731
@vanzin, @andrewor14, if you are okay with this fix, do you think it could
still make it into 1.6?
---
If your project is set up for it, you can reply to this email
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9291#issuecomment-152799657
@vanzin -- I pushed the nit pickity fixes :mag: -- Thanks :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/9291#issuecomment-152904046
@vanzin -- Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/7563#discussion_r36254686
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -541,7 +541,7 @@ class HiveQuerySuite extends
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42408083
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends
Github user ckadner closed the pull request at:
https://github.com/apache/spark/pull/9345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
54 matches
Mail list logo
