Github user cl4es commented on the pull request:
https://github.com/apache/spark/pull/11160#issuecomment-183662509
This should likely be refactored to a place where both sbt and test code
can access it, but I hope this is good enough.
---
If your project is set up for it, you can
Github user cl4es commented on the pull request:
https://github.com/apache/spark/pull/11160#issuecomment-183558848
While not a general rule, testing lexically that `version >= "1.8.0"` like
in `UtilsSuite` is actually OK for all current and all possible JEP-223
vers
Github user cl4es commented on the pull request:
https://github.com/apache/spark/pull/11160#issuecomment-183523227
I tried building with JDK 9 EA, and there are more immediate issues such as
-XX:MaxPermSize (which was deprecated/removed in 8 and fails to start in 9)
being used in
Github user cl4es commented on a diff in the pull request:
https://github.com/apache/spark/pull/11160#discussion_r52550759
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java ---
@@ -336,4 +334,18 @@ static void addPermGenSizeOpt(List cmd
Github user cl4es commented on a diff in the pull request:
https://github.com/apache/spark/pull/11160#discussion_r52549879
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java ---
@@ -336,4 +334,18 @@ static void addPermGenSizeOpt(List cmd
GitHub user cl4es opened a pull request:
https://github.com/apache/spark/pull/11160
[SPARK-13278][CORE] Launcher fails to start with JDK 9 EA
See http://openjdk.java.net/jeps/223 for more information about the JDK 9
version string scheme.
You can merge this pull request into a Git
