GitHub user d80tb7 opened a pull request:

    https://github.com/apache/spark/pull/21901

    [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and millisToDays fails 
w/java 8 181-b13

    ## What changes were proposed in this pull request?
    
    - Update DateTimeUtilsSuite so that when testing roundtripping in 
daysToMillis and millisToDays multiple skipdates can be specified.
    - Updated test so that both new years eve 2014 and new years day 2015 are 
skipped for kiribati time zones.  This is necessary as java versions pre 
181-b13 considered new years day 2015 to be skipped while susequent versions 
corrected this to new years eve.
    
    ## How was this patch tested?
    Unit tests
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/d80tb7/spark 
SPARK-24950_datetimeUtilsSuite_failures

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21901
    
----
commit 5867e62531fd9d5027e7af726711fc1b7d5d282f
Author: Chris Martin <chris@...>
Date:   2018-07-27T20:32:54Z

    daysToMillis and millisToDays can exclude multiple dates

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to