Github user dennishuo commented on the pull request:
https://github.com/apache/spark/pull/8072#issuecomment-132321367
Thanks everyone for the reviews! @sryza it sounds like after further
clarification with @vanzin we're okay with the code as-is. Is there anything
else I should
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r37323794
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36892350
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36814288
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -170,6 +173,39 @@ class ClientSuite extends SparkFunSuite with Matchers
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36814036
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -170,6 +173,39 @@ class ClientSuite extends SparkFunSuite with Matchers
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709395
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -170,6 +173,39 @@ class ClientSuite extends SparkFunSuite with Matchers
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709333
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709324
--- Diff: docs/running-on-yarn.md ---
@@ -320,6 +320,14 @@ If you need a reference to the proper location to put
log files in the YARN so t
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709328
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709327
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709312
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user dennishuo commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709305
--- Diff: docs/running-on-yarn.md ---
@@ -320,6 +320,14 @@ If you need a reference to the proper location to put
log files in the YARN so t
GitHub user dennishuo opened a pull request:
https://github.com/apache/spark/pull/8072
[SPARK-9782] [YARN] Support YARN application tags via SparkConf
Add a new test case in yarn/ClientSuite which checks how the various
SparkConf
and ClientArguments propagate into the
GitHub user dennishuo opened a pull request:
https://github.com/apache/spark/pull/7549
[SPARK-9206] [SQL] Fix HiveContext classloading for GCS connector.
IsolatedClientLoader.isSharedClass includes all of com.google.\*, presumably
for Guava, protobuf, and/or other shared Google
14 matches
Mail list logo