[GitHub] spark issue #21317: [SPARK-24232][k8s] Add support for secret env vars

Github user dharmeshkakadia commented on the issue: https://github.com/apache/spark/pull/21317 Thanks @skonto ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21317: [SPARK-24232][k8s] Add support for secret env vars

Github user dharmeshkakadia commented on the issue: https://github.com/apache/spark/pull/21317 This is great 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request: typo in comment

GitHub user dharmeshkakadia opened a pull request: https://github.com/apache/spark/pull/8497 typo in comment You can merge this pull request into a Git repository by running: $ git pull https://github.com/dharmeshkakadia/spark patch-2 Alternatively you can review and apply

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia commented on the pull request: https://github.com/apache/spark/pull/7829#issuecomment-128310509 @cbvoxel Thanks for your insights ! I am trying Hive-on-Spark-on-Yarn-on-Windows :smile: Let me know if I can help in anyway, though I am fairly new to the

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia commented on the pull request: https://github.com/apache/spark/pull/7829#issuecomment-128294738 Thanks. I assumed it is a correct fix because spark examples and few other simple spark programs I have tried, worked with it. --- If your project is set up

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia closed the pull request at: https://github.com/apache/spark/pull/7829 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia commented on the pull request: https://github.com/apache/spark/pull/7829#issuecomment-127999490 Running Spark-on-Yarn-on-Windows requires to fixes : (putting it here for reference) 1. single quote to double quote (included in the patch) 2. removing

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia commented on the pull request: https://github.com/apache/spark/pull/7829#issuecomment-126886798 I have checked it on windows on yarn and seems to be working. But I agree, that this might not be complete fix. Do we want to check the platform/OS and apply

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia commented on the pull request: https://github.com/apache/spark/pull/7829#issuecomment-126659465 @srowen Sorry. I saw your comment on the issue and assumed it. This is my first patch to Spark. How can I find committer who can review this? --- If your

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

Github user dharmeshkakadia commented on the pull request: https://github.com/apache/spark/pull/7829#issuecomment-126654395 @srowen Can you please help me merging this? This is a trivial patch. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-5754] Spark AM not launching on Windows

GitHub user dharmeshkakadia opened a pull request: https://github.com/apache/spark/pull/7829 [SPARK-5754] Spark AM not launching on Windows Properly escaping for windows platform as well - single quote -> escaped double quote You can merge this pull request into a Git reposit