[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/19218 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #18805: [SPARK-19112][CORE] Support for ZStandard codec

Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/18805 how about TPCDS ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18244: [SPARK-20211][SQL] Fix the Precision and Scale of Decima...

Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/18244 how about select 1 > 0.0001D select floor(0.0001D) select ceil(0.0001D) i think constant doube value should be parsed to double as old spark version, not to bigdeci

[GitHub] spark pull request #16637: [SPARK-19225][SQL]round decimal return normal val...

Github user discipleforteen closed the pull request at: https://github.com/apache/spark/pull/16637 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/16637 how about cast constant 4.4 to double instead of decimal like spark 1.x. @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/16637 @AmplabJenkins @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/16637 ok. i will try to update code gen and MathFunctionsSuite.scala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16637: [SPARK-19225][SQL]round decimal return normal val...

GitHub user discipleforteen opened a pull request: https://github.com/apache/spark/pull/16637 [SPARK-19225][SQL]round decimal return normal value but not null ## What changes were proposed in this pull request? in https://issues.apache.org/jira/browse/SPARK-19225

[GitHub] spark pull request #16612: [SPARK-19225][SQL]round decimal return the same v...

Github user discipleforteen closed the pull request at: https://github.com/apache/spark/pull/16612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #16612: [SPARK-19225][SQL]round decimal return the same v...

GitHub user discipleforteen opened a pull request: https://github.com/apache/spark/pull/16612 [SPARK-19225][SQL]round decimal return the same value as spark 1.x ## What changes were proposed in this pull request? in https://issues.apache.org/jira/browse/SPARK-19225