[GitHub] spark pull request #20658: [SPARK-23488][python] Add missing catalog methods...

2018-02-21 Thread drboyer
GitHub user drboyer opened a pull request: https://github.com/apache/spark/pull/20658 [SPARK-23488][python] Add missing catalog methods to python API ## What changes were proposed in this pull request? As noted in SPARK-23488, the Python Catalog API was missing some methods

[GitHub] spark pull request #20658: [SPARK-23488][python] Add missing catalog methods...

2018-02-22 Thread drboyer
Github user drboyer commented on a diff in the pull request: https://github.com/apache/spark/pull/20658#discussion_r170158422 --- Diff: python/pyspark/sql/catalog.py --- @@ -28,7 +28,7 @@ Database = namedtuple("Database", "name description locationUri")

[GitHub] spark issue #20658: [SPARK-23488][python] Add missing catalog methods to pyt...

2018-02-24 Thread drboyer
Github user drboyer commented on the issue: https://github.com/apache/spark/pull/20658 @HyukjinKwon thanks for the review so far! Sorry for the delay, I somehow missed the Python style output in the test logs earlier. How's this look now? Can you elaborate more on &qu

[GitHub] spark issue #20658: [SPARK-23488][python] Add missing catalog methods to pyt...

2018-02-28 Thread drboyer
Github user drboyer commented on the issue: https://github.com/apache/spark/pull/20658 Thanks @holdenk, I can open a separate JIRA about the missing field in `Function` if it seems worth fixing. It wasn't critical for me, I just happened to notice while doing some testing