[GitHub] spark pull request: [SPARK-6126][SQL] added coverage for UDTs in J...

2015-08-05 Thread drubbo
Github user drubbo closed the pull request at: https://github.com/apache/spark/pull/7416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6126][SQL] added coverage for UDTs in J...

2015-08-05 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/7416#issuecomment-127903905 Thank you, and sorry for the mess ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6126][SQL] added coverage for UDTs in J...

2015-07-16 Thread drubbo
Github user drubbo commented on a diff in the pull request: https://github.com/apache/spark/pull/7416#discussion_r34763387 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -58,6 +61,8 @@ private[sql] class MyDenseVectorUDT extends

[GitHub] spark pull request: [SPARK-6126][SQL] added coverage for UDTs in J...

2015-07-15 Thread drubbo
GitHub user drubbo opened a pull request: https://github.com/apache/spark/pull/7416 [SPARK-6126][SQL] added coverage for UDTs in JSON RDDs You can merge this pull request into a Git repository by running: $ git pull https://github.com/drubbo/spark master Alternatively you

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-06-23 Thread drubbo
Github user drubbo closed the pull request at: https://github.com/apache/spark/pull/6193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-06-02 Thread drubbo
Github user drubbo commented on a diff in the pull request: https://github.com/apache/spark/pull/6193#discussion_r31501082 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala --- @@ -53,7 +53,12 @@ abstract class UserDefinedType[UserType] extends

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-31 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/6193#issuecomment-107173272 Everything works fine. I would consider anyway adding the simple test and expanding the comment on deserialize as in my last two commits above https://github.com

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-28 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/6193#issuecomment-106224730 Absolutely, will do that asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-27 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/6193#issuecomment-106101645 Neat. I saw the change in this JIRA, so this is expected to flow into spark-1.5 ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-19 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/6193#issuecomment-103524458 Should be done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-18 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/6193#issuecomment-102952370 This for instance: in [SparkGIS](https://github.com/drubbo/SparkGIS) we're adding support for geometry types that may be serialized in GeoJSON format, so that we'd like

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-18 Thread drubbo
Github user drubbo commented on the pull request: https://github.com/apache/spark/pull/6193#issuecomment-102953351 Sure. I'd also give a look at the comment of UserDefinedType.deserialize and make sure this usage of the method is reported as well. --- If your project is set up

[GitHub] spark pull request: [SPARK-6126][SQL] enforce UDTs as well in Json...

2015-05-15 Thread drubbo
GitHub user drubbo opened a pull request: https://github.com/apache/spark/pull/6193 [SPARK-6126][SQL] enforce UDTs as well in JsonRDDs You can merge this pull request into a Git repository by running: $ git pull https://github.com/drubbo/spark branch-1.4 Alternatively you