[GitHub] spark pull request: SPARK-2186: Spark SQL DSL support for simple a...

2014-07-02 Thread edrevo
Github user edrevo commented on the pull request: https://github.com/apache/spark/pull/1211#issuecomment-47805299 No problem. Thanks for the update! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-2186: Spark SQL DSL support for simple a...

2014-07-02 Thread edrevo
Github user edrevo commented on the pull request: https://github.com/apache/spark/pull/1211#issuecomment-47758337 All feedback has been addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-2186: Spark SQL DSL support for simple a...

2014-06-26 Thread edrevo
Github user edrevo commented on a diff in the pull request: https://github.com/apache/spark/pull/1211#discussion_r14280656 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala --- @@ -108,6 +108,24 @@ package object dsl { implicit

[GitHub] spark pull request: SPARK-2186: Spark SQL DSL support for simple a...

2014-06-25 Thread edrevo
Github user edrevo commented on the pull request: https://github.com/apache/spark/pull/1211#issuecomment-47191917 I have added DSL support (`avg()`, `count(distinct())`...) following @rxin's suggestion. I'm happy to change the DSL style if you end up favoring the othe

[GitHub] spark pull request: SPARK-2186: Spark SQL DSL support for simple a...

2014-06-25 Thread edrevo
Github user edrevo commented on the pull request: https://github.com/apache/spark/pull/1211#issuecomment-47149603 Yup, that's definitely doable. I'll work on adding that DSL support and add it to this pull request. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: SPARK-2186: Spark SQL DSL support for simple a...

2014-06-25 Thread edrevo
GitHub user edrevo opened a pull request: https://github.com/apache/spark/pull/1211 SPARK-2186: Spark SQL DSL support for simple aggregations such as SUM and AVG **Description** This patch enables using the `.select()` function in SchemaRDD with functions such as `Sum`, `Count