[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-06 Thread eric-maynard
Github user eric-maynard commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r193549547 --- Diff: external/kafka-0-10-sql/pom.xml --- @@ -29,7 +29,7 @@ spark-sql-kafka-0-10_2.11 sql-kafka-0-10 -0.10.0.1

[GitHub] spark pull request #21470: [SPARK-24443][SQL] comparison should accept struc...

2018-06-04 Thread eric-maynard
Github user eric-maynard commented on a diff in the pull request: https://github.com/apache/spark/pull/21470#discussion_r192820148 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -803,18 +803,60 @@ object TypeCoercion

[GitHub] spark pull request #21470: [SPARK-24443][SQL] comparison should accept struc...

2018-06-04 Thread eric-maynard
Github user eric-maynard commented on a diff in the pull request: https://github.com/apache/spark/pull/21470#discussion_r192819128 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -803,18 +803,60 @@ object TypeCoercion

[GitHub] spark pull request #21168: added check to ensure main method is found [SPARK...

2018-04-26 Thread eric-maynard
Github user eric-maynard commented on a diff in the pull request: https://github.com/apache/spark/pull/21168#discussion_r184442769 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -675,9 +675,14 @@ private[spark] class

[GitHub] spark pull request #21168: added check to ensure main method is found [SPARK...

2018-04-26 Thread eric-maynard
Github user eric-maynard commented on a diff in the pull request: https://github.com/apache/spark/pull/21168#discussion_r184435342 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -675,9 +675,14 @@ private[spark] class

[GitHub] spark pull request #21168: added check to ensure main method is found [SPARK...

2018-04-26 Thread eric-maynard
GitHub user eric-maynard opened a pull request: https://github.com/apache/spark/pull/21168 added check to ensure main method is found [SPARK-23830] ## What changes were proposed in this pull request? When a user specifies the wrong class -- or, in fact, a class instead of