Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647470
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -1358,6 +1363,41 @@ private[spark] abstract class
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647311
--- Diff: examples/src/main/python/mllib/streaming_test_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647567
--- Diff: python/pyspark/mllib/stat/test.py ---
@@ -80,3 +85,118 @@ class KolmogorovSmirnovTestResult(TestResult):
"""
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647915
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/TestResult.scala ---
@@ -114,7 +114,7 @@ class KolmogorovSmirnovTestResult private[stat
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647656
--- Diff: python/pyspark/mllib/tests.py ---
@@ -1688,6 +1689,44 @@ def test_binary_term_freqs(self):
": exp
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647664
--- Diff: python/pyspark/mllib/tests.py ---
@@ -1688,6 +1689,44 @@ def test_binary_term_freqs(self):
": exp
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647454
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -1358,6 +1363,41 @@ private[spark] abstract class
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647843
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -1576,17 +1616,49 @@ private[spark] object SerDe extends
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647607
--- Diff: python/pyspark/mllib/stat/test.py ---
@@ -80,3 +85,118 @@ class KolmogorovSmirnovTestResult(TestResult):
"""
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647232
--- Diff: examples/src/main/python/mllib/streaming_test_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647320
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -44,7 +44,7 @@ import org.apache.spark.mllib.regression
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647221
--- Diff: examples/src/main/python/mllib/streaming_test_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647632
--- Diff: python/pyspark/mllib/tests.py ---
@@ -1688,6 +1689,44 @@ def test_binary_term_freqs(self):
": exp
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647207
--- Diff: examples/src/main/python/mllib/streaming_test_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647534
--- Diff: python/pyspark/mllib/stat/test.py ---
@@ -15,10 +15,15 @@
# limitations under the License.
#
+from collections import
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647905
--- Diff: python/pyspark/mllib/stat/test.py ---
@@ -80,3 +85,118 @@ class KolmogorovSmirnovTestResult(TestResult):
"""
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647272
--- Diff: examples/src/main/python/mllib/streaming_test_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11374#discussion_r85647289
--- Diff: examples/src/main/python/mllib/streaming_test_example.py ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user feynmanliang commented on the issue:
https://github.com/apache/spark/pull/11374
Apologies for the delay, I am traveling but I'll get this done this
weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user feynmanliang commented on the issue:
https://github.com/apache/spark/pull/11374
I'll review this tonight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/10743#issuecomment-172811882
@dbtsai validating coefficients with R will be harder than expected,
`glmnet` requires feature dimension >= 2 and `glm` doesn't yield +/- Infinity
intercepts w
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r50006902
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -276,113 +276,123 @@ class LogisticRegression @Since
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r50006858
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -276,113 +276,123 @@ class LogisticRegression @Since
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r50007441
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -883,6 +884,27 @@ class LogisticRegressionSuite
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/10743#issuecomment-172556919
@dbtsai Added `fitIntercept=false` tests and fixed comments/`logWarning`
messages.
---
If your project is set up for it, you can reply to this email and have
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r50041066
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -276,113 +276,123 @@ class LogisticRegression @Since
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r50041068
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -276,113 +276,123 @@ class LogisticRegression @Since
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r49946338
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -883,6 +884,22 @@ class LogisticRegressionSuite
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r49946694
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -339,9 +339,11 @@ class LogisticRegression @Since
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/10743#issuecomment-172328753
@dbtsai @jkbradley ready for second review.
The big diff is because I grouped the same label cases with the normal case
to generate `coefficients
GitHub user feynmanliang opened a pull request:
https://github.com/apache/spark/pull/10743
[SPARK-12804][ML] Fix LogisticRegression with FitIntercept on all same
label training data
You can merge this pull request into a Git repository by running:
$ git pull https
Github user feynmanliang closed the pull request at:
https://github.com/apache/spark/pull/8618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9974#issuecomment-159869256
LGTM, though I didn't know what was wrong with the old PR so this should
get a second set of eyes
---
If your project is set up for it, you can reply
GitHub user feynmanliang opened a pull request:
https://github.com/apache/spark/pull/10005
[SPARK-11960][MLlib][Doc]User guide for streaming tests
CC @jkbradley @mengxr @josepablocam
You can merge this pull request into a Git repository by running:
$ git pull https
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9722#issuecomment-158329286
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9722#issuecomment-158329258
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45314139
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,25 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45382273
--- Diff: docs/ml-guide.md ---
@@ -40,6 +40,7 @@ Also, some algorithms have additional capabilities in the
`spark.ml` API; e.g.,
provide class
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45381957
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,31 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45382669
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaLDAExample.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9722#issuecomment-158153601
LGTM after changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45382120
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,31 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45206456
--- Diff: docs/mllib-guide.md ---
@@ -73,6 +73,7 @@ concepts. It also contains sections on using algorithms
within the Pipelines API
* [Ensembles
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45206436
--- Diff: docs/ml-guide.md ---
@@ -45,6 +45,7 @@ provide class probabilities, and linear models provide
model summaries.
* [Linear methods
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45207331
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,25 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45207931
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaLDAExample.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45207539
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaLDAExample.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45206861
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,25 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45206909
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,25 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45207955
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/LDAExample.scala ---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45207421
--- Diff: docs/ml-clustering.md ---
@@ -0,0 +1,25 @@
+---
+layout: global
+title: Clustering - ML
+displayTitle: ML - Clustering
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9722#issuecomment-157738214
Made a pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9722#discussion_r45206678
--- Diff: docs/mllib-guide.md ---
@@ -73,6 +73,7 @@ concepts. It also contains sections on using algorithms
within the Pipelines API
* [Ensembles
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9678#discussion_r44720208
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -468,7 +452,37 @@ class LDAModel private[ml
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9678#issuecomment-156249049
LGTM, all comments minor / optional
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9678#discussion_r44720409
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -314,31 +314,31 @@ private[clustering] trait LDAParams extends Params
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9678#discussion_r44721007
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -480,58 +494,38 @@ class DistributedLDAModel private[ml
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9678#discussion_r44720740
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -468,7 +452,37 @@ class LDAModel private[ml
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9678#discussion_r44720656
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -468,7 +452,37 @@ class LDAModel private[ml
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9678#discussion_r44720555
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -480,58 +494,38 @@ class DistributedLDAModel private[ml
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155714828
@avulanov On [this
page](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45410/consoleFull)
search for "*** FAILED ***"
---
If yo
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155376552
+1 on the renames
On Tue, Nov 10, 2015, 02:48 Apache Spark QA <notificati...@github.com>
wrote:
> *Test build #2025 has finished
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8551#issuecomment-155376709
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155630055
I still think it's wrong for a `LocalLDAModel` to *optionally* have a
`OldLocalLDAModel` when it's basically a wrapper for `OldLocalLDAModel`.
Forking
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155627493
Oh wait I see what you're saying
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155627361
@jkbradley Not sure I understand, if `lazy val oldModel =
*something*.collect()` then `collect()` will only be called once on the first
reference to `oldModel
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44341246
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44341643
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44322164
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44322120
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44323247
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44324308
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44323843
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44323496
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155185664
Second pass. Most significant comments are about completely removing
`Vector` from the public API and debating `DistributedLDAModel < LDAModel` vs
`abstract cl
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44323084
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44324500
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44321879
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44354690
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44354638
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-155243816
LGTM
If we do decide to change the inheritance structure it should be done
before 1.6 release to prevent breaking public APIs
---
If your project is set
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202059
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202038
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44203476
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44203542
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202262
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44203245
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44203695
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/9513#issuecomment-154590891
Made a pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202348
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202796
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44203600
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202645
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202165
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202952
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202889
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202541
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202484
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44203006
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9513#discussion_r44202982
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -0,0 +1,740 @@
+/*
+ * Licensed to the Apache Software Foundation
1 - 100 of 1159 matches
Mail list logo
