[GitHub] spark pull request: Update py4j to 0.9.

2015-09-11 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/8722#issuecomment-139644659 Is this duplicated? #8615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3325][Streaming] Add a parameter to the...

2014-11-20 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/3237#issuecomment-63822056 @tdas @watermen I believe python code become like this. ``` def pprint(self, num): """ Print the first num e

[GitHub] spark pull request: [DOC][PySpark][Streaming] Fix docstring for sp...

2014-11-17 Thread giwa
GitHub user giwa opened a pull request: https://github.com/apache/spark/pull/3311 [DOC][PySpark][Streaming] Fix docstring for sphinx This commit should be merged for 1.2 release. cc @tdas You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] spark pull request: [SPARK-3982] [Streaming] [PySpark] Python API:...

2014-10-27 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2833#issuecomment-60675214 @tdas CC @davies If this feature is ready for 1.2 release, it would be great! Could you take a look why this test fails in Jenkins since code freeze for 1.2 is November

[GitHub] spark pull request: Add echo "Run streaming tests ..."

2014-10-12 Thread giwa
GitHub user giwa opened a pull request: https://github.com/apache/spark/pull/2778 Add echo "Run streaming tests ..." You can merge this pull request into a Git repository by running: $ git pull https://github.com/giwa/spark patch-2 Alternatively you can review

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-12 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-58795386 Thank you for merging this! I appreciate to you, @tdas , to give me many advices. Thank you, @davies to refactor code a lot. I learned many thing from your commits. And

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-10 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18739441 --- Diff: examples/src/main/python/streaming/stateful_network_wordcount.py --- @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-10 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-58695306 @davies I see. This would be huge PR. It makes sense to test more before merging this PR. Thank you! --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-10 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-58687330 @davies #2624 is merged. Are we waiting for py4j 9.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-06 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-58101900 @davies @tdas @JoshRosen What do we need for merging this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-06 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-58088738 @davies @nchammas @shaneknapp Thank you for information. I hope we never suffer from this error. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-05 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-57957378 Why was this error happened in jenkins? Is this because of many commits? The error said ``` Fetching upstream changes from https://github.com/apache

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-10-02 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18379709 --- Diff: python/pyspark/streaming/dstream.py --- @@ -0,0 +1,624 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-09-30 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-57281449 @davies That's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2377] Python API for Streaming

2014-09-29 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-57230596 @davies This error is interesting. I also doubt start and stop StreamingContext. I changed the order of execution of tests. I run TestWindowFunctions first. However, I

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-29 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-57148324 @davies Python API for Streaming becomes much nicer. You are awesome! Tests have been failed so far. But it looks like other issue, I think. Thanks to you

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-29 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18148393 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala --- @@ -549,6 +549,10 @@ class JavaStreamingContext(val ssc

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-28 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-57103181 @davies Could you add pyspark/streaming/util.py as a doc test? It has a doc test. ``` PYSPARK_DOC_TEST=1 run_test "pyspark/broadcast.py"

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-28 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18133131 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -288,7 +293,7 @@ private class PythonException(msg: String, cause: Exception

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-28 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18132833 --- Diff: python/pyspark/streaming/tests.py --- @@ -0,0 +1,385 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-28 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18132354 --- Diff: examples/src/main/python/streaming/network_wordcount.py --- @@ -0,0 +1,20 @@ +import sys + +from pyspark import SparkContext +from

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-28 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18132355 --- Diff: examples/src/main/python/streaming/wordcount.py --- @@ -0,0 +1,21 @@ +import sys + +from pyspark import SparkContext +from

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-28 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18132327 --- Diff: python/pyspark/streaming/dstream.py --- @@ -0,0 +1,632 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/2538#issuecomment-56942157 @davies @JoshRosen Is there any idea about how to kill callback server after an error is happened? I tried signal and atexit to call gateway

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18080721 --- Diff: python/pyspark/streaming/tests.py --- @@ -0,0 +1,321 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18079928 --- Diff: python/pyspark/streaming/dstream.py --- @@ -0,0 +1,400 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18079362 --- Diff: python/pyspark/streaming/tests.py --- @@ -0,0 +1,321 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18078104 --- Diff: examples/src/main/python/streaming/wordcount.py --- @@ -0,0 +1,21 @@ +import sys + +from pyspark.streaming.context import StreamingContext

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18078083 --- Diff: examples/src/main/python/streaming/network_wordcount.py --- @@ -0,0 +1,20 @@ +import sys + +from pyspark.streaming.context import

[GitHub] spark pull request: [WIP] [SPARK-2377] Python API for Streaming

2014-09-26 Thread giwa
Github user giwa commented on a diff in the pull request: https://github.com/apache/spark/pull/2538#discussion_r18077695 --- Diff: python/pyspark/streaming/jtime.py --- @@ -0,0 +1,135 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark pull request: Fixed wrong links

2014-08-19 Thread giwa
GitHub user giwa opened a pull request: https://github.com/apache/spark/pull/2042 Fixed wrong links You can merge this pull request into a Git repository by running: $ git pull https://github.com/giwa/spark patch-1 Alternatively you can review and apply these changes as the

[GitHub] spark pull request: follow pep8 None should be compared using is o...

2014-07-15 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/1422#issuecomment-49123784 It's my pleasure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: follow pep8 None should be compared using is o...

2014-07-15 Thread giwa
GitHub user giwa opened a pull request: https://github.com/apache/spark/pull/1422 follow pep8 None should be compared using is or is not http://legacy.python.org/dev/peps/pep-0008/ ## Programming Recommendations - Comparisons to singletons like None should always

[GitHub] spark pull request: Consistency for function naming in Duration

2014-05-18 Thread giwa
Github user giwa commented on the pull request: https://github.com/apache/spark/pull/814#issuecomment-43447806 @ash211 Thank you for your comment. After my second thought, this suggestion is not good. toString in Java world gives back human readable format. The reason why I

[GitHub] spark pull request: Consistency for function naming in Duration

2014-05-18 Thread giwa
Github user giwa closed the pull request at: https://github.com/apache/spark/pull/814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Consistency for function naming in Duration

2014-05-18 Thread giwa
GitHub user giwa opened a pull request: https://github.com/apache/spark/pull/814 Consistency for function naming in Duration toFormattedString should represent formatted millisecond like "10 ms" not simply give back "10" toString should represent string of