Github user gmoehler commented on the issue:
https://github.com/apache/spark/pull/16660
Thanks for pointing out. I had overseen this comment.
Really appreciate you commitment to clean code!
Change is pushed and ready for a test build.
---
If your project is set up
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97736380
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on the issue:
https://github.com/apache/spark/pull/16660
@viirya Which comment are you referring to? I thought i had included all of
them ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97534883
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -194,4 +293,35 @@ class UserDefinedTypeSuite extends QueryTest
Github user gmoehler commented on the issue:
https://github.com/apache/spark/pull/16660
Thanks for the valuable (and fast!) comments - i have worked them in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97512560
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -194,4 +293,35 @@ class UserDefinedTypeSuite extends QueryTest
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97504006
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97503551
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97503371
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97503434
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97500817
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97498083
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97498043
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -20,13 +20,15 @@ package org.apache.spark.sql
import
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97498057
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,7 +73,104 @@ object UDT {
}
+// object
Github user gmoehler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16660#discussion_r97333990
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -71,6 +71,94 @@ object UDT {
}
+// object
GitHub user gmoehler opened a pull request:
https://github.com/apache/spark/pull/16660
[SPARK-19311][SQL] fix UDT hierarchy issue
## What changes were proposed in this pull request?
acceptType() in UDT will no only accept the same type but also all base
types
## How
16 matches
Mail list logo
