[GitHub] spark pull request #16714: [SPARK-16333][Core] Enable EventLoggingListener t...

2017-02-21 Thread jasonmoore2k
Github user jasonmoore2k commented on a diff in the pull request: https://github.com/apache/spark/pull/16714#discussion_r102396498 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -62,18 +62,21 @@ private[spark] object JsonProtocol { * JSON

[GitHub] spark pull request #16714: [SPARK-16333][Core] Enable EventLoggingListener t...

2017-02-21 Thread jasonmoore2k
Github user jasonmoore2k commented on a diff in the pull request: https://github.com/apache/spark/pull/16714#discussion_r102395516 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -97,61 +100,80 @@ private[spark] object JsonProtocol { case

[GitHub] spark issue #16714: [SPARK-16333][Core] Enable EventLoggingListener to log l...

2017-02-21 Thread jasonmoore2k
Github user jasonmoore2k commented on the issue: https://github.com/apache/spark/pull/16714 Would some of the other recent contributors to this area (e.g. @zsxwing or @JoshRosen) be able to comment on any use for these internal accumulables / block status updates, and whether they

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-05-05 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12751#issuecomment-217293599 Ta! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-05-05 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12751#issuecomment-217133890 Great, thanks! Not too concerned with 1.5 (and after checking it out looks like it doesn't go on cleanly), but I've been testing this patch on top o

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-05-05 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12751#issuecomment-217128160 @srowen Any chance of getting this picked onto the 1.5 and 1.6 branches too? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-05-04 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12751#issuecomment-217081200 Done! Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-05-04 Thread jasonmoore2k
Github user jasonmoore2k commented on a diff in the pull request: https://github.com/apache/spark/pull/12751#discussion_r62137083 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -716,7 +716,15 @@ private[spark] class TaskSetManager

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-04-27 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12751#issuecomment-215325217 @andrewor14 @kayousterhout Would appreciate your thoughts on this change (or anybody else who you recommend with some experience with the task scheduler

[GitHub] spark pull request: [SPARK-14915] [CORE] Don't re-queue a task if ...

2016-04-27 Thread jasonmoore2k
GitHub user jasonmoore2k opened a pull request: https://github.com/apache/spark/pull/12751 [SPARK-14915] [CORE] Don't re-queue a task if another attempt has already succeeded ## What changes were proposed in this pull request? Don't re-queue a task if another a

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-26 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-214658162 I've opened this ticket: https://issues.apache.org/jira/browse/SPARK-14915 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-26 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-214651693 Previously, code was in place to treat a CDE in a particular way, but it wasn't sufficient (it didn't consider that the CDE was actually nested insid

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-25 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-214628237 @andrewor14 @srowen I'm starting to think this change wasn't great to make. I'm now seeing speculated tasks sometimes getting into a c

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-07 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-207196510 @andrewor14, think it's safe to just retest? I don't think the fatal error was because of these changes. I don't have the permissions to st

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-07 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-207194131 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-07 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-207188334 Flaky test? The second test that is running has passed that one. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-07 Thread jasonmoore2k
Github user jasonmoore2k commented on a diff in the pull request: https://github.com/apache/spark/pull/12228#discussion_r58967842 --- Diff: core/src/test/scala/org/apache/spark/util/CausedBySuite.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-06 Thread jasonmoore2k
Github user jasonmoore2k commented on the pull request: https://github.com/apache/spark/pull/12228#issuecomment-206658369 Should the matching for FetchFailedException, TaskKilledException & InterruptedException get similar treatment? --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-14357] [CORE] Properly handle the root ...

2016-04-06 Thread jasonmoore2k
GitHub user jasonmoore2k opened a pull request: https://github.com/apache/spark/pull/12228 [SPARK-14357] [CORE] Properly handle the root cause being a commit denied exception ## What changes were proposed in this pull request? When deciding whether a CommitDeniedException